Re: [macports-ports] branch master updated: berkeleygw: Remove svn $Id$ line.

[Sean Farley]

Rainer Müller  writes:

> On 2016-11-01 19:23, Sean Farley wrote:
>> Lawrence Velázquez  writes:
>> 
>>> You should set your repository's user.email to your MacPorts email address.
>> 
>> Is this really necessary? I've seen mention of a mailmap but that hardly
>> seems like a big enough reason to force us to change user.email.
>> 
>> I'm pushing back on this, by the way, because I'd like to keep the fact
>> that I have one email for all the projects I've contributed to and this
>> is the first time there's been an email requirement.
>
> This is no hard requirement. However, all your existing commits were
> attributed to your @macports.org mail address.

Ah, I forgot I did my own custom map since I was using hgsubversion.

> I am only aware of one case where the commit author email address will
> be used:
>
> When you close a ticket with "Closes
> ​https://trac.macports.org/ticket/...; in a commit message, a comment
> will automatically be added to the corresponding ticket. This comment
> will be attributed to the author of the commit. By using the same email
> address for your commits that is also configured in Trac, you ensure
> that these comments will be properly attributed to you.

That is a fairly compelling reason so I'll go with that.
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev

Re: GitHub usernames as maintainers [Was: Re: [macports-ports] branch master updated: berkeleygw: Remove svn $Id$ line.]

[Rainer Müller]

On 2016-11-01 19:57, Clemens Lang wrote:
> On Tue, Nov 01, 2016 at 07:42:23PM +0100, Mojca Miklavec wrote:
>> At some point (rather sooner than later) we'll have to start adding
>> GitHub usernames to Portfiles (we might have to extend the base to
>> properly support that).
> 
> I agree, especially because the GitHub username is now also valid in
> Trac. At the moment, you'd get new tickets sent to your email address,
> not your Trac account (unless a user notices the equivalence in the
> auto-completion box).

Should we get Trac to automatically replace email addresses with the
corresponding username in the Owner and CC fields?

>> And quite honestly I would also be in favour of asking committers to
>> use the same MacPorts handle as their GitHub account name (and only
>> keep the old ones as aliases).
> 
> I like my handle, but I can see how it could lead to confusion. On the
> other hand, the maintainer handles are bound to become less important in
> the future anyway. If you want to reach a committer, there usually are
> contact methods on their GitHub profile.

Using GitHub usernames in the maintainer field has the downside that you
can no longer reach port maintainers outside of GitHub or Trac. There is
no requirement to have a public email address on the GitHub profile.

We could add a mapping of GitHub username to MacPorts handle to the
ports tree, but that would also only solve the problem for the
developers team, not outside collaborators.

Rainer
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev

GitHub usernames as maintainers [Was: Re: [macports-ports] branch master updated: berkeleygw: Remove svn $Id$ line.]

[Clemens Lang]

On Tue, Nov 01, 2016 at 07:42:23PM +0100, Mojca Miklavec wrote:
> If someone submits a pull request for a maintained port, the
> maintainer should probably be notified explicitly with @username. The
> problem is that currently only Trac maintainers have access to that
> mapping.

It's not a set of data I'd like to keep forever. We're requesting
people's non-public email addresses from GitHub to do the migration, not
to implement arbitrary other features on top of that data.


> At some point (rather sooner than later) we'll have to start adding
> GitHub usernames to Portfiles (we might have to extend the base to
> properly support that).

I agree, especially because the GitHub username is now also valid in
Trac. At the moment, you'd get new tickets sent to your email address,
not your Trac account (unless a user notices the equivalence in the
auto-completion box).

> And quite honestly I would also be in favour of asking committers to
> use the same MacPorts handle as their GitHub account name (and only
> keep the old ones as aliases).

I like my handle, but I can see how it could lead to confusion. On the
other hand, the maintainer handles are bound to become less important in
the future anyway. If you want to reach a committer, there usually are
contact methods on their GitHub profile.

-- 
Clemens
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev

Re: [macports-ports] branch master updated: berkeleygw: Remove svn $Id$ line.

[Rainer Müller]

On 2016-11-01 19:23, Sean Farley wrote:
> Lawrence Velázquez  writes:
> 
>> You should set your repository's user.email to your MacPorts email address.
> 
> Is this really necessary? I've seen mention of a mailmap but that hardly
> seems like a big enough reason to force us to change user.email.
> 
> I'm pushing back on this, by the way, because I'd like to keep the fact
> that I have one email for all the projects I've contributed to and this
> is the first time there's been an email requirement.

This is no hard requirement. However, all your existing commits were
attributed to your @macports.org mail address.

I am only aware of one case where the commit author email address will
be used:

When you close a ticket with "Closes
​https://trac.macports.org/ticket/...; in a commit message, a comment
will automatically be added to the corresponding ticket. This comment
will be attributed to the author of the commit. By using the same email
address for your commits that is also configured in Trac, you ensure
that these comments will be properly attributed to you.

Rainer
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev

Re: [macports-ports] branch master updated: berkeleygw: Remove svn $Id$ line.

[Mojca Miklavec]

On 1 November 2016 at 19:23, Sean Farley wrote:
> Lawrence Velázquez writes:
>
>> You should set your repository's user.email to your MacPorts email address.
>
> Is this really necessary? I've seen mention of a mailmap but that hardly
> seems like a big enough reason to force us to change user.email.
>
> I'm pushing back on this, by the way, because I'd like to keep the fact
> that I have one email for all the projects I've contributed to and this
> is the first time there's been an email requirement.

Under subversion you had absolutely no other choice, but to login with
your usern...@macports.org, so all your commits had that email
recorded. Personally I would be in favour to keep that convention and
to commit to MacPorts with your MacPorts handle. But I also agree that
raising the question of whether this is absolutely necessary is
perfectly valid.

Switching to GitHub raised a few other issues. Many committers now
have two different usernames, one MacPorts handle and one GitHub
account. And most (if not all) maintainers will now be known under
some GitHub username. If someone submits a pull request for a
maintained port, the maintainer should probably be notified explicitly
with @username. The problem is that currently only Trac maintainers
have access to that mapping. (You can potentially get the username by
checking the commit logs on the GitHub website ... but that takes a
lot of extra effort.)

At some point (rather sooner than later) we'll have to start adding
GitHub usernames to Portfiles (we might have to extend the base to
properly support that). And quite honestly I would also be in favour
of asking committers to use the same MacPorts handle as their GitHub
account name (and only keep the old ones as aliases).

Those are completely different questions of course.

Mojca
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev

Re: [macports-ports] branch master updated: berkeleygw: Remove svn $Id$ line.

[Sean Farley]

Lawrence Velázquez  writes:

> You should set your repository's user.email to your MacPorts email address.

Is this really necessary? I've seen mention of a mailmap but that hardly
seems like a big enough reason to force us to change user.email.

I'm pushing back on this, by the way, because I'd like to keep the fact
that I have one email for all the projects I've contributed to and this
is the first time there's been an email requirement.
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev

Re: [macports-ports] branch master updated: berkeleygw: Remove svn $Id$ line.

[David Strubbe]

I just wanted to try out the new git setup to make sure things were working
for me, and this was a simple little thing to do.

On Mon, Oct 31, 2016 at 7:10 PM, Brandon Allbery 
wrote:

>
> On Mon, Oct 31, 2016 at 10:05 PM, Lawrence Velázquez 
> wrote:
>
>> new 8ed388e berkeleygw: Remove svn $Id$ line.
>
>
> btw, given that it's not being automated because of the unnecessary builds
> it would trigger, I would say don't bother making commits that *only*
> remove the Id line. It's not harmful; it's just irrelevant with git. Just
> remember to remove the line as part of the next update you make.
>
> --
> brandon s allbery kf8nh   sine nomine
> associates
> allber...@gmail.com
> ballb...@sinenomine.net
> unix, openafs, kerberos, infrastructure, xmonad
> http://sinenomine.net
>
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev

Re: [macports-ports] branch master updated: berkeleygw: Remove svn $Id$ line.

[Brandon Allbery]

On Mon, Oct 31, 2016 at 10:05 PM, Lawrence Velázquez 
wrote:

> new 8ed388e berkeleygw: Remove svn $Id$ line.


btw, given that it's not being automated because of the unnecessary builds
it would trigger, I would say don't bother making commits that *only*
remove the Id line. It's not harmful; it's just irrelevant with git. Just
remember to remove the line as part of the next update you make.

-- 
brandon s allbery kf8nh   sine nomine associates
allber...@gmail.com  ballb...@sinenomine.net
unix, openafs, kerberos, infrastructure, xmonadhttp://sinenomine.net
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev

Re: [macports-ports] branch master updated: berkeleygw: Remove svn $Id$ line.

[David Strubbe]

Thanks, yes I just realized I hadn't set that up.

David

On Mon, Oct 31, 2016 at 7:05 PM, Lawrence Velázquez 
wrote:

> You should set your repository's user.email to your MacPorts email address.
>
> vq
>
> On Oct 31, 2016, at 9:50 PM, dstrubbe 
> wrote:
>
> dstrubbe pushed a commit to branch master
> in repository macports-ports.
>
>
> https://github.com/macports/macports-ports/commit/
> 8ed388e541ce01d92d698791fefd72a4bd2448c9
>
> The following commit(s) were added to refs/heads/master by this push: new 
> 8ed388e  berkeleygw: Remove svn $Id$ line.8ed388e is described below
> commit 8ed388e541ce01d92d698791fefd72a4bd2448c9Author: David Strubbe 
> 
> AuthorDate: Mon Oct 31 18:48:04 2016 -0700
> berkeleygw: Remove svn $Id$ line.---
>  science/berkeleygw/Portfile | 1 -
>  1 file changed, 1 deletion(-)
> diff --git a/science/berkeleygw/Portfile b/science/berkeleygw/Portfileindex 
> 0a82359..9f495ea 100644--- a/science/berkeleygw/Portfile+++ 
> b/science/berkeleygw/Portfile@@ -1,5 +1,4 @@ # -*- coding: utf-8; mode: tcl; 
> tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- 
> vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4-# $Id$
>  PortSystem  1.0
>  PortGroup   mpi 1.0
>
> ___
> macports-changes mailing list
> macports-chan...@lists.macosforge.org
> https://lists.macosforge.org/mailman/listinfo/macports-changes
>
>
>
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev

Re: [macports-ports] branch master updated: berkeleygw: Remove svn $Id$ line.

[Lawrence Velázquez]

You should set your repository's user.email to your MacPorts email address.

vq

> On Oct 31, 2016, at 9:50 PM, dstrubbe  
> wrote:
> 
> dstrubbe pushed a commit to branch master
> in repository macports-ports.
> 
> https://github.com/macports/macports-ports/commit/8ed388e541ce01d92d698791fefd72a4bd2448c9
>  
> 
> The following commit(s) were added to refs/heads/master by this push:
>  new 8ed388e  berkeleygw: Remove svn $Id$ line.
> 8ed388e is described below
> 
> commit 8ed388e541ce01d92d698791fefd72a4bd2448c9
> Author: David Strubbe 
> AuthorDate: Mon Oct 31 18:48:04 2016 -0700
> 
> berkeleygw: Remove svn $Id$ line.
> ---
>  science/berkeleygw/Portfile | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/science/berkeleygw/Portfile b/science/berkeleygw/Portfile
> index 0a82359..9f495ea 100644
> --- a/science/berkeleygw/Portfile
> +++ b/science/berkeleygw/Portfile
> @@ -1,5 +1,4 @@
>  # -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; 
> c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
> -# $Id$
>  
>  PortSystem  1.0
>  PortGroup   mpi 1.0
> 
> ___
> macports-changes mailing list
> macports-chan...@lists.macosforge.org
> https://lists.macosforge.org/mailman/listinfo/macports-changes

___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev