Re: New guide section on Git and GitHub

2018-04-14 Thread Rainer Müller
On 2018-04-13 15:31, Jonathan Stickel wrote: > As a long time contributor of patches using the ticket interface (Trac), > I think it would be a mistake to discourage submission of patches there. > While it is fine to encourage use of git pull requests, the barrier of > entry is much higher. In

Ticket #56139 update to pymol 2.1.0 with PyQt interface support

2018-04-14 Thread Jack Howarth
Can someone commit my final update to pymol 2.1.0 with PyQt interface support? The packaging switches pymol to use the new PyQt based interface while retaining the tcl/k/pmw dependencies for the legacy plugins. Regarding the legacy plugins, the apbstools one only properly functions on the default

Re: port version reports 2.4.2 when built from tag v2.4.3

2018-04-14 Thread Enrico Maria Crisostomo
> On 13 Apr 2018, at 23:55, Joshua Root wrote: > > On 2018-4-14 07:30 , Enrico Maria Crisostomo wrote: >> I think I found the culprit: >> >>% strings /opt/macports-2.4.3-dirty/libexec/macports/lib/libtcl8.5.dylib >> | grep 2\\.4\\. >>

Re: New guide section on Git and GitHub

2018-04-14 Thread Perry E. Metzger
On Fri, 13 Apr 2018 07:31:45 -0600 Jonathan Stickel wrote: > As a long time contributor of patches using the ticket interface > (Trac), I think it would be a mistake to discourage submission of > patches there. While it is fine to encourage use of git pull > requests, the

How long should we wait for submitter action on a PR?

2018-04-14 Thread Perry E. Metzger
We have one open PR where the submitter hasn't replied to some requests for changes since the initial request several weeks ago. (I tried emailing the requester directly some time ago and got no response there either.) Clearly there should be a timeout after which the pull request gets closed for

let's actually fix the ccpnmr build

2018-04-14 Thread Jack Howarth
Can someone please commit the changes that I posted in the ticket... https://trac.macports.org/ticket/56292 so that ccpnmr actually builds again? People keep committing changes to this package without actually checking that they work. We need to resort to a compiler.blacklist to avoid all

Re: port version reports 2.4.2 when built from tag v2.4.3

2018-04-14 Thread Rainer Müller
On 2018-04-13 23:55, Joshua Root wrote: > On 2018-4-14 07:30 , Enrico Maria Crisostomo wrote: >> Hence, the macports installation that was built from the dirty tree is >> referring to the installation directory of the previous build. That also >> explains why removing that directory makes port

Re: New guide section on Git and GitHub

2018-04-14 Thread Andrew Moore
On Apr 14, 2018, at 4:01 PM, Jonathan Stickel wrote: > > Sure, it makes perfect sense to encourage PRs while continue to consider > patches. I'm not against that at all, and I'm willing to figure it out. But > care should be taken about the tone of the message, especially

Re: how to create a patch for configure?

2018-04-14 Thread Joshua Root
On 2018-4-15 11:11 , macpo...@parvis.nl wrote: > I made a patch resulting in > > pango configure.ac:221 > -- > if $have_fontconfig ; then > pango_save_libs=$LIBS > LIBS="$LIBS $FONTCONFIG_LIBS" > -># AC_CHECK_FUNCS(FcWeightFromOpenTypeDouble) > ->cat

Re: How long should we wait for submitter action on a PR?

2018-04-14 Thread Perry E. Metzger
On Sat, 14 Apr 2018 18:31:51 -0500 Ryan Schmidt wrote: > On Apr 14, 2018, at 09:37, Perry E. Metzger wrote: > > > We have one open PR where the submitter hasn't replied to some > > requests for changes since the initial request several weeks ago. > > (I tried emailing

Re: New guide section on Git and GitHub

2018-04-14 Thread Jonathan Stickel
On 4/14/18 08:29 , Perry E. Metzger wrote: On Fri, 13 Apr 2018 07:31:45 -0600 Jonathan Stickel wrote: As a long time contributor of patches using the ticket interface (Trac), I think it would be a mistake to discourage submission of patches there. While it is fine to

Re: How long should we wait for submitter action on a PR?

2018-04-14 Thread Ryan Schmidt
On Apr 14, 2018, at 09:37, Perry E. Metzger wrote: > We have one open PR where the submitter hasn't replied to some > requests for changes since the initial request several weeks ago. (I > tried emailing the requester directly some time ago and got no > response there either.) > > Clearly there

Re: let's actually fix the ccpnmr build

2018-04-14 Thread Ryan Schmidt
On Apr 14, 2018, at 09:20, Jack Howarth wrote: > Can someone please commit the changes that I posted in the ticket... > > https://trac.macports.org/ticket/56292 > > so that ccpnmr actually builds again? People keep committing changes to this > package without actually checking that they work.

how to create a patch for configure?

2018-04-14 Thread macports
Working on my missing dejavusansmono in rrdtool pango cairo fontconfig problem: pango calls 'FcWeightFromOpenTypeDouble' an that function exists only in fontconfig >= 2.92 That implies changes to pango or fontconfig and I can't oversee the consequences. But I verified pango source and it