Re: [macports-ports] branch master updated: remove unused patches

[Zero King]

On Mon, Feb 12, 2018 at 08:30:58AM -0500, Perry E. Metzger wrote:

On Mon, 12 Feb 2018 03:52:59 -0600 Ryan Schmidt
 wrote:


Perry, it's your responsibility to ensure commit messages conform
to our guidelines before merging a PR.



Gotcha. It's a bit irritating that there isn't a good way to edit a
commit message in the course of merging, because it seems unfriendly
to me to make people go around again for something trivial I should
be able to fix. Anyone know if there's some way to do that?


If the PR author allowed edits from maintainers (on by default), you can
force push to the PR source branch. See
https://trac.macports.org/wiki/WorkingWithGit#WorkingwithsomeoneelsespullrequestthroughitsID
and https://gist.github.com/l2dy/7da9621954ebcf1a19869f391662a41e for
some instructions.

--
Best regards,
Zero King


smime.p7s
Description: S/MIME cryptographic signature

Re: [macports-ports] branch master updated: remove unused patches

[Perry E. Metzger]

On Mon, 12 Feb 2018 03:52:59 -0600 Ryan Schmidt
 wrote:
> 
> Perry, it's your responsibility to ensure commit messages conform
> to our guidelines before merging a PR.
> 

Gotcha. It's a bit irritating that there isn't a good way to edit a
commit message in the course of merging, because it seems unfriendly
to me to make people go around again for something trivial I should
be able to fix. Anyone know if there's some way to do that?

-- 
Perry E. Metzgerpe...@piermont.com

Re: [macports-ports] branch master updated: remove unused patches

[Ryan Schmidt]

On Feb 11, 2018, at 12:13, jabenninghoff wrote:

> Perry E. Metzger (pmetzger) pushed a commit to branch master
> in repository macports-ports.
> 
> 
> https://github.com/macports/macports-ports/commit/117968ef4391653b839790af2b924baa3e7d19ea
> 
> The following commit(s) were added to refs/heads/master by this push:
> 
>  new 117968e  remove unused patches
> 
> 117968e is described below
> 
> 
> commit 117968ef4391653b839790af2b924baa3e7d19ea
> 
> Author: jabenninghoff
> AuthorDate: Sun Feb 11 11:39:46 2018 -0600
> 
> 
> remove unused patches

Please ensure that commit messages begin with the name of the port and a colon, 
e.g. "rsync: remove unused patches".

Perry, it's your responsibility to ensure commit messages conform to our 
guidelines before merging a PR.