Eloy,
I applied your change to dup, rolled out my change, and then the tests
that I wrote still pass.
-Scott
On Feb 12, 2009, at 2:02 PM, Eloy Duran wrote:
Hi Scott,
As you can see in this commit:
http://github.com/masterkain/macruby/commit/0cb18321229b35a61e9af46e068b3d55a3678bd6
I hav
Hi Scott,
As you can see in this commit:
http://github.com/masterkain/macruby/commit/0cb18321229b35a61e9af46e068b3d55a3678bd6
I have fixed the problem in a different way. Because if I understood
your intention right, then the problem was in #dup.
Please let me know if this fixes your issue, or
Eloy,
Here is an updated patch that uses spec style tests.
-Scott
hash_merge.patch
Description: Binary data
On Feb 12, 2009, at 9:16 AM, Eloy Duran wrote:
Hi Scott,
If you would like to re write your patch in a more spec style as the
one I pointed to that would be great!
We can then e
Hi Scott,
If you would like to re write your patch in a more spec style as the
one I pointed to that would be great!
We can then easily migrate it to rubyspec later on.
Thanks,
- Eloy
On 12 feb 2009, at 15:09, M. Scott Ford wrote:
Eloy,
I did not see your email before I submitted the patc
Eloy,
I did not see your email before I submitted the patch.
I glanced at the hash tests in the RubySpec project and there is not
much there, so moving this test into RubySpec sounds like a good idea.
Is that something that I should take care of now?
-Scott
On Feb 12, 2009, at 8:53 AM, El
Laurent,
The patch is attached.
-Scott
hash_merge.patch
Description: Binary data
On Feb 11, 2009, at 10:21 PM, Laurent Sansonetti wrote:
Thanks for the detective work Scott! Could you create a test case in
test/ruby/test_hash.rb and send us a patch? I would then merge it.
Laurent
___
Hi,
If this is a problem with the Objective-C Hash implementation, I would
be inclined to say that the test case should go in test-macruby/cases/
rubyspec/hash_test.rb.
Because we might need to move this into the rubyspec project, if it's
not already in there, once we start on integrating ru
Thanks for the detective work Scott! Could you create a test case in
test/ruby/test_hash.rb and send us a patch? I would then merge it.
Laurent
On Feb 11, 2009, at 12:11 PM, M. Scott Ford wrote:
And the fix.
Change rb_hash_merge to use rb_obj_dup instead of rb_hash_dup.
On Feb 11, 2009, at
And the fix.
Change rb_hash_merge to use rb_obj_dup instead of rb_hash_dup.
On Feb 11, 2009, at 2:48 PM, M. Scott Ford wrote:
Sorry to reply to my own post but I have been playing with this all
day to figure out what is wrong. I have narrowed the problem down to
the merge method, but I am n
Sorry to reply to my own post but I have been playing with this all
day to figure out what is wrong. I have narrowed the problem down to
the merge method, but I am not sure how to fix it. Here are some test
cases. These all pass in ruby 1.9.1. The first one fails in MacRuby
trunk, but the o
10 matches
Mail list logo
