[Mahara-contributors] [Bug 1218092] Re: Search in blocks that have a search doesn't work

2013-09-02 Thread Aaron Wells
To replicate: 1. Create multiple text boxes 2. Go to create another text box. 3. Click the link that says to use the text from another text box 4. In the text box selection are, click the Search tab 5. Enter a search value and submit it. Expected Result: It should limit the listed text boxes

[Mahara-contributors] [Bug 1218091] A change has been merged

2013-09-02 Thread Mahara Bot
Reviewed: https://reviews.mahara.org/2470 Committed: http://gitorious.org/mahara/mahara/commit/93dd97eee511afa4f15c97a373d7feb6e7cfd0d3 Submitter: Aaron Wells (aar...@catalyst.net.nz) Branch:master commit 93dd97eee511afa4f15c97a373d7feb6e7cfd0d3 Author: Robert Lyon Date: Thu Aug 29 15:22:

[Mahara-contributors] [Bug 1218091] Re: Pager in search in a block doesn't work

2013-09-02 Thread Aaron Wells
I split off part of https://reviews.mahara.org/#/c/2466/ into https://reviews.mahara.org/#/c/2470/ ** Changed in: mahara/1.5 Status: In Progress => Fix Committed ** Changed in: mahara/1.6 Status: In Progress => Fix Committed ** Changed in: mahara Status: In Progress => Fix C

[Mahara-contributors] [Bug 1218091] A change has been merged

2013-09-02 Thread Mahara Bot
Reviewed: https://reviews.mahara.org/2448 Committed: http://gitorious.org/mahara/mahara/commit/d70745a89db2db61fbdcf33e493d1ae7111ff945 Submitter: Aaron Wells (aar...@catalyst.net.nz) Branch:1.6_STABLE commit d70745a89db2db61fbdcf33e493d1ae7111ff945 Author: Robert Lyon Date: Thu Aug 29 15

[Mahara-contributors] [Bug 1218091] A change has been merged

2013-09-02 Thread Mahara Bot
Reviewed: https://reviews.mahara.org/2449 Committed: http://gitorious.org/mahara/mahara/commit/755dda4f64270dc0e923425318cc5fc4c220df60 Submitter: Aaron Wells (aar...@catalyst.net.nz) Branch:1.5_STABLE commit 755dda4f64270dc0e923425318cc5fc4c220df60 Author: Robert Lyon Date: Thu Aug 29 15

[Mahara-contributors] [Bug 1218091] A change has been merged

2013-09-02 Thread Mahara Bot
Reviewed: https://reviews.mahara.org/2447 Committed: http://gitorious.org/mahara/mahara/commit/aa8e3a1942444e6a01ebf934e160f00348ecbeca Submitter: Aaron Wells (aar...@catalyst.net.nz) Branch:1.7_STABLE commit aa8e3a1942444e6a01ebf934e160f00348ecbeca Author: Robert Lyon Date: Thu Aug 29 15

[Mahara-contributors] [Bug 1218091] Re: Pager in search in a block doesn't work

2013-09-02 Thread Aaron Wells
** Changed in: mahara/1.7 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org

[Mahara-contributors] [Bug 1220044] Re: allowed blocktypes and common blocktypes in chooser issue

2013-09-02 Thread Aaron Wells
Or to put it another way, contenteditor.tpl needs to respect the list of allowed blocktypes in the "local_get_allowed_blocktypes()" and "local_get_allowed_blocktype_categories()" functions. Although since those functions are category-specific, I'm not entirely sure how that's going to work... I gue

[Mahara-contributors] [Bug 1220044] [NEW] allowed blocktypes and common blocktypes in chooser issue

2013-09-02 Thread Robert Lyon
Public bug reported: Now that we are having a couple of common blocktypes being default on the artefact chooser panel there needs to be some sort of check to make sure the theme is allowed to see them. I know than in some themes they can have their blocktypes and blocktype categories be restrict

[Mahara-contributors] [Bug 1220028] Re: Warnings in the activity_process_queue cron task

2013-09-02 Thread Robert Lyon
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org foru

[Mahara-contributors] [Bug 1220028] A change has been merged

2013-09-02 Thread Mahara Bot
Reviewed: https://reviews.mahara.org/2468 Committed: http://gitorious.org/mahara/mahara/commit/7e6a6f56b34fe1e883db99b06c1a2c8efee153fb Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 7e6a6f56b34fe1e883db99b06c1a2c8efee153fb Author: Aaron Wells Date: Tue Sep 3 15:14:

[Mahara-contributors] [Bug 1220028] Re: Warnings in the activity_process_queue cron task

2013-09-02 Thread Aaron Wells
I figured the best thing to do is make the code that tries to generate the group homepage's URL be more robust for if the page has no group id. A more invasive alternative would have been to change the set_access() method so that you can tell it not to send out notifications, but it seemed like a l

[Mahara-contributors] [Bug 1220028] Re: Warnings in the activity_process_queue cron task

2013-09-02 Thread Aaron Wells
Hm, ultimately this is happening because one of the changes in the code was to use the proper API functions for creating a view and changing its access (View::create() and $view->set_access()) rather than inserting directly into the database, when creating the Group Homepage template page. This cau

[Mahara-contributors] [Bug 1220028] Re: Warnings in the activity_process_queue cron task

2013-09-02 Thread Aaron Wells
Using git bisect, it looks like the problem is caused by something added in the Pagemaker mega-change: 8b34dc82d4f25e8fec7f97658e5a53789dce8058 is the first bad commit commit 8b34dc82d4f25e8fec7f97658e5a53789dce8058 Author: Robert Lyon Date: Mon Aug 5 09:45:29 2013 +1200 Merging flexible l

[Mahara-contributors] [Bug 1220028] Re: Warnings in the activity_process_queue cron task

2013-09-02 Thread Aaron Wells
It's a regression, because this doesn't happen with a clean install of 1.7. On the other hand, it's just a warning, not an error, so it doesn't seem to kill your cron job, just throw some junk into your log. -- You received this bug notification because you are a member of Mahara Contributors, wh

[Mahara-contributors] [Bug 1220028] Re: Warnings in the activity_process_queue cron task

2013-09-02 Thread Aaron Wells
Specifically, you get this warning whenever there is any content in the activity_queue table. If it's empty, then activity_process_queue() doesn't throw a warning. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscr

[Mahara-contributors] [Bug 1220028] [NEW] Warnings in the activity_process_queue cron task

2013-09-02 Thread Aaron Wells
Public bug reported: To replicate: 1. Do a clean install of Mahara 1.8dev (from master) 2. After installation is complete, run the cron job. You see a bunch of warning messages from the activity_process_queue task: [INF] ab (lib/cron.php:153) Running core cron activity_process_queue [DBG] ab (l

[Mahara-contributors] [Bug 1017281] Re: The pagination drop down shows when less than 10 entries on the page.

2013-09-02 Thread Robert Lyon
new patch added https://reviews.mahara.org/#/c/2467/ this one changes pagination itself to hide dropbox selector if results are equal or less than minimum option ie 10 or fewer results ** Changed in: mahara Assignee: (unassigned) => Robert Lyon (robertl-9) ** Changed in: mahara Stat

[Mahara-contributors] [Bug 1194255] Re: ' Use content from another text box' showing incorrect titles

2013-09-02 Thread Robert Lyon
Have submitted patches to address this https://reviews.mahara.org/#/c/2463/ https://reviews.mahara.org/#/c/2464/ https://reviews.mahara.org/#/c/2465/ when $viewid is known get the current title from the blockinstance otherwise get a comma separated string of the current titles for all block instan

[Mahara-contributors] [Bug 634193] Re: post-max-size exceeding error is not tracked

2013-09-02 Thread Kristina Hoeppner
** Changed in: mahara Milestone: 1.8.0rc1 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before edi

[Mahara-contributors] [Bug 1044877] Re: Go back to the page on which you had started

2013-09-02 Thread Robert Lyon
I've taken what Jose Fontanilla began and reworked it a bit and submitted it https://reviews.mahara.org/#/c/2461/ This only works for the deleting of pages. The notes deletion works in a different way (delete via form submission). ** Changed in: mahara Status: Triaged => In Progress **

[Mahara-contributors] [Bug 1219666] Re: The help files for Elasticsearch need to be fixed

2013-09-02 Thread Kristina Hoeppner
Thanks, Mits. I took that as occasion to also look at the strings in general fixing them up a bit. I had not yet done the general lang string review of new strings in 1.8. https://reviews.mahara.org/2462 ** Summary changed: - The help file for Elasticsearch Analyzer needs to be fixed. + The help

[Mahara-contributors] [Bug 634193] Re: post-max-size exceeding error is not tracked

2013-09-02 Thread Robert Lyon
Not sure if this may be of help: In something I was working on there was a case where post_max_size can caused problem when exceeded as the $_POST becomes empty. To check for that I'd used the code: if (empty($_FILES) && empty($_POST) && isset($_SERVER['REQUEST_METHOD']) && strtolower($_SERVER['

[Mahara-contributors] [Bug 692769] Re: [Ongoing] Make sure that the print stylesheet still works

2013-09-02 Thread Robert Lyon
** Summary changed: - Make sure that the print stylesheet still works + [Ongoing] Make sure that the print stylesheet still works -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mah

[Mahara-contributors] [Bug 1214124] A change has been merged

2013-09-02 Thread Mahara Bot
Reviewed: https://reviews.mahara.org/2431 Committed: http://gitorious.org/mahara/mahara/commit/6764ecbfe85a6f87f73e0c2319d6ae57dc485930 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 6764ecbfe85a6f87f73e0c2319d6ae57dc485930 Author: Robert Lyon Date: Fri Aug 23 13:23

[Mahara-contributors] [Bug 1216764] Re: JSON error when using drop zone

2013-09-02 Thread Robert Lyon
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org foru

[Mahara-contributors] [Bug 1214124] Re: Improve stylesheet cacheing

2013-09-02 Thread Robert Lyon
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org foru

[Mahara-contributors] [Bug 1219666] [NEW] The help file for Elasticsearch Analyzer needs to be fixed.

2013-09-02 Thread Mitsuhiro Yoshida
Public bug reported: The help file for Elasticsearch Analyzer needs to be fixed. The help file for Elasticsearch Analyzer needs to be fixed as below. Help file: search/elasticsearch/lang/en.utf8/help/forms/pluginconfig.analyzer.html [Before] http://www.elasticsearch.org/guide/reference/index-mo