[Mahara-contributors] [Bug 1391073] [NEW] missing closing if-tag in topright.tpl template

2014-11-10 Thread Tobias Zeuch
Public bug reported: Found a template-issue in the current head: In the dwoo template topright.tpl the if-tag for {if $item.icon} has no corresponding closing if-tag ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a

[Mahara-contributors] [Bug 1391073] A patch has been submitted for review

2014-11-10 Thread Mahara Bot
Patch for master branch: https://reviews.mahara.org/3956 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before

[Mahara-contributors] [Bug 1354222] Re: Files within a group aren't deleted after deleting the group

2014-11-10 Thread Lars
Aaron. 1) We are working on this as a 2) part of the cronjob. We decided not to assign the files uploaded in a group to a certain user, instead we will make the cron delete them, IF and only IF they aren't used in a view any longer. The reason we don't want to assign the file to a user is

[Mahara-contributors] [Bug 1382905] A change has been merged

2014-11-10 Thread Mahara Bot
Reviewed: https://reviews.mahara.org/3866 Committed: http://gitorious.org/mahara/mahara/commit/f4dbb0162d217dfe731fbbbfb0f630a142fadd9d Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit f4dbb0162d217dfe731fbbbfb0f630a142fadd9d Author: Tobias Zeuch tobias.ze...@kit.edu

[Mahara-contributors] [Bug 1382905] Re: Do not show Delete check box for notifications that can't be deleted

2014-11-10 Thread Robert Lyon
** Changed in: mahara Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org

[Mahara-contributors] [Bug 1252085] A patch has been submitted for review

2014-11-10 Thread Mahara Bot
Patch for master branch: https://reviews.mahara.org/3960 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before

[Mahara-contributors] [Bug 1354222] Re: Files within a group aren't deleted after deleting the group

2014-11-10 Thread Kristina Hoeppner
Hi Lars, Thank you for looking into fixing the issue. Is it OK with you if I assign you to it or would it be somebody else? Thank you Kristina -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions:

[Mahara-contributors] [Bug 1382905] Re: Do not show Delete check box for notifications that can't be deleted

2014-11-10 Thread Kristina Hoeppner
** Tags added: usermanualupdate -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing

[Mahara-contributors] [Bug 1391073] Re: missing closing if-tag in topright.tpl template

2014-11-10 Thread Kristina Hoeppner
** Changed in: mahara Status: New = In Progress ** Changed in: mahara Milestone: None = 15.04.0 ** Changed in: mahara Assignee: (unassigned) = Tobias Zeuch (tobias-zeuch-8) -- You received this bug notification because you are a member of Mahara Contributors, which is

[Mahara-contributors] [Bug 1360535] Re: Set default sort order for page sorting

2014-11-10 Thread Kristina Hoeppner
** Changed in: mahara Milestone: None = 15.04.0 ** Changed in: mahara Assignee: (unassigned) = Tobias Zeuch (tobias-zeuch-8) ** Changed in: mahara Status: Confirmed = Fix Committed ** Tags added: nominatedfeature -- You received this bug notification because you are a member

[Mahara-contributors] [Bug 1384496] Re: Update mobiledetect to 2.8.5

2014-11-10 Thread Kristina Hoeppner
** Changed in: mahara Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org

[Mahara-contributors] [Bug 1391073] Re: missing closing if-tag in topright.tpl template

2014-11-10 Thread Aaron Wells
** Also affects: mahara/1.10 Importance: Undecided Status: New ** Also affects: mahara/15.04 Importance: Undecided Assignee: Tobias Zeuch (tobias-zeuch-8) Status: In Progress ** Changed in: mahara/1.10 Milestone: None = 1.10.1 ** Changed in: mahara/1.10

[Mahara-contributors] [Bug 1391004] Re: Allow admin/staff to edit the list of suggested social media profiles

2014-11-10 Thread Kristina Hoeppner
Would users still be able to add any sites of their own that the site admin had not yet thought about? If so, we would still need bug #1391004. If users can't add their own profiles, the site admin would need to maintain a potentially quite long list. When would they be able to take out old

[Mahara-contributors] [Bug 1391073] A patch has been submitted for review

2014-11-10 Thread Mahara Bot
Patch for 1.10_STABLE branch: https://reviews.mahara.org/3961 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum

[Mahara-contributors] [Bug 1391073] A change has been merged

2014-11-10 Thread Mahara Bot
Reviewed: https://reviews.mahara.org/3956 Committed: http://gitorious.org/mahara/mahara/commit/82879c61f649c8da44ea64a6cbda2057a91b3d09 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 82879c61f649c8da44ea64a6cbda2057a91b3d09 Author: Tobias Zeuch tobias.ze...@kit.edu

[Mahara-contributors] [Bug 1391073] Re: missing closing if-tag in topright.tpl template

2014-11-10 Thread Robert Lyon
** Changed in: mahara/15.04 Importance: Undecided = Medium ** Changed in: mahara/15.04 Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all

[Mahara-contributors] [Bug 1340151] Re: Consider a different approach to libxml_disable_entity_loader(true) in init.php

2014-11-10 Thread Aaron Wells
Hi Yuliya, Any specific operation in Moodle that causes problems? I seem to recall that maybe it was creating (or restoring) course backups that could foul up? Because that's actually using XML, which is what gets affected by this bug. Cheers, Aaron -- You received this bug notification

[Mahara-contributors] [Bug 1391004] Re: Allow admin/staff to edit the list of suggested social media profiles

2014-11-10 Thread Aaron Wells
We could change the default favicon service to http://getfavicon.appspot.com. That one works for Flickr, and it may be more reliable across the board. http://getfavicon.appspot.com/http://www.flickr.com -- You received this bug notification because you are a member of Mahara Contributors, which

[Mahara-contributors] [Bug 1391004] Re: Allow admin/staff to edit the list of suggested social media profiles

2014-11-10 Thread Aaron Wells
Hi Kristina, You mean Bug 1388665: Use the favicon identification code for social media profiles ? As I mentioned on that bug, we already use the same technique for fetching favicons here as we do for the iframes. (Try adding flickr.com as an iframe source and you'll see that it gets that same

[Mahara-contributors] [Bug 946880] A change has been merged

2014-11-10 Thread Mahara Bot
Reviewed: https://reviews.mahara.org/3506 Committed: http://gitorious.org/mahara/mahara/commit/cb26cb8a8d6f5c2e49475788d7f942dfb0686ac6 Submitter: Aaron Wells (aar...@catalyst.net.nz) Branch:master commit cb26cb8a8d6f5c2e49475788d7f942dfb0686ac6 Author: Nigel Cunningham

[Mahara-contributors] [Bug 1391393] [NEW] When you're required to fill in mandatory fields after login, you should be sent to your requested URL afterward

2014-11-10 Thread Aaron Wells
Public bug reported: As originally described here: https://bugs.launchpad.net/mahara/+bug/946880/comments/15 I have another suggestion, with a patch that I've just pushed. The required fields form works by hijacking any link that the user has requested, so all we need to do after the user has

[Mahara-contributors] [Bug 1391393] Re: When you're required to fill in mandatory fields after login, you should be sent to your requested URL afterward

2014-11-10 Thread Aaron Wells
Patch for master branch: https://reviews.mahara.org/3507 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before

[Mahara-contributors] [Bug 946880] A patch has been submitted for review

2014-11-10 Thread Mahara Bot
Patch for 1.10_STABLE branch: https://reviews.mahara.org/3962 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum

[Mahara-contributors] [Bug 946880] A patch has been submitted for review

2014-11-10 Thread Mahara Bot
Patch for 1.9_STABLE branch: https://reviews.mahara.org/3963 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum

[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting

2014-11-10 Thread Aaron Wells
There were two patches for this bug. The first one, https://reviews.mahara.org/#/c/3506/, fixes the problem initially described. The second one, https://reviews.mahara.org/#/c/3507/, fixes a related problem described in comment #15. I've merged patch 3506, but found problems with patch 3507. So

[Mahara-contributors] [Bug 946880] A change has been merged

2014-11-10 Thread Mahara Bot
Reviewed: https://reviews.mahara.org/3964 Committed: http://gitorious.org/mahara/mahara/commit/b3a168117a9cd1cdec7a115fd95b8b1a3127636c Submitter: Aaron Wells (aar...@catalyst.net.nz) Branch:1.8_STABLE commit b3a168117a9cd1cdec7a115fd95b8b1a3127636c Author: Nigel Cunningham

[Mahara-contributors] [Bug 946880] A patch has been submitted for review

2014-11-10 Thread Mahara Bot
Patch for 1.8_STABLE branch: https://reviews.mahara.org/3964 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum

[Mahara-contributors] [Bug 946880] A change has been merged

2014-11-10 Thread Mahara Bot
Reviewed: https://reviews.mahara.org/3962 Committed: http://gitorious.org/mahara/mahara/commit/981608927926ba22dd9246934515f5580adcee6f Submitter: Aaron Wells (aar...@catalyst.net.nz) Branch:1.10_STABLE commit 981608927926ba22dd9246934515f5580adcee6f Author: Nigel Cunningham

[Mahara-contributors] [Bug 946880] Re: Broken html error message for no-reply email setting

2014-11-10 Thread Aaron Wells
** Changed in: mahara/1.10 Importance: Undecided = Low ** Changed in: mahara/1.10 Status: New = Fix Committed ** Changed in: mahara/1.10 Milestone: None = 1.10.1 ** Changed in: mahara/1.8 Importance: Undecided = Low ** Changed in: mahara/1.8 Status: New = Fix Committed

[Mahara-contributors] [Bug 1353069] Re: db_format_tsfield() returning time value with offset on POstgres

2014-11-10 Thread Aaron Wells
Worth noting, there's an in-depth discussion of how Mahara handles time values here: https://mahara.org/interaction/forum/topic.php?id=6045#post25831 And, indeed, it is written with the assumption that the (no-TZ) timestamp stored in the DB will have the database server's timezone applied to it

[Mahara-contributors] [Bug 1353069] Re: db_format_tsfield() returning time value with offset on POstgres

2014-11-10 Thread Aaron Wells
To any future readers who've stumbled across this bug report because you're having time issues in Mahara, it's also worth noting that there's a separate problem that can be caused if Mahara's web server has a different timezone than its database server, and we added a $cfg-dbtimezone setting in

[Mahara-contributors] [Bug 1045123] Re: don't send out password for admin created users

2014-11-10 Thread Aaron Wells
We should include these options (inspired by what Moodle has): 1. Checkbox (ticked by default): Send one-time login link to user If this is ticked, it greys out the other options. 2. Text box: Password 3. Checkbox (ticked by default): Force password change If you tick box #1, it should send

[Mahara-contributors] [Bug 1384009] A change has been merged

2014-11-10 Thread Mahara Bot
Reviewed: https://reviews.mahara.org/3939 Committed: http://gitorious.org/mahara/mahara/commit/e7d46cfc36d0a45a99c7dd598a455e0556d9f4b5 Submitter: Aaron Wells (aar...@catalyst.net.nz) Branch:master commit e7d46cfc36d0a45a99c7dd598a455e0556d9f4b5 Author: Aaron Wells aar...@catalyst.net.nz

[Mahara-contributors] [Bug 1384009] Re: Cookie lacking secure flag for HTTPS sites

2014-11-10 Thread Aaron Wells
Robert, Can you please publish your draft change https://reviews.mahara.org/#/c/3898/2 ? I've marked this as a public security bug, so there's no need to keep the patch secret now. Cheers, Aaron -- You received this bug notification because you are a member of Mahara Contributors, which is

[Mahara-contributors] [Bug 1389913] A change has been merged

2014-11-10 Thread Mahara Bot
Reviewed: https://reviews.mahara.org/3932 Committed: http://gitorious.org/mahara/mahara/commit/78b97d4e8f77423151e40b3cf7ffb3ed8eab1698 Submitter: Aaron Wells (aar...@catalyst.net.nz) Branch:master commit 78b97d4e8f77423151e40b3cf7ffb3ed8eab1698 Author: Robert Lyon robe...@catalyst.net.nz

[Mahara-contributors] [Bug 1387365] A change has been merged

2014-11-10 Thread Mahara Bot
Reviewed: https://reviews.mahara.org/3881 Committed: http://gitorious.org/mahara/mahara/commit/b57028242aa47ffa4b89a39213c8fb7657cd2f0b Submitter: Aaron Wells (aar...@catalyst.net.nz) Branch:master commit b57028242aa47ffa4b89a39213c8fb7657cd2f0b Author: Robert Lyon robe...@catalyst.net.nz