[Mahara-contributors] [Bug 1689685] Re: SAML SSO authentication doesn't work as SimpleSAMLphp generates non-existent AssertionConsumerServiceURL

2017-05-16 Thread Robert Lyon
Looking at the code I suspect its worked for some but not others is due to public function startSSO($idp, array $state) in extlib/simplesamlphp/modules/saml/lib/Auth/Source/SP.php where startSSO1 doesn't call the setAssertionConsumerServiceURL() but startSSO2 does The problem with fixing this

[Mahara-contributors] [Bug 1691329] [NEW] Fetching folder size value not working for Mysql

2017-05-16 Thread Robert Lyon
Public bug reported: We have a bit of code to estimate the size of a folder to display it in the files content list. This works on postgres but fails on mysql The issue is when we call SUM(aff.size) in postgres it sets the column title to sum for the results but with mysql it returns

[Mahara-contributors] [Bug 1689685] Re: SAML SSO authentication doesn't work as SimpleSAMLphp generates non-existent AssertionConsumerServiceURL

2017-05-16 Thread Kristina Hoeppner
Tagged it to 17.10 so it stays on our radar to look at since we can't verify it immediately. ** Changed in: mahara Milestone: None => 17.10.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions:

[Mahara-contributors] [Bug 1691317] A patch has been submitted for review

2017-05-16 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/7766 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum

[Mahara-contributors] [Bug 1691317] [NEW] Allow LTI to be a child auth

2017-05-16 Thread Robert Lyon
Public bug reported: Set a parent auth for LTI external app so that if a user logs in for the first time via LTI SSO they create a user in Mahara with parent auth as the main auth so the user can log in direct to mahara as well as via the LTI SSO ** Affects: mahara Importance: Wishlist

[Mahara-contributors] [Bug 1691313] [NEW] Using 'No title' for new page is not needed now that we create the page before displaying config form

2017-05-16 Thread Robert Lyon
Public bug reported: Way back when in Mahara when a user wanted to create a page they needed to fill in details first before saving the page title/metadata. So a $new var was passed about so we knew we were in this state. Also the page was called 'No title' to be shown in browser titlebar. But

[Mahara-contributors] [Bug 1689685] Re: SAML SSO authentication doesn't work as SimpleSAMLphp generates non-existent AssertionConsumerServiceURL

2017-05-16 Thread Yaju Mahida
Hi Shane, We had to fix this on SimpleSAMLphp library (1.14.7) mahara/htdocs/auth/saml/extlib/simplesamlphp/modules/saml/lib/Auth/Source/SP.php line 189 From $ar->setAssertionConsumerServiceURL(SimpleSAML_Module::getModuleURL('saml/sp/saml2-acs.php/' . $this->authId)); To

[Mahara-contributors] [Bug 1689685] Re: SAML SSO authentication doesn't work as SimpleSAMLphp generates non-existent AssertionConsumerServiceURL

2017-05-16 Thread shane
@Yaju Can you share what changes you made to get it working? -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum

[Mahara-contributors] [Bug 1688452] A change has been merged

2017-05-16 Thread Mahara Bot
Reviewed: https://reviews.mahara.org/7716 Committed: https://git.mahara.org/mahara/mahara/commit/1d8cdcd89256966042fecffcda8196528057ac61 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 1d8cdcd89256966042fecffcda8196528057ac61 Author: Amalie Hendy

[Mahara-contributors] [Bug 1688452] Re: Need to change 'Make public' for comment section to say 'Make comment public'

2017-05-16 Thread Robert Lyon
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org

[Mahara-contributors] [Bug 1688452] A change has been merged

2017-05-16 Thread Mahara Bot
Reviewed: https://reviews.mahara.org/7717 Committed: https://git.mahara.org/mahara/mahara/commit/1ea505f3ee1ec4755250b9105705b1a30961565d Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 1ea505f3ee1ec4755250b9105705b1a30961565d Author: Amalie Hendy

[Mahara-contributors] [Bug 1575512] Re: Behat tests are failing due to not waiting for Javascript to finish

2017-05-16 Thread Robert Lyon
** Changed in: mahara/17.10 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or

[Mahara-contributors] [Bug 1690687] A patch has been submitted for review

2017-05-16 Thread Mahara Bot
Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7764 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org

[Mahara-contributors] [Bug 1690687] A change has been merged

2017-05-16 Thread Mahara Bot
Reviewed: https://reviews.mahara.org/7760 Committed: https://git.mahara.org/mahara/mahara/commit/8750854f471eb78d621b12cb5abb1e5ad0a51d84 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 8750854f471eb78d621b12cb5abb1e5ad0a51d84 Author: Robert Lyon

[Mahara-contributors] [Bug 1690687] A change has been merged

2017-05-16 Thread Mahara Bot
Reviewed: https://reviews.mahara.org/7764 Committed: https://git.mahara.org/mahara/mahara/commit/47d08b2442fe3efc76f425e5f29521fefa6ccc0c Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:17.04_STABLE commit 47d08b2442fe3efc76f425e5f29521fefa6ccc0c Author: Robert Lyon

[Mahara-contributors] [Bug 1690687] Re: Excluded tagged entries are not styled differently now

2017-05-16 Thread Robert Lyon
** Changed in: mahara/17.10 Status: In Progress => Fix Committed ** Changed in: mahara/17.04 Status: New => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for

[Mahara-contributors] [Bug 1575512] A change has been merged

2017-05-16 Thread Mahara Bot
Reviewed: https://reviews.mahara.org/6988 Committed: https://git.mahara.org/mahara/mahara/commit/f27e5ebf72bb88e8feac9fced877c27c5f7eec3e Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit f27e5ebf72bb88e8feac9fced877c27c5f7eec3e Author: Son Nguyen