[Mahara-contributors] [Bug 1889369] [NEW] Language menu shows when there's only one language

2020-07-29 Thread Peter Spicer
Public bug reported: On a fresh 20.04, we've seen cases of the language menu showing up even when only one language is actually present. The reason is that LANGCHOICES is an array of all possible languages that can be selected, and the test in the template to show/hide the language selector is

[Mahara-contributors] [Bug 1859605] Re: Mahara portfolio as Moodle assignment cannot be previewed

2020-01-14 Thread Peter Spicer
On reflection, I've just pushed the changes for review as-is for 18.10, 19.04, 19.10 and master. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask

[Mahara-contributors] [Bug 1859605] [NEW] Mahara portfolio as Moodle assignment cannot be previewed

2020-01-14 Thread Peter Spicer
Public bug reported: When using the assignsubmission_mahara plugin to connect Moodle assignments to Mahara, the link to view the portfolio works fine to open Mahara, but the preview iframe in Moodle doesn't. This is because MNET auth doesn't set up the session in the same way as LTI does with

[Mahara-contributors] [Bug 1839157] [NEW] Behat configurable via environment variables

2019-08-06 Thread Peter Spicer
Public bug reported: Currently Behat is hardcoded to respond to localhost/127.0.0.1, which is fine in a lot of cases but it makes it difficult if trying to use Docker or similar where specific hostnames or ports won't be available. Additionally, the mahara_behat.sh runner starts and stops

[Mahara-contributors] [Bug 1837194] Re: Adding notifications hooks for plugins

2019-07-19 Thread Peter Spicer
Here's also the patch for the inbox. Note the change to the JS, I don't remember exactly why that was there but from my notes, it seems that if you came to the message directly (e.g. from Moodle's notifications, which is what this patch was for), the act of opening it directly would break the

[Mahara-contributors] [Bug 1837194] Re: Adding notifications hooks for plugins

2019-07-19 Thread Peter Spicer
** Patch added: "notification_msg_create.diff" https://bugs.launchpad.net/mahara/+bug/1837194/+attachment/5278049/+files/notification_msg_create.diff -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions:

[Mahara-contributors] [Bug 1837194] Re: Adding notifications hooks for plugins

2019-07-19 Thread Peter Spicer
** Patch added: "notification_delete.diff" https://bugs.launchpad.net/mahara/+bug/1837194/+attachment/5278051/+files/notification_delete.diff -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions:

[Mahara-contributors] [Bug 1837194] Re: Adding notifications hooks for plugins

2019-07-19 Thread Peter Spicer
Here's the first bunch of patches, these represent the core functionality of letting notifications be passed to a plugin to do something additional with them. ** Patch added: "notification_internal_create.diff"

[Mahara-contributors] [Bug 1837194] Re: Adding notifications hooks for plugins

2019-07-19 Thread Peter Spicer
** Patch added: "notification_delete_bulk.diff" https://bugs.launchpad.net/mahara/+bug/1837194/+attachment/5278052/+files/notification_delete_bulk.diff -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching

[Mahara-contributors] [Bug 1837194] Re: Adding notifications hooks for plugins

2019-07-19 Thread Peter Spicer
** Patch added: "notification_read.diff" https://bugs.launchpad.net/mahara/+bug/1837194/+attachment/5278050/+files/notification_read.diff -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription

[Mahara-contributors] [Bug 1837194] [NEW] Adding notifications hooks for plugins

2019-07-19 Thread Peter Spicer
Public bug reported: At Moodlemoot UK 2019, I demoed a piece of work we'd done for QMUL to better integrate their Moodle and Mahara - https://www.youtube.com/watch?v=Ixy4Ah9webQ for the presentation - and said I'd talk to the Mahara team about getting it into core so I could then release the rest

[Mahara-contributors] [Bug 1824386] [NEW] Inappropriate comparison for DB versions

2019-04-11 Thread Peter Spicer
Public bug reported: Relevant code from htdocs/init.php if (is_postgres()) { $okversion = '8.3'; $dbfriendlyname = 'PostgreSQL'; } else if (is_mysql()) { $okversion = '5.0.25'; $dbfriendlyname = 'MySQL'; } if (floatval($dbversion['version']) <

[Mahara-contributors] [Bug 1788625] [NEW] auth/saml claims to require mcrypt - but mcrypt dropped from SSPHP

2018-08-23 Thread Peter Spicer
Public bug reported: As of SimpleSAMLphp 1.15.0, their dependencies on mcrypt were removed as mcrypt is deprecated in PHP 7. Since current builds of Mahara use SimpleSAMLphp 1.15.0 or higher, the warning about no mcrypt could be removed. ** Affects: mahara Importance: Undecided

[Mahara-contributors] [Bug 1788173] [NEW] Incorrect language strings in module_lti and module_mobileapi

2018-08-21 Thread Peter Spicer
Public bug reported: Both module_lti and module_mobileapi contain the following language string: $string['configstep'] = 'Conguration item'; This should read $string['configstep'] = 'Configuration item'; ** Affects: mahara Importance: Undecided Status: New -- You received this

[Mahara-contributors] [Bug 1787583] [NEW] Redis support can't be used without sentinel (18.04)

2018-08-17 Thread Peter Spicer
Public bug reported: Redis support for the session handler was added in #1747297 (in 18.04) but the connector requires sentinel support (which isn't documented), and can't be used with the AWS Redis-as-a-service feature. Or at least, if it can, it's not clear how to actually do that, because all

[Mahara-contributors] [Bug 1427885] Re: Change "artefact.path" column to use the "nested set" technique for managing hierarchical data

2018-01-16 Thread Peter Spicer
Regarding nested sets, there is one problem - it's not just slower on write, it gets progressively slower the more nodes in the tree since in the usual implementation you need to update the left/right values for every single set in the tree... which potentially amounts to every row in the table.

[Mahara-contributors] [Bug 1734171] Re: Revoke privacy consent

2017-11-27 Thread Peter Spicer
There is one caveat: when consent is withdrawn, it will usually cover all of the rights to processing, which includes holding the data at all. Fortunately for most installations this shouldn't be a problem because in most cases there's more than just consent for the data being the right to process