[Mahara-contributors] [Bug 1220028] Re: Warnings in the activity_process_queue cron task

2013-10-23 Thread Aaron Wells
** Changed in: mahara Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org

[Mahara-contributors] [Bug 1220028] Re: Warnings in the activity_process_queue cron task

2013-09-30 Thread Aaron Wells
** Changed in: mahara Milestone: 1.8rc1 = 1.8.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before

[Mahara-contributors] [Bug 1220028] Re: Warnings in the activity_process_queue cron task

2013-09-02 Thread Aaron Wells
Specifically, you get this warning whenever there is any content in the activity_queue table. If it's empty, then activity_process_queue() doesn't throw a warning. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching

[Mahara-contributors] [Bug 1220028] Re: Warnings in the activity_process_queue cron task

2013-09-02 Thread Aaron Wells
It's a regression, because this doesn't happen with a clean install of 1.7. On the other hand, it's just a warning, not an error, so it doesn't seem to kill your cron job, just throw some junk into your log. -- You received this bug notification because you are a member of Mahara Contributors,

[Mahara-contributors] [Bug 1220028] Re: Warnings in the activity_process_queue cron task

2013-09-02 Thread Aaron Wells
Using git bisect, it looks like the problem is caused by something added in the Pagemaker mega-change: 8b34dc82d4f25e8fec7f97658e5a53789dce8058 is the first bad commit commit 8b34dc82d4f25e8fec7f97658e5a53789dce8058 Author: Robert Lyon robe...@catalyst.net.nz Date: Mon Aug 5 09:45:29 2013 +1200

[Mahara-contributors] [Bug 1220028] Re: Warnings in the activity_process_queue cron task

2013-09-02 Thread Aaron Wells
Hm, ultimately this is happening because one of the changes in the code was to use the proper API functions for creating a view and changing its access (View::create() and $view-set_access()) rather than inserting directly into the database, when creating the Group Homepage template page. This

[Mahara-contributors] [Bug 1220028] Re: Warnings in the activity_process_queue cron task

2013-09-02 Thread Aaron Wells
I figured the best thing to do is make the code that tries to generate the group homepage's URL be more robust for if the page has no group id. A more invasive alternative would have been to change the set_access() method so that you can tell it not to send out notifications, but it seemed like a

[Mahara-contributors] [Bug 1220028] Re: Warnings in the activity_process_queue cron task

2013-09-02 Thread Robert Lyon
** Changed in: mahara Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org