Reviewed: https://reviews.mahara.org/10327 Committed: https://git.mahara.org/mahara/mahara/commit/1622bd2e02a302df961451459781e0ca662e2a02 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch: master
commit 1622bd2e02a302df961451459781e0ca662e2a02 Author: Evonne <evo...@catalyst.net.nz> Date: Tue Sep 10 15:28:54 2019 +1200 Bug 1843363 Add space between external media video and card header Put in class card-body for external media video block to add the space and be consistent with other blocks. behatnotneeded Change-Id: I164ecff8b2505a5f5e393ff623dff4512f296345 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1843363 Title: Add space between external media video and card header Status in Mahara: Fix Committed Bug description: When you have an image, the image has a bit of space to the block heading whereas "External media" does not. The latter is missing the card body class. "Embedded media" for internal video does have the class again. see attachment To replicate: 1. Add a photo to a page. 2. Add a YouTube video to the page via the "External media" block. Expected result: Both media items have a bit of space to the block header. Actual result: Only the image has the space. The YouTube video is right at the header line so it's hardly visible. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1843363/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
