[Mahara-contributors] [Bug 620258] Re: View access accessible when view is in a collection

2010-08-19 Thread Stacey Walker
Hi Kristina,

Are you talking about the link to the access page from the view itself?

I just discovered that by clicking on the visible 'Edit Access' in the
top right of the view takes me back to the current views access page
without realising that it is part of a collection.

I am wondering if we might want to:

a) change 'Edit Access' to go to the collections access page when the view is 
part of a collection and,
b) add an 'Edit Collection' link up there - so that a user can be looking at 
their new collections display and decide that hang on that view doesn't quite 
belong in this collection now that I think about it ...  or hmm, I want to 
change that navigation order around a bit and want easy access back to this

Obviously there might be other solutions but these seem the easiest. :)

-- 
View access accessible when view is in a collection
https://bugs.launchpad.net/bugs/620258
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.

Status in Mahara ePortfolio: New

Bug description:
When a view is in a collection, its Edit Access page is still accessible and 
the access rights can be changed. When I went into the collection access 
rights, the new user had been added as well though I did not get a message on 
the view access page telling me that I update the collection access at the same 
time. 

When I go to the view access page of another view in the same collection, I 
still have the old access rights in there.

As collection access rights overwrite view access rights, I would disable the 
Edit View Access link on a view that sits in a collection. The user cannot 
get to it from the view overview page - why should he get to it on the actual 
view? That would make it easier to edit the access rights for a collection 
really only on the collection page.



___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 619266] Re: Collection missing 'cancel' during create functionality

2010-08-19 Thread Stacey Walker
While fixing this I thought about visually making the 'next' element on
the right of the 'cancel' (which I'd wanted to do for a while).

Using the existing submitcancel pieform element this wasn't possible due
to the explicit indexing and drawing of the elements in the return
statement.

I had originally copied this and created a new element called
cancelsubmit that simply just reversed everything.  Richard then
suggested that we instead make the submitcancel element more generic and
handle some string indices as well as the default numeric indices.  That
way we can add the submit/cancel buttons in any order we want by
specifying what they are with 'cancel' and 'submit' as array keys.  The
way they are entered into the array determines the order in which they
will be drawn in the form.

http://gitorious.org/~stacey/mahara/staceys-
sandbox/commit/b2989c50b8b4e74c494c93fde97261fae560f568

e.g.,  we can add cancel and submit buttons by either of the following
ways:

$elements['submit']['values'] = array(
'submit' = get_string('submit'),
'cancel' = get_string('cancel'),
);
 
 or,

$elements['submit']['values'] = array(get_string('cancel'),
get_string('submit'));

The first syntax might also mean that we can have any amount of elements
if we wanted; provided the plugin does exist.

e.g.,

$elements['submit']['values'] = array(
'submit'  = get_string('submit'),
'cancel'  = get_string('cancel'),
'anotherplugin' = get_string('anotherplugin'),
...
);

I haven't tested just what you can add in there yet. :) but if it does
work with lots of plugins, then it might solve one of the TODOs at the
bottom of this page:
http://wiki.mahara.org/Developer_Area/Core_Subsystems/Form_API_(Pieforms)

any thoughts?

I also have the simple fix for the cancellation issue now, but I need to
separate it out into more appropriate commits before pushing to master.

-- 
Collection missing 'cancel' during create functionality
https://bugs.launchpad.net/bugs/619266
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.

Status in Mahara ePortfolio: In Progress

Bug description:
Functionality for canceling creation of a new collection has disappeared.

Using the existing functionality in view creation as a template, this should be 
checking for the 'new' flag, alerting the user about the fact that they are 
canceling and then removing all traces of the aborted collection.

Edit collection, add views and collection access pages need to ensure the user 
can cancel creation at any stage.



___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 620258] Re: View access accessible when view is in a collection

2010-08-19 Thread Kristina Hoeppner
Hi Stacey,

 Are you talking about the link to the access page from the view
itself?

Yes, exactly.

I'm fonder of option a) when it can be made clear that they will be
looking at the collection access page and not the view access page. And
that they'll be changing the access for the entire collection.

-- 
View access accessible when view is in a collection
https://bugs.launchpad.net/bugs/620258
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.

Status in Mahara ePortfolio: New

Bug description:
When a view is in a collection, its Edit Access page is still accessible and 
the access rights can be changed. When I went into the collection access 
rights, the new user had been added as well though I did not get a message on 
the view access page telling me that I update the collection access at the same 
time. 

When I go to the view access page of another view in the same collection, I 
still have the old access rights in there.

As collection access rights overwrite view access rights, I would disable the 
Edit View Access link on a view that sits in a collection. The user cannot 
get to it from the view overview page - why should he get to it on the actual 
view? That would make it easier to edit the access rights for a collection 
really only on the collection page.



___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 620258] Re: View access accessible when view is in a collection

2010-08-19 Thread Stacey Walker
What do you think of adding the 'Edit Collection' link as well?  I'd
imagine this just linking to the collection/views.php page for managing
viewlists.

-- 
View access accessible when view is in a collection
https://bugs.launchpad.net/bugs/620258
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.

Status in Mahara ePortfolio: New

Bug description:
When a view is in a collection, its Edit Access page is still accessible and 
the access rights can be changed. When I went into the collection access 
rights, the new user had been added as well though I did not get a message on 
the view access page telling me that I update the collection access at the same 
time. 

When I go to the view access page of another view in the same collection, I 
still have the old access rights in there.

As collection access rights overwrite view access rights, I would disable the 
Edit View Access link on a view that sits in a collection. The user cannot 
get to it from the view overview page - why should he get to it on the actual 
view? That would make it easier to edit the access rights for a collection 
really only on the collection page.



___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 620825] Re: Remove rank within mahara.org-registered sites from stats area

2010-08-19 Thread Richard Mansfield
** Changed in: mahara
   Status: Confirmed = Fix Committed

-- 
Remove rank within mahara.org-registered sites from stats area
https://bugs.launchpad.net/bugs/620825
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.

Status in Mahara ePortfolio: Fix Committed

Bug description:
If your site is registered at mahara.org, the stats area displays information 
about where your site ranks (in number of users, groups, views) when compared 
with other registered sites, e.g. http://master.dev.mahara.org says this:

Users: 171 (Rank: 60*)
Groups: 27 (Rank: 42*)
Views: 546 (Rank: 42*)

No information about any other sites is transmitted from mahara.org or 
displayed, but we are going to remove this information from the stats area 
anyway, just in case it raises privacy concerns.  Ranking information will also 
be removed from the response that mahara.org sends back to the site after the 
registration data has been sent.



___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 619057] Re: http://master.dev.mahara.org sets wrong default block title in contact block

2010-08-19 Thread Richard Mansfield
I can't seem to reproduce this one Heinz.  Is it still happening for
you?  Which browser are you using?

It's a bit like that other bug you reported where the text on a button
changed to something completely unexpected
(https://bugs.launchpad.net/mahara/+bug/492902)

** Changed in: mahara
   Status: Triaged = Incomplete

-- 
http://master.dev.mahara.org sets wrong default block title in contact block
https://bugs.launchpad.net/bugs/619057
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.

Status in Mahara ePortfolio: Incomplete

Bug description:
While playing with http://master.dev.mahara.org

I noticed that after adding a navigation block and renaming the block title for 
this block the next added contact block has a wrong block title which is the 
former used text. 

See attached screenie



___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 620175] Re: Display of the colon in employment history titles in resume and view

2010-08-19 Thread Richard Mansfield
** Changed in: mahara
   Status: New = Confirmed

** Changed in: mahara
Milestone: None = 1.3.0

-- 
Display of the colon in employment history titles in resume and view
https://bugs.launchpad.net/bugs/620175
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.

Status in Mahara ePortfolio: Confirmed

Bug description:
This is a minor thing and hopefully easy to fix.

When you are adding employment history titles and the employer, there's a colon 
between the two. In the resume (in profile), the colon is enclosed by spaces, 
but there shouldn't be a space between the title and the colon (in English and 
many other languages except for French ;-) ).

When you look at the employment information in a view, there is no space 
between the title and the colon, which is the correct way.



___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 620148] Re: Update of employment / education history takes me back to cover letter

2010-08-19 Thread Richard Mansfield
** Changed in: mahara
   Status: New = Triaged

** Changed in: mahara
Milestone: None = 1.3.0

** Changed in: mahara
   Importance: Undecided = Medium

-- 
Update of employment / education history takes me back to cover letter
https://bugs.launchpad.net/bugs/620148
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.

Status in Mahara ePortfolio: Triaged

Bug description:
When I update an entry in the employment history and save it, I am taken to the 
cover letter section instead of back to the overview page of education and 
employment history where I want to be to see the result of my update.



___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 620161] Re: Distinction between Name and Profile not clear

2010-08-19 Thread Richard Mansfield
Kristina,

I wonder whether we even need most of those links at all (I assume
you're talking about the top links in the small view header).  I think
when I created that header I lazily just used the same variable that was
holding the main top level site menu, so you just get the same stuff.
But Paul  Evonne both think there are way too many links there.  It
would be good to cut it down to just one or two that are the most useful
places to go when you're looking at a view.

For example, after looking at a view I quite often want to go to My
Views, but almost never want to go to Edit profile or Groups.  Maybe
those two links could be removed altogether.  (I agree about adding the
'Home' link, by the way).

R.

** Changed in: mahara
   Status: New = Opinion

-- 
Distinction between Name and Profile not clear
https://bugs.launchpad.net/bugs/620161
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.

Status in Mahara ePortfolio: Opinion

Bug description:
I still have trouble clicking on the correct link and think and adjustment may 
be necessary. 

When I click on my name, I am taken to my profile page as others can see it.

When I click on Profile, I can edit my profile, but I would think that I 
could actually view it.

Having the name and Profile right next to each other is not ideal, I think, 
because they are almost the same, but not quite.

When I'm on my profile page (the view), I don't know how to get back to my 
dashboard - Oh. I have to click on the Mahara logo.

I like that we have Settings instead of the username in the top right because 
that already lessens confusion.

What about the following:
- Include a link Home in the navigation links before the others.
- Profile (also in the tabs on the dashboard page etc.) links to the profile 
view.
- And somewhere we need a link Edit Profile Information to get to all that 
stuff. It could go next to Edit Content (though then people might be confused 
to distinguish between adding profile info and dragging that info into a view).

Any ideas?



___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 615323] Re: HTML Export progress bar strings not translatable

2010-08-19 Thread Richard Mansfield
** Changed in: mahara
   Status: Confirmed = Fix Committed

** Changed in: mahara
 Assignee: (unassigned) = Richard Mansfield (richard-mansfield)

-- 
HTML Export progress bar strings not translatable
https://bugs.launchpad.net/bugs/615323
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.

Status in Mahara ePortfolio: Fix Committed

Bug description:
The string, which are displaying while generating HTML export couldn't be 
translated - the strings, while generating LEAP export are translated...

See line 139, 170, 181, 188, 199, 217 and 232 in 
http://gitorious.org/mahara/mahara/blobs/master/htdocs/export/html/lib.php 
(please double check, maybe I missed a line)

Regards, Gregor



___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 620170] Re: Merge/simplify view access records

2010-08-19 Thread Richard Mansfield
** Changed in: mahara
   Status: New = Confirmed

** Changed in: mahara
   Importance: Undecided = Medium

** Changed in: mahara
Milestone: None = 1.3.0

** Changed in: mahara
 Assignee: (unassigned) = Richard Mansfield (richard-mansfield)

-- 
Merge/simplify view access records
https://bugs.launchpad.net/bugs/620170
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.

Status in Mahara ePortfolio: Confirmed

Bug description:
We need a good function to take a bunch of view access records and simpify them 
down to a sensible minimal set.  This has always been a bit of a problem, but 
it will become worse now that we are merging sets of access records when adding 
views to collections.

The process for rationalising the access rules should be something like this:

- Remove any records with a stop date in the past
- Remove start dates that are in the past from all records
- If the view allows comments, set allowcomments/approvecomments on all access 
records to the default (0/1)
- If any two records are identical apart from start/stop dates, and their date 
ranges overlap, merge them to one with the minimum start date and maximum stop 
date
- Remove any identical duplicates



There are a bunch of other simplifications that could be done, but I'd rather 
leave them alone for now because someone might have a use for them.  For 
example:
- If there's a public access record, we could remove all other records with a 
date range included in the public access date range,
- If there's a logged-in access record, we could remove all other records 
except public with a date range included in the logged-in access date range,
- If there's a 'whole group' access record, we could remove all group role 
access records for the same group with a date range included in the whole group 
access date range,
etc.


For now, we should also make sure this process doesn't mess with invisible 
access records.



___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp