[Mahara-contributors] [Bug 1798932] [NEW] Peer assessment qualities are lost when pages are added to a collection

2018-10-19 Thread Kristina Hoeppner
Public bug reported:

Mahara 18.10RC2

When pages are created outside of a collection and the peer role is
given, the peer qualities, i.e. not displaying content in blocks are
lost when they are added to a collection. I believe it is due to the
fact that the user who is a peer is listed multiple times and even if
they show all the peer role, the content was displayed.

To replicate:

1. Create 2 pages: 1 with a peer assessment, the other without. Place a text 
block with some text on both pages.
2. Give another user peer permissions on both pages.
Correct result: On the page with the peer assessment, only the block heading is 
displayed. On the page without the peer assessment, only the notice "You cannot 
see the content on this page because it does not require a peer assessment." is 
displayed.

3. Add the pages to a new collection.
Expected result: The pages are displayed as above for the peer assessor.
Actual result: The content of the pages is displayed to the peer assessor.

On the "Edit access" page, the name of the peer assessor appears twice
(or however many pages were added) and it seems that they are cancelling
each other out.

Also, when you remove the collection and look at the pages separately
again, the content is displayed for the peer assessor even after
removing one of the access lines. You need to remove both of them, save
the page, and then add the permissions back in to get it to work
properly.

** Affects: mahara
 Importance: High
 Status: Confirmed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1798932

Title:
  Peer assessment qualities are lost when pages are added to a
  collection

Status in Mahara:
  Confirmed

Bug description:
  Mahara 18.10RC2

  When pages are created outside of a collection and the peer role is
  given, the peer qualities, i.e. not displaying content in blocks are
  lost when they are added to a collection. I believe it is due to the
  fact that the user who is a peer is listed multiple times and even if
  they show all the peer role, the content was displayed.

  To replicate:

  1. Create 2 pages: 1 with a peer assessment, the other without. Place a text 
block with some text on both pages.
  2. Give another user peer permissions on both pages.
  Correct result: On the page with the peer assessment, only the block heading 
is displayed. On the page without the peer assessment, only the notice "You 
cannot see the content on this page because it does not require a peer 
assessment." is displayed.

  3. Add the pages to a new collection.
  Expected result: The pages are displayed as above for the peer assessor.
  Actual result: The content of the pages is displayed to the peer assessor.

  On the "Edit access" page, the name of the peer assessor appears twice
  (or however many pages were added) and it seems that they are
  cancelling each other out.

  Also, when you remove the collection and look at the pages separately
  again, the content is displayed for the peer assessor even after
  removing one of the access lines. You need to remove both of them,
  save the page, and then add the permissions back in to get it to work
  properly.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1798932/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1798931] [NEW] Show the manager and peer role when viewing the access permissions on "Pages and Collections"

2018-10-19 Thread Kristina Hoeppner
Public bug reported:

When you view the access permissions for a portfolio via "Pages and
collections", the peer and manager role are not mentioned whereas they
are on "Shared by me". It would be good to display them under "Manage
access" on a page viewed via "Pages and collections" as well to see
directly what level of access people have.

The display would be like so:

Displayname (Peer)
Displayname (Manager)
Displayname (Peer and manager)

** Affects: mahara
 Importance: Medium
 Status: Confirmed


** Tags: bite-sized

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1798931

Title:
  Show the manager and peer role when viewing the access permissions on
  "Pages and Collections"

Status in Mahara:
  Confirmed

Bug description:
  When you view the access permissions for a portfolio via "Pages and
  collections", the peer and manager role are not mentioned whereas they
  are on "Shared by me". It would be good to display them under "Manage
  access" on a page viewed via "Pages and collections" as well to see
  directly what level of access people have.

  The display would be like so:

  Displayname (Peer)
  Displayname (Manager)
  Displayname (Peer and manager)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1798931/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1798203] Re: Peer review role prevents site admin from seeing all content on page

2018-10-19 Thread Kristina Hoeppner
This is a tricky one. The site or institution admin can be peer
assessor. In that role, they should only be able to see what the peer
assessor is allowed to see.

However, when objectionable content is reported, the institution and
site admin need to be able to see everything on the page that the
portfolio author can see. That means any published peer assessments.
They should not be able to see peer assessments that are in draft status
as the portfolio author cannot see them either.

** Summary changed:

- Peer review role prevents site admin from seeing all content on page 
+ Peer review role prevents site / institution admin from seeing all content on 
page during objectionable review

** Changed in: mahara
   Status: New => Confirmed

** Changed in: mahara
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1798203

Title:
  Peer review role prevents site / institution admin from seeing all
  content on page during objectionable review

Status in Mahara:
  Confirmed

Bug description:
  Bug Summary: Content author has a public portfolio page -> Another user 
reports objectionable material = author sees warning on page -> does not edit 
page but adds the site admin as a peer reviewer -> who can not see the page 
details but only the headings 
  ---

  Environment tested: Master
  Browser tested: Chrome

  Preconditions:
  1. Content author creates a portfolio page 
  2. Another site user reports objectionable material on the page 

  Test Steps: 
  1. Content author does not change any content on the page
  2. Content author shares the page with Site admin and assigns the role of 
peer for peer review 
  3. Content author notify site admin stuff has been changed 
  4. Site admin logs in and browses to the page with objectionable material 

  Actual result: The site admin only sees headings on the page and
  cannot see the actual page content

  Expected result: Site admin should be able to see all page content
  even if they are assigned the role of peer for peer review or site
  admins should not be in the list of users that can do peer reviews

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1798203/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1798203] Re: Peer review role prevents site / institution admin from seeing all content on page during objectionable review

2018-10-19 Thread Kristina Hoeppner
Marked as medium because the portfolio author doesn't have to share
their page with the admin in order to show that they fixed things. Also,
the site admin can log in as the portfolio author if needed.

** Changed in: mahara
Milestone: None => 18.10rc2

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1798203

Title:
  Peer review role prevents site / institution admin from seeing all
  content on page during objectionable review

Status in Mahara:
  Confirmed

Bug description:
  Bug Summary: Content author has a public portfolio page -> Another user 
reports objectionable material = author sees warning on page -> does not edit 
page but adds the site admin as a peer reviewer -> who can not see the page 
details but only the headings 
  ---

  Environment tested: Master
  Browser tested: Chrome

  Preconditions:
  1. Content author creates a portfolio page 
  2. Another site user reports objectionable material on the page 

  Test Steps: 
  1. Content author does not change any content on the page
  2. Content author shares the page with Site admin and assigns the role of 
peer for peer review 
  3. Content author notify site admin stuff has been changed 
  4. Site admin logs in and browses to the page with objectionable material 

  Actual result: The site admin only sees headings on the page and
  cannot see the actual page content

  Expected result: Site admin should be able to see all page content
  even if they are assigned the role of peer for peer review or site
  admins should not be in the list of users that can do peer reviews

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1798203/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1797821] Re: Submitted page 'Undefined ltigradeform' error when accessed

2018-10-19 Thread Kristina Hoeppner
** Summary changed:

- submitted page 'Undefined ltigradeform' error when accessed
+ Submitted page 'Undefined ltigradeform' error when accessed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1797821

Title:
  Submitted page 'Undefined ltigradeform' error when accessed

Status in Mahara:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  In a site with no lti plugin installed
  - Have a group that allows submissions
  - as a normal member of a group, create a collection with at least one page 
and submit it to the group
  - as the group admin, access the page of the collection

  an error message is displayed

  [WAR] 8e (view/view.php:149) Undefined variable: ltigradeform

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1797821/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1797993] Re: Switching tablet orientation causes timeline to display incorrectly - refresh is needed

2018-10-19 Thread Kristina Hoeppner
This is most likely a lag in the refresh in the JS library.

** Summary changed:

- switching tablet orientation causes timeline to display incorrectly - refresh 
is needed
+ Switching tablet orientation causes timeline to display incorrectly - refresh 
is needed

** Changed in: mahara
   Status: New => Confirmed

** Changed in: mahara
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1797993

Title:
  Switching tablet orientation causes timeline to display incorrectly -
  refresh is needed

Status in Mahara:
  Confirmed

Bug description:
  Bug Summary: When viewing a time line of a page that has more than 6 
iterations and the user is viewing the last iteration in portrait orientation 
and then switches to landscape orientation, the time line still displays the 
same length as in portrait orientation
  ---

  Environment tested: Master
  Browser tested: iPad tablet 

  Preconditions:
  1. User has set a page to a time line that has more than 6 iteration to the 
page 

  Test Steps: 
  1. User views the last iteration on the time line page in portrait 
orientation 
  2. User switches the view from portrait to landscape

  Actual result: The time line bar at the top of the page does not
  display correctly until user does a refresh of the page

  Expected result:The time line bar at the top of the page displays
  correctly in both orientations of the tablet

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1797993/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1797813] Re: Editing an image through the edit image when editing an image gallery on a portfolio page not working

2018-10-19 Thread Kristina Hoeppner
** Changed in: mahara
   Status: New => Confirmed

** Changed in: mahara
   Importance: Undecided => Medium

** Changed in: mahara
Milestone: None => 18.10rc2

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1797813

Title:
  Editing an image through the edit image when editing an image gallery
  on a portfolio page not working

Status in Mahara:
  Confirmed

Bug description:
  Bug Summary: User wants to edit an image while in the Image gallery: 
Configure modal when editing an image gallery on a portfolio page. 
  ---
  Environment tested: Master
  Browser tested: Chrome
  ---
  Preconditions: 
  1. User has images uploaded to a folder 
  --- a. some images have a description 
  --- b. some images do not have description 

  
  Test Steps: 
  1. User Creates portfolio page 
  2. User add image gallery to page 
  3. User user edit an image file and add description and tag
  4. User click save changes or cancel

  Actual result: Nothing seems to happen - close the "Image gallery:
  Configure" modal and browse to Main menu > Create > Files > Folder
  image is in and check the image file, the image does display the
  changes made in the previous step

  Expected result: The edit modal closes and user is still on to open
  "Image gallery: Configure" modal, ready to add an image to image
  gallery

  Note: Adding am image file from your local machine and editig is
  working correctly - seems to be only image files that are in folders

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1797813/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1797812] Re: Privacy statements in logged out page should show latest version

2018-10-19 Thread Kristina Hoeppner
** Also affects: mahara/18.04
   Importance: Undecided
   Status: New

** Changed in: mahara/18.04
   Status: New => Confirmed

** Changed in: mahara/18.04
   Importance: Undecided => High

** Changed in: mahara/18.04
Milestone: None => 18.04.3

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1797812

Title:
  Privacy statements in logged out page should show latest version

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Confirmed
Status in Mahara 18.10 series:
  Fix Committed

Bug description:
  in logged out page for privacy statement (/legal.php) the latest
  privacy should be displayed.

  Instead we order by version title, that could any string, and show the
  first result. It can be seen in this query

  SELECT s.content
  FROM site_content_version s
  WHERE s.institution = 'mahara'
  AND s.type = 'privacy'
  ORDER BY s.version DESC
  LIMIT 1;

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1797812/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1798701] Re: Behat Test for peer review functionality

2018-10-19 Thread Kristina Hoeppner
** Changed in: mahara
   Status: New => In Progress

** Changed in: mahara
   Importance: Undecided => Medium

** Changed in: mahara
 Assignee: (unassigned) => Steven (stevens-q)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1798701

Title:
  Behat Test for peer review functionality

Status in Mahara:
  In Progress

Bug description:
  BEHAT SCRIPT : Create Script for feature file
  ->peer_assessment.feature

  RELATED TO: https://bugs.launchpad.net/mahara/+bug/1784778

  SUMMARY: Behat test is required for outlining the peer review process
  and ensuring functionality of the new feature

  Requirements: 
  1. The Peer Assessment block should be available on portfolio pages 
  2. Users with the role of peer can make a peer review - they can see headings 
only and no content
  3. Users with the role Manager should see headings and content but no be able 
to make a peer review
  4. Users with both peer and manager role should be able to make a peer review 
and see all page content

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1798701/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp