[Mahara-contributors] [Bug 1802048] [NEW] firmware crashes when laptop lid closed (suspend)

2018-11-06 Thread gartim
Public bug reported:

samsung laptop running Mint Linux 19/Mate,

kernel:
--
Linux gartim-930X2K-931X2K 4.15.0-38-generic #41-Ubuntu SMP Wed Oct 10 10:59:38 
UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

os-version:
--
NAME="Linux Mint"
VERSION="19 (Tara)"
ID=linuxmint
ID_LIKE=ubuntu
PRETTY_NAME="Linux Mint 19"
VERSION_ID="19"
HOME_URL="https://www.linuxmint.com/;
SUPPORT_URL="https://forums.ubuntu.com/;
BUG_REPORT_URL="http://linuxmint-troubleshooting-guide.readthedocs.io/en/latest/;
PRIVACY_POLICY_URL="https://www.linuxmint.com/;
VERSION_CODENAME=tara
UBUNTU_CODENAME=bionic

console log:
---
[   25.380372] ath: EEPROM regdomain: 0x8348
[   25.380373] ath: EEPROM indicates we should expect a country code
[   25.380374] ath: doing EEPROM country->regdmn map search
[   25.380376] ath: country maps to regdmn code: 0x3a
[   25.380377] ath: Country alpha2 being used: US
[   25.380378] ath: Regpair used: 0x3a
[   25.380379] ath: regdomain 0x8348 dynamically updated by country IE
[   25.400502] IPv6: ADDRCONF(NETDEV_CHANGE): wlp1s0: link becomes ready
[   75.248558] wlp1s0: deauthenticating from f8:1a:67:32:ee:14 by local choice 
(Reason: 3=DEAUTH_LEAVING)
[   75.261058] ath10k_pci :01:00.0: firmware crashed! (guid 
11fd3719-d3fb-4315-aa31-02ca1a37ba93)
[   75.261078] ath10k_pci :01:00.0: qca6174 hw2.1 target 0x0501 chip_id 
0x003405ff sub 144d:4125
[   75.261086] ath10k_pci :01:00.0: kconfig debug 0 debugfs 1 tracing 1 dfs 
0 testmode 0
[   75.261602] ath10k_pci :01:00.0: firmware ver 
SW_RM.1.1.1-00157-QCARMSWPZ-1 api 5 features ignore-otp,no-4addr-pad crc32 
10bf8e08
[   75.261861] ath10k_pci :01:00.0: board_file api 2 bmi_id N/A crc32 
ae2e275a
[   75.261866] ath10k_pci :01:00.0: htt-ver 3.1 wmi-op 4 htt-op 3 cal otp 
max-sta 32 raw 0 hwcrypto 1
[   75.263875] ath10k_pci :01:00.0: firmware register dump:
[   75.263883] ath10k_pci :01:00.0: [00]: 0x0501 0x 0x0092E4DC 
0x9C0BFF62
[   75.263889] ath10k_pci :01:00.0: [04]: 0x0092E4DC 0x00060130 0x0018 
0x0041A760
[   75.263893] ath10k_pci :01:00.0: [08]: 0x9C0BFF4E 0x0040 0x 
0x000A5C88
[   75.263898] ath10k_pci :01:00.0: [12]: 0x0009 0x 0x0096C09C 
0x0096C0A7
[   75.263903] ath10k_pci :01:00.0: [16]: 0x0096BDBC 0x009287BD 0x 
0x009287BD
[   75.263907] ath10k_pci :01:00.0: [20]: 0x4092E4DC 0x0041A710 0x 
0x0F00
[   75.263911] ath10k_pci :01:00.0: [24]: 0x809432A7 0x0041A770 0x0040D400 
0xC092E4DC
[   75.263916] ath10k_pci :01:00.0: [28]: 0x80942BC4 0x0041A790 0x9C0BFF4E 
0x0040
[   75.263920] ath10k_pci :01:00.0: [32]: 0x80947BA7 0x0041A7B0 0x00404D88 
0x0040E074
[   75.263925] ath10k_pci :01:00.0: [36]: 0x809BDECC 0x0041A7D0 0x00404D88 
0x0040E074
[   75.263929] ath10k_pci :01:00.0: [40]: 0x8099638C 0x0041A7F0 0x00404D88 
0x
[   75.263934] ath10k_pci :01:00.0: [44]: 0x80992076 0x0041A810 0x0044FD68 
0x0046FFE8
[   75.263938] ath10k_pci :01:00.0: [48]: 0x80996BD3 0x0041A830 0x0044FD68 
0x
[   75.263943] ath10k_pci :01:00.0: [52]: 0x800B4405 0x0041A850 0x00422318 
0x5002
[   75.263947] ath10k_pci :01:00.0: [56]: 0x809A6C34 0x0041A8E0 0x0042932C 
0x0042CA44
[   75.263951] ath10k_pci :01:00.0: Copy Engine register dump:
[   75.263962] ath10k_pci :01:00.0: [00]: 0x00034400   1   1   3   3
[   75.263974] ath10k_pci :01:00.0: [01]: 0x00034800  11  11 462 463
[   75.263985] ath10k_pci :01:00.0: [02]: 0x00034c00  36  36  99 100
[   75.263995] ath10k_pci :01:00.0: [03]: 0x00035000  11  11  12  11
[   75.264006] ath10k_pci :01:00.0: [04]: 0x00035400 463 463  41 233
[   75.264017] ath10k_pci :01:00.0: [05]: 0x00035800   0   0   0   0
[   75.264028] ath10k_pci :01:00.0: [06]: 0x00035c00  15  15  15  15
[   75.264038] ath10k_pci :01:00.0: [07]: 0x00036000   1   1   1   1
[   75.281888] PM: suspend entry (deep)
[   75.281890] PM: Syncing filesystems ... done.
[   75.300369] Freezing user space processes ... 
[   75.374433] ieee80211 phy0: Hardware restart was requested
[   75.374464] ath10k_pci :01:00.0: failed to delete WMI vdev 1: -108
[   95.298483] Freezing of tasks failed after 20.001 seconds (1 tasks refusing 
to freeze, wq_busy=0):
[   95.298505] wpa_supplicant  D0   737  1 0x0004
[   95.298511] Call Trace:
[   95.298525]  __schedule+0x291/0x8a0
[   95.298531]  schedule+0x2c/0x80
[   95.298537]  schedule_timeout+0x15d/0x350
[   95.298547]  ? __next_timer_interrupt+0xe0/0xe0
[   95.298551]  msleep+0x2d/0x40
[   95.298563]  ath10k_pci_hif_stop+0x63/0xc0 [ath10k_pci]
[   95.298584]  ath10k_core_stop+0x4b/0x70 [ath10k_core]
[   95.298600]  ath10k_halt+0x10c/0x170 [ath10k_core]
[   95.298615]  ath10k_stop+0x39/0x80 [ath10k_core]
[   95.298658]  drv_stop+0x39/0x100 [mac80211]
[   95.298700]  ieee80211_stop_device+0x43/0x50 [mac80211]
[   95.298734]  ieee80211_do_stop+0x4cb/0x7f0 [mac80211]
[   95.298743]  ? nla_memcpy+0x26/0x50
[   

[Mahara-contributors] [Bug 1802046] A patch has been submitted for review

2018-11-06 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/9293

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1802046

Title:
  Upgrade to 18.10 error on oAuth clean up

Status in Mahara:
  New

Bug description:
  Mahara: 18.10.0
  DB: Postgres
  OS: Linux
  Brower: N/A

  During an upgrade from 17.04 to 18.10, the following error occurs:

  [INF] 79 (lib/mahara.php:238) Upgrading auth.webservice
  [WAR] 79 (lib/errors.php:858) Failed to get a recordset: postgres8 error: 
[-1: ERROR:  update or delete on table "oauth_server_registry" violates foreign 
key constraint "oautservconf_oau_fk" on table "oauth_server_config"
  [WAR] 79 (lib/errors.php:858) DETAIL:  Key (id)=(7) is still referenced from 
table "oauth_server_config".] in adodb_throw(DELETE FROM 
"oauth_server_registry" WHERE externalserviceid IN (SELECT id FROM 
"external_services" WHERE component = ?), Array)Command was: DELETE FROM 
"oauth_server_registry" WHERE externalserviceid IN (SELECT id FROM 
"external_services" WHERE component = ?) and values was (0:module/lti)
  Call stack (most recent first):
* log_message("Failed to get a recordset: postgres8 error: [-1: E...", 8, 
true, true) at /var/www/mahara/htdocs/lib/errors.php:95
* log_warn("Failed to get a recordset: postgres8 error: [-1: E...") at 
/var/www/mahara/htdocs/lib/errors.php:858
* SQLException->__construct("Failed to get a recordset: postgres8 error: 
[-1: E...") at /var/www/mahara/htdocs/lib/dml.php:1025
* delete_records_sql("DELETE FROM "oauth_server_registry" WHERE 
external...", array(size 1)) at /var/www/mahara/htdocs/lib/dml.php:1002
* delete_records_select("oauth_server_registry", "WHERE externalserviceid 
IN (SELECT id FROM {extern...", array(size 1)) at 
/var/www/mahara/htdocs/webservice/lib.php:1529
* external_delete_descriptions("module/lti") at 
/var/www/mahara/htdocs/webservice/lib.php:1570
* external_reload_webservices() at 
/var/www/mahara/htdocs/auth/webservice/db/upgrade.php:594
* xmldb_auth_webservice_upgrade("2017030600") at 
/var/www/mahara/htdocs/lib/upgrade.php:450
* upgrade_plugin(object(stdClass)) at 
/var/www/mahara/htdocs/lib/mahara.php:272
* upgrade_mahara(array(size 1)) at 
/var/www/mahara/htdocs/admin/cli/upgrade.php:56

  [WAR] 79 (lib/dml.php:1025) Failed to get a recordset: postgres8 error: [-1: 
ERROR:  update or delete on table "oauth_server_registry" violates foreign key 
constraint "oautservconf_oau_fk" on table "oauth_server_config"
  [WAR] 79 (lib/dml.php:1025) DETAIL:  Key (id)=(7) is still referenced from 
table "oauth_server_config".] in adodb_throw(DELETE FROM 
"oauth_server_registry" WHERE externalserviceid IN (SELECT id FROM 
"external_services" WHERE component = ?), Array)Command was: DELETE FROM 
"oauth_server_registry" WHERE externalserviceid IN (SELECT id FROM 
"external_services" WHERE component = ?) and values was (0:module/lti)
  Call stack (most recent first):
* delete_records_sql("DELETE FROM "oauth_server_registry" WHERE 
external...", array(size 1)) at /var/www/mahara/htdocs/lib/dml.php:1002
* delete_records_select("oauth_server_registry", "WHERE externalserviceid 
IN (SELECT id FROM {extern...", array(size 1)) at 
/var/www/mahara/htdocs/webservice/lib.php:1529
* external_delete_descriptions("module/lti") at 
/var/www/mahara/htdocs/webservice/lib.php:1570
* external_reload_webservices() at 
/var/www/mahara/htdocs/auth/webservice/db/upgrade.php:594
* xmldb_auth_webservice_upgrade("2017030600") at 
/var/www/mahara/htdocs/lib/upgrade.php:450
* upgrade_plugin(object(stdClass)) at 
/var/www/mahara/htdocs/lib/mahara.php:272
* upgrade_mahara(array(size 1)) at 
/var/www/mahara/htdocs/admin/cli/upgrade.php:56


  The lti service had been configured in the past but is now disabled.
  During the upgrade, it tries to clean up the tables for unused modules
  and the lti comes up in the list.

  But, it's failing due to a foreign key constraint on the
  oauth_server_config table.

  The external_delete_descriptions() needs to also remove records from
  the oauth_server_config table before removing records from the
  oauth_server_registry table.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1802046/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1802046] [NEW] Upgrade to 18.10 error on oAuth clean up

2018-11-06 Thread Ghada El-Zoghbi
Public bug reported:

Mahara: 18.10.0
DB: Postgres
OS: Linux
Brower: N/A

During an upgrade from 17.04 to 18.10, the following error occurs:

[INF] 79 (lib/mahara.php:238) Upgrading auth.webservice
[WAR] 79 (lib/errors.php:858) Failed to get a recordset: postgres8 error: [-1: 
ERROR:  update or delete on table "oauth_server_registry" violates foreign key 
constraint "oautservconf_oau_fk" on table "oauth_server_config"
[WAR] 79 (lib/errors.php:858) DETAIL:  Key (id)=(7) is still referenced from 
table "oauth_server_config".] in adodb_throw(DELETE FROM 
"oauth_server_registry" WHERE externalserviceid IN (SELECT id FROM 
"external_services" WHERE component = ?), Array)Command was: DELETE FROM 
"oauth_server_registry" WHERE externalserviceid IN (SELECT id FROM 
"external_services" WHERE component = ?) and values was (0:module/lti)
Call stack (most recent first):
  * log_message("Failed to get a recordset: postgres8 error: [-1: E...", 8, 
true, true) at /var/www/mahara/htdocs/lib/errors.php:95
  * log_warn("Failed to get a recordset: postgres8 error: [-1: E...") at 
/var/www/mahara/htdocs/lib/errors.php:858
  * SQLException->__construct("Failed to get a recordset: postgres8 error: [-1: 
E...") at /var/www/mahara/htdocs/lib/dml.php:1025
  * delete_records_sql("DELETE FROM "oauth_server_registry" WHERE external...", 
array(size 1)) at /var/www/mahara/htdocs/lib/dml.php:1002
  * delete_records_select("oauth_server_registry", "WHERE externalserviceid IN 
(SELECT id FROM {extern...", array(size 1)) at 
/var/www/mahara/htdocs/webservice/lib.php:1529
  * external_delete_descriptions("module/lti") at 
/var/www/mahara/htdocs/webservice/lib.php:1570
  * external_reload_webservices() at 
/var/www/mahara/htdocs/auth/webservice/db/upgrade.php:594
  * xmldb_auth_webservice_upgrade("2017030600") at 
/var/www/mahara/htdocs/lib/upgrade.php:450
  * upgrade_plugin(object(stdClass)) at 
/var/www/mahara/htdocs/lib/mahara.php:272
  * upgrade_mahara(array(size 1)) at 
/var/www/mahara/htdocs/admin/cli/upgrade.php:56

[WAR] 79 (lib/dml.php:1025) Failed to get a recordset: postgres8 error: [-1: 
ERROR:  update or delete on table "oauth_server_registry" violates foreign key 
constraint "oautservconf_oau_fk" on table "oauth_server_config"
[WAR] 79 (lib/dml.php:1025) DETAIL:  Key (id)=(7) is still referenced from 
table "oauth_server_config".] in adodb_throw(DELETE FROM 
"oauth_server_registry" WHERE externalserviceid IN (SELECT id FROM 
"external_services" WHERE component = ?), Array)Command was: DELETE FROM 
"oauth_server_registry" WHERE externalserviceid IN (SELECT id FROM 
"external_services" WHERE component = ?) and values was (0:module/lti)
Call stack (most recent first):
  * delete_records_sql("DELETE FROM "oauth_server_registry" WHERE external...", 
array(size 1)) at /var/www/mahara/htdocs/lib/dml.php:1002
  * delete_records_select("oauth_server_registry", "WHERE externalserviceid IN 
(SELECT id FROM {extern...", array(size 1)) at 
/var/www/mahara/htdocs/webservice/lib.php:1529
  * external_delete_descriptions("module/lti") at 
/var/www/mahara/htdocs/webservice/lib.php:1570
  * external_reload_webservices() at 
/var/www/mahara/htdocs/auth/webservice/db/upgrade.php:594
  * xmldb_auth_webservice_upgrade("2017030600") at 
/var/www/mahara/htdocs/lib/upgrade.php:450
  * upgrade_plugin(object(stdClass)) at 
/var/www/mahara/htdocs/lib/mahara.php:272
  * upgrade_mahara(array(size 1)) at 
/var/www/mahara/htdocs/admin/cli/upgrade.php:56


The lti service had been configured in the past but is now disabled.
During the upgrade, it tries to clean up the tables for unused modules
and the lti comes up in the list.

But, it's failing due to a foreign key constraint on the
oauth_server_config table.

The external_delete_descriptions() needs to also remove records from the
oauth_server_config table before removing records from the
oauth_server_registry table.

** Affects: mahara
 Importance: Undecided
 Assignee: Ghada El-Zoghbi (ghada-z)
 Status: New

** Changed in: mahara
 Assignee: (unassigned) => Ghada El-Zoghbi (ghada-z)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1802046

Title:
  Upgrade to 18.10 error on oAuth clean up

Status in Mahara:
  New

Bug description:
  Mahara: 18.10.0
  DB: Postgres
  OS: Linux
  Brower: N/A

  During an upgrade from 17.04 to 18.10, the following error occurs:

  [INF] 79 (lib/mahara.php:238) Upgrading auth.webservice
  [WAR] 79 (lib/errors.php:858) Failed to get a recordset: postgres8 error: 
[-1: ERROR:  update or delete on table "oauth_server_registry" violates foreign 
key constraint "oautservconf_oau_fk" on table "oauth_server_config"
  [WAR] 79 (lib/errors.php:858) DETAIL:  Key (id)=(7) is still referenced from 
table 

[Mahara-contributors] [Bug 1802046] Re: Upgrade to 18.10 error on oAuth clean up

2018-11-06 Thread Ghada El-Zoghbi
To replicate:

* In previous version 17.04, create an lti configuration
* disable the lti configuration
* upgrade to 18.10

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1802046

Title:
  Upgrade to 18.10 error on oAuth clean up

Status in Mahara:
  New

Bug description:
  Mahara: 18.10.0
  DB: Postgres
  OS: Linux
  Brower: N/A

  During an upgrade from 17.04 to 18.10, the following error occurs:

  [INF] 79 (lib/mahara.php:238) Upgrading auth.webservice
  [WAR] 79 (lib/errors.php:858) Failed to get a recordset: postgres8 error: 
[-1: ERROR:  update or delete on table "oauth_server_registry" violates foreign 
key constraint "oautservconf_oau_fk" on table "oauth_server_config"
  [WAR] 79 (lib/errors.php:858) DETAIL:  Key (id)=(7) is still referenced from 
table "oauth_server_config".] in adodb_throw(DELETE FROM 
"oauth_server_registry" WHERE externalserviceid IN (SELECT id FROM 
"external_services" WHERE component = ?), Array)Command was: DELETE FROM 
"oauth_server_registry" WHERE externalserviceid IN (SELECT id FROM 
"external_services" WHERE component = ?) and values was (0:module/lti)
  Call stack (most recent first):
* log_message("Failed to get a recordset: postgres8 error: [-1: E...", 8, 
true, true) at /var/www/mahara/htdocs/lib/errors.php:95
* log_warn("Failed to get a recordset: postgres8 error: [-1: E...") at 
/var/www/mahara/htdocs/lib/errors.php:858
* SQLException->__construct("Failed to get a recordset: postgres8 error: 
[-1: E...") at /var/www/mahara/htdocs/lib/dml.php:1025
* delete_records_sql("DELETE FROM "oauth_server_registry" WHERE 
external...", array(size 1)) at /var/www/mahara/htdocs/lib/dml.php:1002
* delete_records_select("oauth_server_registry", "WHERE externalserviceid 
IN (SELECT id FROM {extern...", array(size 1)) at 
/var/www/mahara/htdocs/webservice/lib.php:1529
* external_delete_descriptions("module/lti") at 
/var/www/mahara/htdocs/webservice/lib.php:1570
* external_reload_webservices() at 
/var/www/mahara/htdocs/auth/webservice/db/upgrade.php:594
* xmldb_auth_webservice_upgrade("2017030600") at 
/var/www/mahara/htdocs/lib/upgrade.php:450
* upgrade_plugin(object(stdClass)) at 
/var/www/mahara/htdocs/lib/mahara.php:272
* upgrade_mahara(array(size 1)) at 
/var/www/mahara/htdocs/admin/cli/upgrade.php:56

  [WAR] 79 (lib/dml.php:1025) Failed to get a recordset: postgres8 error: [-1: 
ERROR:  update or delete on table "oauth_server_registry" violates foreign key 
constraint "oautservconf_oau_fk" on table "oauth_server_config"
  [WAR] 79 (lib/dml.php:1025) DETAIL:  Key (id)=(7) is still referenced from 
table "oauth_server_config".] in adodb_throw(DELETE FROM 
"oauth_server_registry" WHERE externalserviceid IN (SELECT id FROM 
"external_services" WHERE component = ?), Array)Command was: DELETE FROM 
"oauth_server_registry" WHERE externalserviceid IN (SELECT id FROM 
"external_services" WHERE component = ?) and values was (0:module/lti)
  Call stack (most recent first):
* delete_records_sql("DELETE FROM "oauth_server_registry" WHERE 
external...", array(size 1)) at /var/www/mahara/htdocs/lib/dml.php:1002
* delete_records_select("oauth_server_registry", "WHERE externalserviceid 
IN (SELECT id FROM {extern...", array(size 1)) at 
/var/www/mahara/htdocs/webservice/lib.php:1529
* external_delete_descriptions("module/lti") at 
/var/www/mahara/htdocs/webservice/lib.php:1570
* external_reload_webservices() at 
/var/www/mahara/htdocs/auth/webservice/db/upgrade.php:594
* xmldb_auth_webservice_upgrade("2017030600") at 
/var/www/mahara/htdocs/lib/upgrade.php:450
* upgrade_plugin(object(stdClass)) at 
/var/www/mahara/htdocs/lib/mahara.php:272
* upgrade_mahara(array(size 1)) at 
/var/www/mahara/htdocs/admin/cli/upgrade.php:56


  The lti service had been configured in the past but is now disabled.
  During the upgrade, it tries to clean up the tables for unused modules
  and the lti comes up in the list.

  But, it's failing due to a foreign key constraint on the
  oauth_server_config table.

  The external_delete_descriptions() needs to also remove records from
  the oauth_server_config table before removing records from the
  oauth_server_registry table.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1802046/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1791544] Re: Make an easier way to decide which sideblocks are shown on which pages

2018-11-06 Thread Steven
*Environment tested:* Master
*Browser tested:* Chrome

*Preconditions:*  
1. Mahara site exists with content 
2. 2nd site exist with exact database 
3. Apply patch to first site


*Test Steps:*  
1. view all site pages side by side using and ensure pages do not differ in any 
way regarding the side blocks 

*Expected result:*  Existing site pages with side blocks should still
display the same, pages without side blocks should not display
additional side blocks

*Actual result:*  As expected

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1791544

Title:
  Make an easier way to decide which sideblocks are shown on which pages

Status in Mahara:
  In Progress

Bug description:
  Currently we have only a couple of ways to show side blocks on a page.

  1) If we want a sideblock to appear on only one page we can add the
  code to the $smarty call from the page as the 4th array or parameters,
  for example:

  $smarty = new smarty(array(), array(), array(), array('sideblocks' =>
  array(array('name' => 'customblock', 'weight' => 20, 'data' => 'test
  data';

  But we also need to create the corresponding 'customblock' theme
  template in the sideblocks to display the block.

  2) If we want the sideblock to appear on multiple pages we tend to add
  the block to the smarty() function directly below the "sideblock
  stuff" do a bunch of checks to see which blocks can be added to what
  pages - this section is quite confusing / all hardcoded / difficult to
  change. Some sideblocks are shown based on the menu section they are
  in, which makes sense for some of the menu options but not others.

  --

  I feel this needs to be tidied up and simplified so that we end up
  with a system that can do an easier version of option (1) - where we
  can just create the array for $smarty and it will use a generic
  sideblock template if you one doesn't need to define a custom one. So
  the array for some static content could look like:

  array('name' => 'customblock',
'weight' => 20,
'title' => 'Custom block',
'content' => 'My custom content',
'template' => false,
  )

  where we pass in a content string
  versus one that requires dynamic content

  array('name' => 'customblock',
'weight' => 20,
'title' => 'Custom block',
'content' => custom_block_data(),
'template' => 'sideblocks/customblock.tpl',
  )

  where we pass in a content array/object to our custom template

  And for option (2) we need a easier way for defining the array of
  sideblocks. We also need an easy way for the page being displayed to
  be able to convey information to the sideblocks array (like what we do
  for the menu array).

  We also need a way for modules/plugins to be able to add to the
  sideblock array if the plugin needs to have the block on multiple
  pages

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1791544/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1801993] A change has been merged

2018-11-06 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/9292
Committed: 
https://git.mahara.org/mahara/mahara/commit/bc4c1e9f4322961e42cacea78cd87c4c54863efe
Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz)
Branch:18.04_STABLE

commit bc4c1e9f4322961e42cacea78cd87c4c54863efe
Author: Robert Lyon 
Date:   Wed Nov 7 07:47:31 2018 +1300

Bug 1801993: Remove old Mochikit function call

And replace it with equivalent jQuery call

To test:
1) Set in cofig.php file:
$cfg->blockeditormaxwidth = true;
2) Add a text block to a page

behatnotneeded

Change-Id: I26855778c53ac36591b6188c477f25648dab9057
Signed-off-by: Robert Lyon 
(cherry picked from commit 07d6e5054cec05c3c93b3b63d81fcf4d7b499f6e)
(cherry picked from commit e3fa699be8ca0970e0f776551afb2dc8e981c4ef)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1801993

Title:
  Old Mochikit function still in views.js

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  When we have the config setting $cfg->blockeditormaxwidth set to true

  And go to add a block to a page we get an error -> "ReferenceError:
  getViewportDimensions is not defined"

  This is due to the getViewportDimensions() function being an old
  MochiKit function.

  We need to adjust this to get the needed value from a jQuery function

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1801993/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1801993] A change has been merged

2018-11-06 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/9287
Committed: 
https://git.mahara.org/mahara/mahara/commit/07d6e5054cec05c3c93b3b63d81fcf4d7b499f6e
Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz)
Branch:master

commit 07d6e5054cec05c3c93b3b63d81fcf4d7b499f6e
Author: Robert Lyon 
Date:   Wed Nov 7 07:47:31 2018 +1300

Bug 1801993: Remove old Mochikit function call

And replace it with equivalent jQuery call

To test:
1) Set in cofig.php file:
$cfg->blockeditormaxwidth = true;
2) Add a text block to a page

behatnotneeded

Change-Id: I26855778c53ac36591b6188c477f25648dab9057
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1801993

Title:
  Old Mochikit function still in views.js

Status in Mahara:
  In Progress
Status in Mahara 18.04 series:
  New
Status in Mahara 18.10 series:
  In Progress
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  When we have the config setting $cfg->blockeditormaxwidth set to true

  And go to add a block to a page we get an error -> "ReferenceError:
  getViewportDimensions is not defined"

  This is due to the getViewportDimensions() function being an old
  MochiKit function.

  We need to adjust this to get the needed value from a jQuery function

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1801993/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1801993] A change has been merged

2018-11-06 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/9291
Committed: 
https://git.mahara.org/mahara/mahara/commit/e3fa699be8ca0970e0f776551afb2dc8e981c4ef
Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz)
Branch:18.10_STABLE

commit e3fa699be8ca0970e0f776551afb2dc8e981c4ef
Author: Robert Lyon 
Date:   Wed Nov 7 07:47:31 2018 +1300

Bug 1801993: Remove old Mochikit function call

And replace it with equivalent jQuery call

To test:
1) Set in cofig.php file:
$cfg->blockeditormaxwidth = true;
2) Add a text block to a page

behatnotneeded

Change-Id: I26855778c53ac36591b6188c477f25648dab9057
Signed-off-by: Robert Lyon 
(cherry picked from commit 07d6e5054cec05c3c93b3b63d81fcf4d7b499f6e)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1801993

Title:
  Old Mochikit function still in views.js

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  When we have the config setting $cfg->blockeditormaxwidth set to true

  And go to add a block to a page we get an error -> "ReferenceError:
  getViewportDimensions is not defined"

  This is due to the getViewportDimensions() function being an old
  MochiKit function.

  We need to adjust this to get the needed value from a jQuery function

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1801993/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1801993] A patch has been submitted for review

2018-11-06 Thread Mahara Bot
Patch for "18.04_STABLE" branch: https://reviews.mahara.org/9292

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1801993

Title:
  Old Mochikit function still in views.js

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  When we have the config setting $cfg->blockeditormaxwidth set to true

  And go to add a block to a page we get an error -> "ReferenceError:
  getViewportDimensions is not defined"

  This is due to the getViewportDimensions() function being an old
  MochiKit function.

  We need to adjust this to get the needed value from a jQuery function

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1801993/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1801993] Re: Old Mochikit function still in views.js

2018-11-06 Thread Cecilia Vela Gurovic
** Also affects: mahara/18.10
   Importance: High
   Status: In Progress

** Also affects: mahara/19.04
   Importance: Undecided
   Status: New

** Also affects: mahara/18.04
   Importance: Undecided
   Status: New

** Changed in: mahara/18.04
   Importance: Undecided => High

** Changed in: mahara/19.04
   Importance: Undecided => High

** Changed in: mahara/18.10
   Status: In Progress => Fix Committed

** Changed in: mahara/18.10
   Status: Fix Committed => In Progress

** Changed in: mahara/18.10
Milestone: 19.04.0 => 18.10.1

** Changed in: mahara/19.04
Milestone: None => 19.04.0

** Changed in: mahara/18.04
Milestone: None => 18.04.4

** Changed in: mahara/19.04
   Status: New => Fix Committed

** Changed in: mahara/18.10
   Status: In Progress => Fix Committed

** Changed in: mahara/18.04
   Status: New => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1801993

Title:
  Old Mochikit function still in views.js

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  When we have the config setting $cfg->blockeditormaxwidth set to true

  And go to add a block to a page we get an error -> "ReferenceError:
  getViewportDimensions is not defined"

  This is due to the getViewportDimensions() function being an old
  MochiKit function.

  We need to adjust this to get the needed value from a jQuery function

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1801993/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1801993] A patch has been submitted for review

2018-11-06 Thread Mahara Bot
Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9291

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1801993

Title:
  Old Mochikit function still in views.js

Status in Mahara:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  When we have the config setting $cfg->blockeditormaxwidth set to true

  And go to add a block to a page we get an error -> "ReferenceError:
  getViewportDimensions is not defined"

  This is due to the getViewportDimensions() function being an old
  MochiKit function.

  We need to adjust this to get the needed value from a jQuery function

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1801993/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1794912] Re: Need to tidy up Mahara so that it better reflects the W3C standards

2018-11-06 Thread Steven
Environment tested: Master
Browser tested: Chrome

Preconditions: 
1. Authenticated user exists
2. Portfolio page with external video block exists (iframe)

Test Steps: 
1. User log in 
2. Browse to page with external media block 
3. select all the source code for the page 
4. run the code through W3 validation here 
https://validator.w3.org/#validate_by_input

Actual result:

1. Bug Fixed - I no longer see Error message "Error: Bad value 1 for attribute 
allowfullscreen on element iframe."
2. I see 2 new bugs - see screenshot attached 

Expected result: No Error messages

** Attachment added: "w3 iframe error message for external media 
iframe_07-11-2018png.png"
   
https://bugs.launchpad.net/mahara/+bug/1794912/+attachment/5209754/+files/w3%20iframe%20error%20message%20for%20external%20media%20iframe_07-11-2018png.png

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1794912

Title:
  Need to tidy up Mahara so that it better reflects the W3C standards

Status in Mahara:
  In Progress

Bug description:
  Running a page through https://validator.w3.org/ shows that there are
  HTML issues that we should cleanup

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1794912/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1801993] Re: Old Mochikit function still in views.js

2018-11-06 Thread Steven
Environment tested: Master
Browser tested: Chrome

Preconditions:  
1) Set in cofig.php file:   $cfg->blockeditormaxwidth = true;

Test Steps:  
1) log in and add a text block to a portfolio page

Expected result: The text configure flyout modal from the right side of
screen is displayed  and the "Block content" editor window is approx 675
px in height (old height was approx 180)

Actual result:  As Expected

Catalyst QA Approved ✔

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1801993

Title:
  Old Mochikit function still in views.js

Status in Mahara:
  In Progress

Bug description:
  When we have the config setting $cfg->blockeditormaxwidth set to true

  And go to add a block to a page we get an error -> "ReferenceError:
  getViewportDimensions is not defined"

  This is due to the getViewportDimensions() function being an old
  MochiKit function.

  We need to adjust this to get the needed value from a jQuery function

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1801993/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1801843] A change has been merged

2018-11-06 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/9288
Committed: 
https://git.mahara.org/mahara/mahara/commit/81ff372df8a0673e6ba7f994eb0153988c0f1b60
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:18.10_STABLE

commit 81ff372df8a0673e6ba7f994eb0153988c0f1b60
Author: Robert Lyon 
Date:   Tue Nov 6 13:50:17 2018 +1300

Bug 1801843: Need to pass thru the $cleanurlbase string

So that it appears above the field for the 'Page URL' field on page
settings screen

behatnotneeded

Change-Id: Iace84c2ffe9cb6a9635d577cfe9e32e4e3f9ecbe
Signed-off-by: Robert Lyon 
(cherry picked from commit 0a716cbfb93b33cca9751672076b465376558508)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1801843

Title:
  Cleanurl prefix not displayed on the page edit setting form

Status in Mahara:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  This used to be displayed back in 17.04 but now doesn't

  We need to get it displaying again

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1801843/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1801843] Re: Cleanurl prefix not displayed on the page edit setting form

2018-11-06 Thread Robert Lyon
** Changed in: mahara/18.10
   Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1801843

Title:
  Cleanurl prefix not displayed on the page edit setting form

Status in Mahara:
  Fix Committed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Fix Committed
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  This used to be displayed back in 17.04 but now doesn't

  We need to get it displaying again

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1801843/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1801843] A change has been merged

2018-11-06 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/9289
Committed: 
https://git.mahara.org/mahara/mahara/commit/302a5b231400890013b89891ecbf90f691962c0c
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:18.04_STABLE

commit 302a5b231400890013b89891ecbf90f691962c0c
Author: Robert Lyon 
Date:   Wed Nov 7 08:15:58 2018 +1300

Bug 1801843: Need to pass thru the $cleanurlbase string

So that it appears above the field for the 'Page URL' field on page
settings screen

behatnotneeded

Change-Id: Iace84c2ffe9cb6a9635d577cfe9e32e4e3f9ecbe
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1801843

Title:
  Cleanurl prefix not displayed on the page edit setting form

Status in Mahara:
  Confirmed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Confirmed
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  This used to be displayed back in 17.04 but now doesn't

  We need to get it displaying again

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1801843/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1801843] Re: Cleanurl prefix not displayed on the page edit setting form

2018-11-06 Thread Robert Lyon
** Changed in: mahara/18.04
   Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1801843

Title:
  Cleanurl prefix not displayed on the page edit setting form

Status in Mahara:
  Confirmed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Confirmed
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  This used to be displayed back in 17.04 but now doesn't

  We need to get it displaying again

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1801843/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1801843] A change has been merged

2018-11-06 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/9290
Committed: 
https://git.mahara.org/mahara/mahara/commit/8a12682ab2a904d0f1ba9406e617059f96861fca
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:17.10_STABLE

commit 8a12682ab2a904d0f1ba9406e617059f96861fca
Author: Robert Lyon 
Date:   Wed Nov 7 08:18:21 2018 +1300

Bug 1801843: Need to pass thru the $cleanurlbase string

So that it appears above the field for the 'Page URL' field on page
settings screen

behatnotneeded

Change-Id: Iace84c2ffe9cb6a9635d577cfe9e32e4e3f9ecbe
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1801843

Title:
  Cleanurl prefix not displayed on the page edit setting form

Status in Mahara:
  Confirmed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Confirmed
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  This used to be displayed back in 17.04 but now doesn't

  We need to get it displaying again

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1801843/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1801843] Re: Cleanurl prefix not displayed on the page edit setting form

2018-11-06 Thread Robert Lyon
** Changed in: mahara/17.10
   Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1801843

Title:
  Cleanurl prefix not displayed on the page edit setting form

Status in Mahara:
  Confirmed
Status in Mahara 17.10 series:
  Fix Committed
Status in Mahara 18.04 series:
  Fix Committed
Status in Mahara 18.10 series:
  Confirmed
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  This used to be displayed back in 17.04 but now doesn't

  We need to get it displaying again

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1801843/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1801843] A patch has been submitted for review

2018-11-06 Thread Mahara Bot
Patch for "18.04_STABLE" branch: https://reviews.mahara.org/9289

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1801843

Title:
  Cleanurl prefix not displayed on the page edit setting form

Status in Mahara:
  Confirmed
Status in Mahara 17.10 series:
  Confirmed
Status in Mahara 18.04 series:
  Confirmed
Status in Mahara 18.10 series:
  Confirmed
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  This used to be displayed back in 17.04 but now doesn't

  We need to get it displaying again

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1801843/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1801843] A change has been merged

2018-11-06 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/9285
Committed: 
https://git.mahara.org/mahara/mahara/commit/0a716cbfb93b33cca9751672076b465376558508
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 0a716cbfb93b33cca9751672076b465376558508
Author: Robert Lyon 
Date:   Tue Nov 6 13:50:17 2018 +1300

Bug 1801843: Need to pass thru the $cleanurlbase string

So that it appears above the field for the 'Page URL' field on page
settings screen

behatnotneeded

Change-Id: Iace84c2ffe9cb6a9635d577cfe9e32e4e3f9ecbe
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1801843

Title:
  Cleanurl prefix not displayed on the page edit setting form

Status in Mahara:
  Confirmed
Status in Mahara 17.10 series:
  Confirmed
Status in Mahara 18.04 series:
  Confirmed
Status in Mahara 18.10 series:
  Confirmed
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  This used to be displayed back in 17.04 but now doesn't

  We need to get it displaying again

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1801843/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1801843] A patch has been submitted for review

2018-11-06 Thread Mahara Bot
Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9288

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1801843

Title:
  Cleanurl prefix not displayed on the page edit setting form

Status in Mahara:
  Confirmed
Status in Mahara 17.10 series:
  Confirmed
Status in Mahara 18.04 series:
  Confirmed
Status in Mahara 18.10 series:
  Confirmed
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  This used to be displayed back in 17.04 but now doesn't

  We need to get it displaying again

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1801843/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1801843] A patch has been submitted for review

2018-11-06 Thread Mahara Bot
Patch for "17.10_STABLE" branch: https://reviews.mahara.org/9290

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1801843

Title:
  Cleanurl prefix not displayed on the page edit setting form

Status in Mahara:
  Confirmed
Status in Mahara 17.10 series:
  Confirmed
Status in Mahara 18.04 series:
  Confirmed
Status in Mahara 18.10 series:
  Confirmed
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  This used to be displayed back in 17.04 but now doesn't

  We need to get it displaying again

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1801843/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1801843] Re: Cleanurl prefix not displayed on the page edit setting form

2018-11-06 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1801843

Title:
  Cleanurl prefix not displayed on the page edit setting form

Status in Mahara:
  Confirmed
Status in Mahara 17.10 series:
  Confirmed
Status in Mahara 18.04 series:
  Confirmed
Status in Mahara 18.10 series:
  Confirmed
Status in Mahara 19.04 series:
  Fix Committed

Bug description:
  This used to be displayed back in 17.04 but now doesn't

  We need to get it displaying again

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1801843/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1801993] [NEW] Old Mochikit function still in views.js

2018-11-06 Thread Robert Lyon
Public bug reported:

When we have the config setting $cfg->blockeditormaxwidth set to true

And go to add a block to a page we get an error -> "ReferenceError:
getViewportDimensions is not defined"

This is due to the getViewportDimensions() function being an old
MochiKit function.

We need to adjust this to get the needed value from a jQuery function

** Affects: mahara
 Importance: High
 Status: In Progress

** Changed in: mahara
   Importance: Undecided => High

** Changed in: mahara
   Status: New => In Progress

** Changed in: mahara
Milestone: None => 19.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1801993

Title:
  Old Mochikit function still in views.js

Status in Mahara:
  In Progress

Bug description:
  When we have the config setting $cfg->blockeditormaxwidth set to true

  And go to add a block to a page we get an error -> "ReferenceError:
  getViewportDimensions is not defined"

  This is due to the getViewportDimensions() function being an old
  MochiKit function.

  We need to adjust this to get the needed value from a jQuery function

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1801993/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1801057] Re: Feature Request. Cascade Navigation Block in Collection

2018-11-06 Thread Kristina Hoeppner
** Tags added: nomin

** Tags removed: nomin
** Tags added: nominatedfeature

** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1801057

Title:
  Feature Request. Cascade Navigation Block in Collection

Status in Mahara:
  Fix Committed

Bug description:
  Current setup (in v18.04) means that if you have a collection of 10
  pages and want to add a navigation block to each page in the
  collection, you need to edit all 10 pages separately and add the
  navigation block every time. From a usability perspective it would be
  much better if when adding the navigation block to a page in a
  collection if you were prompted to ask if you wanted the same
  navigation block to be added to all pages in the collection - and if
  you chose yes it was automatically added to all pages in the
  collection.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1801057/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1801881] [NEW] Allowing comments when sharing a page filters through to artefact comments

2018-11-06 Thread Kristina Hoeppner
Public bug reported:

Currently, we can determine which artefacts can be commented on and
which ones can't by selecting the option either in the artefact
settings, e.g. file options or on the blocks, e.g. note block.

So we can have the case that 2 images can be commented on, a PDF cannot,
and then the page itself has moderated comments. This is rather complex.

A more streamlined approach would be to go with the page permissions: If
comments are allowed on a page, any artefacts that allow comments can be
commented on. If comments are moderated then that goes for all
artefacts, if certain people can comment and others can't, that
propagates through to the artefacts.

That way, we could simplify the options for artefacts / blocks esp. in
light of simplifying Mahara pages in general and go with the page
permissions.

** Affects: mahara
 Importance: Wishlist
 Status: Confirmed


** Tags: usability

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1801881

Title:
  Allowing comments when sharing a page filters through to artefact
  comments

Status in Mahara:
  Confirmed

Bug description:
  Currently, we can determine which artefacts can be commented on and
  which ones can't by selecting the option either in the artefact
  settings, e.g. file options or on the blocks, e.g. note block.

  So we can have the case that 2 images can be commented on, a PDF
  cannot, and then the page itself has moderated comments. This is
  rather complex.

  A more streamlined approach would be to go with the page permissions:
  If comments are allowed on a page, any artefacts that allow comments
  can be commented on. If comments are moderated then that goes for all
  artefacts, if certain people can comment and others can't, that
  propagates through to the artefacts.

  That way, we could simplify the options for artefacts / blocks esp. in
  light of simplifying Mahara pages in general and go with the page
  permissions.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1801881/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp