[Mahara-contributors] [Bug 1773600] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/9582 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1773600 Title: Correct capitalization of time registration expiry selector Status in Mahara: In Progress Bug description: In Admin -> Configure site -> Site options -> Account settings you can choose the "Default registration expiry lifetime". This drop-down menu displays the correct options with the correct capitalization. However, when an admin receives the registration request email, the time period is capitalized as it is taken from the drop-down menu, e.g. "You will need to approve or deny this registration request within 2 Weeks." However, it should read: "You will need to approve or deny this registration request within 2 weeks." A new set of strings should be set up that shows "days", "weeks", "months", "years" not capitalized so that these strings can be used in the HTML and plain text emails sent out for this message. Unfortunately, it's not just a case of renaming the strings as their capitalized versions need to be kept in the pieforms element for the drop-down menu. To replicate: 1. Activate the "Default registration expiry lifetime" and set it to a number of days / weeks / months / years. 2. turn on "Confirm registration" in an institution on the site and allow self-registration. 3. Self-register for an account in the institution. 4. Check the email you'd receive either as admin of the institution or site admin. Expected result: "You will need to approve or deny this registration request within 2 weeks." (or days / months / years) Actual result: "You will need to approve or deny this registration request within 2 Weeks." (or Days / Months / Years) All options, including the "No end date set" one should be tested as well as the plain text and HTML messages. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1773600/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1773600] Re: Correct capitalization of time registration expiry selector
I have updated lang/en.utf8/pieforms with new lowercase strings for both plural and singular units of time. Please note that the previous capitlized strings are still in place and have NOT been removed from the file. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1773600 Title: Correct capitalization of time registration expiry selector Status in Mahara: In Progress Bug description: In Admin -> Configure site -> Site options -> Account settings you can choose the "Default registration expiry lifetime". This drop-down menu displays the correct options with the correct capitalization. However, when an admin receives the registration request email, the time period is capitalized as it is taken from the drop-down menu, e.g. "You will need to approve or deny this registration request within 2 Weeks." However, it should read: "You will need to approve or deny this registration request within 2 weeks." A new set of strings should be set up that shows "days", "weeks", "months", "years" not capitalized so that these strings can be used in the HTML and plain text emails sent out for this message. Unfortunately, it's not just a case of renaming the strings as their capitalized versions need to be kept in the pieforms element for the drop-down menu. To replicate: 1. Activate the "Default registration expiry lifetime" and set it to a number of days / weeks / months / years. 2. turn on "Confirm registration" in an institution on the site and allow self-registration. 3. Self-register for an account in the institution. 4. Check the email you'd receive either as admin of the institution or site admin. Expected result: "You will need to approve or deny this registration request within 2 weeks." (or days / months / years) Actual result: "You will need to approve or deny this registration request within 2 Weeks." (or Days / Months / Years) All options, including the "No end date set" one should be tested as well as the plain text and HTML messages. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1773600/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1773600] Re: Correct capitalization of time registration expiry selector
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1773600 Title: Correct capitalization of time registration expiry selector Status in Mahara: In Progress Bug description: In Admin -> Configure site -> Site options -> Account settings you can choose the "Default registration expiry lifetime". This drop-down menu displays the correct options with the correct capitalization. However, when an admin receives the registration request email, the time period is capitalized as it is taken from the drop-down menu, e.g. "You will need to approve or deny this registration request within 2 Weeks." However, it should read: "You will need to approve or deny this registration request within 2 weeks." A new set of strings should be set up that shows "days", "weeks", "months", "years" not capitalized so that these strings can be used in the HTML and plain text emails sent out for this message. Unfortunately, it's not just a case of renaming the strings as their capitalized versions need to be kept in the pieforms element for the drop-down menu. To replicate: 1. Activate the "Default registration expiry lifetime" and set it to a number of days / weeks / months / years. 2. turn on "Confirm registration" in an institution on the site and allow self-registration. 3. Self-register for an account in the institution. 4. Check the email you'd receive either as admin of the institution or site admin. Expected result: "You will need to approve or deny this registration request within 2 weeks." (or days / months / years) Actual result: "You will need to approve or deny this registration request within 2 Weeks." (or Days / Months / Years) All options, including the "No end date set" one should be tested as well as the plain text and HTML messages. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1773600/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1814499] Re: Primary School font doesn't support Māori characters
Liam, can you please check with Evonne? -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1814499 Title: Primary School font doesn't support Māori characters Status in Mahara: Confirmed Bug description: The fun font in the primary school theme in the homeinfo.tpl part (see screenshot) doesn't support the full set of special characters. It may also mean that special characters found in other languages are not supported. The character set should be expanded to support more characters. This should be similar to the fix made for bug #1747856. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1814499/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1765276] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/9581 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1765276 Title: Upgrade to Bootstrap 4 Status in Mahara: In Progress Bug description: Bootstrap 4 has been released. We should upgrade. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1765276/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1816311] A change has been merged
Reviewed: https://reviews.mahara.org/9580 Committed: https://git.mahara.org/mahara/mahara/commit/bf174c60fc089c950074d1dd330b430300b05b19 Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:17.10_STABLE commit bf174c60fc089c950074d1dd330b430300b05b19 Author: Robert Lyon Date: Mon Feb 18 08:31:13 2019 +1300 Bug 1816311: Showing correct journal entry poster's name When adding comment to the entry and the journal is owned by group/institution behatnotneeded Change-Id: Id492c04e3facdbf00a5dfdc4d714c3c5103ff3a2 Signed-off-by: Robert Lyon (cherry picked from commit 5988b7de00b4a12dd71004056aeec3b55e190243) (cherry picked from commit 582e9a3e23e50ab76c8f3d6c550344f9eda5a3e4) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1816311 Title: Adding comment to journal entry shows wrong poster Status in Mahara: Fix Committed Status in Mahara 17.10 series: Fix Committed Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Bug description: When adding a comment to a journal entry artefact via a page we see the piece of information: Posted by [owner] on [date] This information is correct when doing this for a user's journal but the information is not correct if the journal is a group / institution journal. In these cases we see: Posted by [viewer of page] on [date] Steps to replicate: 1) Login as UserA and create a group, GroupA 2) Create a journal in the group and add a journal entry to it 3) Add a page in GroupA and add the journal block to it and choose the group journal 4) Share the group page with registered users 5) Logout 6) Login as UserB and visit the page 7) Click on the 'Add comment' link for the journal block The "Posted by..." line will say UserB instead of UserA To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1816311/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1816311] Re: Adding comment to journal entry shows wrong poster
** Changed in: mahara/17.10 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1816311 Title: Adding comment to journal entry shows wrong poster Status in Mahara: Fix Committed Status in Mahara 17.10 series: Fix Committed Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Bug description: When adding a comment to a journal entry artefact via a page we see the piece of information: Posted by [owner] on [date] This information is correct when doing this for a user's journal but the information is not correct if the journal is a group / institution journal. In these cases we see: Posted by [viewer of page] on [date] Steps to replicate: 1) Login as UserA and create a group, GroupA 2) Create a journal in the group and add a journal entry to it 3) Add a page in GroupA and add the journal block to it and choose the group journal 4) Share the group page with registered users 5) Logout 6) Login as UserB and visit the page 7) Click on the 'Add comment' link for the journal block The "Posted by..." line will say UserB instead of UserA To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1816311/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1816311] A patch has been submitted for review
Patch for "17.10_STABLE" branch: https://reviews.mahara.org/9580 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1816311 Title: Adding comment to journal entry shows wrong poster Status in Mahara: Fix Committed Status in Mahara 17.10 series: Fix Committed Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Bug description: When adding a comment to a journal entry artefact via a page we see the piece of information: Posted by [owner] on [date] This information is correct when doing this for a user's journal but the information is not correct if the journal is a group / institution journal. In these cases we see: Posted by [viewer of page] on [date] Steps to replicate: 1) Login as UserA and create a group, GroupA 2) Create a journal in the group and add a journal entry to it 3) Add a page in GroupA and add the journal block to it and choose the group journal 4) Share the group page with registered users 5) Logout 6) Login as UserB and visit the page 7) Click on the 'Add comment' link for the journal block The "Posted by..." line will say UserB instead of UserA To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1816311/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1816311] A change has been merged
Reviewed: https://reviews.mahara.org/9579 Committed: https://git.mahara.org/mahara/mahara/commit/582e9a3e23e50ab76c8f3d6c550344f9eda5a3e4 Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:18.04_STABLE commit 582e9a3e23e50ab76c8f3d6c550344f9eda5a3e4 Author: Robert Lyon Date: Mon Feb 18 08:31:13 2019 +1300 Bug 1816311: Showing correct journal entry poster's name When adding comment to the entry and the journal is owned by group/institution behatnotneeded Change-Id: Id492c04e3facdbf00a5dfdc4d714c3c5103ff3a2 Signed-off-by: Robert Lyon (cherry picked from commit 5988b7de00b4a12dd71004056aeec3b55e190243) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1816311 Title: Adding comment to journal entry shows wrong poster Status in Mahara: Fix Committed Status in Mahara 17.10 series: Fix Committed Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Bug description: When adding a comment to a journal entry artefact via a page we see the piece of information: Posted by [owner] on [date] This information is correct when doing this for a user's journal but the information is not correct if the journal is a group / institution journal. In these cases we see: Posted by [viewer of page] on [date] Steps to replicate: 1) Login as UserA and create a group, GroupA 2) Create a journal in the group and add a journal entry to it 3) Add a page in GroupA and add the journal block to it and choose the group journal 4) Share the group page with registered users 5) Logout 6) Login as UserB and visit the page 7) Click on the 'Add comment' link for the journal block The "Posted by..." line will say UserB instead of UserA To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1816311/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1816311] A patch has been submitted for review
Patch for "18.04_STABLE" branch: https://reviews.mahara.org/9579 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1816311 Title: Adding comment to journal entry shows wrong poster Status in Mahara: Fix Committed Status in Mahara 17.10 series: Fix Committed Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Bug description: When adding a comment to a journal entry artefact via a page we see the piece of information: Posted by [owner] on [date] This information is correct when doing this for a user's journal but the information is not correct if the journal is a group / institution journal. In these cases we see: Posted by [viewer of page] on [date] Steps to replicate: 1) Login as UserA and create a group, GroupA 2) Create a journal in the group and add a journal entry to it 3) Add a page in GroupA and add the journal block to it and choose the group journal 4) Share the group page with registered users 5) Logout 6) Login as UserB and visit the page 7) Click on the 'Add comment' link for the journal block The "Posted by..." line will say UserB instead of UserA To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1816311/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1816311] Re: Adding comment to journal entry shows wrong poster
** Changed in: mahara/18.10 Status: In Progress => Fix Committed ** Changed in: mahara/18.04 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1816311 Title: Adding comment to journal entry shows wrong poster Status in Mahara: Fix Committed Status in Mahara 17.10 series: Fix Committed Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Bug description: When adding a comment to a journal entry artefact via a page we see the piece of information: Posted by [owner] on [date] This information is correct when doing this for a user's journal but the information is not correct if the journal is a group / institution journal. In these cases we see: Posted by [viewer of page] on [date] Steps to replicate: 1) Login as UserA and create a group, GroupA 2) Create a journal in the group and add a journal entry to it 3) Add a page in GroupA and add the journal block to it and choose the group journal 4) Share the group page with registered users 5) Logout 6) Login as UserB and visit the page 7) Click on the 'Add comment' link for the journal block The "Posted by..." line will say UserB instead of UserA To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1816311/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1816311] A change has been merged
Reviewed: https://reviews.mahara.org/9578 Committed: https://git.mahara.org/mahara/mahara/commit/1261963a64292940029235f80d75d9e7f9552d9f Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:18.10_STABLE commit 1261963a64292940029235f80d75d9e7f9552d9f Author: Robert Lyon Date: Mon Feb 18 08:31:13 2019 +1300 Bug 1816311: Showing correct journal entry poster's name When adding comment to the entry and the journal is owned by group/institution behatnotneeded Change-Id: Id492c04e3facdbf00a5dfdc4d714c3c5103ff3a2 Signed-off-by: Robert Lyon (cherry picked from commit 5988b7de00b4a12dd71004056aeec3b55e190243) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1816311 Title: Adding comment to journal entry shows wrong poster Status in Mahara: Fix Committed Status in Mahara 17.10 series: In Progress Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Bug description: When adding a comment to a journal entry artefact via a page we see the piece of information: Posted by [owner] on [date] This information is correct when doing this for a user's journal but the information is not correct if the journal is a group / institution journal. In these cases we see: Posted by [viewer of page] on [date] Steps to replicate: 1) Login as UserA and create a group, GroupA 2) Create a journal in the group and add a journal entry to it 3) Add a page in GroupA and add the journal block to it and choose the group journal 4) Share the group page with registered users 5) Logout 6) Login as UserB and visit the page 7) Click on the 'Add comment' link for the journal block The "Posted by..." line will say UserB instead of UserA To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1816311/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1816311] A patch has been submitted for review
Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9578 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1816311 Title: Adding comment to journal entry shows wrong poster Status in Mahara: Fix Committed Status in Mahara 17.10 series: In Progress Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Bug description: When adding a comment to a journal entry artefact via a page we see the piece of information: Posted by [owner] on [date] This information is correct when doing this for a user's journal but the information is not correct if the journal is a group / institution journal. In these cases we see: Posted by [viewer of page] on [date] Steps to replicate: 1) Login as UserA and create a group, GroupA 2) Create a journal in the group and add a journal entry to it 3) Add a page in GroupA and add the journal block to it and choose the group journal 4) Share the group page with registered users 5) Logout 6) Login as UserB and visit the page 7) Click on the 'Add comment' link for the journal block The "Posted by..." line will say UserB instead of UserA To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1816311/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1765276] Re: Upgrade to Bootstrap 4
Bugs Fixed - no new issues found Tested the following themes - Raw, default and Modern. Catalyst QA Approved ✔ -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1765276 Title: Upgrade to Bootstrap 4 Status in Mahara: In Progress Bug description: Bootstrap 4 has been released. We should upgrade. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1765276/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1816311] Re: Adding comment to journal entry shows wrong poster
** Changed in: mahara/19.04 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1816311 Title: Adding comment to journal entry shows wrong poster Status in Mahara: Fix Committed Status in Mahara 17.10 series: In Progress Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Bug description: When adding a comment to a journal entry artefact via a page we see the piece of information: Posted by [owner] on [date] This information is correct when doing this for a user's journal but the information is not correct if the journal is a group / institution journal. In these cases we see: Posted by [viewer of page] on [date] Steps to replicate: 1) Login as UserA and create a group, GroupA 2) Create a journal in the group and add a journal entry to it 3) Add a page in GroupA and add the journal block to it and choose the group journal 4) Share the group page with registered users 5) Logout 6) Login as UserB and visit the page 7) Click on the 'Add comment' link for the journal block The "Posted by..." line will say UserB instead of UserA To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1816311/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1816311] A change has been merged
Reviewed: https://reviews.mahara.org/9573 Committed: https://git.mahara.org/mahara/mahara/commit/5988b7de00b4a12dd71004056aeec3b55e190243 Submitter: Cecilia Vela Gurovic (cecili...@catalyst.net.nz) Branch:master commit 5988b7de00b4a12dd71004056aeec3b55e190243 Author: Robert Lyon Date: Mon Feb 18 08:31:13 2019 +1300 Bug 1816311: Showing correct journal entry poster's name When adding comment to the entry and the journal is owned by group/institution behatnotneeded Change-Id: Id492c04e3facdbf00a5dfdc4d714c3c5103ff3a2 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1816311 Title: Adding comment to journal entry shows wrong poster Status in Mahara: Fix Committed Status in Mahara 17.10 series: In Progress Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Bug description: When adding a comment to a journal entry artefact via a page we see the piece of information: Posted by [owner] on [date] This information is correct when doing this for a user's journal but the information is not correct if the journal is a group / institution journal. In these cases we see: Posted by [viewer of page] on [date] Steps to replicate: 1) Login as UserA and create a group, GroupA 2) Create a journal in the group and add a journal entry to it 3) Add a page in GroupA and add the journal block to it and choose the group journal 4) Share the group page with registered users 5) Logout 6) Login as UserB and visit the page 7) Click on the 'Add comment' link for the journal block The "Posted by..." line will say UserB instead of UserA To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1816311/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
