[Mahara-contributors] [Bug 1801057] Re: Cascade navigation block in collection

2019-03-18 Thread Kristina Hoeppner
** Summary changed:

- Feature Request. Cascade Navigation Block in Collection
+ Cascade navigation block in collection

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1801057

Title:
  Cascade navigation block in collection

Status in Mahara:
  Fix Committed

Bug description:
  Current setup (in v18.04) means that if you have a collection of 10
  pages and want to add a navigation block to each page in the
  collection, you need to edit all 10 pages separately and add the
  navigation block every time. From a usability perspective it would be
  much better if when adding the navigation block to a page in a
  collection if you were prompted to ask if you wanted the same
  navigation block to be added to all pages in the collection - and if
  you chose yes it was automatically added to all pages in the
  collection.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1801057/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1819807] A patch has been submitted for review

2019-03-18 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/9635

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1819807

Title:
  Search box overlaps navigaiton icons on right side of page

Status in Mahara:
  New

Bug description:
  Mahara version: Mahara 18.10.1testing
  Browser: Chrome, Safari, Firefox windows edge
  OS: Mac
  PHP: 7.0
  Database: Mysql 8

  Issue:
  Search box is set with a right margin of 193px, but the icons on the right 
take up more than that space.

  Solution:
  change the lines 38 and 39 in htdocs/theme/raw/layout/nav/_navbar.scss to 
  right: 25%;   
  margin: 0;

  The 25% value is to match the layout grid to keep the right icons
  clear.

  Patch file with the change attached (A recompile of the css is
  necessary to confirm the change)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1819807/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1803101] A patch has been submitted for review

2019-03-18 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/9634

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1803101

Title:
  Error importing Leap2A w/ peer assessment

Status in Mahara:
  In Progress
Status in Mahara 18.10 series:
  Confirmed
Status in Mahara 19.04 series:
  In Progress

Bug description:
  I exported a simple portfolio page as Leap2A and got the error
  messages below when importing it via the admin interface. The Leap2A
  file is attached.

  [WAR] 37 (lib/adodb/adodb-exceptions.inc.php:45) Array to string conversion
  Call stack (most recent first):

  log_message("Array to string conversion", 8, true, true, 
"/home/kristina/code/mahara/htdocs/lib/adodb/adodb-...", 45) at 
/home/kristina/code/mahara/htdocs/lib/errors.php:520
  error(8, "Array to string conversion", 
"/home/kristina/code/mahara/htdocs/lib/adodb/adodb-...", 45, array(size 7)) at 
/home/kristina/code/mahara/htdocs/lib/adodb/adodb-exceptions.inc.php:45
  ADODB_Exception->__construct("postgres8", "adodb_throw", -1, "ERROR: null 
value in column "block" violates not-...", "INSERT INTO 
"artefact_peer_assessment" ("assessmen...", array(size 3), 
object(ADODB_postgres8)) at 
/home/kristina/code/mahara/htdocs/lib/adodb/adodb-exceptions.inc.php:80
  adodb_throw("postgres8", "adodb_throw", -1, "ERROR: null value in column 
"block" violates not-...", "INSERT INTO "artefact_peer_assessment" 
("assessmen...", array(size 3), object(ADODB_postgres8)) at 
/home/kristina/code/mahara/htdocs/lib/adodb/adodb.inc.php:313
  ADODB_TransMonitor("postgres8", "adodb_throw", -1, "ERROR: null value in 
column "block" violates not-...", "INSERT INTO "artefact_peer_assessment" 
("assessmen...", array(size 3), object(ADODB_postgres8)) at 
/home/kristina/code/mahara/htdocs/lib/adodb/adodb.inc.php:1263
  ADOConnection->_Execute("INSERT INTO "artefact_peer_assessment" 
("assessmen...", array(size 3)) at 
/home/kristina/code/mahara/htdocs/lib/adodb/adodb.inc.php:1223
  ADOConnection->Execute("INSERT INTO "artefact_peer_assessment" 
("assessmen...", array(size 3)) at 
/home/kristina/code/mahara/htdocs/lib/dml.php:1102
  insert_record("artefact_peer_assessment", object(stdClass)) at 
/home/kristina/code/mahara/htdocs/artefact/peerassessment/lib.php:240
  ArtefactTypePeerassessment->commit() at 
/home/kristina/code/mahara/htdocs/artefact/peerassessment/import/leap/lib.php:180
  LeapImportPeerassessment::import_using_strategy(object(SimpleXMLElement), 
object(PluginImportLeap), 1, array(size 0)) at 
/home/kristina/code/mahara/htdocs/lib/mahara.php:1813
  call_static_method("LeapImportPeerassessment", "import_using_strategy", 
object(SimpleXMLElement), object(PluginImportLeap), 1, array(size 0)) at 
/home/kristina/code/mahara/htdocs/import/leap/lib.php:665
  PluginImportLeap->import_from_load_mapping() at 
/home/kristina/code/mahara/htdocs/import/leap/lib.php:188
  PluginImportLeap->process() at 
/home/kristina/code/mahara/htdocs/admin/users/add.php:348
  adduser_submit(object(Pieform), array(size 24)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:542
  Pieform->__construct(array(size 8)) at 
/home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:164
  Pieform::process(array(size 8)) at 
/home/kristina/code/mahara/htdocs/lib/mahara.php:5258
  pieform(array(size 8)) at 
/home/kristina/code/mahara/htdocs/admin/users/add.php:156

  [WAR] 37 (lib/errors.php:858) Failed to get a recordset: postgres8 error: 
[-1: ERROR:  null value in column "block" violates not-null constraint
  DETAIL:  Failing row contains (22, null, null, 11, 0).] in adodb_throw(INSERT 
INTO "artefact_peer_assessment" ("assessment", "view", "private") VALUES (?, ?, 
?), Array)Command was: INSERT INTO "artefact_peer_assessment" ("assessment", 
"view", "private") VALUES (?, ?, ?) and values was 
(assessment:22,view:11,private:0)
  Call stack (most recent first):

  log_message("Failed to get a recordset: postgres8 error: [-1: E...", 8, 
true, true) at /home/kristina/code/mahara/htdocs/lib/errors.php:95
  log_warn("Failed to get a recordset: postgres8 error: [-1: E...") at 
/home/kristina/code/mahara/htdocs/lib/errors.php:858
  SQLException->__construct("Failed to get a recordset: postgres8 error: 
[-1: E...") at /home/kristina/code/mahara/htdocs/lib/dml.php:1105
  insert_record("artefact_peer_assessment", object(stdClass)) at 
/home/kristina/code/mahara/htdocs/artefact/peerassessment/lib.php:240
  ArtefactTypePeerassessment->commit() at 
/home/kristina/code/mahara/htdocs/artefact/peerassessment/import/leap/lib.php:180
  LeapImportPeerassessment::import_using_strategy(object(SimpleXMLElement), 
object(PluginImportLeap), 1, array(size 0)) 

[Mahara-contributors] [Bug 1765276] Re: Upgrade to Bootstrap 4

2019-03-18 Thread Steven
TITLE:  Fixed styling of SmartEvidence popover

BUG SUMMARY: When hovering over an aspect of the smart evidence, a popup
modal is displayed that does not have the right background colour for
the header

=

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS: 
 
1) Mahara UserA exists (no roles) 
2) Smart evidence collection exists with SmartEvidence framework = Career 
readiness


TEST STEPS: 
 
1) Log in as UserA
2) Browse to the Smart evidence collection as mentioned above 
3) hover mouse over one of the aspects in the list (ie. Critical thinking) 
4) Verify that the popup modal header has the same background colour as the 
table header ✔

Catalyst QA Approved ✔

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1765276

Title:
  Upgrade to Bootstrap 4

Status in Mahara:
  Fix Committed

Bug description:
  Bootstrap 4 has been released. We should upgrade.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1765276/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1771774] Re: No way to bypass externallogin

2019-03-18 Thread Steven
Bug Fixed - Documentation has been added ✔

Catalyst QA Approved ✔

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1771774

Title:
  No way to bypass externallogin

Status in Mahara:
  In Progress

Bug description:
  When the externallogin setting is turned on, it's impossible to fix
  things such as metadata URLs etc which are required for some external
  logins to work.

  It would be good to be able to pass in a special URL parameter to make
  Mahara skip the external login process. Here is a patch which I can
  push up to gerrit once someone confirms that the proposed change is
  useful and that the url parameter is unique enough:

  diff --git a/htdocs/auth/lib.php b/htdocs/auth/lib.php
  index 779d080352..4baf2c7875 100644
  --- a/htdocs/auth/lib.php
  +++ b/htdocs/auth/lib.php
  @@ -1171,7 +1171,7 @@ function auth_draw_login_page($message=null, Pieform 
$form=null) {
   }
   
   $externallogin = get_config('externallogin');
  -if ($externallogin) {
  +if ($externallogin && !isset($_GET['internallogin'])) {
   $externallogin = preg_replace('/{shorturlencoded}/', 
urlencode(get_relative_script_path()), $externallogin);
   $externallogin = preg_replace('/{wwwroot}/', get_config('wwwroot'), 
$externallogin);
   redirect($externallogin);

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1771774/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1765276] Re: Upgrade to Bootstrap 4

2019-03-18 Thread Steven
TITLE:   Navigation scrollbar

BUG SUMMARY: On screens that have a small height - the admin menu will
extend beyond the bottom of the page and hiding the last few menu items.
The menu items are not able to be scrolled into view and therefore
should have a scroll bar on the menu

Acceptance Criteria
-
1) scroll bars should only display when main menu itens are displayed below the 
bottom of the screen
2) Menu scroll bars should not display on screens that are capable of 
displaying full dropdown menu on screen

==

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS: 
 
1) none

TEST STEPS: 
 
1) Adjust the browser window so that the main drop down menu when open, goes 
beyond the bottom of the window
2) Verify that scroll bars are displayed for the menu items 
3) Verify that the bottom menu items can be scrolled into view ✘
4) Open a main drop down menu that does not extend beyond the bottom of the 
page 
5) Verify that scroll bars are not displayed  ✘

Catalyst QA Failed Testing ✘

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1765276

Title:
  Upgrade to Bootstrap 4

Status in Mahara:
  Fix Committed

Bug description:
  Bootstrap 4 has been released. We should upgrade.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1765276/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1820774] Re: Resume 'introduction' submenu not working in clean urls site

2019-03-18 Thread Robert Lyon
** Description changed:

  Go to artefact/resume/index.php
  
  And click on the 'Introduction' arrow menu item
  
  When on non clean urls site it loads the page correctly
  
- But on a clean urls site we get an error
+ But on a clean urls site we get an error:
+ 
+ Page not found
+ You tried to access a page that does not exist.
+ 
+ Page resume by artefact not found.
+ 
+ 
+ This is when we have the following rewrite rules in place:
+   RewriteRule ^/user/([a-z0-9-]+)/?$ 
/user/view.php?profile=$1&%{QUERY_STRING}
+   RewriteRule ^/user/([a-z0-9-]+)/([a-z0-9-]+)/?$ 
/view/view.php?profile=$1=$2&%{QUERY_STRING}
+   RewriteRule ^/group/([a-z0-9-]+)/?$ 
/group/view.php?homepage=$1&%{QUERY_STRING}
+   RewriteRule ^/group/([a-z0-9-]+)/([a-z0-9-]+)/?$ 
/view/view.php?homepage=$1=$2&%{QUERY_STRING}
+   RewriteRule ^/([a-z0-9-]+)/?$ /user/view.php?profile=$1&%{QUERY_STRING}
+   RewriteRule ^/([a-z0-9-]+)/([a-z0-9-]+)/?$ 
/view/view.php?profile=$1=$2&%{QUERY_STRING}

** Changed in: mahara
   Status: New => In Progress

** Changed in: mahara
   Importance: Undecided => High

** Changed in: mahara
   Importance: High => Medium

** Changed in: mahara
 Assignee: (unassigned) => Robert Lyon (robertl-9)

** Changed in: mahara
   Importance: Medium => High

** Changed in: mahara
Milestone: None => 19.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1820774

Title:
  Resume 'introduction' submenu not working in clean urls site

Status in Mahara:
  In Progress

Bug description:
  Go to artefact/resume/index.php

  And click on the 'Introduction' arrow menu item

  When on non clean urls site it loads the page correctly

  But on a clean urls site we get an error:

  Page not found
  You tried to access a page that does not exist.

  Page resume by artefact not found.

  
  This is when we have the following rewrite rules in place:
RewriteRule ^/user/([a-z0-9-]+)/?$ 
/user/view.php?profile=$1&%{QUERY_STRING}
RewriteRule ^/user/([a-z0-9-]+)/([a-z0-9-]+)/?$ 
/view/view.php?profile=$1=$2&%{QUERY_STRING}
RewriteRule ^/group/([a-z0-9-]+)/?$ 
/group/view.php?homepage=$1&%{QUERY_STRING}
RewriteRule ^/group/([a-z0-9-]+)/([a-z0-9-]+)/?$ 
/view/view.php?homepage=$1=$2&%{QUERY_STRING}
RewriteRule ^/([a-z0-9-]+)/?$ /user/view.php?profile=$1&%{QUERY_STRING}
RewriteRule ^/([a-z0-9-]+)/([a-z0-9-]+)/?$ 
/view/view.php?profile=$1=$2&%{QUERY_STRING}

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1820774/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1820774] A patch has been submitted for review

2019-03-18 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/9632

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1820774

Title:
  Resume 'introduction' submenu not working in clean urls site

Status in Mahara:
  In Progress

Bug description:
  Go to artefact/resume/index.php

  And click on the 'Introduction' arrow menu item

  When on non clean urls site it loads the page correctly

  But on a clean urls site we get an error:

  Page not found
  You tried to access a page that does not exist.

  Page resume by artefact not found.

  
  This is when we have the following rewrite rules in place:
RewriteRule ^/user/([a-z0-9-]+)/?$ 
/user/view.php?profile=$1&%{QUERY_STRING}
RewriteRule ^/user/([a-z0-9-]+)/([a-z0-9-]+)/?$ 
/view/view.php?profile=$1=$2&%{QUERY_STRING}
RewriteRule ^/group/([a-z0-9-]+)/?$ 
/group/view.php?homepage=$1&%{QUERY_STRING}
RewriteRule ^/group/([a-z0-9-]+)/([a-z0-9-]+)/?$ 
/view/view.php?homepage=$1=$2&%{QUERY_STRING}
RewriteRule ^/([a-z0-9-]+)/?$ /user/view.php?profile=$1&%{QUERY_STRING}
RewriteRule ^/([a-z0-9-]+)/([a-z0-9-]+)/?$ 
/view/view.php?profile=$1=$2&%{QUERY_STRING}

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1820774/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1820774] [NEW] Resume 'introduction' submenu not working in clean urls site

2019-03-18 Thread Robert Lyon
Public bug reported:

Go to artefact/resume/index.php

And click on the 'Introduction' arrow menu item

When on non clean urls site it loads the page correctly

But on a clean urls site we get an error:

Page not found
You tried to access a page that does not exist.

Page resume by artefact not found.


This is when we have the following rewrite rules in place:
  RewriteRule ^/user/([a-z0-9-]+)/?$ 
/user/view.php?profile=$1&%{QUERY_STRING}
  RewriteRule ^/user/([a-z0-9-]+)/([a-z0-9-]+)/?$ 
/view/view.php?profile=$1=$2&%{QUERY_STRING}
  RewriteRule ^/group/([a-z0-9-]+)/?$ 
/group/view.php?homepage=$1&%{QUERY_STRING}
  RewriteRule ^/group/([a-z0-9-]+)/([a-z0-9-]+)/?$ 
/view/view.php?homepage=$1=$2&%{QUERY_STRING}
  RewriteRule ^/([a-z0-9-]+)/?$ /user/view.php?profile=$1&%{QUERY_STRING}
  RewriteRule ^/([a-z0-9-]+)/([a-z0-9-]+)/?$ 
/view/view.php?profile=$1=$2&%{QUERY_STRING}

** Affects: mahara
 Importance: High
 Assignee: Robert Lyon (robertl-9)
 Status: In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1820774

Title:
  Resume 'introduction' submenu not working in clean urls site

Status in Mahara:
  In Progress

Bug description:
  Go to artefact/resume/index.php

  And click on the 'Introduction' arrow menu item

  When on non clean urls site it loads the page correctly

  But on a clean urls site we get an error:

  Page not found
  You tried to access a page that does not exist.

  Page resume by artefact not found.

  
  This is when we have the following rewrite rules in place:
RewriteRule ^/user/([a-z0-9-]+)/?$ 
/user/view.php?profile=$1&%{QUERY_STRING}
RewriteRule ^/user/([a-z0-9-]+)/([a-z0-9-]+)/?$ 
/view/view.php?profile=$1=$2&%{QUERY_STRING}
RewriteRule ^/group/([a-z0-9-]+)/?$ 
/group/view.php?homepage=$1&%{QUERY_STRING}
RewriteRule ^/group/([a-z0-9-]+)/([a-z0-9-]+)/?$ 
/view/view.php?homepage=$1=$2&%{QUERY_STRING}
RewriteRule ^/([a-z0-9-]+)/?$ /user/view.php?profile=$1&%{QUERY_STRING}
RewriteRule ^/([a-z0-9-]+)/([a-z0-9-]+)/?$ 
/view/view.php?profile=$1=$2&%{QUERY_STRING}

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1820774/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1771774] Re: No way to bypass externallogin

2019-03-18 Thread Steven
Environment tested: Master
Browser tested: Chrome

PRECONDITIONS: 
 
1) The following code is enabled in the config.php file 
  $cfg->externallogin = 
'http://moodle.example.com/auth/mnet/jump.php?hostwwwroot={wwwroot}={shorturlencoded}';
2) Site admin is not logged in 

TEST STEPS: 
 
1) Site admin browse to 
http://mahara.stevens-lp.dynamic.wgtn.cat-it.co.nz/admin/users/search.php
2) confirm the page will not load "This site can’t be reached 
moodle.example.com’s server IP address could not be found."
3) Enter the base URL  
http://mahara.stevens-lp.dynamic.wgtn.cat-it.co.nz/admin/users/search.php in 
the address bar and amment it with the following
  a) ?override=true
4) Verify the user is redirected to Mahara login page ✔
5) Verify that the how to is documented in the  config-defaults.php file ✘

NOTE: By entering the code above in the config.php file - it will cause
the error "Site not found" - this represents what would happen if your
authentication server went down. By adding the  override parameter to
the end of the URL , the site admin can still log in to Mahara

Catalyst QA Failed testing ✘

NOTE 
1) Needs further documentation in the config-defaults.php file
2) external override Functionality working as expected

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1771774

Title:
  No way to bypass externallogin

Status in Mahara:
  In Progress

Bug description:
  When the externallogin setting is turned on, it's impossible to fix
  things such as metadata URLs etc which are required for some external
  logins to work.

  It would be good to be able to pass in a special URL parameter to make
  Mahara skip the external login process. Here is a patch which I can
  push up to gerrit once someone confirms that the proposed change is
  useful and that the url parameter is unique enough:

  diff --git a/htdocs/auth/lib.php b/htdocs/auth/lib.php
  index 779d080352..4baf2c7875 100644
  --- a/htdocs/auth/lib.php
  +++ b/htdocs/auth/lib.php
  @@ -1171,7 +1171,7 @@ function auth_draw_login_page($message=null, Pieform 
$form=null) {
   }
   
   $externallogin = get_config('externallogin');
  -if ($externallogin) {
  +if ($externallogin && !isset($_GET['internallogin'])) {
   $externallogin = preg_replace('/{shorturlencoded}/', 
urlencode(get_relative_script_path()), $externallogin);
   $externallogin = preg_replace('/{wwwroot}/', get_config('wwwroot'), 
$externallogin);
   redirect($externallogin);

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1771774/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1768160] Re: resume tinyMCE keeps old text

2019-03-18 Thread Steven
Environment tested: Master
Browser tested: Chrome

PRECONDITIONS: 
 
1) Mahara user exists (no roles)

TEST STEPS: 
 
1) Log in as Mahara user 
2) Browse to Main menu > Create > Resume and click on the Education and 
employment link
3) Click add for the Education history section
4) Fill in all the fields with data and save 
5) Click the add button a second time for the Education history section
6) Confirm all of the fields are empty  ✔
7) Confirm the TinyMCE text area is empty ✔

Catalyst QA Approved ✔

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1768160

Title:
  resume tinyMCE keeps old text

Status in Mahara:
  In Progress

Bug description:
  In User Menu-> Content -> Resume

  when adding "Education and employment" or "Achievements items", e.g.
  "Education history" we can add and item with description "Some text"
  in the TinyMCE text area, when we save and want to add a new one, we
  can see that the text "Some text" still show in the description field,
  but it should be empty.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1768160/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1777971] Re: jquery-ui timepicker- old code needs to be removed

2019-03-18 Thread Robert Lyon
** Changed in: mahara
Milestone: 19.10.0 => None

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1777971

Title:
  jquery-ui timepicker- old code needs to be removed

Status in Mahara:
  Invalid

Bug description:
  when upgrading jquery-ui to 1.12.1 I found a customization in the file 
  jquery-ui/js/jquery-ui.min.js that was made when this message was added to 
js/jquery/jquery-ui/README.Mahara

  * Added call to function after datepicker arrow key is pressed - to
  allow the year arrows to be re-added on day change

  that was added in commit 
  here, a function add_prev_next_year() was defined and added to 
jquery-ui/js/jquery-ui.min.js

  that function was removed in commit 8d796e7ca04b6df776b5deeb07cf38b9c7b037c0
  for Bug #1744191: Updated the datepicker to use the bootstrap one

  there is no need to add extra code to jquery-ui.min.js
  and it would be good to check what else is in the code but not needed anymore

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1777971/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1777971] Re: jquery-ui timepicker- old code needs to be removed

2019-03-18 Thread Lisa Seeto
** Changed in: mahara
   Status: In Progress => Invalid

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1777971

Title:
  jquery-ui timepicker- old code needs to be removed

Status in Mahara:
  Invalid

Bug description:
  when upgrading jquery-ui to 1.12.1 I found a customization in the file 
  jquery-ui/js/jquery-ui.min.js that was made when this message was added to 
js/jquery/jquery-ui/README.Mahara

  * Added call to function after datepicker arrow key is pressed - to
  allow the year arrows to be re-added on day change

  that was added in commit 
  here, a function add_prev_next_year() was defined and added to 
jquery-ui/js/jquery-ui.min.js

  that function was removed in commit 8d796e7ca04b6df776b5deeb07cf38b9c7b037c0
  for Bug #1744191: Updated the datepicker to use the bootstrap one

  there is no need to add extra code to jquery-ui.min.js
  and it would be good to check what else is in the code but not needed anymore

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1777971/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1777971] Re: jquery-ui timepicker- old code needs to be removed

2019-03-18 Thread Lisa Seeto
I gone over the previous commits to the file:

1st: b5a7abd380a12e6b97304f35c2425017ff4d34a4
2nd: 00e96e99c0c75159a7d1b0eb8d145c8f94cd50fb
3rd: cccb223aed4e34de57c1408d2c6326fd04c5985e

It seems that the only custom change to jquery-ui/js/jquery-ui.min.js
came in on the 2nd commit and was subsequently removed.  The only
modifications to the file have been version upgrades.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1777971

Title:
  jquery-ui timepicker- old code needs to be removed

Status in Mahara:
  Invalid

Bug description:
  when upgrading jquery-ui to 1.12.1 I found a customization in the file 
  jquery-ui/js/jquery-ui.min.js that was made when this message was added to 
js/jquery/jquery-ui/README.Mahara

  * Added call to function after datepicker arrow key is pressed - to
  allow the year arrows to be re-added on day change

  that was added in commit 
  here, a function add_prev_next_year() was defined and added to 
jquery-ui/js/jquery-ui.min.js

  that function was removed in commit 8d796e7ca04b6df776b5deeb07cf38b9c7b037c0
  for Bug #1744191: Updated the datepicker to use the bootstrap one

  there is no need to add extra code to jquery-ui.min.js
  and it would be good to check what else is in the code but not needed anymore

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1777971/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1815979] Re: Blog block in page versioning only shows the first few posts

2019-03-18 Thread Steven
TITLE:  Blog block in page versioning only shows the first few posts

BUG SUMMARY:
 
Even though the system records the artefact ids of all the current posts
We need to adjust the block to rendering to fetch all posts if in versioning
==

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS: 
 
1) Mahara user exists (no roles) 
2) Portfolio page exists with a Journal block (block has 5 entries per page set 
up)
3) Journal exists and has 13 journal entries 
4) Portfolio page has been saved to time line when there was 5 journal entries 
and 13 journal entries

TEST STEPS: 
 
1) Log in as Mahara user
2) Browse to Portfolio page that has the above criteria 
3) Verify that the journal block has pagination 
4) View the timeline for the page 
5) Verify that the timeline displays all of the journal posts ✔

Catalyst QA Approved ✔

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1815979

Title:
  Blog block in page versioning only shows the first few posts

Status in Mahara:
  In Progress
Status in Mahara 18.10 series:
  Confirmed
Status in Mahara 19.04 series:
  In Progress

Bug description:
  Even though the system records the artefact ids of all the current
  posts

  We need to adjust the block to rendering to fetch all posts if in
  versioning

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1815979/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp