[Mahara-contributors] [Bug 1821267] Re: Email notice for submisisons and reports on submisisons
Apparently Email notice is existing functionality and code was not changed in this patch. I did receive notification when the user submits a page/collection for submission. However, the only time I got a notification of release was when the Site admin released the submission. Never got a release email when Group admin released the submission. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1821267 Title: Email notice for submisisons and reports on submisisons Status in Mahara: In Progress Bug description: Wishlist item: When a user submits a page or collection for marking - to send out an email notice to that user. A report to view all submissions and when they were marked and released To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1821267/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1821267] Re: Email notice for submisisons and reports on submisisons
Commit hash: c924173dfcc42acbbb447d1cfe8ed7c32a6767a6 97607ef61eef076b3c8fc445ce9a343e8d9641df Environment tested: Master Browser tested: Chrome Theme used: Raw | Default raw | Ocean | Modern | Primary school PRECONDITIONS: 1) Group Exists as follows: (Group four - Controlled, Allows submissions) a) Controlled = Yes b) Roles = Course: Member, Tutor, Admin c) Friend invitations = No d) Allow submissions = Yes e) Allow archiving of submissions = No f) Hide group = No g) Auto-add users = No h) Shared page notifications = All group members (required for testing) i) Comment notifications = All group members 2) Institution one exists - Associate group 'Group four' with an institution. 3) The following members exist a) SIte admin - not associated with inst - Group admin b) Alice User1 - Inst admin - Group admin c) Bob User2 - Inst staff - Group Tutor d) Carol User3 - Inst member - Group member e) Earl User4 - Inst member - Group member 4) Site admin set Access reports for staff = Yes 5) The following users have submitted pages and collections a) Alice User1 Alice Page. Alice collection b) Bob User2 Bob Page. Bob collection c) Carol User3 Carol Page. Carol collection d) Earl User4 Earl Page. Earl collection TEST STEPS: 1) Log in as Site admin 2) Browse to Group page and release a submission 3) Browse to the Report page 4) Configure the report 5) Verify that the Report type drop down field contains "Submissions" selection uder the Groups category ✔ 6) Verify that the To: date field is set for tomorrows date ✔ 7) enable all of the available fields/columns 8) Click the Submit button 9) Verify the report displays the correct title ✘ The title should be "Submissions" (and not "People overview") 10) Verify the table has the following columns a) # b) SUBMISSION TYPE (SORT BY: ASCENDING) c) PAGE (SORT BY: ASCENDING) d) USERNAME (SORT BY: ASCENDING) e) GROUP (SORT BY: ASCENDING) f) SUBMISSION DATE (SORT BY: ASCENDING) g) RELEASED DATE (SORT BY: ASCENDING) h) RELEASED BY 11) Verify that the Pages and collections that have been released have a Release date ✔ 12) Verify that the Pages and collections that have been released have a Released by User name ✔ NOTE: Log out and log in as Group admin and repeat the above script BUGS Found 1) BUG - Incorrect title for the report - Title should be "Submissions" 2) BUG - Released pages / collections by Group admin do not display a Release date or a Released By Username 3) BUG - Username field contains the Users full name + a user name = expected to see only User name 4) BUG - The # is not helpful information to display = why even include it? 5) BUG - Archive of submissions not working for me - Had errors in the Export Queue and would not ever archive the submissions - ended up using the setting "Allow archiving of submissions" set to "NO" ** Attachment added: "No archive submission_21-06-19-13:39:25.png" https://bugs.launchpad.net/mahara/+bug/1821267/+attachment/5271978/+files/No%20archive%20submission_21-06-19-13%3A39%3A25.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1821267 Title: Email notice for submisisons and reports on submisisons Status in Mahara: In Progress Bug description: Wishlist item: When a user submits a page or collection for marking - to send out an email notice to that user. A report to view all submissions and when they were marked and released To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1821267/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1810990] A change has been merged
Reviewed: https://reviews.mahara.org/10075 Committed: https://git.mahara.org/mahara/mahara/commit/f17759734ceffb27a8a001a4208cdd5e39e4f884 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit f17759734ceffb27a8a001a4208cdd5e39e4f884 Author: Robert Lyon Date: Wed Jun 12 14:19:11 2019 +1200 Bug 1810990: Allowing the uploading of archive file in behat And have it treated as an archive Change-Id: I74ae535ad4a9e104049d3feb80f5452c8fa2aebb Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1810990 Title: Create Behat background steps to easily set up page content Status in Mahara: Fix Released Bug description: When a page needs to have content, it's rather cumbersome to get that in as it needs to be mentioned in the scenario making that rather long. Instead, we are looking into setting up background steps that will allow the easy creation of page content. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1810990/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1785985] A change has been merged
Reviewed: https://reviews.mahara.org/10022 Committed: https://git.mahara.org/mahara/mahara/commit/a2f72b46ae62d107f2db9af3ddb55f9ea028f0c3 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:18.04_STABLE commit a2f72b46ae62d107f2db9af3ddb55f9ea028f0c3 Author: Robert Lyon Date: Thu May 16 09:47:25 2019 +1200 Bug 1785985: Offset the problematic cron jobs As mentioned in forum post https://mahara.org/interaction/forum/topic.php?id=8450#post33705 behatnotneeded Change-Id: I700c295d6d4ced232a119c3f8dbbc922a73298d3 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1785985 Title: Remove triggers from Mahara database Status in Mahara: In Progress Bug description: I've created a forum post to discuss this: * https://mahara.org/interaction/forum/topic.php?id=8324 Basically, my reasoning is: 1. Mahara supports two DB types - MySql and Postgres. Each DB has different syntax when it comes to creating/updating/deleting triggers. This makes it complicated to develop and maintain. 2. Mahara already has the concept of events in place. We can move the functionality of each trigger into an event. We would then have more control over the event. For example, don't action an event during an upgrade. 3. Triggers make it difficult to see what is actually happening. They are not transparent. If you weren't aware that there is a trigger on the table, it can make it difficult to track down why something is behaving in a certain way. We can start slowly by removing one at a time. It doesn't have to happen all at once. Just my thoughts. Cheers. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1785985/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1785985] A change has been merged
Reviewed: https://reviews.mahara.org/10023 Committed: https://git.mahara.org/mahara/mahara/commit/6c6bbc2526e4cde55c4dfab0f2eaa5411105c0e5 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:18.10_STABLE commit 6c6bbc2526e4cde55c4dfab0f2eaa5411105c0e5 Author: Robert Lyon Date: Thu May 16 09:47:25 2019 +1200 Bug 1785985: Offset the problematic cron jobs As mentioned in forum post https://mahara.org/interaction/forum/topic.php?id=8450#post33705 behatnotneeded Change-Id: I700c295d6d4ced232a119c3f8dbbc922a73298d3 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1785985 Title: Remove triggers from Mahara database Status in Mahara: In Progress Bug description: I've created a forum post to discuss this: * https://mahara.org/interaction/forum/topic.php?id=8324 Basically, my reasoning is: 1. Mahara supports two DB types - MySql and Postgres. Each DB has different syntax when it comes to creating/updating/deleting triggers. This makes it complicated to develop and maintain. 2. Mahara already has the concept of events in place. We can move the functionality of each trigger into an event. We would then have more control over the event. For example, don't action an event during an upgrade. 3. Triggers make it difficult to see what is actually happening. They are not transparent. If you weren't aware that there is a trigger on the table, it can make it difficult to track down why something is behaving in a certain way. We can start slowly by removing one at a time. It doesn't have to happen all at once. Just my thoughts. Cheers. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1785985/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1785985] A change has been merged
Reviewed: https://reviews.mahara.org/10024 Committed: https://git.mahara.org/mahara/mahara/commit/4c620d4d4a93771ddf4932c1a8b34d9aa26fcdad Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit 4c620d4d4a93771ddf4932c1a8b34d9aa26fcdad Author: Robert Lyon Date: Thu May 16 09:47:25 2019 +1200 Bug 1785985: Offset the problematic cron jobs As mentioned in forum post https://mahara.org/interaction/forum/topic.php?id=8450#post33705 behatnotneeded Change-Id: I700c295d6d4ced232a119c3f8dbbc922a73298d3 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1785985 Title: Remove triggers from Mahara database Status in Mahara: In Progress Bug description: I've created a forum post to discuss this: * https://mahara.org/interaction/forum/topic.php?id=8324 Basically, my reasoning is: 1. Mahara supports two DB types - MySql and Postgres. Each DB has different syntax when it comes to creating/updating/deleting triggers. This makes it complicated to develop and maintain. 2. Mahara already has the concept of events in place. We can move the functionality of each trigger into an event. We would then have more control over the event. For example, don't action an event during an upgrade. 3. Triggers make it difficult to see what is actually happening. They are not transparent. If you weren't aware that there is a trigger on the table, it can make it difficult to track down why something is behaving in a certain way. We can start slowly by removing one at a time. It doesn't have to happen all at once. Just my thoughts. Cheers. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1785985/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1818067] Re: Goals and skills - add file - after preview focus return to the main page
*** This bug is a duplicate of bug 1817326 *** https://bugs.launchpad.net/bugs/1817326 ** Also affects: mahara/19.04 Importance: Undecided Status: New ** Also affects: mahara/19.10 Importance: Undecided Status: New ** Changed in: mahara/19.10 Status: New => Fix Committed ** Changed in: mahara/19.10 Milestone: None => 19.10.0 ** Changed in: mahara/19.04 Status: New => Fix Committed ** Changed in: mahara/19.04 Milestone: None => 19.04.1 ** Changed in: mahara/19.04 Importance: Undecided => Medium ** Changed in: mahara/19.10 Importance: Undecided => Medium -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1818067 Title: Goals and skills - add file - after preview focus return to the main page Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Bug description: Sorry, but in my first try i think we are misunderstood, but this is really a bug. I'am in Goals and skills, to reproduce it: - in Goals and skills | Summary page click on "Add a file" - add a lot of files so that the window must be longer than the screen (more 20 files) - view an image, in the preview popup click outside the visualization - you can see that it is impossible to scroll in the window that displays the list of images (the focus has returned to the page back) Thank you for looking at the attached gif that shows exactly the problem (@Kristina) Thank you - Mahara 18.10 - Windows 10 (web server on linux) - Mysql Database - Google Chrome To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1818067/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1817326] Re: Goals and skills - add file - after preview focus lost on the pop-up with my files
Hmm, the issue seems to exist in 19.10 and below - the problem looks to be the fact that when the inner modal is closed when clicking outside it - it removes a class from 'body' of the page that scrolling within the outer modal relies on ** Changed in: mahara/18.10 Status: In Progress => Fix Committed ** Changed in: mahara/18.04 Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1817326 Title: Goals and skills - add file - after preview focus lost on the pop-up with my files Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Bug description: I'am in Goals and skills. I add file, a new window open with my files, if i click of one of them a preview pop-up open. If a click on the side, this pop close, but the focus was lost on the windows who display my files. The scrolling it's on the main page not on the first open pop-up (list of my files). If you want to reproduice the bug, you should have many files (+ 10) in your bank. I hope to be clear to explain the bug. Thank you - Mahara 18.10 - Windows 10 (web server on linux) - Mysql Database - Google Chrome To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/18.04/+bug/1817326/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1817326] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/10113 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1817326 Title: Goals and skills - add file - after preview focus lost on the pop-up with my files Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Bug description: I'am in Goals and skills. I add file, a new window open with my files, if i click of one of them a preview pop-up open. If a click on the side, this pop close, but the focus was lost on the windows who display my files. The scrolling it's on the main page not on the first open pop-up (list of my files). If you want to reproduice the bug, you should have many files (+ 10) in your bank. I hope to be clear to explain the bug. Thank you - Mahara 18.10 - Windows 10 (web server on linux) - Mysql Database - Google Chrome To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/18.04/+bug/1817326/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1817326] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10114 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1817326 Title: Goals and skills - add file - after preview focus lost on the pop-up with my files Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Bug description: I'am in Goals and skills. I add file, a new window open with my files, if i click of one of them a preview pop-up open. If a click on the side, this pop close, but the focus was lost on the windows who display my files. The scrolling it's on the main page not on the first open pop-up (list of my files). If you want to reproduice the bug, you should have many files (+ 10) in your bank. I hope to be clear to explain the bug. Thank you - Mahara 18.10 - Windows 10 (web server on linux) - Mysql Database - Google Chrome To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/18.04/+bug/1817326/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1817326] A patch has been submitted for review
Patch for "18.10_STABLE" branch: https://reviews.mahara.org/10117 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1817326 Title: Goals and skills - add file - after preview focus lost on the pop-up with my files Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Bug description: I'am in Goals and skills. I add file, a new window open with my files, if i click of one of them a preview pop-up open. If a click on the side, this pop close, but the focus was lost on the windows who display my files. The scrolling it's on the main page not on the first open pop-up (list of my files). If you want to reproduice the bug, you should have many files (+ 10) in your bank. I hope to be clear to explain the bug. Thank you - Mahara 18.10 - Windows 10 (web server on linux) - Mysql Database - Google Chrome To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/18.04/+bug/1817326/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1817326] A patch has been submitted for review
Patch for "18.04_STABLE" branch: https://reviews.mahara.org/10118 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1817326 Title: Goals and skills - add file - after preview focus lost on the pop-up with my files Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Bug description: I'am in Goals and skills. I add file, a new window open with my files, if i click of one of them a preview pop-up open. If a click on the side, this pop close, but the focus was lost on the windows who display my files. The scrolling it's on the main page not on the first open pop-up (list of my files). If you want to reproduice the bug, you should have many files (+ 10) in your bank. I hope to be clear to explain the bug. Thank you - Mahara 18.10 - Windows 10 (web server on linux) - Mysql Database - Google Chrome To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/18.04/+bug/1817326/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1817326] A patch has been submitted for review
Patch for "18.10_STABLE" branch: https://reviews.mahara.org/10116 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1817326 Title: Goals and skills - add file - after preview focus lost on the pop-up with my files Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Bug description: I'am in Goals and skills. I add file, a new window open with my files, if i click of one of them a preview pop-up open. If a click on the side, this pop close, but the focus was lost on the windows who display my files. The scrolling it's on the main page not on the first open pop-up (list of my files). If you want to reproduice the bug, you should have many files (+ 10) in your bank. I hope to be clear to explain the bug. Thank you - Mahara 18.10 - Windows 10 (web server on linux) - Mysql Database - Google Chrome To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/18.04/+bug/1817326/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1817326] A patch has been submitted for review
Patch for "18.04_STABLE" branch: https://reviews.mahara.org/10119 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1817326 Title: Goals and skills - add file - after preview focus lost on the pop-up with my files Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Bug description: I'am in Goals and skills. I add file, a new window open with my files, if i click of one of them a preview pop-up open. If a click on the side, this pop close, but the focus was lost on the windows who display my files. The scrolling it's on the main page not on the first open pop-up (list of my files). If you want to reproduice the bug, you should have many files (+ 10) in your bank. I hope to be clear to explain the bug. Thank you - Mahara 18.10 - Windows 10 (web server on linux) - Mysql Database - Google Chrome To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/18.04/+bug/1817326/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1817326] A change has been merged
Reviewed: https://reviews.mahara.org/10115 Committed: https://git.mahara.org/mahara/mahara/commit/b8532ff6cc5e7ff78586ca01df1c25ba6b28d1d2 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit b8532ff6cc5e7ff78586ca01df1c25ba6b28d1d2 Author: Robert Lyon Date: Fri Jun 21 11:35:18 2019 +1200 Bug 1817326: Modal in a Modal popup problem for editcomposite When closing the inner modal it removes a class from the tag causing the scrolling to break behatnotneeded Change-Id: Ic7d6678a6d69d57343678f1ca57e8fa2e00861e2 Signed-off-by: Robert Lyon (cherry picked from commit 5bff19e5e7b7ec59e9b8afd9ce3f865a1895498a) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1817326 Title: Goals and skills - add file - after preview focus lost on the pop-up with my files Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Bug description: I'am in Goals and skills. I add file, a new window open with my files, if i click of one of them a preview pop-up open. If a click on the side, this pop close, but the focus was lost on the windows who display my files. The scrolling it's on the main page not on the first open pop-up (list of my files). If you want to reproduice the bug, you should have many files (+ 10) in your bank. I hope to be clear to explain the bug. Thank you - Mahara 18.10 - Windows 10 (web server on linux) - Mysql Database - Google Chrome To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/18.04/+bug/1817326/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1817326] A change has been merged
Reviewed: https://reviews.mahara.org/10113 Committed: https://git.mahara.org/mahara/mahara/commit/5bff19e5e7b7ec59e9b8afd9ce3f865a1895498a Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 5bff19e5e7b7ec59e9b8afd9ce3f865a1895498a Author: Robert Lyon Date: Fri Jun 21 11:35:18 2019 +1200 Bug 1817326: Modal in a Modal popup problem for editcomposite When closing the inner modal it removes a class from the tag causing the scrolling to break behatnotneeded Change-Id: Ic7d6678a6d69d57343678f1ca57e8fa2e00861e2 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1817326 Title: Goals and skills - add file - after preview focus lost on the pop-up with my files Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Bug description: I'am in Goals and skills. I add file, a new window open with my files, if i click of one of them a preview pop-up open. If a click on the side, this pop close, but the focus was lost on the windows who display my files. The scrolling it's on the main page not on the first open pop-up (list of my files). If you want to reproduice the bug, you should have many files (+ 10) in your bank. I hope to be clear to explain the bug. Thank you - Mahara 18.10 - Windows 10 (web server on linux) - Mysql Database - Google Chrome To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/18.04/+bug/1817326/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1817326] A change has been merged
Reviewed: https://reviews.mahara.org/10116 Committed: https://git.mahara.org/mahara/mahara/commit/cea4728fa91500f1b0b9cc264d8c7830b2978707 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:18.10_STABLE commit cea4728fa91500f1b0b9cc264d8c7830b2978707 Author: Robert Lyon Date: Fri Jun 21 11:29:13 2019 +1200 Bug 1817326: Modal in a Modal popup problem When closing the inner modal it removes a class from the tag causing the scrolling to break behatnotneeded Change-Id: I9d132a91cd48500276951c24c0987b418daacb6e Signed-off-by: Robert Lyon (cherry picked from commit 9bd277e5257e498119be95489db4107231e4f13c) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1817326 Title: Goals and skills - add file - after preview focus lost on the pop-up with my files Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Bug description: I'am in Goals and skills. I add file, a new window open with my files, if i click of one of them a preview pop-up open. If a click on the side, this pop close, but the focus was lost on the windows who display my files. The scrolling it's on the main page not on the first open pop-up (list of my files). If you want to reproduice the bug, you should have many files (+ 10) in your bank. I hope to be clear to explain the bug. Thank you - Mahara 18.10 - Windows 10 (web server on linux) - Mysql Database - Google Chrome To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/18.04/+bug/1817326/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1817326] A change has been merged
Reviewed: https://reviews.mahara.org/10118 Committed: https://git.mahara.org/mahara/mahara/commit/af790cac5f45fedf680b79b3f89053ee6b3a75ca Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:18.04_STABLE commit af790cac5f45fedf680b79b3f89053ee6b3a75ca Author: Robert Lyon Date: Fri Jun 21 11:29:13 2019 +1200 Bug 1817326: Modal in a Modal popup problem When closing the inner modal it removes a class from the tag causing the scrolling to break behatnotneeded Change-Id: I9d132a91cd48500276951c24c0987b418daacb6e Signed-off-by: Robert Lyon (cherry picked from commit 9bd277e5257e498119be95489db4107231e4f13c) (cherry picked from commit cea4728fa91500f1b0b9cc264d8c7830b2978707) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1817326 Title: Goals and skills - add file - after preview focus lost on the pop-up with my files Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Bug description: I'am in Goals and skills. I add file, a new window open with my files, if i click of one of them a preview pop-up open. If a click on the side, this pop close, but the focus was lost on the windows who display my files. The scrolling it's on the main page not on the first open pop-up (list of my files). If you want to reproduice the bug, you should have many files (+ 10) in your bank. I hope to be clear to explain the bug. Thank you - Mahara 18.10 - Windows 10 (web server on linux) - Mysql Database - Google Chrome To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/18.04/+bug/1817326/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1817326] A change has been merged
Reviewed: https://reviews.mahara.org/10117 Committed: https://git.mahara.org/mahara/mahara/commit/757ba5e6b90888ba0e219afd010d50b3931b230e Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:18.10_STABLE commit 757ba5e6b90888ba0e219afd010d50b3931b230e Author: Robert Lyon Date: Fri Jun 21 11:35:18 2019 +1200 Bug 1817326: Modal in a Modal popup problem for editcomposite When closing the inner modal it removes a class from the tag causing the scrolling to break behatnotneeded Change-Id: Ic7d6678a6d69d57343678f1ca57e8fa2e00861e2 Signed-off-by: Robert Lyon (cherry picked from commit 5bff19e5e7b7ec59e9b8afd9ce3f865a1895498a) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1817326 Title: Goals and skills - add file - after preview focus lost on the pop-up with my files Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Bug description: I'am in Goals and skills. I add file, a new window open with my files, if i click of one of them a preview pop-up open. If a click on the side, this pop close, but the focus was lost on the windows who display my files. The scrolling it's on the main page not on the first open pop-up (list of my files). If you want to reproduice the bug, you should have many files (+ 10) in your bank. I hope to be clear to explain the bug. Thank you - Mahara 18.10 - Windows 10 (web server on linux) - Mysql Database - Google Chrome To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/18.04/+bug/1817326/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1817326] A change has been merged
Reviewed: https://reviews.mahara.org/10114 Committed: https://git.mahara.org/mahara/mahara/commit/594184f10f9c20186944c598f11c0fa3b4b48501 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit 594184f10f9c20186944c598f11c0fa3b4b48501 Author: Robert Lyon Date: Fri Jun 21 11:29:13 2019 +1200 Bug 1817326: Modal in a Modal popup problem When closing the inner modal it removes a class from the tag causing the scrolling to break behatnotneeded Change-Id: I9d132a91cd48500276951c24c0987b418daacb6e Signed-off-by: Robert Lyon (cherry picked from commit 9bd277e5257e498119be95489db4107231e4f13c) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1817326 Title: Goals and skills - add file - after preview focus lost on the pop-up with my files Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Bug description: I'am in Goals and skills. I add file, a new window open with my files, if i click of one of them a preview pop-up open. If a click on the side, this pop close, but the focus was lost on the windows who display my files. The scrolling it's on the main page not on the first open pop-up (list of my files). If you want to reproduice the bug, you should have many files (+ 10) in your bank. I hope to be clear to explain the bug. Thank you - Mahara 18.10 - Windows 10 (web server on linux) - Mysql Database - Google Chrome To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/18.04/+bug/1817326/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1817326] A change has been merged
Reviewed: https://reviews.mahara.org/10112 Committed: https://git.mahara.org/mahara/mahara/commit/9bd277e5257e498119be95489db4107231e4f13c Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 9bd277e5257e498119be95489db4107231e4f13c Author: Robert Lyon Date: Fri Jun 21 11:29:13 2019 +1200 Bug 1817326: Modal in a Modal popup problem When closing the inner modal it removes a class from the tag causing the scrolling to break behatnotneeded Change-Id: I9d132a91cd48500276951c24c0987b418daacb6e Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1817326 Title: Goals and skills - add file - after preview focus lost on the pop-up with my files Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Bug description: I'am in Goals and skills. I add file, a new window open with my files, if i click of one of them a preview pop-up open. If a click on the side, this pop close, but the focus was lost on the windows who display my files. The scrolling it's on the main page not on the first open pop-up (list of my files). If you want to reproduice the bug, you should have many files (+ 10) in your bank. I hope to be clear to explain the bug. Thank you - Mahara 18.10 - Windows 10 (web server on linux) - Mysql Database - Google Chrome To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/18.04/+bug/1817326/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1817326] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/10112 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1817326 Title: Goals and skills - add file - after preview focus lost on the pop-up with my files Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Bug description: I'am in Goals and skills. I add file, a new window open with my files, if i click of one of them a preview pop-up open. If a click on the side, this pop close, but the focus was lost on the windows who display my files. The scrolling it's on the main page not on the first open pop-up (list of my files). If you want to reproduice the bug, you should have many files (+ 10) in your bank. I hope to be clear to explain the bug. Thank you - Mahara 18.10 - Windows 10 (web server on linux) - Mysql Database - Google Chrome To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/18.04/+bug/1817326/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1817326] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10115 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1817326 Title: Goals and skills - add file - after preview focus lost on the pop-up with my files Status in Mahara 18.04 series: Fix Committed Status in Mahara 18.10 series: Fix Committed Bug description: I'am in Goals and skills. I add file, a new window open with my files, if i click of one of them a preview pop-up open. If a click on the side, this pop close, but the focus was lost on the windows who display my files. The scrolling it's on the main page not on the first open pop-up (list of my files). If you want to reproduice the bug, you should have many files (+ 10) in your bank. I hope to be clear to explain the bug. Thank you - Mahara 18.10 - Windows 10 (web server on linux) - Mysql Database - Google Chrome To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/18.04/+bug/1817326/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1833520] [NEW] Calendar widget is not displayed
Public bug reported: Mahara version = 18.04.4 Browser = Firefox and Chrome PHP version = 5.6 Database = MySQL The new calendar widget to select dates and times in Mahara 18.04.4 is not shown in any of the places where it is. However, version 17.10.9 of Mahara is installed on the same server and the calendar widget works correctly. I attach an image (calendar-widget.png) ** Affects: mahara Importance: Undecided Status: New ** Attachment added: "calendar-widget.png" https://bugs.launchpad.net/bugs/1833520/+attachment/5271760/+files/calendar-widget.png ** Attachment removed: "calendar-widget.png" https://bugs.launchpad.net/mahara/+bug/1833520/+attachment/5271760/+files/calendar-widget.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1833520 Title: Calendar widget is not displayed Status in Mahara: New Bug description: Mahara version = 18.04.4 Browser = Firefox and Chrome PHP version = 5.6 Database = MySQL The new calendar widget to select dates and times in Mahara 18.04.4 is not shown in any of the places where it is. However, version 17.10.9 of Mahara is installed on the same server and the calendar widget works correctly. I attach an image (calendar-widget.png) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1833520/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1833520] Re: Calendar widget is not displayed
Sorry, in the previous message I did not attach the correct image. The one that I attach now if that is the correct image ** Attachment added: "calendar-widget.png" https://bugs.launchpad.net/mahara/+bug/1833520/+attachment/5271761/+files/calendar-widget.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1833520 Title: Calendar widget is not displayed Status in Mahara: New Bug description: Mahara version = 18.04.4 Browser = Firefox and Chrome PHP version = 5.6 Database = MySQL The new calendar widget to select dates and times in Mahara 18.04.4 is not shown in any of the places where it is. However, version 17.10.9 of Mahara is installed on the same server and the calendar widget works correctly. I attach an image (calendar-widget.png) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1833520/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1833495] Re: Syncing LDAP usernames with Mahara's internal username leads to incorrect user record matching
** Description changed:
Mahara: 19.04.0
OS: Linux 16.04
DB: Postgres
Browser: FF / Chrome (really n/a)
The LDAP sync_users() functionality is not correctly matching user
records - i.e. LDAP username with Mahara username.
Scenario:
1. Create an institution with and LDAP authentication
- Update user info on login = Yes
- We auto-create users = Yes
- Sync users automatically via cron job = Yes
- Update user info in cron = Yes
- Auto-create users in cron = Yes
- If a user is no longer present in LDAP = Suspend user's account
2. Create an XML-RPC authentication with a Moodle for this institution
- Parent authority = LDAP auth created above
- SSO direction = Yes
- Update user info on login = Yes
- We auto-create users = Yes
- We import content = Yes
* The Moodle instance needs to have LDAP set up as well.
3. Create an internal Mahara user (i.e. not LDAP)
- username: AAA (make sure this username exists in the LDAP directory)
* The username 'AAA' needs to be in Moodle created via LDAP.
4. Login to Moodle with the username AAA - the LDAP user
5. SSO to Mahara
This will do the following
- a new user record is created with username AAA1
- auth_remote_user table will link Mahara user AAA1 to Moodle user AAA
- 6. As Admin, update AAA1's auth metho to LDAP.
+ 6. As Admin, update AAA1's auth method to LDAP.
7. Logout of Mahara and Moodle.
8. Run cron so LDAP syncs users
Expected Results: user AAA1 to remain active in Mahara
Actual Results: user AAA1 is suspended because it matches on username (i.e.
AAA)
That is, this join is correct:
from {usr} u
inner join {auth_ldap_extusers_temp} e on u.username = e.extusername
The username in auth_ldap_extusers_temp is: AAA
The LDAP username in Mahara is: AAA1
Hence, it will not match on username and think the user is no longer in
the LDAP directory and suspend the user.
The join needs to be on another field that is present in both LDAP and
Mahara.
We should also join to the auth_remote_user table to get the correct
external username.
i.e.
select
u.id as id,
aru.remoteusername as username,
u.suspendedreason as suspendedreason,
...
from {usr} u
inner join {auth_remote_user} aru on u.id = aru.localusr
inner join {auth_ldap_extusers_temp} e on aru.remoteusername = e.extusername
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1833495
Title:
Syncing LDAP usernames with Mahara's internal username leads to
incorrect user record matching
Status in Mahara:
New
Bug description:
Mahara: 19.04.0
OS: Linux 16.04
DB: Postgres
Browser: FF / Chrome (really n/a)
The LDAP sync_users() functionality is not correctly matching user
records - i.e. LDAP username with Mahara username.
Scenario:
1. Create an institution with and LDAP authentication
- Update user info on login = Yes
- We auto-create users = Yes
- Sync users automatically via cron job = Yes
- Update user info in cron = Yes
- Auto-create users in cron = Yes
- If a user is no longer present in LDAP = Suspend user's account
2. Create an XML-RPC authentication with a Moodle for this institution
- Parent authority = LDAP auth created above
- SSO direction = Yes
- Update user info on login = Yes
- We auto-create users = Yes
- We import content = Yes
* The Moodle instance needs to have LDAP set up as well.
3. Create an internal Mahara user (i.e. not LDAP)
- username: AAA (make sure this username exists in the LDAP directory)
* The username 'AAA' needs to be in Moodle created via LDAP.
4. Login to Moodle with the username AAA - the LDAP user
5. SSO to Mahara
This will do the following
- a new user record is created with username AAA1
- auth_remote_user table will link Mahara user AAA1 to Moodle user AAA
6. As Admin, update AAA1's auth method to LDAP.
7. Logout of Mahara and Moodle.
8. Run cron so LDAP syncs users
Expected Results: user AAA1 to remain active in Mahara
Actual Results: user AAA1 is suspended because it matches on username (i.e.
AAA)
That is, this join is correct:
from {usr} u
inner join {auth_ldap_extusers_temp} e on u.username = e.extusername
The username in auth_ldap_extusers_temp is: AAA
The LDAP username in Mahara is: AAA1
Hence, it will not match on username and think the user is no longer
in the LDAP directory and suspend the user.
The join needs to be on another field that is present in both LDAP and
Mahara.
We should also join to the auth_remote_user table to get the correct
external username.
i.e.
select
u.id as id,
aru.remoteusername as username,
u.suspendedreason as
[Mahara-contributors] [Bug 1833495] Re: Syncing LDAP usernames with Mahara's internal username leads to incorrect user record matching
** Description changed:
Mahara: 19.04.0
OS: Linux 16.04
DB: Postgres
Browser: FF / Chrome (really n/a)
The LDAP sync_users() functionality is not correctly matching user
records - i.e. LDAP username with Mahara username.
Scenario:
1. Create an institution with and LDAP authentication
- Update user info on login = Yes
- We auto-create users = Yes
- Sync users automatically via cron job = Yes
- Update user info in cron = Yes
- Auto-create users in cron = Yes
- If a user is no longer present in LDAP = Suspend user's account
2. Create an XML-RPC authentication with a Moodle for this institution
- Parent authority = LDAP auth created above
- SSO direction = Yes
- Update user info on login = Yes
- We auto-create users = Yes
- We import content = Yes
* The Moodle instance needs to have LDAP set up as well.
-
3. Create an internal Mahara user (i.e. not LDAP)
- username: AAA (make sure this username exists in the LDAP directory)
-
* The username 'AAA' needs to be in Moodle created via LDAP.
4. Login to Moodle with the username AAA - the LDAP user
5. SSO to Mahara
This will do the following
- a new user record is created with username AAA1
- auth_remote_user table will link Mahara user AAA1 to Moodle user AAA
- 6. Logout of Mahara and Moodle.
+ 6. As Admin, update AAA1's auth metho to LDAP.
- 7. Run cron so LDAP syncs users
+ 7. Logout of Mahara and Moodle.
+
+ 8. Run cron so LDAP syncs users
Expected Results: user AAA1 to remain active in Mahara
Actual Results: user AAA1 is suspended because it matches on username (i.e.
AAA)
That is, this join is correct:
from {usr} u
inner join {auth_ldap_extusers_temp} e on u.username = e.extusername
-
The username in auth_ldap_extusers_temp is: AAA
The LDAP username in Mahara is: AAA1
Hence, it will not match on username and think the user is no longer in
the LDAP directory and suspend the user.
The join needs to be on another field that is present in both LDAP and
Mahara.
We should also join to the auth_remote_user table to get the correct
external username.
i.e.
select
u.id as id,
aru.remoteusername as username,
u.suspendedreason as suspendedreason,
...
from {usr} u
inner join {auth_remote_user} aru on u.id = aru.localusr
inner join {auth_ldap_extusers_temp} e on aru.remoteusername = e.extusername
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1833495
Title:
Syncing LDAP usernames with Mahara's internal username leads to
incorrect user record matching
Status in Mahara:
New
Bug description:
Mahara: 19.04.0
OS: Linux 16.04
DB: Postgres
Browser: FF / Chrome (really n/a)
The LDAP sync_users() functionality is not correctly matching user
records - i.e. LDAP username with Mahara username.
Scenario:
1. Create an institution with and LDAP authentication
- Update user info on login = Yes
- We auto-create users = Yes
- Sync users automatically via cron job = Yes
- Update user info in cron = Yes
- Auto-create users in cron = Yes
- If a user is no longer present in LDAP = Suspend user's account
2. Create an XML-RPC authentication with a Moodle for this institution
- Parent authority = LDAP auth created above
- SSO direction = Yes
- Update user info on login = Yes
- We auto-create users = Yes
- We import content = Yes
* The Moodle instance needs to have LDAP set up as well.
3. Create an internal Mahara user (i.e. not LDAP)
- username: AAA (make sure this username exists in the LDAP directory)
* The username 'AAA' needs to be in Moodle created via LDAP.
4. Login to Moodle with the username AAA - the LDAP user
5. SSO to Mahara
This will do the following
- a new user record is created with username AAA1
- auth_remote_user table will link Mahara user AAA1 to Moodle user AAA
6. As Admin, update AAA1's auth method to LDAP.
7. Logout of Mahara and Moodle.
8. Run cron so LDAP syncs users
Expected Results: user AAA1 to remain active in Mahara
Actual Results: user AAA1 is suspended because it matches on username (i.e.
AAA)
That is, this join is correct:
from {usr} u
inner join {auth_ldap_extusers_temp} e on u.username = e.extusername
The username in auth_ldap_extusers_temp is: AAA
The LDAP username in Mahara is: AAA1
Hence, it will not match on username and think the user is no longer
in the LDAP directory and suspend the user.
The join needs to be on another field that is present in both LDAP and
Mahara.
We should also join to the auth_remote_user table to get the correct
external username.
i.e.
select
u.id as id,
aru.remoteusername as username,
