[Mahara-contributors] [Bug 537492] Re: Group View Creation Error

2010-06-17 Thread Rich Trott
There's nothing in the apache log indicating an error. In the likely event that those database dumps provided above aren't very useful, the answer to your (Richard Mansfield's) question about what if anything is in the view_access* tables for the view in question is: Nothing. For example, I just

[Mahara-contributors] [Bug 537492] Re: Group View Creation Error

2010-06-17 Thread Rich Trott
Not sure if this will be helpful, but I put the whole Pieforms constructor in a try/catch block and printed out the stack trace. Caught exception: /web/mahara/htdocs-1.2.4/lib/activity.php #0 /web/mahara/htdocs-1.2.4/lib/activity.php(74): ActivityTypeViewaccess-__construct(Object(stdClass),

[Mahara-contributors] [Bug 537492] Re: Group View Creation Error

2010-06-18 Thread Rich Trott
Thanks! That patch fixed it! -- Group View Creation Error https://bugs.launchpad.net/bugs/537492 You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Status in Mahara ePortfolio: Confirmed Bug description: Creating a new Group View

[Mahara-contributors] [Bug 537492] Re: Group View Creation Error

2010-06-21 Thread Rich Trott
Thanks again! Although I wasn't directly involved in it, I'm told that the setting the delay to 0 was a bug fix (or at least a workaround) for a problem where duplicate notifications were going out for events. We'll try setting it back to 1 and see what happens... -- Group View Creation Error

[Mahara-contributors] [Bug 638455] [NEW] Japanese string missing in pieforms minlength.php file

2010-09-14 Thread Rich Trott
Public bug reported: Each file under htdocs/lib/pieforms/pieform/rules contains strings for 8 languages except for minlength.php which only contains 7. It appears that the ja.utf8 string is missing. This is on 1.3.0. It may be possible that a minimum character length is not generally useful in

[Mahara-contributors] [Bug 638497] [NEW] en_US entries need to be added to Pieforms

2010-09-14 Thread Rich Trott
Public bug reported: (If I understand it correctly, Nigel's comment in http://wiki.mahara.org/Developer_Area/Language_Packs/Structure says to file a bug in the tracker when new translation strings are ready to be added to Pieforms, so here I am.) Not sure if it's the best way to handle it or

[Mahara-contributors] [Bug 638497] Re: en_US entries need to be added to Pieforms

2010-09-14 Thread Rich Trott
** Patch added: 0003-Add-en_US-strings-to-Pieforms-rules-files.patch https://bugs.launchpad.net/bugs/638497/+attachment/1585732/+files/0003-Add-en_US-strings-to-Pieforms-rules-files.patch -- en_US entries need to be added to Pieforms https://bugs.launchpad.net/bugs/638497 You received this

[Mahara-contributors] [Bug 638497] Re: en_US entries need to be added to Pieforms

2010-09-14 Thread Rich Trott
Oh, uh, this is for Mahara 1.3.0, although I suspect the same patch will work in 1.2.6 as well... -- en_US entries need to be added to Pieforms https://bugs.launchpad.net/bugs/638497 You received this bug notification because you are a member of Mahara Contributors, which is subscribed to

[Mahara-contributors] [Bug 638525] Re: Untranslated Pieforms strings don't fall back to en.utf8

2010-09-14 Thread Rich Trott
Patch attached. Should fix it for rules, elements, and anything else that might get added in the future. ** Patch added: 0004-Make-untranslated-Pieforms-strings-fall-back-to-defa.patch

[Mahara-contributors] [Bug 670546] [NEW] auth saml config form does not work

2010-11-03 Thread Rich Trott
Public bug reported: Trying to use the config form for the auth:saml plugin/extension results in the form submission hanging and this appears in the error log: PHP Fatal error: Cannot use object of type Pieform as array in /web/mahara/htdocs/auth/saml/lib.php on line 461, referer:

[Mahara-contributors] [Bug 684963] [NEW] Reformating in auth_config.host_url.html

2010-12-03 Thread Rich Trott
Public bug reported: Attached patch will remove unbalanced single-quote, add missing period, add italics, use example.com (see RFC 2606 Section 3). ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara

[Mahara-contributors] [Bug 688395] [NEW] /auth/saml doesn't redirect to deep-linked pages

2010-12-09 Thread Rich Trott
Public bug reported: /auth/saml/index.php always redirects to $CFG-wwwroot, even when the original page requested is something else. The attached patch makes it so that it redirects to whatever page sent it to the /auth/saml/index.php in the first place. A couple of notes: 1) I don't grok

[Mahara-contributors] [Bug 688395] Re: /auth/saml doesn't redirect to deep-linked pages

2010-12-09 Thread Rich Trott
** Patch added: 0001-Redirect-to-deep-linked-pages.patch https://bugs.launchpad.net/bugs/688395/+attachment/1761505/+files/0001-Redirect-to-deep-linked-pages.patch -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara.

[Mahara-contributors] [Bug 688395] Re: /auth/saml doesn't redirect to deep-linked pages

2010-12-10 Thread Rich Trott
When I run with your patch, I get: Fatal error: Call to a member function get() on a non-object in /web/mahara/mahara/htdocs/auth/saml/index.php on line 82 $SESSION has not been initialized, so that would seem to be the problem. Previously, I had played around with instantiating the object

[Mahara-contributors] [Bug 688395] Re: /auth/saml doesn't redirect to deep-linked pages

2010-12-10 Thread Rich Trott
I'm attaching a slightly improved patch. Improvements from my first attempt: 1) It uses the Session object rather than the $_SESSION variable. 2) As you (Ruslan) recommended, it clears the wantsurl data out of the Session object. I tried to move the reading of wantsurl (and clearing of the

[Mahara-contributors] [Bug 690427] [NEW] /auth/saml/index.php hardcodes default SP

2010-12-14 Thread Rich Trott
Public bug reported: Here's a patch to allow a typical scenario where users get to select from multiple Service Providers to log in. The service provider specified in the as parameter is passed to simplesamlphp, but otherwise defaults to default-sp, which is what is hardcoded in the current

[Mahara-contributors] [Bug 690427] Re: /auth/saml/index.php hardcodes default SP

2010-12-14 Thread Rich Trott
** Patch added: 0001-Allow-specification-of-service-provider-with-as-in-R.patch https://bugs.launchpad.net/mahara/+bug/690427/+attachment/1766327/+files/0001-Allow-specification-of-service-provider-with-as-in-R.patch -- You received this bug notification because you are a member of Mahara

[Mahara-contributors] [Bug 690427] Re: /auth/saml/index.php hardcodes default SP

2010-12-14 Thread Rich Trott
Whoops...small bug in the patch...it lets you log into whatever you want, but unless you send it an as value in the logout request, it will only log you out of the default SP. Will fix and upload another patch -- You received this bug notification because you are a member of Mahara

[Mahara-contributors] [Bug 690427] Re: /auth/saml/index.php hardcodes default SP

2010-12-15 Thread Rich Trott
Great! Guess I better get to writing that documentation I said I was happy to do -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/690427 Title: /auth/saml/index.php hardcodes default SP

[Mahara-contributors] [Bug 688395] Re: /auth/saml doesn't redirect to deep-linked pages

2010-12-15 Thread Rich Trott
** Changed in: mahara Status: New = Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/688395 Title: /auth/saml doesn't redirect to deep-linked pages Status in Mahara

[Mahara-contributors] [Bug 670546] Re: auth saml config form does not work

2010-12-15 Thread Rich Trott
Uh, yeah, let's try that again, but this time I'll make sure my code uses Unix line-endings before making the patch ** Patch added: 0001-validate_config_options-should-work-with-Pieform-obj.patch

[Mahara-contributors] [Bug 693149] [NEW] English usage consistency (anymore vs. any more)

2010-12-21 Thread Rich Trott
Public bug reported: Per http://mahara.org/interaction/forum/topic.php?id=2607#post11430, two other default language files favour any more but htdocs/artefact/file/blocktype/internalmedia/lang/en.utf8/blocktype.internalmedia.php favors anymore instead. Here's a patch to change that. (I'll

[Mahara-contributors] [Bug 706151] [NEW] Odd capitalization in educationhistory.startdate.html

2011-01-21 Thread Rich Trott
Public bug reported: htdocs/artefact/resume/lang/en.utf8/help/forms/educationhistory.startdate.html capitalizes the first letter of Institute but not organisation. It seems to me that they should both begin with a lowercase letter. Is there a good reason for the initial capital letter for

[Mahara-contributors] [Bug 670546] Re: auth saml config form does not work

2011-01-27 Thread Rich Trott
If it helps at all, here's the patch with the whitespace that shouldn't be there removed. ** Patch added: 0001-validate_config_options-needs-to-handle-Pieform-obje.patch

[Mahara-contributors] [Bug 670546] Re: auth saml config form does not work

2011-01-27 Thread Rich Trott
** Changed in: mahara Status: Confirmed = Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/670546 Title: auth saml config form does not work Status in Mahara ePortfolio:

[Mahara-contributors] [Bug 723324] [NEW] Spelling of 'organisation' inconsistent in install.php

2011-02-22 Thread Rich Trott
Public bug reported: There are two spellings for 'organisation' in install.php. Patch attached. ** Affects: mahara Importance: Undecided Status: New -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara.

[Mahara-contributors] [Bug 723324] Re: Spelling of 'organisation' inconsistent in install.php

2011-02-22 Thread Rich Trott
** Patch added: 0001-Keep-spelling-of-organisation-consistent.patch https://bugs.launchpad.net/bugs/723324/+attachment/1866003/+files/0001-Keep-spelling-of-organisation-consistent.patch -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed

[Mahara-contributors] [Bug 724471] Re: SAML does not fail gracefully when Identity Provider does not provide require attribute

2011-02-24 Thread Rich Trott
** Attachment added: example error log for when this issue occurs https://bugs.launchpad.net/bugs/724471/+attachment/1869303/+files/portfolio_error_log -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara.

[Mahara-contributors] [Bug 724471] Re: SAML does not fail gracefully when Identity Provider does not provide require attribute

2011-02-24 Thread Rich Trott
I always forget to include version information. This is running the 1.3_STABLE branch with the fixes for bugs #670546 and #688395. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/724471 Title:

[Mahara-contributors] [Bug 724492] [NEW] typo in htdocs/lang/en.utf8/install.php?

2011-02-24 Thread Rich Trott
Public bug reported: Is this sentence in install.php missing an article, or is it perfectly acceptable NZ English and I just need to change it in the US English langpack if I don't like it? In order to help protect your personal information, please do not disclose your Username or Password to

[Mahara-contributors] [Bug 724492] Re: typo in htdocs/lang/en.utf8/install.php?

2011-02-24 Thread Rich Trott
This is in the master branch. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/724492 Title: typo in htdocs/lang/en.utf8/install.php? Status in Mahara ePortfolio: New Bug description: Is

[Mahara-contributors] [Bug 725356] [NEW] SAML and Pieforms have different ideas about required checkboxes

2011-02-25 Thread Rich Trott
Public bug reported: Somewhere along the line, Pieforms started throwing an exception for a checkbox has any value set for the required rule. SAML sets that to false, so the institutional config form no longer works. Patch to fix this is attached. This bug is in the current master branch. **

[Mahara-contributors] [Bug 725356] Re: SAML and Pieforms have different ideas about required checkboxes

2011-02-25 Thread Rich Trott
** Patch added: 0001-Pieforms-now-blows-up-if-required-is-set-to-any-valu.patch https://bugs.launchpad.net/bugs/725356/+attachment/1872002/+files/0001-Pieforms-now-blows-up-if-required-is-set-to-any-valu.patch -- You received this bug notification because you are a member of Mahara

[Mahara-contributors] [Bug 787262] [NEW] erroneous timezone offset error message

2011-05-23 Thread Rich Trott
Public bug reported: In the 1.4 RC, htdocs/lib/upgrade.php checks to see that strftime('%z') returns a + followed by four digits. However, the timezone offset can start with a - as well. So, for example, someone running Mahara in the US will be told that their PHP is not returning a useful

[Mahara-contributors] [Bug 803657] [NEW] Stray views instead of pages in pluginconfig.commentratings.html

2011-06-29 Thread Rich Trott
Public bug reported: There is an instance of views in pluginconfig.commentratings.html that should be changed to pages. Patch attached. ** Affects: mahara Importance: Undecided Assignee: Rich Trott (richard-trott) Status: New -- You received this bug notification because

[Mahara-contributors] [Bug 803657] Re: Stray views instead of pages in pluginconfig.commentratings.html

2011-06-29 Thread Rich Trott
** Patch added: 0032-views-pages.patch https://bugs.launchpad.net/bugs/803657/+attachment/2184839/+files/0032-views-pages.patch ** Changed in: mahara Assignee: (unassigned) = Rich Trott (richard-trott) -- You received this bug notification because you are a member of Mahara

[Mahara-contributors] [Bug 803657] Re: Stray views instead of pages in pluginconfig.commentratings.html

2011-06-29 Thread Rich Trott
This is on master and 1.4.0_RELEASE. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/803657 Title: Stray views instead of pages in pluginconfig.commentratings.html Status in Mahara

[Mahara-contributors] [Bug 888255] [NEW] than vs. then confusion in htdocs/blocktype/googleapps/lang/en.utf8/help/forms/instconf.appsid.html

2011-11-09 Thread Rich Trott
Public bug reported: On master, there are a number of instances of than in htdocs/blocktype/googleapps/lang/en.utf8/help/forms/instconf.appsid.html that should be then. ** Affects: mahara Importance: Undecided Status: New ** Tags: bite-sized -- You received this bug

[Mahara-contributors] [Bug 888255] Re: than vs. then confusion in htdocs/blocktype/googleapps/lang/en.utf8/help/forms/instconf.appsid.html

2011-11-09 Thread Rich Trott
/en.utf8/help/forms/instconf.appsid.html ** Changed in: mahara Assignee: (unassigned) = Rich Trott (richard-trott) ** Changed in: mahara Status: New = In Progress ** Changed in: mahara Status: In Progress = Fix Committed ** Changed in: mahara Status: Fix Committed

[Mahara-contributors] [Bug 888255] Re: typos in htdocs/blocktype/googleapps/lang/en.utf8/help/forms/instconf.appsid.html

2011-11-09 Thread Rich Trott
OK, patch uploaded, ready to go, not sure what the next step is, hope someone comes and grabs this -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/888255 Title: typos in

[Mahara-contributors] [Bug 888255] Re: typos in htdocs/blocktype/googleapps/lang/en.utf8/help/forms/instconf.appsid.html

2011-11-09 Thread Rich Trott
** Patch added: signed patch that corrects the typos https://bugs.launchpad.net/mahara/+bug/888255/+attachment/2591233/+files/0001-Bug-888255-typos-in-htdocs-blocktype-googleapps-lang.patch -- You received this bug notification because you are a member of Mahara Contributors, which is

[Mahara-contributors] [Bug 888255] Re: typos in htdocs/blocktype/googleapps/lang/en.utf8/help/forms/instconf.appsid.html

2011-11-09 Thread Rich Trott
OK, it's in Gerrit! -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/888255 Title: typos in htdocs/blocktype/googleapps/lang/en.utf8/help/forms/instconf.appsid.html Status in Mahara

[Mahara-contributors] [Bug 923854] [NEW] SAML can disallow login if email is absent

2012-01-30 Thread Rich Trott
Public bug reported: This is more of a feature request than a bug, perhaps. If the SAML auth plugin is set to update data, a user with an existing account but no email in SAML will be denied access. It would be nice if the plugin just ignored the absent email on account updates, or at least if

[Mahara-contributors] [Bug 923854] Re: SAML can disallow login if email is absent

2012-01-30 Thread Rich Trott
** Changed in: mahara Assignee: (unassigned) = Rich Trott (richard-trott) ** Changed in: mahara Status: New = In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/923854

[Mahara-contributors] [Bug 923854] Re: SAML can disallow login if email is absent

2012-01-30 Thread Rich Trott
Patch submitted at https://reviews.mahara.org/#change,1017 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/923854 Title: SAML can disallow login if email is absent Status in Mahara

[Mahara-contributors] [Bug 1052062] [NEW] Invalid short tag on site logo link in header

2012-09-17 Thread Rich Trott
Public bug reported: Mahara 1.6 generates this code out of `htdocs/theme/raw/templates/header/head.tpl` and/or `htdocs/theme/default/templates/header/head.tpl`: link rel=image_src href={$sitelogo} / Since the DOCTYPE specified HTML 4.01, this is technically invalid. It should either not