Public bug reported:
auth/xmlrpc fails in xmlenc_envelope() for PHP 8.0 with the error:
Could not generate public key resource from certificate
This is because the return value for `openssl_get_publickey` is an
instance of `OpenSSLAsymmetricKey` from PHP 8.0 onwards.
** Affects: mahara
Cheers Luke,
That patch looks good to me.
Just to confirm, this is to work around issues where you wish to use a
function which is defined outside of the pieforms structure and where
the function has already been defined. Therefore it is not necessary (or
appropriate) to include the file from
** Changed in: mahara
Status: In Progress = Fix Committed
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/891170
Title:
race conditions in cron
Status in Mahara ePortfolio:
Fix
Public bug reported:
Following bug #891170:
Write relevant unit tests for cron_lock, and cron_free if possile
This may not be possible without a reshuffle of lib/cron.php
At present, the actual logic is not in a function so including the file
to test the functions will lead to the cron system
Public bug reported:
Thanks to tim hunt at the OU for pointing the first issue out:
It's possible for cron_lock to fail to get the $started value if the row has
been deleted between attempting to insert the record, and attempting to
retrieve the start date
Public bug reported:
We dont' need to produce releases including our unit tests. We need to
modify the release scripts to remove the unit tests
** Affects: mahara
Importance: High
Assignee: Andrew Nicols (dobedobedoh)
Status: New
** Tags: release tests
** Changed in: mahara
** Changed in: mahara
Milestone: None = 1.5.0
** Changed in: mahara
Assignee: (unassigned) = Andrew Nicols (dobedobedoh)
** Changed in: mahara
Status: New = Triaged
** Changed in: mahara
Status: Triaged = In Progress
** Changed in: mahara
Importance: Undecided = Low
Hi Melissa,
Can you please summarise the effects of these changes and why they're
required?
Thanks,
Andrew
** Changed in: mahara
Milestone: None = 1.5.0
** Changed in: mahara
Status: New = Triaged
** Changed in: mahara
Importance: Undecided = Low
--
You received this bug
Hi Melissa,
I've added a milestone of 1.5.0 for this. Is there a specific bug fix
which affects you?
Also, there's no need to attach the upstream zip - we'll download it and
verify hashes when we work on the bug.
Andrew
** Changed in: mahara
Milestone: None = 1.5.0
** Changed in: mahara
Public bug reported:
At present the CLI framework grabs $argv wholesale and works through it
testing whole words.
Typically, the short form of an option has always allowed a slightly different
form. Whilst the long option might be
--foo=bar
The short option should support:
-f bar
Updated to catch a missing case. Awaiting review
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/824445
Title:
Missing Plugins Should be disabled automatically
Status in Mahara ePortfolio:
** Changed in: mahara
Status: In Progress = Fix Committed
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/844607
Title:
Create CLI Framework/Libraries
Status in Mahara ePortfolio:
Fix committed, but found a minor bug in upgrade code. New patch
submitted in https://reviews.mahara.org/692
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/844604
Title:
Create CLI
I've pushed a fix for part of the MySQL stuff - it turns out that you
can't simply reverse the order of indexes and keys, as the names will
get changed. You have to build the names, then order (the names are
cached).
https://reviews.mahara.org/693
Haven't worked out why tearDown is being called
https://reviews.mahara.org/687
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/844607
Title:
Create CLI Framework/Libraries
Status in Mahara ePortfolio:
In Progress
Bug description:
https://reviews.mahara.org/688
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/844604
Title:
Create CLI installer/upgrader
Status in Mahara ePortfolio:
In Progress
Bug description:
As
=yes
--upgrade-only -p=letmein -e=f...@example.org)
* add a log_exit or equivelant which would exit with the appropriate exit code
(0 = success, 127 = error, other supplied ints in range) and exit - e.g.
cli_exit().
** Affects: mahara
Importance: Wishlist
Assignee: Andrew Nicols
I've been pondering whether the log_exit should go with the other error
functions (e.g. log_debug) in lib/errors.php.
We currently have no log_die, and I doubt we want one except for CLI stuff
(correct me if I'm wrong). Setting the exit code is very CLI specific.
Therefore I've been toying with
Public bug reported:
As discussed in the unit testing documentation, it would be pretty handy
to have a CLI installer and upgrader
** Affects: mahara
Importance: Wishlist
Assignee: Andrew Nicols (dobedobedoh)
Status: In Progress
** Tags: install upgrade
** Changed
Ideally should be implemented with CLI libraries - see bug #844607
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/844604
Title:
Create CLI installer/upgrader
Status in Mahara ePortfolio:
I'd like a milestone of 1.5.0 to aid us in our unit testing desires...
** Changed in: mahara
Milestone: None = 1.5.0
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/844604
Title:
Create
This bug also requires inclusion of:
Bug #841708
Bug #841694
Bug #841723
Bug #841711
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/819396
Title:
Add unit testing to Mahara
Status in Mahara
Submitted for review.
The actual framework is in https://reviews.mahara.org/#change,647
Some sample tests are in https://reviews.mahara.org/#change,648
Francois: No problem with doing this what-so-ever having thought about
it more.
** Changed in: mahara
Status: Confirmed = In Progress
--
Public bug reported:
Add support to uninstall tables from xmldb
This is part of the work to provide unit testing
** Affects: mahara
Importance: Wishlist
Assignee: Andrew Nicols (dobedobedoh)
Status: In Progress
** Tags: db phpunit xmldb
** Changed in: mahara
Status
Public bug reported:
When a page is created, if a title is given in the $viewdata it should
be honoured.
** Affects: mahara
Importance: Wishlist
Assignee: Andrew Nicols (dobedobedoh)
Status: In Progress
** Tags: creation page phpunit view
** Changed in: mahara
Status
This is required for some of the phpunit tests
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/841708
Title:
Allow page title specification at page creation
Status in Mahara ePortfolio:
In
Submitted Penny's patch for this (with minor alternations):
https://reviews.mahara.org/#change,638
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/841694
Title:
Add uninstall_from_xmldb_file
) can
probably ignore this change and use stock adodb
** Affects: mahara
Importance: Wishlist
Assignee: Andrew Nicols (dobedobedoh)
Status: In Progress
** Tags: adodb db phpunit
** Changed in: mahara
Status: New = In Progress
** Changed in: mahara
Importance
Submitted penny's change for this with changes - added to
adodb/README.mahara and removed debugging echos
https://reviews.mahara.org/640
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/841711
Submitted Penny's change for this with minor changes:
https://reviews.mahara.org/#change,639
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/841708
Title:
Allow page title specification at
enough and you end up with collisions.
Changing to use microtime fixes these issues and allows for unit tests
to be run
** Affects: mahara
Importance: Wishlist
Assignee: Andrew Nicols (dobedobedoh)
Status: In Progress
** Tags: accuracy deletion phpunit user
** Changed
Commited supplied by Penny: https://reviews.mahara.org/641
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/841723
Title:
Use microtime instead of float for user deletion
Status in Mahara
AFAIK it's not possible to change the 300x300 default..? Or do you mean
on a block level.
I've updated the patch to reflect a better limit.
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Public bug reported:
If a plugin has been installed, but then goes away (e.g. it is moved or
the user wants to uninstall it by removing the plugin directory), this
can cause various frustrations and site issues (unrecoverable error)
which prevent all users from using any plugin.
We should
: mahara
Importance: Wishlist
Assignee: Andrew Nicols (dobedobedoh)
Status: In Progress
** Tags: artefact file internalmedia size video
** Changed in: mahara
Importance: Undecided = Wishlist
** Changed in: mahara
Status: New = In Progress
** Changed in: mahara
Submitted for review in change 579
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/824519
Title:
Make default video size of internalmedia configurable
Status in Mahara ePortfolio:
In
** Changed in: mahara
Status: New = In Progress
** Changed in: mahara
Importance: Undecided = Wishlist
** Changed in: mahara
Assignee: (unassigned) = Andrew Nicols (dobedobedoh)
--
You received this bug notification because you are a member of Mahara
Contributors, which
Fix committed in Change 578 - awaiting review
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/824445
Title:
Missing Plugins Should be disabled automatically
Status in Mahara ePortfolio:
In
I'm putting the target to 1.4.1 for the moment as it is a bug which
makes life harder for users of other languages
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/824638
Title:
Date of Birth
that this should go in to 1.5 to allow us to test the various new
features which are planned more thoroughly.
** Affects: mahara
Importance: Wishlist
Assignee: Andrew Nicols (dobedobedoh)
Status: New
** Tags: core infrastructure phpunit test unit
** Changed in: mahara
As I say, I've updated the original branch. I'm awaiting some feedback
on how best to integrate Penny's commits (e.g. squash commits) using
gerrit.
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Public bug reported:
htdocs/auth/session.php has a TEMPORARY: this will be REMOVED... which has
been in there for four years and since 0.7.0
It's not a major issue, and it serves the job of ensuring that the session
directories exist, but this should be done at install time, and should have
Public bug reported:
It would be beneficial to protect ourselves from somehow adding a virus
to the repo. I know it's less likely now we have peer review with
gerrit, but it could still be possible to accept some form of infected
image etc.
** Affects: mahara
Importance: Undecided
I'd prefer to see this in every supported release
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/818045
Title:
Check repo for viruses to pass minaccept
Status in Mahara ePortfolio:
New
Commit added to gerrit
** Changed in: mahara
Importance: Undecided = Wishlist
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/818045
Title:
Check repo for viruses to pass minaccept
Public bug reported:
It would be really helpful if it were possible to set the post delay for
a forum at either the whole group level, or the individual forum level.
This is particularly useful for forums such as the Support forum on
mahara.org where timely responses to people's queries would
Public bug reported:
Similar to bug #817372 it would be helpful if it were possible to send a
forum post immediately, rather than waiting for the post delay. This is
probably much harder to display to users in a meaningful fashion
though...
** Affects: mahara
Importance: Wishlist
Public bug reported:
Some of the fields in admin/site/options.php don't have the disabled =
in_array('foo', $OVERRIDDEN) option set
Have patch, will submit
Affects 1.4.x and master
** Affects: mahara
Importance: Low
Assignee: Andrew Nicols (dobedobedoh)
Status: In Progress
Submitted fix in https://reviews.mahara.org/#change,420
** Changed in: mahara
Status: New = In Progress
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/803955
Title:
Overridden site
Submitted fix in https://reviews.mahara.org/#change,421
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/803962
Title:
Some overridden fields are not disabled in admin/site/options.php
Status
This increases the amount of fields held in the $OVERRIDDEN. I don't
think that this is a major problem as only the field name is stored in
the array, not the field value.
This doesn't handle plugin setting overrides, but none of the plugins
handle this at present anyway.
--
You received this
Public bug reported:
It'd be great if we could link to the new blog post page from the block
type in a page (for the owner user)
** Affects: mahara
Importance: Wishlist
Status: New
** Tags: bitesize blog blogpost journal
--
You received this bug notification because you are a
Hmm. Might be worth checking whether the plugin enables itself when
users are upgrading. Since it's now a core plugin it should be enabled
IMO, unlike new plugins just placed in the relevant directory.
** Summary changed:
- Googledocs blocktype don't show
+ Googledocs blocktype not enabled after
p.s. Haven't confirmed this yet but didn't want to forget about it -
will try and check tomorrow and verify.
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/785703
Title:
Googledocs blocktype
Now pushed :)
I opted for the get_class($e) option rather than catching the exception
to reduce code duplication.
** Changed in: mahara
Assignee: (unassigned) = Andrew Nicols (dobedobedoh)
** Changed in: mahara
Status: New = Fix Committed
--
You received this bug notification
Public bug reported:
A change introduced by 4ce12125c10984b946f4061e517521cbb6322389 meant
that if email_user threw an exception, the admin was sent an e-mail. If
an admin user has email disabled, then mahara gets stuck in an email
loop trying to send them e-mail informing them of the failure.
The infrastructure for this is already in place. Mahara uses the
Variable Envelope Return Path (VERP) technique for it's bounced e-mail
catcher which validates a bounced mail and increases a bounce-count for
that user, eventually disabling e-mail for this user.
It should be possible to add a case
I'm going to push this with a tidy up - removing the catching of the
EmailDisabledException in forgotpass and removing the language string
relating to this. Probably get around to finishing it this afternoon.
I don't think that it makes sense to make this a configuration option,
but I wonder
I've pushed a fix which warns a user if the recipient address is over
the bounce threshold but attempts to send the e-mail even if e-mail has
been disabled.
** Changed in: mahara
Status: New = In Progress
** Changed in: mahara
Assignee: (unassigned) = Andrew Nicols (dobedobedoh
Hmmm. All e-mail is handled by the email_user function in lib/user.php.
If e-mail is disabled, an exception is thrown (EmailDisabledException).
There's only one check for disabled e-mail so it would be relatively
easy to bypass this check.
The question is how best to do so. We could add a
Ahh. Rather than adding another parameter, we could add a variable to
$user (after it's selected from the database) such that:
forgotpass.php-forgotpass_submit we set
$user-ignoredisabled = true;
after $user is pulled from the database and before it's passed to email_user
In email_user we modify
.
** Changed in: mahara
Status: New = Fix Committed
** Changed in: mahara
Assignee: (unassigned) = Andrew Nicols (dobedobedoh)
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/685642
Public bug reported:
Came across this whilst looking at #685633 but thought that it deserved a
separate bug.
If a cron function causes an exception for whatever reason, then the cron will
stop, but the lock isn't removed. The job then isn't tried again for another 24
hours.
Whilst this is
Public bug reported:
This affects postgres, and may affect MySQL too. Although this is
currently the intended behaviour of lib/cron.php-cron_lock(), and the
SQLException is caught in the php, the error is still seen by the
database and logged in the database server's logs.
Although it's not
** Patch added: 0001-Check-whether-record-exists-before-inserting-rather.patch
https://bugs.launchpad.net/mahara/+bug/685642/+attachment/1756688/+files/0001-Check-whether-record-exists-before-inserting-rather.patch
--
You received this bug notification because you are a member of Mahara
Pushed 388eb21753ad14bcf4c6a742677f3dab097adb52
** Changed in: mahara
Status: In Progress = Fix Committed
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/684963
Title:
Reformating in
Have removed trailing whitespace from patch and added bug ID to commit
message.
** Changed in: mahara
Assignee: (unassigned) = Andrew Nicols (dobedobedoh)
** Changed in: mahara
Importance: Undecided = Low
** Changed in: mahara
Status: New = In Progress
--
You received this bug
** Changed in: mahara
Status: New = Confirmed
** Changed in: mahara
Assignee: (unassigned) = Andrew Nicols (dobedobedoh)
** Changed in: mahara
Status: Confirmed = Fix Committed
--
Admin user unable to login after installation - salt issue
https://bugs.launchpad.net/bugs
Hi Richard,
Cheers - that sheds a bit of light on things! I've pushed my fix to
master.
Andrew
--
Admin user unable to login after installation - salt issue
https://bugs.launchpad.net/bugs/676461
You received this bug notification because you are a member of Mahara
Contributors, which is
Hi,
Can you please ensure that have installed the php openssl module installed.
You've included a snippet from your apache configuration which suggests you
have apache's mod_ssl, but this is *not* the same as the php openssl module.
phpinfo will give you details as to which PHP modules are
Public bug reported:
According to the note for %e on
http://uk3.php.net/manual/en/function.strftime.php windows doesn't support the
%e format.
There's a cross-platform 'fix' for this which involves determining whether
you're running windows and substr ing any %e to a %#d.
I've not confirmed
Richard, when I tried to use the file upload, I was expecting it to
behave in exactly the same way as other uploads - e.g. javascript upload
without having to submit the form for the file to be uploaded. On deeper
inspection, it appears that the file upload on the comments input areas
don't even
: mahara
Importance: Low
Assignee: Andrew Nicols (dobedobedoh)
Status: Fix Committed
** Tags: creation language password user
** Changed in: mahara
Status: New = Fix Committed
--
Invalid password on CSV Upload gives a rubbish error message
https://bugs.launchpad.net/bugs
I went for the combination approach
--
Invalid password on CSV Upload gives a rubbish error message
https://bugs.launchpad.net/bugs/654589
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Status in Mahara ePortfolio: Fix
Hi Eugene,
Here are the steps I took:
* Create a new post in admin's blog with a picture uploaded and displayed
inline in the blog;
* Add the 'Recent Blog Posts' (or any other Blog blocktype I should imagine)
into the user's Profile View
* Login as a new user
* View admin's profile
* View the
** Attachment added: image_description.png
https://bugs.launchpad.net/bugs/652784/+attachment/1661860/+files/image_description.png
--
Inserting a file with no description using tinymce gives default description of
'null'
https://bugs.launchpad.net/bugs/652784
You received this bug
Public bug reported:
Bug reproduced using master
Steps to reproduce:
* Login as a user
* My Portfolio - My Blog - New Post
* Add a new file using the attachments section
* Using TinyMCE, Insert/Edit Image
* Select the image from the 'Attached image' section
* Description is set to 'null'
I was wondering whether we could do some kind of COWing, but now that
you mention it, exporting views should be sufficient for most purposes.
--
Locking a view should lock all artefacts
https://bugs.launchpad.net/bugs/644169
You received this bug notification because you are a member of Mahara
I've not got a Windows VM running with php at present to fully verify or
test patches against, but I see how this could well be the case.
_get_path is used by both get_path and get_url.
I believe php under windows will correctly handle use of forward slashes (/) in
a path so this shouldn't cause
Public bug reported:
On fresh install on master using linux:
Viewing a blog as a view artefact doesn't get comment counts correctly.
Steps to reproduce:
* Create blog post with comments enabled.
* Add recent blog posts to profile view
* Create second user.
* View first user.
* View the blog as
Would be handy to also have a tinymce button to embed videos within a
blog too...
--
Embedded video not shown in blog editor
https://bugs.launchpad.net/bugs/623671
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Status in Mahara
Public bug reported:
Came across this at the same time as bug #643645.
If you view a blog using view/artefact.php, which has downloads (or
specifically images) included in it's posts then the appropriate permissions
are not set and trying to view the files gives a 403.
** Affects: mahara
Public bug reported:
On fresh install on master using linux:
Viewing a blog as a view artefact doesn't get comment counts correctly.
Steps to reproduce:
* Create blog post with comments enabled.
* Add recent blog posts to profile view
* Create second user.
* View first user.
* View the blog as
Public bug reported:
The TinyMCE insert image dialogue differs on Blog Post to other
locations (e.g. place feedback). IMO this is a usability bug as users
will expect it to be the same everywhere (I did!).
Since feedback can include uploaded files, I'd favour use of the same
image dialogue as
84 matches
Mail list logo
