** Changed in: mahara
Assignee: (unassigned) = Melissa Draper (melissa)
** Changed in: mahara
Status: Confirmed = In Progress
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/692784
** Changed in: mahara
Status: In Progress = Fix Committed
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/692784
Title:
Reporting objectionable content link should ask for confirmation
Patch refers to the page as view which is a recent change as per bug
771152 and will hence need re-rolling.
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/692784
Title:
Reporting
fixed and attached patch.
** Patch added:
0001-objectional-content-should-ask-for-confirmation-Bug-.patch
https://bugs.launchpad.net/mahara/+bug/692784/+attachment/1856569/+files/0001-objectional-content-should-ask-for-confirmation-Bug-.patch
--
You received this bug notification because
I have added a popup confirm dialogue before the submission of this. It was a
small modification of the javascript used to create the form.
Should I try to avoid javascript at all costs instead and for future
modifications?
for example, should I convert this popup into a yes no form like on
It would be better to be consistent with other similar areas in Mahara.
Also, we're hoping that someday Mahara will gracefully degrade but still
be usable when Javascript is turned off. So if you can easily do
something without Javascript, that's probably a good idea.
--
You received this bug
the simple fix for this is here
http://www.gitorious.org/~ioniser/mahara/ionisers-mahara/commits/lp692784-objectional-content-link-should-confirm
I will also start an experimental branch to try out replacing all
confirm forms with one customisable one. This will include a richer
jquery confirm
7 matches
Mail list logo