[Mahara-contributors] [Bug 1831689] Re: Datepicker doesnt work with different date formats
** Changed in: mahara/19.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1831689 Title: Datepicker doesnt work with different date formats Status in Mahara: Fix Released Status in Mahara 19.04 series: Fix Released Status in Mahara 19.10 series: Fix Released Bug description: When a different date format (other than the Mahara default /MM/DD HH:mm), the datepicker doesnt work. Steps to reproduce: 1. Update lang/en.utf8/langconfig.php with the following: $string['pieform_calendar_dateformat'] = '%%d/%%m/%%Y'; $string['pieform_calendar_timeformat'] = '%%l:%%M %%p'; 2. Clear site cache 3. In the Shared by Me, set 'Allow comments' = Yes 4. Enter a page to share with a group with an end date selected from outside of the current month. 5. Save and re-enter the page. Expected result: Clicking on the 'to' field opens the datepicker Actual result: the datepicker doesnt open and error messages are displayed in the console. Steps I've tried to fix: -Hard coding the new date format (DD/MM/ h:mm A) into theme/raw/templates/form/viewacl.tpl:164 -Adding new code to the library as per https://github.com/tempusdominus/bootstrap-4/issues/193#issuecomment-465649868 -Removing the local from theme/raw/templates/form/viewacl.tpl:165 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1831689/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1831689] Re: Datepicker doesnt work with different date formats
** Changed in: mahara/19.04 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1831689 Title: Datepicker doesnt work with different date formats Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Released Status in Mahara 19.10 series: Fix Committed Bug description: When a different date format (other than the Mahara default /MM/DD HH:mm), the datepicker doesnt work. Steps to reproduce: 1. Update lang/en.utf8/langconfig.php with the following: $string['pieform_calendar_dateformat'] = '%%d/%%m/%%Y'; $string['pieform_calendar_timeformat'] = '%%l:%%M %%p'; 2. Clear site cache 3. In the Shared by Me, set 'Allow comments' = Yes 4. Enter a page to share with a group with an end date selected from outside of the current month. 5. Save and re-enter the page. Expected result: Clicking on the 'to' field opens the datepicker Actual result: the datepicker doesnt open and error messages are displayed in the console. Steps I've tried to fix: -Hard coding the new date format (DD/MM/ h:mm A) into theme/raw/templates/form/viewacl.tpl:164 -Adding new code to the library as per https://github.com/tempusdominus/bootstrap-4/issues/193#issuecomment-465649868 -Removing the local from theme/raw/templates/form/viewacl.tpl:165 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1831689/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1831689] Re: Datepicker doesnt work with different date formats
** Changed in: mahara/19.04 Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1831689 Title: Datepicker doesnt work with different date formats Status in Mahara: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Bug description: When a different date format (other than the Mahara default /MM/DD HH:mm), the datepicker doesnt work. Steps to reproduce: 1. Update lang/en.utf8/langconfig.php with the following: $string['pieform_calendar_dateformat'] = '%%d/%%m/%%Y'; $string['pieform_calendar_timeformat'] = '%%l:%%M %%p'; 2. Clear site cache 3. In the Shared by Me, set 'Allow comments' = Yes 4. Enter a page to share with a group with an end date selected from outside of the current month. 5. Save and re-enter the page. Expected result: Clicking on the 'to' field opens the datepicker Actual result: the datepicker doesnt open and error messages are displayed in the console. Steps I've tried to fix: -Hard coding the new date format (DD/MM/ h:mm A) into theme/raw/templates/form/viewacl.tpl:164 -Adding new code to the library as per https://github.com/tempusdominus/bootstrap-4/issues/193#issuecomment-465649868 -Removing the local from theme/raw/templates/form/viewacl.tpl:165 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1831689/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1831689] Re: Datepicker doesnt work with different date formats
** Changed in: mahara/19.10 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1831689 Title: Datepicker doesnt work with different date formats Status in Mahara: Fix Committed Status in Mahara 19.04 series: Confirmed Status in Mahara 19.10 series: Fix Committed Bug description: When a different date format (other than the Mahara default /MM/DD HH:mm), the datepicker doesnt work. Steps to reproduce: 1. Update lang/en.utf8/langconfig.php with the following: $string['pieform_calendar_dateformat'] = '%%d/%%m/%%Y'; $string['pieform_calendar_timeformat'] = '%%l:%%M %%p'; 2. Clear site cache 3. In the Shared by Me, set 'Allow comments' = Yes 4. Enter a page to share with a group with an end date selected from outside of the current month. 5. Save and re-enter the page. Expected result: Clicking on the 'to' field opens the datepicker Actual result: the datepicker doesnt open and error messages are displayed in the console. Steps I've tried to fix: -Hard coding the new date format (DD/MM/ h:mm A) into theme/raw/templates/form/viewacl.tpl:164 -Adding new code to the library as per https://github.com/tempusdominus/bootstrap-4/issues/193#issuecomment-465649868 -Removing the local from theme/raw/templates/form/viewacl.tpl:165 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1831689/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1831689] Re: Datepicker doesnt work with different date formats
** Changed in: mahara Status: Confirmed => In Progress ** Also affects: mahara/19.04 Importance: Undecided Status: New ** Also affects: mahara/19.10 Importance: High Status: In Progress ** Changed in: mahara/19.04 Status: New => Confirmed ** Changed in: mahara/19.04 Importance: Undecided => High ** Changed in: mahara/19.10 Milestone: None => 19.10.0 ** Changed in: mahara/19.04 Milestone: None => 19.04.1 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1831689 Title: Datepicker doesnt work with different date formats Status in Mahara: In Progress Status in Mahara 19.04 series: Confirmed Status in Mahara 19.10 series: In Progress Bug description: When a different date format (other than the Mahara default /MM/DD HH:mm), the datepicker doesnt work. Steps to reproduce: 1. Update lang/en.utf8/langconfig.php with the following: $string['pieform_calendar_dateformat'] = '%%d/%%m/%%Y'; $string['pieform_calendar_timeformat'] = '%%l:%%M %%p'; 2. Clear site cache 3. In the Shared by Me, set 'Allow comments' = Yes 4. Enter a page to share with a group with an end date selected from outside of the current month. 5. Save and re-enter the page. Expected result: Clicking on the 'to' field opens the datepicker Actual result: the datepicker doesnt open and error messages are displayed in the console. Steps I've tried to fix: -Hard coding the new date format (DD/MM/ h:mm A) into theme/raw/templates/form/viewacl.tpl:164 -Adding new code to the library as per https://github.com/tempusdominus/bootstrap-4/issues/193#issuecomment-465649868 -Removing the local from theme/raw/templates/form/viewacl.tpl:165 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1831689/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1831689] Re: Datepicker doesnt work with different date formats
I've added a patch that seems to sort our problem - there is still a warning when first initializing the datepicker for the first time with a set date - as it calls getMoment() before it checks format and so complains about the date being of bad format - but once it initialises with this._initFormatting() fully the date format is set correctly -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1831689 Title: Datepicker doesnt work with different date formats Status in Mahara: Confirmed Bug description: When a different date format (other than the Mahara default /MM/DD HH:mm), the datepicker doesnt work. Steps to reproduce: 1. Update lang/en.utf8/langconfig.php with the following: $string['pieform_calendar_dateformat'] = '%%d/%%m/%%Y'; $string['pieform_calendar_timeformat'] = '%%l:%%M %%p'; 2. Clear site cache 3. In the Shared by Me, set 'Allow comments' = Yes 4. Enter a page to share with a group with an end date selected from outside of the current month. 5. Save and re-enter the page. Expected result: Clicking on the 'to' field opens the datepicker Actual result: the datepicker doesnt open and error messages are displayed in the console. Steps I've tried to fix: -Hard coding the new date format (DD/MM/ h:mm A) into theme/raw/templates/form/viewacl.tpl:164 -Adding new code to the library as per https://github.com/tempusdominus/bootstrap-4/issues/193#issuecomment-465649868 -Removing the local from theme/raw/templates/form/viewacl.tpl:165 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1831689/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1831689] Re: Datepicker doesnt work with different date formats
Strange - I try replicating the steps above on master in Firefox / Chrome and I have no problem saving / editing the date in the new format if the date is non-ambiguous Eg if the date I enter / edit is 27/09/2019 07:36 AM then all works fine but if I enter and save 04/09/2019 07:36 AM then try to edit it fails I believe this is because 04/09/2019 can mean both 04 Sept 2019 and April 09 2019 so things break as we are being unclear -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1831689 Title: Datepicker doesnt work with different date formats Status in Mahara: Confirmed Bug description: When a different date format (other than the Mahara default /MM/DD HH:mm), the datepicker doesnt work. Steps to reproduce: 1. Update lang/en.utf8/langconfig.php with the following: $string['pieform_calendar_dateformat'] = '%%d/%%m/%%Y'; $string['pieform_calendar_timeformat'] = '%%l:%%M %%p'; 2. Clear site cache 3. In the Shared by Me, set 'Allow comments' = Yes 4. Enter a page to share with a group with an end date selected from outside of the current month. 5. Save and re-enter the page. Expected result: Clicking on the 'to' field opens the datepicker Actual result: the datepicker doesnt open and error messages are displayed in the console. Steps I've tried to fix: -Hard coding the new date format (DD/MM/ h:mm A) into theme/raw/templates/form/viewacl.tpl:164 -Adding new code to the library as per https://github.com/tempusdominus/bootstrap-4/issues/193#issuecomment-465649868 -Removing the local from theme/raw/templates/form/viewacl.tpl:165 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1831689/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1831689] Re: Datepicker doesnt work with different date formats
** Description changed: When a different date format (other than the Mahara default /MM/DD HH:mm), the datepicker doesnt work. Steps to reproduce: 1. Update lang/en.utf8/langconfig.php with the following: $string['pieform_calendar_dateformat'] = '%%d/%%m/%%Y'; $string['pieform_calendar_timeformat'] = '%%l:%%M %%p'; 2. Clear site cache - 3. In the Shared by Me, set 'Allow comments' = No + 3. In the Shared by Me, set 'Allow comments' = Yes 4. Enter a page to share with a group with an end date selected from outside of the current month. 5. Save and re-enter the page. Expected result: Clicking on the 'to' field opens the datepicker Actual result: the datepicker doesnt open and error messages are displayed in the console. Steps I've tried to fix: -Hard coding the new date format (DD/MM/ h:mm A) into theme/raw/templates/form/viewacl.tpl:164 -Adding new code to the library as per https://github.com/tempusdominus/bootstrap-4/issues/193#issuecomment-465649868 -Removing the local from theme/raw/templates/form/viewacl.tpl:165 ** Changed in: mahara Importance: Undecided => High -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1831689 Title: Datepicker doesnt work with different date formats Status in Mahara: Confirmed Bug description: When a different date format (other than the Mahara default /MM/DD HH:mm), the datepicker doesnt work. Steps to reproduce: 1. Update lang/en.utf8/langconfig.php with the following: $string['pieform_calendar_dateformat'] = '%%d/%%m/%%Y'; $string['pieform_calendar_timeformat'] = '%%l:%%M %%p'; 2. Clear site cache 3. In the Shared by Me, set 'Allow comments' = Yes 4. Enter a page to share with a group with an end date selected from outside of the current month. 5. Save and re-enter the page. Expected result: Clicking on the 'to' field opens the datepicker Actual result: the datepicker doesnt open and error messages are displayed in the console. Steps I've tried to fix: -Hard coding the new date format (DD/MM/ h:mm A) into theme/raw/templates/form/viewacl.tpl:164 -Adding new code to the library as per https://github.com/tempusdominus/bootstrap-4/issues/193#issuecomment-465649868 -Removing the local from theme/raw/templates/form/viewacl.tpl:165 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1831689/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
