[Mahara-contributors] [Bug 618509] Re: XMLRPC link to hosts with underscores in hostname fails

2010-09-09 Thread Richard Mansfield
** Changed in: mahara Milestone: 1.3.0 => None -- XMLRPC link to hosts with underscores in hostname fails https://bugs.launchpad.net/bugs/618509 You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Status in Mahara ePortfolio: Inv

[Mahara-contributors] [Bug 618509] Re: XMLRPC link to hosts with underscores in hostname fails

2010-09-05 Thread Nathan Mares
Good stuff. Will save someone many hours of searching! -- XMLRPC link to hosts with underscores in hostname fails https://bugs.launchpad.net/bugs/618509 You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Status in Mahara ePortfolio

[Mahara-contributors] [Bug 618509] Re: XMLRPC link to hosts with underscores in hostname fails

2010-09-03 Thread Andrew Robert Nicols
I've added a potential fix based on HEAD to my clone of mahara which will give a more informative error message if trying to use an invalid hostname at: http://gitorious.org/~dobedobedoh/mahara/luns-mahara-upstream-submissions/commits/618509 Any thoughts? -- XMLRPC link to hosts with underscore

[Mahara-contributors] [Bug 618509] Re: XMLRPC link to hosts with underscores in hostname fails

2010-09-03 Thread Andrew Robert Nicols
I suspect that the reason you're getting an unknown error is that, in 1.2.5, we were only catching RemoteServerExceptions in auth/xmlrpc/lib.php:PluginAuthXmlrpc->validate_config_options(). In Mahara 1.3+ we also catch ParamOutOfRangeException and you would actually get the correct error message

[Mahara-contributors] [Bug 618509] Re: XMLRPC link to hosts with underscores in hostname fails

2010-09-03 Thread Nathan Mares
Hi Andrew, Yes - the line "throw new ParamOutOfRangeException('Could not find IP address for host: '.addslashes($hostname));" in bootstrap(..) is being thrown. The hostname I used was something like moodle_19.xxx.corp, get_hostname_from_uri() returns "moodle", gethostbyname() returns the same "mo

[Mahara-contributors] [Bug 618509] Re: XMLRPC link to hosts with underscores in hostname fails

2010-09-03 Thread Andrew Robert Nicols
Hi Nathan, I've tried to replicate this issue but am having trouble in doing so. I've tried both on HEAD and 1.2.5_RELEASE in case this bug had already been fixed elsewhere. I've tried connecting from moodle_badhostname.local to mahara.local with no issue When I tried setting up networking fro

[Mahara-contributors] [Bug 618509] Re: XMLRPC link to hosts with underscores in hostname fails

2010-09-03 Thread Andrew Robert Nicols
I think that we should uphold the standard. If we start making exceptions to the odd standard here, it'll turn into the thin end of the wedge. I'll set up a Moodle VM on an invalid hostname and see what error messages I'm getting and how they can be improved. -- XMLRPC link to hosts with undersc

[Mahara-contributors] [Bug 618509] Re: XMLRPC link to hosts with underscores in hostname fails

2010-09-01 Thread Nathan Mares
Hi Andrew, Ok - agreed the standards don't permit underscores. Some DNS and HTTP implementations do permit these but (even if incorrectly) so it becomes somewhat philosophical, is it best to uphold the standard or do you attempt to cater for the various implementations? If just the standard then a

[Mahara-contributors] [Bug 618509] Re: XMLRPC link to hosts with underscores in hostname fails

2010-09-01 Thread Andrew Robert Nicols
Hi Nathan, I've just been having a closer look at this bug. I can confirm that, as you suggest, get_hostname_from_uri() in api/xmlrpc/lib.php does not accept underscores in hostnames. However, I also believe that it is correct in no accepting these. Section 3.2.2 of RFC 2396[1] describes the form

[Mahara-contributors] [Bug 618509] Re: XMLRPC link to hosts with underscores in hostname fails

2010-08-15 Thread Richard Mansfield
** Changed in: mahara Status: New => Triaged ** Changed in: mahara Importance: Undecided => Medium ** Changed in: mahara Milestone: None => 1.3.0 -- XMLRPC link to hosts with underscores in hostname fails https://bugs.launchpad.net/bugs/618509 You received this bug notification be