[Mahara-contributors] [Bug 731990] Re: Forum post editing timeout issue

2011-06-13 Thread François Marier
** Changed in: mahara Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/731990 Title: Forum post editing timeout issue Status in Mahara ePortfolio:

[Mahara-contributors] [Bug 731990] Re: Forum post editing timeout issue

2011-03-28 Thread Ruslan Kabalin
** Changed in: mahara Status: Confirmed = Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/731990 Title: Forum post editing timeout issue Status in Mahara ePortfolio:

[Mahara-contributors] [Bug 731990] Re: Forum post editing timeout issue

2011-03-15 Thread François Marier
I guess I was wondering whether I had missed anything in terms of defining the problem we are trying to solve (as opposed to describing a possible solution). Cheers, Francois -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara.

[Mahara-contributors] [Bug 731990] Re: Forum post editing timeout issue

2011-03-14 Thread Ruslan Kabalin
For the case when email notification workflow is not changed, there is nothing else I can think about. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/731990 Title: Forum post editing timeout

[Mahara-contributors] [Bug 731990] Re: Forum post editing timeout issue

2011-03-13 Thread François Marier
You latest idea does sound like it would work. The one thing that worries me however, is that it would increase the complexity of sending forum emails quite a bit and might lead to bugs that are much harder to find/fix. Going back to the problem we are trying to solve: the mismatch between a

[Mahara-contributors] [Bug 731990] Re: Forum post editing timeout issue

2011-03-11 Thread Ruslan Kabalin
what's to prevent me from changing my session and editing the post hours after it has been sent out via email It will not let you to start editing if more than 30 minutes has passed from the time when you opened edit window. But, I agree, email sending has not been considered. I had another

[Mahara-contributors] [Bug 731990] Re: Forum post editing timeout issue

2011-03-10 Thread Ruslan Kabalin
As a possible solution, the edit time could be stored in the session when editing is initiated and substituted instead of $post-ctime on the edit submission. This will allow to submit the last post edit within postdelay value (e.g. 30 mins) since edit button was clicked. The patch below implements

[Mahara-contributors] [Bug 731990] Re: Forum post editing timeout issue

2011-03-10 Thread François Marier
Maybe I'm missing something here, but by essentially moving the check from the server to the client (i.e. in the session) then what's to prevent me from changing my session and editing the post hours after it has been sent out via email? Or more simply clicking the edit link, leaving the browser

[Mahara-contributors] [Bug 731990] Re: Forum post editing timeout issue

2011-03-09 Thread François Marier
That's indeed a very annoying behaviour. However, the solution sounds a bit complicated (and error prone). We'd need to have a new timeout (how long somehow has to edit a post) and keep track of when editing was started. A few scenarios to consider: - user clicks edit and submits the edited