[Mahara-contributors] [Bug 1626281] A change has been merged
Reviewed: https://reviews.mahara.org/7008
Committed:
https://git.mahara.org/mahara/mahara/commit/b91f4f67594e22f2007eb64cacbeee475a482584
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.10_STABLE
commit b91f4f67594e22f2007eb64cacbeee475a482584
Author: Robert Lyon
Date: Thu Sep 22 09:16:20 2016 +1200
Bug 1626281: Pass the 'section' for js lang strings for better
debugging.
@TODO: Allow the js lang strings be picked based on on the section
supplied so that name/section make them unique rather than just name
behatnotneeded - existing test will be sufficient
Change-Id: Ie64725702527b7fd9a08749816ea1fd084e95a2d
Signed-off-by: Robert Lyon
(cherry picked from commit 75316569320985ece0d5df5d6840e7fda3762a45)
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1626281
Title:
Allow the js lang strings to have their section set when doing
variable replacement
Status in Mahara:
Fix Committed
Bug description:
Currently when we have a js string, say string.nrrows='%s rows' and we
call it with get_string('nrrows', 4) - but we should call it with
get_string('nrrows', 'view', 4) to indicate that this string is from
the 'view' lang file.
I'll make the change so that the 'section' can be passed in as well so
that in the future we can decide which section's lang string to use
rather than currently having them be all unique.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1626281/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1626281] A change has been merged
Reviewed: https://reviews.mahara.org/6995
Committed:
https://git.mahara.org/mahara/mahara/commit/75316569320985ece0d5df5d6840e7fda3762a45
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master
commit 75316569320985ece0d5df5d6840e7fda3762a45
Author: Robert Lyon
Date: Thu Sep 22 09:16:20 2016 +1200
Bug 1626281: Pass the 'section' for js lang strings for better
debugging.
@TODO: Allow the js lang strings be picked based on on the section
supplied so that name/section make them unique rather than just name
behatnotneeded - existing test will be sufficient
Change-Id: Ie64725702527b7fd9a08749816ea1fd084e95a2d
Signed-off-by: Robert Lyon
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1626281
Title:
Allow the js lang strings to have their section set when doing
variable replacement
Status in Mahara:
Fix Committed
Bug description:
Currently when we have a js string, say string.nrrows='%s rows' and we
call it with get_string('nrrows', 4) - but we should call it with
get_string('nrrows', 'view', 4) to indicate that this string is from
the 'view' lang file.
I'll make the change so that the 'section' can be passed in as well so
that in the future we can decide which section's lang string to use
rather than currently having them be all unique.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1626281/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
