[Mahara-contributors] [Bug 1822911] Re: User icons not appearing circular in some themes due to proportions of image uploaded
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1822911 Title: User icons not appearing circular in some themes due to proportions of image uploaded Status in Mahara: Fix Released Bug description: When a user uploads a profile picture and the image is not a square, in a theme like Modern where it adds border-radius to it to try and make it circular, it ends up like an oval instead due to the proportion of the image. Need to remove the border-radius on the image and put it on the wrapper instead where possible, and hide overflow. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1822911/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1822911] Re: User icons not appearing circular in some themes due to proportions of image uploaded
** Changed in: mahara Milestone: 19.04rc1 => 19.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1822911 Title: User icons not appearing circular in some themes due to proportions of image uploaded Status in Mahara: Fix Committed Bug description: When a user uploads a profile picture and the image is not a square, in a theme like Modern where it adds border-radius to it to try and make it circular, it ends up like an oval instead due to the proportion of the image. Need to remove the border-radius on the image and put it on the wrapper instead where possible, and hide overflow. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1822911/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1822911] Re: User icons not appearing circular in some themes due to proportions of image uploaded
Fix amended to include those that have failed QA. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1822911 Title: User icons not appearing circular in some themes due to proportions of image uploaded Status in Mahara: Fix Committed Bug description: When a user uploads a profile picture and the image is not a square, in a theme like Modern where it adds border-radius to it to try and make it circular, it ends up like an oval instead due to the proportion of the image. Need to remove the border-radius on the image and put it on the wrapper instead where possible, and hide overflow. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1822911/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1822911] Re: User icons not appearing circular in some themes due to proportions of image uploaded
** Attachment added: "Onlineusers page display issue_08-04-19-13:18:40.png" https://bugs.launchpad.net/mahara/+bug/1822911/+attachment/5253850/+files/Onlineusers%20page%20display%20issue_08-04-19-13%3A18%3A40.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1822911 Title: User icons not appearing circular in some themes due to proportions of image uploaded Status in Mahara: Fix Committed Bug description: When a user uploads a profile picture and the image is not a square, in a theme like Modern where it adds border-radius to it to try and make it circular, it ends up like an oval instead due to the proportion of the image. Need to remove the border-radius on the image and put it on the wrapper instead where possible, and hide overflow. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1822911/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1822911] Re: User icons not appearing circular in some themes due to proportions of image uploaded
** Attachment added: "searching for recipeints to message _08-04-19-13:27:34.png" https://bugs.launchpad.net/mahara/+bug/1822911/+attachment/5253848/+files/searching%20for%20recipeints%20to%20message%20_08-04-19-13%3A27%3A34.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1822911 Title: User icons not appearing circular in some themes due to proportions of image uploaded Status in Mahara: Fix Committed Bug description: When a user uploads a profile picture and the image is not a square, in a theme like Modern where it adds border-radius to it to try and make it circular, it ends up like an oval instead due to the proportion of the image. Need to remove the border-radius on the image and put it on the wrapper instead where possible, and hide overflow. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1822911/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1822911] Re: User icons not appearing circular in some themes due to proportions of image uploaded
Commit hash: 9ec3afbf05cf8454e1dd852775ad9fc8f03a403d Environment tested: Master Browser tested: Chrome PRECONDITIONS: 1) Mahara users exists - min 5 users (no roles) all users have profile pictures that are not square 2) Rectangular image (900x500px) uploaded for a user profile image 3) The site theme is set to Modern or Primary school 4) Group exists with forum and forum topic 5) forum post to topic exists 6) Portfilio page exists that has Modern theme 7) Comments exsit for a portfolio page TEST STEPS: 1) Log in as a Mahara user 2) Verify the following pages will display circular profile image icons: a) People page /user/index.php ✔ b) User portfolio page with theme set to Ocean or Primary school theme (This functionality must be enabled - site optins - user settings) ✔ c) Group member's page /group/members.php?id=9 ✔ d) Profile pictures page /artefact/file/profileicons.php ✘ e) Admin - User search page /admin/users/search.php ✔ f) Search results page /user/index.php?filter=all=User12 ✔ g) Show all online users page /user/online.php & online users side block (dashboard page) ✔ Found bug - Online users page display error ✘ h) Forum topic post /interaction/forum/topic.php?id=1 ✔ i) Inbox Compose page - Recipients field /module/multirecipientnotification/sendmessage.php search for a recipient ✘ j) Sharing a profile page with users - (search field)edit access page /view/accessurl.php?id=27 ✘ k) Portfolio page comments ✔ Catalyst QA Failed Testing ✘ -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1822911 Title: User icons not appearing circular in some themes due to proportions of image uploaded Status in Mahara: Fix Committed Bug description: When a user uploads a profile picture and the image is not a square, in a theme like Modern where it adds border-radius to it to try and make it circular, it ends up like an oval instead due to the proportion of the image. Need to remove the border-radius on the image and put it on the wrapper instead where possible, and hide overflow. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1822911/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1822911] Re: User icons not appearing circular in some themes due to proportions of image uploaded
** Attachment added: "searching for recipeints to share page _08-04-19-13:27:34.png" https://bugs.launchpad.net/mahara/+bug/1822911/+attachment/5253849/+files/searching%20for%20recipeints%20to%20share%20page%20_08-04-19-13%3A27%3A34.png -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1822911 Title: User icons not appearing circular in some themes due to proportions of image uploaded Status in Mahara: Fix Committed Bug description: When a user uploads a profile picture and the image is not a square, in a theme like Modern where it adds border-radius to it to try and make it circular, it ends up like an oval instead due to the proportion of the image. Need to remove the border-radius on the image and put it on the wrapper instead where possible, and hide overflow. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1822911/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1822911] Re: User icons not appearing circular in some themes due to proportions of image uploaded
To test, load a profile image that is not a square, so either tall or wide. https://reviews.mahara.org/#/c/9713/ ** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1822911 Title: User icons not appearing circular in some themes due to proportions of image uploaded Status in Mahara: Fix Committed Bug description: When a user uploads a profile picture and the image is not a square, in a theme like Modern where it adds border-radius to it to try and make it circular, it ends up like an oval instead due to the proportion of the image. Need to remove the border-radius on the image and put it on the wrapper instead where possible, and hide overflow. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1822911/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1822911] Re: User icons not appearing circular in some themes due to proportions of image uploaded
** Changed in: mahara Status: New => In Progress ** Changed in: mahara Importance: Undecided => Medium ** Changed in: mahara Milestone: None => 19.04rc1 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1822911 Title: User icons not appearing circular in some themes due to proportions of image uploaded Status in Mahara: In Progress Bug description: When a user uploads a profile picture and the image is not a square, in a theme like Modern where it adds border-radius to it to try and make it circular, it ends up like an oval instead due to the proportion of the image. Need to remove the border-radius on the image and put it on the wrapper instead where possible, and hide overflow. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1822911/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
