[Mahara-contributors] [Bug 503598] Re: reply to messages from deleted users lead to access denied page
** Changed in: mahara Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/503598 Title: reply to messages from deleted users lead to access denied page Status in Mahara ePortfolio: Fix Released Bug description: Username: crimson I received this email from a spam message: You have been sent a notification from Mahara ePortfolio System. Message follows: Subject: New message from nancy wilson nancy wilson has sent you a message. To view this message, visit http://mahara.org/user/sendmessage.php?id=6530replyto=879010 ... The issue is that link doesn't work - it gives me access denied: Access Denied You do not have access to view this page You cannot send this user a message Also, navigating to http://mahara.org/account/activity/ then clicking on New message from nancy wilson then More...' (same link as above) gives the same issue. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/503598/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 503598] Re: reply to messages from deleted users lead to access denied page
** Changed in: mahara Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/503598 Title: reply to messages from deleted users lead to access denied page Status in Mahara ePortfolio: Fix Committed Bug description: Username: crimson I received this email from a spam message: You have been sent a notification from Mahara ePortfolio System. Message follows: Subject: New message from nancy wilson nancy wilson has sent you a message. To view this message, visit http://mahara.org/user/sendmessage.php?id=6530replyto=879010 ... The issue is that link doesn't work - it gives me access denied: Access Denied You do not have access to view this page You cannot send this user a message Also, navigating to http://mahara.org/account/activity/ then clicking on New message from nancy wilson then More...' (same link as above) gives the same issue. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/503598/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 503598] Re: reply to messages from deleted users lead to access denied page
** Changed in: mahara Milestone: None = 1.5.0 ** Changed in: mahara Status: Confirmed = In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/503598 Title: reply to messages from deleted users lead to access denied page Status in Mahara ePortfolio: In Progress Bug description: Username: crimson I received this email from a spam message: You have been sent a notification from Mahara ePortfolio System. Message follows: Subject: New message from nancy wilson nancy wilson has sent you a message. To view this message, visit http://mahara.org/user/sendmessage.php?id=6530replyto=879010 ... The issue is that link doesn't work - it gives me access denied: Access Denied You do not have access to view this page You cannot send this user a message Also, navigating to http://mahara.org/account/activity/ then clicking on New message from nancy wilson then More...' (same link as above) gives the same issue. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/503598/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 503598] Re: reply to messages from deleted users lead to access denied page
https://reviews.mahara.org/866 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/503598 Title: reply to messages from deleted users lead to access denied page Status in Mahara ePortfolio: Confirmed Bug description: Username: crimson I received this email from a spam message: You have been sent a notification from Mahara ePortfolio System. Message follows: Subject: New message from nancy wilson nancy wilson has sent you a message. To view this message, visit http://mahara.org/user/sendmessage.php?id=6530replyto=879010 ... The issue is that link doesn't work - it gives me access denied: Access Denied You do not have access to view this page You cannot send this user a message Also, navigating to http://mahara.org/account/activity/ then clicking on New message from nancy wilson then More...' (same link as above) gives the same issue. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/503598/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 503598] Re: reply to messages from deleted users lead to access denied page
Sean, That patch isn't quite right. If you look at where the string 'cantmessageuser' is used, you'll see that the same string gets displayed when you can't send a message to a user for any reason. The user might still exist, but may have set their message preference on the settings page to turn all messages off or to only allow messages from friends. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/503598 Title: reply to messages from deleted users lead to access denied page Status in Mahara ePortfolio: Confirmed Bug description: Username: crimson I received this email from a spam message: You have been sent a notification from Mahara ePortfolio System. Message follows: Subject: New message from nancy wilson nancy wilson has sent you a message. To view this message, visit http://mahara.org/user/sendmessage.php?id=6530replyto=879010 ... The issue is that link doesn't work - it gives me access denied: Access Denied You do not have access to view this page You cannot send this user a message Also, navigating to http://mahara.org/account/activity/ then clicking on New message from nancy wilson then More...' (same link as above) gives the same issue. ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 503598] Re: reply to messages from deleted users lead to access denied page
revised commit http://www.gitorious.org/~ioniser/mahara/ionisers-mahara/commits/lp503598-deleted-users-to-access-denied_revised -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/503598 Title: reply to messages from deleted users lead to access denied page Status in Mahara ePortfolio: Confirmed Bug description: Username: crimson I received this email from a spam message: You have been sent a notification from Mahara ePortfolio System. Message follows: Subject: New message from nancy wilson nancy wilson has sent you a message. To view this message, visit http://mahara.org/user/sendmessage.php?id=6530replyto=879010 ... The issue is that link doesn't work - it gives me access denied: Access Denied You do not have access to view this page You cannot send this user a message Also, navigating to http://mahara.org/account/activity/ then clicking on New message from nancy wilson then More...' (same link as above) gives the same issue. ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 503598] Re: reply to messages from deleted users lead to access denied page
Sean, much better! You should throw a UserNotFoundException rather than access denied in the case where the user doesn't exist, and just say the user was not found, or maybe the user doesn't exist, rather than doesn't exist *anymore*, because we don't really know whether they ever existed. Though if you really wanted to make that distinction, you could check the deleted column. Also in the other case, you've added they have requested to not recieve emails, but I don't think we shouldn't say 'email' there because we also don't know whether their notification preference is email or internal, you just can't send them a message at all. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/503598 Title: reply to messages from deleted users lead to access denied page Status in Mahara ePortfolio: Confirmed Bug description: Username: crimson I received this email from a spam message: You have been sent a notification from Mahara ePortfolio System. Message follows: Subject: New message from nancy wilson nancy wilson has sent you a message. To view this message, visit http://mahara.org/user/sendmessage.php?id=6530replyto=879010 ... The issue is that link doesn't work - it gives me access denied: Access Denied You do not have access to view this page You cannot send this user a message Also, navigating to http://mahara.org/account/activity/ then clicking on New message from nancy wilson then More...' (same link as above) gives the same issue. ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
Re: [Mahara-contributors] [Bug 503598] Re: reply to messages from deleted users lead to access denied page
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Suspended users can still receive messages. so the message will simply be. You cannot access this message because the user account does not exist anymore. On 02/02/11 19:01, Kristina Hoeppner wrote: Agreed as well. I think a special error message like below would be good: You cannot access this message because the user was either suspended or the user account does not exist anymore. - -- Regards, Sean Brennan s...@catalyst.net.nz Cell:0274729712 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJNScLYAAoJEBacL8dH3zIGjJEP/RUfby+ciGUXkxATYpBSkJRa 87/6yIP36j5JBrTB3uJB4w2GkgargJ0seWvwgWjh7a5bL02tpHkIfiSrmlJKFNbS WRpxsNXCv9zR+nLN25dcEfATHo2WmnK2s2FBZord8Q1DYpryj10BBAc+lPMwCtsJ utaQEZboBKI5moadKpqLXl6rK7pLSSibKN+UHnXa1p4x9yV5lQMAxWZmOfOuGXwh DEkyjXwBG247AgUzvh2C94l0d1cu1qS2jAlUt1M6mqK4PBddILi3LBVKoHj3rgEP ue96C0dqI5c7u8P9TJwaoeDUdm61E/j9c1ScRkBGkt92WdoI5ajTgRsxN037E16K THjf2OSUWew+S4WzeEk5h5TqoyeOUI820Jxsv3l0ayNIfgfD7Bbb3aRFfHubksLK XtmGurhDYff4ecP7v4+uiZj9zbGsVWEYiaEupXDSsEEAN+FLkki/q92SL3oHGMNY xM0ZPa5GVs8Kxd9jeb9G6XZJuys3Ih10WBVJOx0FJGZrTEUAEP4c63Zd6VzcftNh ODCmvrk/DwGFqV5oTTk2wi6pcPvEizZdE3igcy06cAoGIIXWMQHERjdrtm6FQPfP 3R1SCpwFciAB9d6iq69SjRnWJDBhU+J+KRCXdH3LEGJvHCf7aGdLKg5j1RmpAfBW YiFMAvXRHddtDG41mog/ =Fbl3 -END PGP SIGNATURE- -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/503598 Title: reply to messages from deleted users lead to access denied page Status in Mahara ePortfolio: Confirmed Bug description: Username: crimson I received this email from a spam message: You have been sent a notification from Mahara ePortfolio System. Message follows: Subject: New message from nancy wilson nancy wilson has sent you a message. To view this message, visit http://mahara.org/user/sendmessage.php?id=6530replyto=879010 ... The issue is that link doesn't work - it gives me access denied: Access Denied You do not have access to view this page You cannot send this user a message Also, navigating to http://mahara.org/account/activity/ then clicking on New message from nancy wilson then More...' (same link as above) gives the same issue. ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 503598] Re: reply to messages from deleted users lead to access denied page
fix committed on http://www.gitorious.org/~ioniser/mahara/ionisers-mahara/commits/lp503598-deleted-users-to-access-denied sorry about the spam email before. Ill strip out all the mess next time. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/503598 Title: reply to messages from deleted users lead to access denied page Status in Mahara ePortfolio: Confirmed Bug description: Username: crimson I received this email from a spam message: You have been sent a notification from Mahara ePortfolio System. Message follows: Subject: New message from nancy wilson nancy wilson has sent you a message. To view this message, visit http://mahara.org/user/sendmessage.php?id=6530replyto=879010 ... The issue is that link doesn't work - it gives me access denied: Access Denied You do not have access to view this page You cannot send this user a message Also, navigating to http://mahara.org/account/activity/ then clicking on New message from nancy wilson then More...' (same link as above) gives the same issue. ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 503598] Re: reply to messages from deleted users lead to access denied page
I think that if a user deletes their account they probably don't want any messages regardless. If an admin has deleted their account, there could be many reasons. but I still don't think the user deserves to receive messages through mahara. I think a simple rewording of the error message to justify this would be sufficient. Opinions? -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/503598 Title: reply to messages from deleted users lead to access denied page Status in Mahara ePortfolio: Confirmed Bug description: Username: crimson I received this email from a spam message: You have been sent a notification from Mahara ePortfolio System. Message follows: Subject: New message from nancy wilson nancy wilson has sent you a message. To view this message, visit http://mahara.org/user/sendmessage.php?id=6530replyto=879010 ... The issue is that link doesn't work - it gives me access denied: Access Denied You do not have access to view this page You cannot send this user a message Also, navigating to http://mahara.org/account/activity/ then clicking on New message from nancy wilson then More...' (same link as above) gives the same issue. ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 503598] Re: reply to messages from deleted users lead to access denied page
Agreed as well. I think a special error message like below would be good: You cannot access this message because the user was either suspended or the user account does not exist anymore. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/503598 Title: reply to messages from deleted users lead to access denied page Status in Mahara ePortfolio: Confirmed Bug description: Username: crimson I received this email from a spam message: You have been sent a notification from Mahara ePortfolio System. Message follows: Subject: New message from nancy wilson nancy wilson has sent you a message. To view this message, visit http://mahara.org/user/sendmessage.php?id=6530replyto=879010 ... The issue is that link doesn't work - it gives me access denied: Access Denied You do not have access to view this page You cannot send this user a message Also, navigating to http://mahara.org/account/activity/ then clicking on New message from nancy wilson then More...' (same link as above) gives the same issue. ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
