Abhilash Raj pushed to branch master at GNU Mailman / Mailman Core
Commits:
3ed5a44b by Abhilash Raj at 2018-04-29T23:43:48Z
remove mime_is_default_digest legacy attribute
- - - - -
4587ccd2 by Abhilash Raj at 2018-04-29T23:43:48Z
Merge branch 'warsaw/mailman-issue235' into 'master'
remove mime_is_default_digest legacy attribute
See merge request mailman/mailman!374
- - - - -
3 changed files:
- +
src/mailman/database/alembic/versions/89913992dd5a_remove_mime_is_default_digest.py
- src/mailman/model/mailinglist.py
- src/mailman/styles/base.py
Changes:
=====================================
src/mailman/database/alembic/versions/89913992dd5a_remove_mime_is_default_digest.py
=====================================
--- /dev/null
+++
b/src/mailman/database/alembic/versions/89913992dd5a_remove_mime_is_default_digest.py
@@ -0,0 +1,32 @@
+"""remove mime_is_default_digest
+
+Revision ID: 89913992dd5a
+Revises: 448a93984c35
+Create Date: 2016-10-31 09:21:24.941438
+
+"""
+
+import sqlalchemy as sa
+
+from alembic import op
+from mailman.database.helpers import exists_in_db, is_sqlite
+
+
+# revision identifiers, used by Alembic.
+revision = '89913992dd5a'
+down_revision = 'dfe82cf73702'
+
+
+def upgrade():
+ if not is_sqlite(op.get_bind()):
+ # SQLite does not support dropping columns.
+ op.drop_column( # pragma: nocover
+ 'mailinglist', 'mime_is_default_digest') # pragma: nocover
+
+
+def downgrade():
+ if not exists_in_db(
+ op.get_bind(), 'mailinglist', 'mime_is_default_digest'):
+ op.add_column(
+ 'mailinglist',
+ sa.Column('mime_is_default_digest', sa.BOOLEAN(), nullable=True))
=====================================
src/mailman/model/mailinglist.py
=====================================
--- a/src/mailman/model/mailinglist.py
+++ b/src/mailman/model/mailinglist.py
@@ -155,7 +155,6 @@ class MailingList(Model):
max_message_size = Column(Integer)
max_num_recipients = Column(Integer)
member_moderation_notice = Column(SAUnicode)
- mime_is_default_digest = Column(Boolean)
# FIXME: There should be no moderator_password
moderator_password = Column(LargeBinary) # TODO : was RawStr()
newsgroup_moderation = Column(Enum(NewsgroupModeration))
=====================================
src/mailman/styles/base.py
=====================================
--- a/src/mailman/styles/base.py
+++ b/src/mailman/styles/base.py
@@ -80,7 +80,6 @@ class BasicOperation:
# Digests.
mlist.digests_enabled = True
mlist.digest_is_default = False
- mlist.mime_is_default_digest = False
mlist.digest_size_threshold = 30 # KB
mlist.digest_send_periodic = True
mlist.digest_volume_frequency = DigestFrequency.monthly
View it on GitLab:
https://gitlab.com/mailman/mailman/compare/edf5564ca85c10fdf843df3b5a3ac1fb8b67c0bd...4587ccd2859eccd8715ec43a3cb6ac2f27506ddd
---
View it on GitLab:
https://gitlab.com/mailman/mailman/compare/edf5564ca85c10fdf843df3b5a3ac1fb8b67c0bd...4587ccd2859eccd8715ec43a3cb6ac2f27506ddd
You're receiving this email because of your account on gitlab.com.
_______________________________________________
Mailman-checkins mailing list
Mailman-checkins@python.org
Unsubscribe:
https://mail.python.org/mailman/options/mailman-checkins/archive%40jab.org
