Mark Sapiro pushed to branch master at GNU Mailman / Mailman Core
Commits:
59d8b47c by Mark Sapiro at 2019-06-23T01:52:23Z
Removed the last remnants of the mailing list attribute nntp_host.
- - - - -
f3b2e4a5 by Mark Sapiro at 2019-06-23T01:52:23Z
Merge branch 'fix_611' into 'master'
Removed the last remnants of the mailing list attribute nntp_host.
Closes #611
See merge request mailman/mailman!529
- - - - -
5 changed files:
- src/mailman/core/tests/test_pipelines.py
- src/mailman/docs/NEWS.rst
- src/mailman/handlers/docs/nntp.rst
- src/mailman/handlers/to_usenet.py
- src/mailman/styles/base.py
Changes:
=====================================
src/mailman/core/tests/test_pipelines.py
=====================================
@@ -180,7 +180,6 @@ testing
# Set up NNTP.
self._mlist.gateway_to_news = True
self._mlist.linked_newsgroup = 'testing'
- self._mlist.nntp_host = 'news.example.com'
# Process the email.
process(self._mlist, self._msg, {},
pipeline_name='default-posting-pipeline')
=====================================
src/mailman/docs/NEWS.rst
=====================================
@@ -70,6 +70,8 @@ Other
* REST Runner now uses Gunicorn to run WSGI server instead of the standard
library wsgiref for better performance.
* Add support for SMPTS/STARTTLS for connections to MTA. (See !508)
+* The last remnants of the mailing list attribute ``nntp_host`` have been
+ removed. (Closes #611)
3.2.2
=====
=====================================
src/mailman/handlers/docs/nntp.rst
=====================================
@@ -44,12 +44,11 @@ Neither are digests ever gated to the newsgroup.
[]
However, other posted messages get gated to the newsgroup via the nntp queue.
-The list owner can set the linked newsgroup and the nntp host that its
-messages are gated to.
+The list owner can set the linked newsgroup. The nntp host that messages are
+gated to is a global configuration.
::
>>> mlist.linked_newsgroup = 'comp.lang.thing'
- >>> mlist.nntp_host = 'news.example.com'
>>> handler.process(mlist, msg, {})
>>> messages = get_queue_messages('nntp')
>>> len(messages)
=====================================
src/mailman/handlers/to_usenet.py
=====================================
@@ -50,8 +50,6 @@ class ToUsenet:
error = []
if not mlist.linked_newsgroup:
error.append('no newsgroup')
- if not mlist.nntp_host:
- error.append('no NNTP host')
if error:
log.error('NNTP gateway improperly configured: %s',
COMMASPACE.join(error))
=====================================
src/mailman/styles/base.py
=====================================
@@ -92,7 +92,6 @@ class BasicOperation:
mlist.dmarc_moderation_notice = ''
mlist.dmarc_wrapped_message_text = ''
# NNTP gateway
- mlist.nntp_host = ''
mlist.linked_newsgroup = ''
mlist.gateway_to_news = False
mlist.gateway_to_mail = False
View it on GitLab:
https://gitlab.com/mailman/mailman/compare/8f88a7c05b0424977820593c06cdeeb7aa238ce7...f3b2e4a536e0fe01db5e586af018232677e40e64
--
View it on GitLab:
https://gitlab.com/mailman/mailman/compare/8f88a7c05b0424977820593c06cdeeb7aa238ce7...f3b2e4a536e0fe01db5e586af018232677e40e64
You're receiving this email because of your account on gitlab.com.
_______________________________________________
Mailman-checkins mailing list
Mailman-checkins@python.org
Unsubscribe:
https://mail.python.org/mailman/options/mailman-checkins/archive%40jab.org
