Re: [Merge] lp:~ralfjung-e/mailman/csrf-injective into lp:mailman/2.1

2018-06-03 Thread Jim Popovitch via Mailman-coders
A couple thoughts: 1) The original code in listinfo.py uses 'now' twice in the token. I wonder if that's necessary. 2) Should use something besides a colon as colons are part of IPv6 addresses? -- https://code.launchpad.net/~ralfjung-e/mailman/csrf-injective/+merge/347340 Your team Mailman

[Bug 1779774] Re: The BLOCK_SPAMHAUS_LISTED_DBL_SUBSCRIBE feature doesn't work.

2018-07-02 Thread Jim Popovitch via Mailman-coders
Opps! That's quite an embarrassing error given the whole discussions around ZEN and PBL, etc. :-) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1779774 Title: The BLOCK_SPAMHAUS_LISTED_DBL_

[Bug 1783417] Re: The fix for https://bugs.launchpad.net/mailman/+bug/1780874 breaks admin and listinfo overview pages

2018-07-24 Thread Jim Popovitch via Mailman-coders
Breaks those pages in what way? -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1783417 Title: The fix for https://bugs.launchpad.net/mailman/+bug/1780874 breaks admin and listinfo overview

[Bug 1783417] Re: The fix for https://bugs.launchpad.net/mailman/+bug/1780874 breaks admin and listinfo overview pages

2018-07-24 Thread Jim Popovitch via Mailman-coders
Ahh, thank you clarifying. I have redirects to specific lists, so I never saw that. It doesn't get said enough, Thank you Mark for your excellent dedication and support. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https:/

[Bug 557995] Re: Edit held message header/body

2019-01-31 Thread Jim Popovitch via Mailman-coders
I feel like there should be something between comment #4 and comment #5 other than time. :-) -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/557995 Title: Edit held message header/body To ma

Re: [Merge] lp:~ralfjung-e/mailman/2.1 into lp:mailman/2.1

2019-06-10 Thread Jim Popovitch via Mailman-coders
I like this solution, it's simple and easily customizable, doesn't rely on 3rd-party integrations, and the CAPTCHA questions can be easily updated. Nice work Ralf. One thing that I would like to see in the future is storing the CAPTCHAs in pck or even sql, etc. -- https://code.launchpad.ne

Re: [Merge] lp:~ralfjung-e/mailman/2.1 into lp:mailman/2.1

2019-06-10 Thread Jim Popovitch via Mailman-coders
If line 20 (in the patch below) sets "captcha_idx = 0" python throws an error: TypeError: cannot concatenate 'str' and 'int' objects I think a better solution would be to remove the captcha_idx from that section of code if it is None, (and set it to None at line 20). -- https://code.launchpa

Re: [Merge] lp:~ralfjung-e/mailman/2.1 into lp:mailman/2.1

2019-06-10 Thread Jim Popovitch via Mailman-coders
The recent change will be included in the MR, you can confirm this by looking at the diff down below these comments on webform for the MR. -- https://code.launchpad.net/~ralfjung-e/mailman/2.1/+merge/368614 Your team Mailman Coders is requested to review the proposed merge of lp:~ralfjung-e/mail

[Bug 1872840] Re: (description)s variable not substituted in emails

2020-04-14 Thread Jim Popovitch via Mailman-coders
(sigh) I'm use to gitlab where the msgs update in real time. My comment above can be ignored. -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1872840 Title: (description)s variable not substit

[Bug 1872840] Re: (description)s variable not substituted in emails

2020-04-14 Thread Jim Popovitch via Mailman-coders
What makes you believe that %(description)s is valid for the Welcome email text? I only ask because this is what I see as the default first two lines of Welcome email text: Welcome to the %(real_name)s@%(host_name)s mailing list! %(welcome)s -- You received this bug notification because you are

[Bug 1878458] Re: Attempting to subscribe to a list can throw a ValueError exception.

2020-05-13 Thread Jim Popovitch via Mailman-coders
What happens if v is 1-tuple and the patch references it in "v[1].address.lower()" ? -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1878458 Title: Attempting to subscribe to a list can throw

[Bug 1878458] Re: Attempting to subscribe to a list can throw a ValueError exception.

2020-05-13 Thread Jim Popovitch via Mailman-coders
Thanks Mark! -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1878458 Title: Attempting to subscribe to a list can throw a ValueError exception. To manage notifications about this bug go to: h