[Mailman-Developers] Re: Regarding issue #553 in mailman-core

2020-01-07 Thread ritwik p
Mark Sapiro wrote: > The comment says > # We can't assert anything about member. It will be None when > # the workflow we're confirming is an unsubscription request, > # and non-None when we're confirming a subscription request. > # This class doesn't know which is happening. > That's backwards.

[Mailman-Developers] Re: Regarding issue #553 in mailman-core

2020-01-07 Thread ritwik p
Mark Sapiro wrote: > No. You do not want to change the confirm(token) function. You want > to > change mailman/commands/eml_confirm.py to do the right thing. Ok. Also, I'm getting member as `not-None` when the member confirms their subscription. But the comments said (which you corrected), that

[Mailman-Developers] Re: Regarding issue #553 in mailman-core

2020-01-07 Thread Mark Sapiro
On 1/7/20 7:35 AM, ritwik p wrote: > Mark Sapiro wrote: > >> The comment says >> # We can't assert anything about member. It will be None when >> # the workflow we're confirming is an unsubscription request, >> # and non-None when we're confirming a subscription request. >> # This class doesn't k

[Mailman-Developers] Re: Regarding issue #553 in mailman-core

2020-01-07 Thread ritwik p
Please disregard this: > I'm getting member as not-None when the member confirms their subscription. > But the comments said (which you corrected), that the member will be None > when subscribing. Sorry for the wrong doubt. ___ Mailman-Developers mailing