Re: [Gluster-Maintainers] [Gluster-devel] 'Reviewd-by' tag for commits

2016-10-15 Thread Jose A. Rivera
On Fri, Oct 14, 2016 at 4:44 AM, Niels de Vos wrote: > On Fri, Oct 14, 2016 at 02:21:23PM +0530, Nigel Babu wrote: >> I've said on this thread before, none of this is easy to do. It needs us to >> fork Gerrit to make our own changes. I would argue that depending on the >> data

Re: [Gluster-Maintainers] [Gluster-devel] 'Reviewd-by' tag for commits

2016-10-14 Thread Pranith Kumar Karampuri
How do we get the following tags in the commit message? > Smoke: Gluster Build System > NetBSD-regression: NetBSD Build System > CentOS-regression: Gluster Build System On Fri, Oct 14, 2016 at 3:14

Re: [Gluster-Maintainers] [Gluster-devel] 'Reviewd-by' tag for commits

2016-10-14 Thread Niels de Vos
On Fri, Oct 14, 2016 at 02:21:23PM +0530, Nigel Babu wrote: > I've said on this thread before, none of this is easy to do. It needs us to > fork Gerrit to make our own changes. I would argue that depending on the > data from the commit message is folly. Eventhough we all seem to agree that

Re: [Gluster-Maintainers] [Gluster-devel] 'Reviewd-by' tag for commits

2016-10-14 Thread Nigel Babu
I've said on this thread before, none of this is easy to do. It needs us to fork Gerrit to make our own changes. I would argue that depending on the data from the commit message is folly. On Fri, Oct 14, 2016 at 12:23 PM, Niels de Vos wrote: > On Thu, Oct 13, 2016 at

Re: [Gluster-Maintainers] [Gluster-devel] 'Reviewd-by' tag for commits

2016-10-14 Thread Niels de Vos
On Thu, Oct 13, 2016 at 11:01:43PM +0530, Pranith Kumar Karampuri wrote: > On Thu, Oct 6, 2016 at 1:49 AM, Michael Adam wrote: > > > On 2016-10-05 at 09:45 -0400, Ira Cooper wrote: > > > "Feedback-given-by: " > > > > Niels/Nigel, >Is this easier

Re: [Gluster-Maintainers] [Gluster-devel] 'Reviewd-by' tag for commits

2016-10-05 Thread Michael Adam
On 2016-10-05 at 09:45 -0400, Ira Cooper wrote: > "Feedback-given-by: " I like that one - thanks! :-) Michael > - Original Message - > > On 2016-09-30 at 17:52 +0200, Niels de Vos wrote: > > > On Fri, Sep 30, 2016 at 08:50:12PM +0530, Ravishankar N wrote: > > >

Re: [Gluster-Maintainers] [Gluster-devel] 'Reviewd-by' tag for commits

2016-10-05 Thread Ira Cooper
"Feedback-given-by: " Cheers, -IRa - Original Message - > On 2016-09-30 at 17:52 +0200, Niels de Vos wrote: > > On Fri, Sep 30, 2016 at 08:50:12PM +0530, Ravishankar N wrote: > > > On 09/30/2016 06:38 PM, Niels de Vos wrote: > > > > On Fri, Sep 30, 2016 at

Re: [Gluster-Maintainers] [Gluster-devel] 'Reviewd-by' tag for commits

2016-10-05 Thread Michael Adam
On 2016-09-30 at 17:52 +0200, Niels de Vos wrote: > On Fri, Sep 30, 2016 at 08:50:12PM +0530, Ravishankar N wrote: > > On 09/30/2016 06:38 PM, Niels de Vos wrote: > > > On Fri, Sep 30, 2016 at 07:11:51AM +0530, Pranith Kumar Karampuri wrote: > ... > > > Maybe we can add an additional tag that

Re: [Gluster-Maintainers] [Gluster-devel] 'Reviewd-by' tag for commits

2016-10-05 Thread Ira Cooper
"Feedback-given-by: " Cheers, -Ira - Original Message - > On 2016-09-30 at 17:52 +0200, Niels de Vos wrote: > > On Fri, Sep 30, 2016 at 08:50:12PM +0530, Ravishankar N wrote: > > > On 09/30/2016 06:38 PM, Niels de Vos wrote: > > > > On Fri, Sep 30, 2016 at

Re: [Gluster-Maintainers] [Gluster-devel] 'Reviewd-by' tag for commits

2016-10-03 Thread Pranith Kumar Karampuri
On Mon, Oct 3, 2016 at 12:17 PM, Joe Julian wrote: > If you get credit for +1, shouldn't you also get credit for -1? It seems > to me that catching a fault is at least as valuable if not more so. > Yes when I said review it could be either +1/-1/+2 > > On October 3,

Re: [Gluster-Maintainers] [Gluster-devel] 'Reviewd-by' tag for commits

2016-10-02 Thread Pranith Kumar Karampuri
On Mon, Oct 3, 2016 at 7:23 AM, Ravishankar N wrote: > On 10/03/2016 06:58 AM, Pranith Kumar Karampuri wrote: > > > > On Mon, Oct 3, 2016 at 6:41 AM, Pranith Kumar Karampuri < > pkara...@redhat.com> wrote: > >> >> >> On Fri, Sep 30, 2016 at 8:50 PM, Ravishankar N

Re: [Gluster-Maintainers] [Gluster-devel] 'Reviewd-by' tag for commits

2016-10-02 Thread Ravishankar N
On 10/03/2016 06:58 AM, Pranith Kumar Karampuri wrote: On Mon, Oct 3, 2016 at 6:41 AM, Pranith Kumar Karampuri > wrote: On Fri, Sep 30, 2016 at 8:50 PM, Ravishankar N > wrote:

Re: [Gluster-Maintainers] [Gluster-devel] 'Reviewd-by' tag for commits

2016-10-02 Thread Pranith Kumar Karampuri
On Mon, Oct 3, 2016 at 6:41 AM, Pranith Kumar Karampuri wrote: > > > On Fri, Sep 30, 2016 at 8:50 PM, Ravishankar N > wrote: > >> On 09/30/2016 06:38 PM, Niels de Vos wrote: >> >> On Fri, Sep 30, 2016 at 07:11:51AM +0530, Pranith Kumar Karampuri

Re: [Gluster-Maintainers] [Gluster-devel] 'Reviewd-by' tag for commits

2016-10-02 Thread Pranith Kumar Karampuri
On Fri, Sep 30, 2016 at 8:50 PM, Ravishankar N wrote: > On 09/30/2016 06:38 PM, Niels de Vos wrote: > > On Fri, Sep 30, 2016 at 07:11:51AM +0530, Pranith Kumar Karampuri wrote: > > hi, > At the moment 'Reviewed-by' tag comes only if a +1 is given on the > final

Re: [Gluster-Maintainers] [Gluster-devel] 'Reviewd-by' tag for commits

2016-09-30 Thread Niels de Vos
On Fri, Sep 30, 2016 at 08:50:12PM +0530, Ravishankar N wrote: > On 09/30/2016 06:38 PM, Niels de Vos wrote: > > On Fri, Sep 30, 2016 at 07:11:51AM +0530, Pranith Kumar Karampuri wrote: ... > > Maybe we can add an additional tag that mentions all the people that > > did do reviews of older

Re: [Gluster-Maintainers] [Gluster-devel] 'Reviewd-by' tag for commits

2016-09-30 Thread Ravishankar N
On 09/30/2016 06:38 PM, Niels de Vos wrote: On Fri, Sep 30, 2016 at 07:11:51AM +0530, Pranith Kumar Karampuri wrote: hi, At the moment 'Reviewed-by' tag comes only if a +1 is given on the final version of the patch. But for most of the patches, different people would spend time on