Re: Allow SHELL to include variables and functions.

2007-10-13 Thread Eli Zaretskii
From: Paul Smith [EMAIL PROTECTED] Cc: make-w32@gnu.org Date: Fri, 12 Oct 2007 21:24:41 -0400 But, I fixed this and applied this patch; let me know if I messed something up: 2007-10-12 Eli Zaretskii [EMAIL PROTECTED] * variable.c (do_variable_definition): Allow $(SHELL) to

Re: Allow SHELL to include variables and functions.

2007-10-12 Thread Paul Smith
On Fri, 2007-10-12 at 19:01 +0200, Eli Zaretskii wrote: And if it's expanded right here then won't the automatic variables like $@, $^, and $? not be set yet? Yes. That is why the modified patch below installs the original value, not the expanded one (as the original patch mistakenly

Re: Allow SHELL to include variables and functions.

2007-10-10 Thread Eli Zaretskii
From: Paul Smith [EMAIL PROTECTED] Cc: make-w32@gnu.org Date: Wed, 10 Oct 2007 09:17:11 -0400 Hi Eli; I was reviewing this patch: http://www.mail-archive.com/make-w32%40gnu.org/msg01387.html and I had a few questions: first, I tried this with UNIX make (using the warning in the

Re: Allow SHELL to include variables and functions.

2007-10-10 Thread Paul Smith
On Wed, 2007-10-10 at 21:00 +0200, Eli Zaretskii wrote: Second, I don't quite get how this works; it seems to me that you're expanding the value when the variable is defined (where things like $@ etc. are not set yet) and then storing the expanded variable...? Yes, that's true. But I