Re: Smoke [5.15.4] v5.15.4-39-g293dcbb FAIL(F) openvms V8.4 (IA64/2 cpu)
On Fri, Nov 4, 2011 at 8:29 PM, Michael G Schwern schw...@pobox.com wrote:
On 2011.11.1 7:29 PM, Craig A. Berry wrote:
Depends on the definition of now. And where. In blead, 6.63_01 plus
my changes passed all tests. Trying to build 6.63_02 independently
just now I get:
$ perl Makefile.PL
Could not open 'bundled/cpan-meta-yaml.dir/cpan/meta/yaml.dir.pm': no
such file or directory at lib/ExtUtils/MM_Unix.pm line 2636.
%RMS-F-SYN, file specification syntax error
Something is fileifying directory specs and still expecting to treat
them as directories. But the bundled/ stuff shouldn't matter for
blead I don't think, so it might be best to get 6.63_02 into blead
assuming Win32 is happy with it.
That's inside parse_version() which is called inside should_use_dist() inside
my/bundles.pm and I'm a dirty slacker.
my $inc_version = MM-parse_version( $bundle_dir/$dist/$pm_file );
that should be:
my $inc_version = MM-parse_version(
File::Spec-catfile($bundle_dir, $dist, $pm_file)
);
I pushed a fix to master. Give it a try please?
That doesn't seem to have done any harm, but nor did it do any good.
Generally, Unix syntax is fine unless you're combining with another
path chunk that is already in native syntax or the path is going to be
seen by an external program (such as the native make equivalents).
I have pushed the following to master, which gets bundles working and
allows us to build and pass all tests.
% git show c6a1f63b04c3a3a6754bb37516f80235929fffa3
commit c6a1f63b04c3a3a6754bb37516f80235929fffa3
Author: Craig A. Berry craigbe...@mac.com
Date: Sat Nov 5 14:36:25 2011 -0500
Portability for my::bundles.
On VMS readdir() by default returns directory names with the .DIR
extension, which needs to be trimmed off if the directory name is
going to be glued together with other pieces to make a path.
Also on VMS, filename case is not preserved by default, so we need
to do a case-blind lookup of Scalar-List-Utils to trigger its
special handling.
diff --git a/my/bundles.pm b/my/bundles.pm
index 9bc8d83..dee6753 100644
--- a/my/bundles.pm
+++ b/my/bundles.pm
@@ -34,7 +34,7 @@ inc/ as a flattened module directory that MakeMaker
can install.
my $bundle_dir = bundled;
my %special_dist = (
-Scalar-List-Utils = sub {
+scalar-list-utils = sub {
# Special case for Scalar::Util, never override the XS version with a
# pure Perl version. Just check that it's there.
my $installed = find_installed(Scalar/Util.pm);
@@ -50,6 +50,9 @@ my %special_dist = (
sub add_bundles_to_inc {
opendir my $dh, $bundle_dir or die Can't open bundles directory: $!;
my @bundles = grep { -d $_ } map { $bundle_dir/$_ } grep
!/^\./, readdir $dh;
+if ($^O eq 'VMS') {
+for my $bundle (@bundles) { $bundle =~ s/\.DIR$//i; }
+}
require lib;
lib-import(@bundles);
@@ -69,7 +72,8 @@ sub copy_bundles {
opendir my $bundle_dh, $src or die $!;
for my $dist (grep !/^\./, grep { -d File::Spec-catdir($src, $_)
} readdir $bundle_dh) {
-my $should_use = $special_dist{$dist} || \should_use_dist;
+$dist =~ s/.DIR$//i if $^O eq 'VMS';
+my $should_use = $special_dist{lc($dist)} || \should_use_dist;
next unless $should_use-($dist);
Re: Smoke [5.15.4] v5.15.4-39-g293dcbb FAIL(F) openvms V8.4 (IA64/2 cpu)
On 2011.11.5 12:47 PM, Craig A. Berry wrote: I have pushed the following to master, which gets bundles working and allows us to build and pass all tests. Thanks for getting it working. I'll work on removing the Unix file path cheats, that should preclude the need to special case VMS (except for the readdir casing incompatibility). -- ...they shared one last kiss that left a bitter yet sweet taste in her mouth--kind of like throwing up after eating a junior mint. -- Dishonorable Mention, 2005 Bulwer-Lytton Fiction Contest by Tami Farmer
Re: Smoke [5.15.4] v5.15.4-39-g293dcbb FAIL(F) openvms V8.4 (IA64/2 cpu)
On Tue, Nov 1, 2011 at 5:20 PM, Michael G Schwern schw...@pobox.com wrote: On 2011.10.28 7:57 PM, Craig A. Berry wrote: I patched the new MakeMaker failures on VMS at: https://github.com/Perl-Toolchain-Gang/ExtUtils-MakeMaker/commit/8d4c9962adb0142bfed60c6b5569c8424637df16 Hopefully once the Win32 test failures introduced by 6.63_01 get sorted out there will be a new dev release soonish. Thanks for that. Everything working ok on VMS now? Depends on the definition of now. And where. In blead, 6.63_01 plus my changes passed all tests. Trying to build 6.63_02 independently just now I get: $ perl Makefile.PL Could not open 'bundled/cpan-meta-yaml.dir/cpan/meta/yaml.dir.pm': no such file or directory at lib/ExtUtils/MM_Unix.pm line 2636. %RMS-F-SYN, file specification syntax error Something is fileifying directory specs and still expecting to treat them as directories. But the bundled/ stuff shouldn't matter for blead I don't think, so it might be best to get 6.63_02 into blead assuming Win32 is happy with it.
Re: Smoke [5.15.4] v5.15.4-39-g293dcbb FAIL(F) openvms V8.4 (IA64/2 cpu)
On 2011.10.28 7:57 PM, Craig A. Berry wrote: I patched the new MakeMaker failures on VMS at: https://github.com/Perl-Toolchain-Gang/ExtUtils-MakeMaker/commit/8d4c9962adb0142bfed60c6b5569c8424637df16 Hopefully once the Win32 test failures introduced by 6.63_01 get sorted out there will be a new dev release soonish. Thanks for that. Everything working ok on VMS now? -- 44. I am not the atheist chaplain. -- The 213 Things Skippy Is No Longer Allowed To Do In The U.S. Army http://skippyslist.com/list/
Re: Smoke [5.15.4] v5.15.4-39-g293dcbb FAIL(F) openvms V8.4 (IA64/2 cpu)
On Thu, Oct 27, 2011 at 1:17 AM, Craig A. Berry craigbe...@mac.com wrote:
Automated smoke report for 5.15.4 patch
293dcbbbfd30a0f0282734d71ac98c53abfd07ec v5.15.4-39-g293dcbb
ALMA: HP rx2600 (1.50GHz/6.0MB) (IA64/2 cpu)
on openvms - V8.4
using ? CC/DECC version 70390020
smoketime 3 hours 23 minutes (average 1 hour 41 minutes)
Summary: FAIL(F)
O = OK F = Failure(s), extended report at the bottom
X = Failure(s) under TEST but not under harness
? = still running or test results not (yet) available
Build failures during: - = unknown or N/A
c = Configure, m = make, M = make (after miniperl), t = make test-prep
v5.15.4-39-g293dcbb Configuration (common) none
--- -
F -
F - -Dusethreads
| +- -DDEBUGGING
+--- no debugging
Locally applied patches:
uncommitted-changes
SMOKE293dcbbbfd30a0f0282734d71ac98c53abfd07ec
Failures: (common-args) none
[default]
[default] -Dusethreads
t/op/glob . FAILED at
test 14
cpan/CGI/t/url FAILED--no
leader found
cpan/ExtUtils-MakeMaker/t/basic ... FAILED at
test 10
cpan/ExtUtils-MakeMaker/t/echo FAILED at
test 1
cpan/ExtUtils-MakeMaker/t/min_perl_version FAILED at
test 24
cpan/ExtUtils-MakeMaker/t/several_authors . FAILED at
test 11
I patched the new MakeMaker failures on VMS at:
https://github.com/Perl-Toolchain-Gang/ExtUtils-MakeMaker/commit/8d4c9962adb0142bfed60c6b5569c8424637df16
Hopefully once the Win32 test failures introduced by 6.63_01 get
sorted out there will be a new dev release soonish.
cpan/Module-Build/t/PL_files .. FAILED at
test 3
cpan/Module-Build/t/properties/dist_suffix FAILED at
test 2
cpan/Module-Build/t/runthrough FAILED at
test 11
cpan/Module-Build/t/tilde . FAILED at
test 16
cpan/Pod-Simple/t/search12 FAILED at
test 7
dist/Carp/t/Carp ..
FAILED--expected 58 tests, saw 34
Compiler messages(VMS):
if (invariant_head = 0) {
^
%CC-I-QUESTCOMPARE, In this statement, the unsigned expression
invariant_head is being compared with a relational operator to a constant
whose value is not greater than zero. This might not be what you intended.
at line number 3355 in file MDA0:[SMOKE.blead]sv.c;1
if (ulen == -1) {
^
%CC-I-QUESTCOMPARE1, In this statement, the unsigned expression ulen is
being compared with an equality operator to a constant whose value is
negative. This might not be what you intended.
at line number 356 in file MDA0:[SMOKE.blead.cpan.Encode]Encode.xs;1
if (ulen == -1)
^
%CC-I-QUESTCOMPARE1, In this statement, the unsigned expression ulen is
being compared with an equality operator to a constant whose value is
negative. This might not be what you intended.
at line number 360 in file MDA0:[SMOKE.blead.cpan.Encode]Encode.xs;1
old_ck(sassign);
...^
%CC-I-EXTRASEMI, Extraneous semicolon.
at line number 120 in file MDA0:[SMOKE.blead.ext.arybase]arybase.xs;1
old_ck(aassign);
...^
%CC-I-EXTRASEMI, Extraneous semicolon.
at line number 121 in file MDA0:[SMOKE.blead.ext.arybase]arybase.xs;1
old_ck(aelem);
.^
%CC-I-EXTRASEMI, Extraneous semicolon.
at line number 122 in file MDA0:[SMOKE.blead.ext.arybase]arybase.xs;1
old_ck(aslice);
..^
%CC-I-EXTRASEMI, Extraneous semicolon.
at line number 123 in file MDA0:[SMOKE.blead.ext.arybase]arybase.xs;1
old_ck(lslice);
..^
%CC-I-EXTRASEMI, Extraneous semicolon.
at line number 124 in file MDA0:[SMOKE.blead.ext.arybase]arybase.xs;1
old_ck(av2arylen);
.^
%CC-I-EXTRASEMI, Extraneous semicolon.
at line number 125 in file MDA0:[SMOKE.blead.ext.arybase]arybase.xs;1
old_ck(splice);
..^
%CC-I-EXTRASEMI, Extraneous semicolon.
at line number 126 in file MDA0:[SMOKE.blead.ext.arybase]arybase.xs;1
old_ck(keys);
^
%CC-I-EXTRASEMI, Extraneous semicolon.
at line number 127 in file MDA0:[SMOKE.blead.ext.arybase]arybase.xs;1
old_ck(each);
^
%CC-I-EXTRASEMI, Extraneous semicolon.
at line number 128 in file MDA0:[SMOKE.blead.ext.arybase]arybase.xs;1
old_ck(substr);
..^
%CC-I-EXTRASEMI, Extraneous semicolon.
at line number 129 in file MDA0:[SMOKE.blead.ext.arybase]arybase.xs;1
old_ck(rindex);
..^
%CC-I-EXTRASEMI, Extraneous semicolon.
at line number 130 in file MDA0:[SMOKE.blead.ext.arybase]arybase.xs;1
