Re: Review Request: MAPREDUCE-2584. Check for serializers early, and give out more information regarding missing serializers.

2011-06-16 Thread Harsh J
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/885/ --- (Updated 2011-06-16 12:24:09.519284) Review request for hadoop-mapreduce.

Re: Review Request: MAPREDUCE-2584. Check for serializers early, and give out more information regarding missing serializers.

2011-06-12 Thread Harsh J
On 2011-06-12 04:39:03, Todd Lipcon wrote: src/java/org/apache/hadoop/mapreduce/JobSubmitter.java, line 471 https://reviews.apache.org/r/885/diff/2/?file=21008#file21008line471 ah, I noticed one more thing. This catch clause is only for the exceptions you've thrown above.

Re: Review Request: MAPREDUCE-2584. Check for serializers early, and give out more information regarding missing serializers.

2011-06-11 Thread Harsh Chouraria
On 2011-06-12 02:31:03, Todd Lipcon wrote: src/java/org/apache/hadoop/mapreduce/JobSubmitter.java, line 400 https://reviews.apache.org/r/885/diff/1/?file=21001#file21001line400 nit: the javadoc style guide says this should be: @param job the job to check for (so

Re: Review Request: MAPREDUCE-2584. Check for serializers early, and give out more information regarding missing serializers.

2011-06-11 Thread Harsh Chouraria
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/885/ --- (Updated 2011-06-12 04:36:10.322990) Review request for hadoop-mapreduce.