Re: [DICUSS] Upgrading Guice to 4.0(HADOOP-12064)

2016-07-07 Thread Tsuyoshi Ozawa
Thanks all for the discussion. I merged it on 2nd July :-) I think the last task about JDK 8 compilation support is to configure maven-enforcer-plugin. Thanks, - Tsuyoshi On Wed, Jul 6, 2016 at 3:41 AM, Ravi Prakash wrote: > Go Go Go! Thanks for all the upgrade work

Re: [DICUSS] Upgrading Guice to 4.0(HADOOP-12064)

2016-07-05 Thread Ravi Prakash
Go Go Go! Thanks for all the upgrade work Tsuyoshi! On Thu, Jun 30, 2016 at 12:03 PM, Tsuyoshi Ozawa wrote: > Thanks, Andrew. > > Based on discussion here, I would like to merge it into *trunk* if > there are no objection tomorrow. > > Thanks, > - Tsuyoshi > > On Wed, Jun 29,

Re: [DICUSS] Upgrading Guice to 4.0(HADOOP-12064)

2016-06-30 Thread Tsuyoshi Ozawa
Thanks, Andrew. Based on discussion here, I would like to merge it into *trunk* if there are no objection tomorrow. Thanks, - Tsuyoshi On Wed, Jun 29, 2016 at 12:28 PM, Andrew Wang wrote: > I think it's okay to merge. We've already bumped other deps in trunk. > > On

Re: [DICUSS] Upgrading Guice to 4.0(HADOOP-12064)

2016-06-29 Thread Andrew Wang
I think it's okay to merge. We've already bumped other deps in trunk. On Wed, Jun 29, 2016 at 12:27 PM, Tsuyoshi Ozawa wrote: > I forgot to mention about importance point: it's a blocker issue to > compile Hadoop with JDK8. Hence, we need to merge it on both client > side and

Re: [DICUSS] Upgrading Guice to 4.0(HADOOP-12064)

2016-06-29 Thread Tsuyoshi Ozawa
I forgot to mention about importance point: it's a blocker issue to compile Hadoop with JDK8. Hence, we need to merge it on both client side and server slide anyway. Thanks, - Tsuyoshi On Wed, Jun 29, 2016 at 12:24 PM, Tsuyoshi Ozawa wrote: > Thanks Vinod, Sangjin, Sean for

Re: [DICUSS] Upgrading Guice to 4.0(HADOOP-12064)

2016-06-29 Thread Tsuyoshi Ozawa
Thanks Vinod, Sangjin, Sean for your comment. Okay, I will take a look at the class path isolation. Should I postpone to merge Guice upgrade to trunk? IMHO, it works with tests, so it's okay to merge to runk. Thoughts? - Tsuyoshi On Wed, Jun 29, 2016 at 12:10 PM, Sangjin Lee

Re: [DICUSS] Upgrading Guice to 4.0(HADOOP-12064)

2016-06-29 Thread Sean Busbey
At the very least, I'm running through an updated shaded hadoop client this week[1] (HBase is my test application and it wandered onto some private things that broke in branch-2). And Sangjin has a good lead on an lower-short-term-cost incremental improvement for runtime isolation of apps built on

Re: [DICUSS] Upgrading Guice to 4.0(HADOOP-12064)

2016-06-29 Thread Vinod Kumar Vavilapalli
My strong expectation is that we’ll have a version of classpath isolation in our first release of 3.x. I’m planning to spending some cycles right away on this. Assuming classpath isolation gets in, it is reasonable to bump up our dependencies like Jetty / Guice to the latest stable versions.

Re: [DICUSS] Upgrading Guice to 4.0(HADOOP-12064)

2016-06-29 Thread Akira AJISAKA
As I commented in the jira, I'm +1 for upgrading. -Akira On 6/29/16 10:16, Tsuyoshi Ozawa wrote: No objections here? - Tsuyoshi On Mon, Jun 27, 2016 at 6:01 AM, Tsuyoshi Ozawa wrote: Hi developers, I will plan to upgrade Google Guice dependency on trunk. The change also

Re: [DICUSS] Upgrading Guice to 4.0(HADOOP-12064)

2016-06-29 Thread Allen Wittenauer
> On Jun 29, 2016, at 10:16 AM, Tsuyoshi Ozawa wrote: > > No objections here? I talked to a handful of non-committer ISV-type folks yesterday and the general consensus was that there is an expectation that 3.x will have all the dependencies updated to something relatively

Re: [DICUSS] Upgrading Guice to 4.0(HADOOP-12064)

2016-06-29 Thread Tsuyoshi Ozawa
No objections here? - Tsuyoshi On Mon, Jun 27, 2016 at 6:01 AM, Tsuyoshi Ozawa wrote: > Hi developers, > > I will plan to upgrade Google Guice dependency on trunk. The change > also includes asm and cglib upgrade. > I checked following points: > > * Both HDFS and YARN UIs work

[DICUSS] Upgrading Guice to 4.0(HADOOP-12064)

2016-06-27 Thread Tsuyoshi Ozawa
Hi developers, I will plan to upgrade Google Guice dependency on trunk. The change also includes asm and cglib upgrade. I checked following points: * Both HDFS and YARN UIs work well. * All webIU-related tests pass as described on HADOOP-12064. * Ran mapreduce job, and it works well.