[jira] [Commented] (MAPREDUCE-7298) Distcp doesn't close the job after the job is completed

2020-10-01 Thread Shashikant Banerjee (Jira)


[ 
https://issues.apache.org/jira/browse/MAPREDUCE-7298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205988#comment-17205988
 ] 

Shashikant Banerjee commented on MAPREDUCE-7298:


+1, for the v2 patch.

> Distcp doesn't close the job after the job is completed
> ---
>
> Key: MAPREDUCE-7298
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7298
> Project: Hadoop Map/Reduce
>  Issue Type: Task
>Reporter: Aasha Medhi
>Assignee: Aasha Medhi
>Priority: Major
> Attachments: MAPREDUCE-7298.01.patch, MAPREDUCE-7298.02.patch
>
>
> Distcp doesn't close the job after the job is completed. This leads to leaked 
> Truststore Reloader Threads.
> The fix is to close the job once it is complete. job.close internally calls 
> yarnClient.close(), which then calls timelineConnector.serviceStop() . This 
> destroys the sslFactory cleaning up the ReloadingX509TrustManager.
> Without the patch for each distcp job, a new ReloadingX509TrustManager is 
> created which creates a new thread. These threads are never killed and they 
> remain like that till HS2 is restarted. With the close, the thread will be 
> cleaned up once the job is completed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org



[jira] [Commented] (MAPREDUCE-7298) Distcp doesn't close the job after the job is completed

2020-10-01 Thread Wangda Tan (Jira)


[ 
https://issues.apache.org/jira/browse/MAPREDUCE-7298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205866#comment-17205866
 ] 

Wangda Tan commented on MAPREDUCE-7298:
---

Thanks [~aasha], I just added you to contributor list.

> Distcp doesn't close the job after the job is completed
> ---
>
> Key: MAPREDUCE-7298
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7298
> Project: Hadoop Map/Reduce
>  Issue Type: Task
>Reporter: Aasha Medhi
>Assignee: Aasha Medhi
>Priority: Major
> Attachments: MAPREDUCE-7298.01.patch, MAPREDUCE-7298.02.patch
>
>
> Distcp doesn't close the job after the job is completed. This leads to leaked 
> Truststore Reloader Threads.
> The fix is to close the job once it is complete. job.close internally calls 
> yarnClient.close(), which then calls timelineConnector.serviceStop() . This 
> destroys the sslFactory cleaning up the ReloadingX509TrustManager.
> Without the patch for each distcp job, a new ReloadingX509TrustManager is 
> created which creates a new thread. These threads are never killed and they 
> remain like that till HS2 is restarted. With the close, the thread will be 
> cleaned up once the job is completed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org



[jira] [Assigned] (MAPREDUCE-7298) Distcp doesn't close the job after the job is completed

2020-10-01 Thread Wangda Tan (Jira)


 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-7298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wangda Tan reassigned MAPREDUCE-7298:
-

Assignee: Aasha Medhi

> Distcp doesn't close the job after the job is completed
> ---
>
> Key: MAPREDUCE-7298
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7298
> Project: Hadoop Map/Reduce
>  Issue Type: Task
>Reporter: Aasha Medhi
>Assignee: Aasha Medhi
>Priority: Major
> Attachments: MAPREDUCE-7298.01.patch, MAPREDUCE-7298.02.patch
>
>
> Distcp doesn't close the job after the job is completed. This leads to leaked 
> Truststore Reloader Threads.
> The fix is to close the job once it is complete. job.close internally calls 
> yarnClient.close(), which then calls timelineConnector.serviceStop() . This 
> destroys the sslFactory cleaning up the ReloadingX509TrustManager.
> Without the patch for each distcp job, a new ReloadingX509TrustManager is 
> created which creates a new thread. These threads are never killed and they 
> remain like that till HS2 is restarted. With the close, the thread will be 
> cleaned up once the job is completed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org



[jira] [Commented] (MAPREDUCE-7298) Distcp doesn't close the job after the job is completed

2020-10-01 Thread Aravindan Vijayan (Jira)


[ 
https://issues.apache.org/jira/browse/MAPREDUCE-7298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205782#comment-17205782
 ] 

Aravindan Vijayan commented on MAPREDUCE-7298:
--

Thanks for working on this [~aasha]. [~wangda] / [~shashikant] Do you have 
permissions to add [~aasha] as a contributor? I am unable to add her as the 
Assignee.

> Distcp doesn't close the job after the job is completed
> ---
>
> Key: MAPREDUCE-7298
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7298
> Project: Hadoop Map/Reduce
>  Issue Type: Task
>Reporter: Aasha Medhi
>Priority: Major
> Attachments: MAPREDUCE-7298.01.patch, MAPREDUCE-7298.02.patch
>
>
> Distcp doesn't close the job after the job is completed. This leads to leaked 
> Truststore Reloader Threads.
> The fix is to close the job once it is complete. job.close internally calls 
> yarnClient.close(), which then calls timelineConnector.serviceStop() . This 
> destroys the sslFactory cleaning up the ReloadingX509TrustManager.
> Without the patch for each distcp job, a new ReloadingX509TrustManager is 
> created which creates a new thread. These threads are never killed and they 
> remain like that till HS2 is restarted. With the close, the thread will be 
> cleaned up once the job is completed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org



[jira] [Comment Edited] (MAPREDUCE-7298) Distcp doesn't close the job after the job is completed

2020-10-01 Thread Aravindan Vijayan (Jira)


[ 
https://issues.apache.org/jira/browse/MAPREDUCE-7298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205782#comment-17205782
 ] 

Aravindan Vijayan edited comment on MAPREDUCE-7298 at 10/1/20, 7:25 PM:


Thanks for working on this [~aasha]. LGTM +1. 

[~wangda] / [~shashikant] Do you have permissions to add [~aasha] as a 
contributor? I am unable to add her as the Assignee.


was (Author: avijayan):
Thanks for working on this [~aasha]. [~wangda] / [~shashikant] Do you have 
permissions to add [~aasha] as a contributor? I am unable to add her as the 
Assignee.

> Distcp doesn't close the job after the job is completed
> ---
>
> Key: MAPREDUCE-7298
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7298
> Project: Hadoop Map/Reduce
>  Issue Type: Task
>Reporter: Aasha Medhi
>Priority: Major
> Attachments: MAPREDUCE-7298.01.patch, MAPREDUCE-7298.02.patch
>
>
> Distcp doesn't close the job after the job is completed. This leads to leaked 
> Truststore Reloader Threads.
> The fix is to close the job once it is complete. job.close internally calls 
> yarnClient.close(), which then calls timelineConnector.serviceStop() . This 
> destroys the sslFactory cleaning up the ReloadingX509TrustManager.
> Without the patch for each distcp job, a new ReloadingX509TrustManager is 
> created which creates a new thread. These threads are never killed and they 
> remain like that till HS2 is restarted. With the close, the thread will be 
> cleaned up once the job is completed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org



[jira] [Commented] (MAPREDUCE-7298) Distcp doesn't close the job after the job is completed

2020-10-01 Thread Wangda Tan (Jira)


[ 
https://issues.apache.org/jira/browse/MAPREDUCE-7298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205770#comment-17205770
 ] 

Wangda Tan commented on MAPREDUCE-7298:
---

+1, thanks for the patch.

> Distcp doesn't close the job after the job is completed
> ---
>
> Key: MAPREDUCE-7298
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7298
> Project: Hadoop Map/Reduce
>  Issue Type: Task
>Reporter: Aasha Medhi
>Priority: Major
> Attachments: MAPREDUCE-7298.01.patch, MAPREDUCE-7298.02.patch
>
>
> Distcp doesn't close the job after the job is completed. This leads to leaked 
> Truststore Reloader Threads.
> The fix is to close the job once it is complete. job.close internally calls 
> yarnClient.close(), which then calls timelineConnector.serviceStop() . This 
> destroys the sslFactory cleaning up the ReloadingX509TrustManager.
> Without the patch for each distcp job, a new ReloadingX509TrustManager is 
> created which creates a new thread. These threads are never killed and they 
> remain like that till HS2 is restarted. With the close, the thread will be 
> cleaned up once the job is completed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org