[jira] [Commented] (MAPREDUCE-7299) data type of parameter 'mapreduce.task.exit.timeout' is inconsistent

2020-10-04 Thread Hadoop QA (Jira) 


[ 
https://issues.apache.org/jira/browse/MAPREDUCE-7299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17207802#comment-17207802
 ] 

Hadoop QA commented on MAPREDUCE-7299:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime ||  Logfile || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 27m 
39s{color} |  | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} || ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} |  | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} |  | {color:green} The patch does not contain any @author tags. 
{color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} |  | {color:red} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} || ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 19m 
45s{color} |  | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
36s{color} |  | {color:green} trunk passed with JDK 
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
33s{color} |  | {color:green} trunk passed with JDK Private 
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
27s{color} |  | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
37s{color} |  | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
14m 53s{color} |  | {color:green} branch has no errors when building and 
testing our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
30s{color} |  | {color:green} trunk passed with JDK 
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
27s{color} |  | {color:green} trunk passed with JDK Private 
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  0m 
58s{color} |  | {color:blue} Used deprecated FindBugs config; considering 
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
55s{color} |  | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} || ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
30s{color} |  | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
28s{color} |  | {color:green} the patch passed with JDK 
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
28s{color} |  | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
25s{color} |  | {color:green} the patch passed with JDK Private 
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
25s{color} |  | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
18s{color} |  | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
27s{color} |  | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} |  | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
13m 51s{color} |  | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
25s{color} |  | {color:green} the patch passed with JDK 
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
23s{color} |  | {color:green} the patch passed with JDK Private 
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m  
0s{color} |  | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} || ||
| {color:green}+1{color} | {color:green} unit {color} |

[jira] [Updated] (MAPREDUCE-7299) data type of parameter 'mapreduce.task.exit.timeout' is inconsistent

2020-10-04 Thread leafeonia (Jira) 


 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-7299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

leafeonia updated MAPREDUCE-7299:
-
Attachment: MAPREDUCE-7299-001.patch
Status: Patch Available  (was: Open)

> data type of parameter 'mapreduce.task.exit.timeout' is inconsistent
> 
>
> Key: MAPREDUCE-7299
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7299
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>Reporter: leafeonia
>Priority: Minor
> Attachments: MAPREDUCE-7299-001.patch
>
>
> *Problem:*
> The data type of parameter `mapreduce.task.exit.timeout` is inconsistent in 
> the code relevant to the parameter.
> In `TaskAttemptFinishingMonitor.java`, getInt() is used to load the parameter 
> value:
> {code:java}
> int expireIntvl = conf.getInt(MRJobConfig.TASK_EXIT_TIMEOUT,
>   MRJobConfig.TASK_EXIT_TIMEOUT_DEFAULT);{code}
> However, in `TaskHeartbeatHandler.java`, the code uses getLong() instead and 
> stores the value in a long-type variable.
> {code:java}
> private long unregisterTimeOut;
> ...
> unregisterTimeOut = conf.getLong(MRJobConfig.TASK_EXIT_TIMEOUT,
>   MRJobConfig.TASK_EXIT_TIMEOUT_DEFAULT);{code}
>  
> *Solution:*
> Convert the type explicitly to avoid inconsistency and potential problems:
> {code:java}
> unregisterTimeOut = (long)conf.getInt(MRJobConfig.TASK_EXIT_TIMEOUT, 
>   MRJobConfig.TASK_EXIT_TIMEOUT_DEFAULT);{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

[jira] [Updated] (MAPREDUCE-7299) data type of parameter 'mapreduce.task.exit.timeout' is inconsistent

2020-10-04 Thread leafeonia (Jira) 


 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-7299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

leafeonia updated MAPREDUCE-7299:
-
Attachment: (was: MAPREDUCE-7299-001.patch)

> data type of parameter 'mapreduce.task.exit.timeout' is inconsistent
> 
>
> Key: MAPREDUCE-7299
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7299
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>Reporter: leafeonia
>Priority: Minor
> Attachments: MAPREDUCE-7299-001.patch
>
>
> *Problem:*
> The data type of parameter `mapreduce.task.exit.timeout` is inconsistent in 
> the code relevant to the parameter.
> In `TaskAttemptFinishingMonitor.java`, getInt() is used to load the parameter 
> value:
> {code:java}
> int expireIntvl = conf.getInt(MRJobConfig.TASK_EXIT_TIMEOUT,
>   MRJobConfig.TASK_EXIT_TIMEOUT_DEFAULT);{code}
> However, in `TaskHeartbeatHandler.java`, the code uses getLong() instead and 
> stores the value in a long-type variable.
> {code:java}
> private long unregisterTimeOut;
> ...
> unregisterTimeOut = conf.getLong(MRJobConfig.TASK_EXIT_TIMEOUT,
>   MRJobConfig.TASK_EXIT_TIMEOUT_DEFAULT);{code}
>  
> *Solution:*
> Convert the type explicitly to avoid inconsistency and potential problems:
> {code:java}
> unregisterTimeOut = (long)conf.getInt(MRJobConfig.TASK_EXIT_TIMEOUT, 
>   MRJobConfig.TASK_EXIT_TIMEOUT_DEFAULT);{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

[jira] [Updated] (MAPREDUCE-7299) data type of parameter 'mapreduce.task.exit.timeout' is inconsistent

2020-10-04 Thread leafeonia (Jira) 


 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-7299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

leafeonia updated MAPREDUCE-7299:
-
Attachment: MAPREDUCE-7299-001.patch

> data type of parameter 'mapreduce.task.exit.timeout' is inconsistent
> 
>
> Key: MAPREDUCE-7299
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7299
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>Reporter: leafeonia
>Priority: Minor
> Attachments: MAPREDUCE-7299-001.patch
>
>
> *Problem:*
> The data type of parameter `mapreduce.task.exit.timeout` is inconsistent in 
> the code relevant to the parameter.
> In `TaskAttemptFinishingMonitor.java`, getInt() is used to load the parameter 
> value:
> {code:java}
> int expireIntvl = conf.getInt(MRJobConfig.TASK_EXIT_TIMEOUT,
>   MRJobConfig.TASK_EXIT_TIMEOUT_DEFAULT);{code}
> However, in `TaskHeartbeatHandler.java`, the code uses getLong() instead and 
> stores the value in a long-type variable.
> {code:java}
> private long unregisterTimeOut;
> ...
> unregisterTimeOut = conf.getLong(MRJobConfig.TASK_EXIT_TIMEOUT,
>   MRJobConfig.TASK_EXIT_TIMEOUT_DEFAULT);{code}
>  
> *Solution:*
> Convert the type explicitly to avoid inconsistency and potential problems:
> {code:java}
> unregisterTimeOut = (long)conf.getInt(MRJobConfig.TASK_EXIT_TIMEOUT, 
>   MRJobConfig.TASK_EXIT_TIMEOUT_DEFAULT);{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

[jira] [Created] (MAPREDUCE-7299) data type of parameter 'mapreduce.task.exit.timeout' is inconsistent

2020-10-04 Thread leafeonia (Jira) 
leafeonia created MAPREDUCE-7299:


 Summary: data type of parameter 'mapreduce.task.exit.timeout' is 
inconsistent
 Key: MAPREDUCE-7299
 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7299
 Project: Hadoop Map/Reduce
  Issue Type: Bug
Reporter: leafeonia


*Problem:*

The data type of parameter `mapreduce.task.exit.timeout` is inconsistent in the 
code relevant to the parameter.

In `TaskAttemptFinishingMonitor.java`, getInt() is used to load the parameter 
value:
{code:java}
int expireIntvl = conf.getInt(MRJobConfig.TASK_EXIT_TIMEOUT,
  MRJobConfig.TASK_EXIT_TIMEOUT_DEFAULT);{code}
However, in `TaskHeartbeatHandler.java`, the code uses getLong() instead and 
stores the value in a long-type variable.
{code:java}
private long unregisterTimeOut;
...
unregisterTimeOut = conf.getLong(MRJobConfig.TASK_EXIT_TIMEOUT,
  MRJobConfig.TASK_EXIT_TIMEOUT_DEFAULT);{code}
 

*Solution:*

Convert the type explicitly to avoid inconsistency and potential problems:
{code:java}
unregisterTimeOut = (long)conf.getInt(MRJobConfig.TASK_EXIT_TIMEOUT, 
  MRJobConfig.TASK_EXIT_TIMEOUT_DEFAULT);{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

[jira] [Updated] (MAPREDUCE-7299) data type of parameter 'mapreduce.task.exit.timeout' is inconsistent

2020-10-04 Thread leafeonia (Jira) 


 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-7299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

leafeonia updated MAPREDUCE-7299:
-
Attachment: 1.patch

> data type of parameter 'mapreduce.task.exit.timeout' is inconsistent
> 
>
> Key: MAPREDUCE-7299
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7299
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>Reporter: leafeonia
>Priority: Minor
>
> *Problem:*
> The data type of parameter `mapreduce.task.exit.timeout` is inconsistent in 
> the code relevant to the parameter.
> In `TaskAttemptFinishingMonitor.java`, getInt() is used to load the parameter 
> value:
> {code:java}
> int expireIntvl = conf.getInt(MRJobConfig.TASK_EXIT_TIMEOUT,
>   MRJobConfig.TASK_EXIT_TIMEOUT_DEFAULT);{code}
> However, in `TaskHeartbeatHandler.java`, the code uses getLong() instead and 
> stores the value in a long-type variable.
> {code:java}
> private long unregisterTimeOut;
> ...
> unregisterTimeOut = conf.getLong(MRJobConfig.TASK_EXIT_TIMEOUT,
>   MRJobConfig.TASK_EXIT_TIMEOUT_DEFAULT);{code}
>  
> *Solution:*
> Convert the type explicitly to avoid inconsistency and potential problems:
> {code:java}
> unregisterTimeOut = (long)conf.getInt(MRJobConfig.TASK_EXIT_TIMEOUT, 
>   MRJobConfig.TASK_EXIT_TIMEOUT_DEFAULT);{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

[jira] [Updated] (MAPREDUCE-7299) data type of parameter 'mapreduce.task.exit.timeout' is inconsistent

2020-10-04 Thread leafeonia (Jira) 


 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-7299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

leafeonia updated MAPREDUCE-7299:
-
Attachment: (was: 1.patch)

> data type of parameter 'mapreduce.task.exit.timeout' is inconsistent
> 
>
> Key: MAPREDUCE-7299
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7299
> Project: Hadoop Map/Reduce
>  Issue Type: Bug
>Reporter: leafeonia
>Priority: Minor
>
> *Problem:*
> The data type of parameter `mapreduce.task.exit.timeout` is inconsistent in 
> the code relevant to the parameter.
> In `TaskAttemptFinishingMonitor.java`, getInt() is used to load the parameter 
> value:
> {code:java}
> int expireIntvl = conf.getInt(MRJobConfig.TASK_EXIT_TIMEOUT,
>   MRJobConfig.TASK_EXIT_TIMEOUT_DEFAULT);{code}
> However, in `TaskHeartbeatHandler.java`, the code uses getLong() instead and 
> stores the value in a long-type variable.
> {code:java}
> private long unregisterTimeOut;
> ...
> unregisterTimeOut = conf.getLong(MRJobConfig.TASK_EXIT_TIMEOUT,
>   MRJobConfig.TASK_EXIT_TIMEOUT_DEFAULT);{code}
>  
> *Solution:*
> Convert the type explicitly to avoid inconsistency and potential problems:
> {code:java}
> unregisterTimeOut = (long)conf.getInt(MRJobConfig.TASK_EXIT_TIMEOUT, 
>   MRJobConfig.TASK_EXIT_TIMEOUT_DEFAULT);{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org