[jira] [Commented] (MAPREDUCE-7311) Fix non-idempotent test in TestTaskProgressReporter
[
https://issues.apache.org/jira/browse/MAPREDUCE-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17240414#comment-17240414
]
Hadoop QA commented on MAPREDUCE-7311:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Logfile || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
53s{color} | {color:blue}{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} || ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green}{color} | {color:green} No case conflicting files
found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green}{color} | {color:green} The patch does not contain any
@author tags. {color} |
| {color:green}+1{color} | {color:green} {color} | {color:green} 0m 0s{color}
| {color:green}test4tests{color} | {color:green} The patch appears to include 1
new or modified test files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} || ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 22m
8s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
48s{color} | {color:green}{color} | {color:green} trunk passed with JDK
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
38s{color} | {color:green}{color} | {color:green} trunk passed with JDK Private
Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
30s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
43s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
16m 22s{color} | {color:green}{color} | {color:green} branch has no errors when
building and testing our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
22s{color} | {color:green}{color} | {color:green} trunk passed with JDK
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green}{color} | {color:green} trunk passed with JDK Private
Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 1m
21s{color} | {color:blue}{color} | {color:blue} Used deprecated FindBugs
config; considering switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
19s{color} | {color:green}{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} || ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
35s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
30s{color} | {color:green}{color} | {color:green} the patch passed with JDK
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
30s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
31s{color} | {color:green}{color} | {color:green} the patch passed with JDK
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
31s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
20s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
32s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green}{color} | {color:green} The patch has no whitespace
issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
14m 44s{color} | {color:green}{color} | {color:green} patch has no errors when
building and testing our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green}{color} | {color:green} the patch passed with JDK
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green}{color} |
[jira] [Commented] (MAPREDUCE-7310) Fix flaky test TestJobHistoryEventHandler.testSigTermedFunctionality
[
https://issues.apache.org/jira/browse/MAPREDUCE-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17240412#comment-17240412
]
Hadoop QA commented on MAPREDUCE-7310:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Logfile || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
49s{color} | {color:blue}{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} || ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green}{color} | {color:green} No case conflicting files
found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green}{color} | {color:green} The patch does not contain any
@author tags. {color} |
| {color:green}+1{color} | {color:green} {color} | {color:green} 0m 0s{color}
| {color:green}test4tests{color} | {color:green} The patch appears to include 1
new or modified test files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} || ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 20m
26s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
36s{color} | {color:green}{color} | {color:green} trunk passed with JDK
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
30s{color} | {color:green}{color} | {color:green} trunk passed with JDK Private
Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
34s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
16m 24s{color} | {color:green}{color} | {color:green} branch has no errors when
building and testing our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
40s{color} | {color:green}{color} | {color:green} trunk passed with JDK
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
26s{color} | {color:green}{color} | {color:green} trunk passed with JDK Private
Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 0m
58s{color} | {color:blue}{color} | {color:blue} Used deprecated FindBugs
config; considering switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
56s{color} | {color:green}{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} || ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
34s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
30s{color} | {color:green}{color} | {color:green} the patch passed with JDK
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
30s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
26s{color} | {color:green}{color} | {color:green} the patch passed with JDK
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
26s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
23s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
30s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green}{color} | {color:green} The patch has no whitespace
issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
14m 39s{color} | {color:green}{color} | {color:green} patch has no errors when
building and testing our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
25s{color} | {color:green}{color} | {color:green} the patch passed with JDK
Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
24s{color} | {color:green}{color} |
[jira] [Updated] (MAPREDUCE-7311) Fix non-idempotent test in TestTaskProgressReporter
[
https://issues.apache.org/jira/browse/MAPREDUCE-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhengxi Li updated MAPREDUCE-7311:
--
Attachment: MAPREDUCE-7311.001.patch
> Fix non-idempotent test in TestTaskProgressReporter
> ---
>
> Key: MAPREDUCE-7311
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7311
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Reporter: Zhengxi Li
>Priority: Minor
> Attachments: MAPREDUCE-7311.001.patch
>
>
> The test
> {{`org.apache.hadoop.mapred.TestTaskProgressReporter.testBytesWrittenRespectingLimit`}}
> is not idempotent and fails if run twice in the same JVM, because it
> pollutes state shared among tests. It may be good to clean this state
> pollution so that some other tests do not fail in the future due to the
> shared state polluted by this test.
> h3. Details
> Running {{`TestTaskProgressReporter.testBytesWrittenRespectingLimit`}} twice
> would result in the second run failing with the following assertion:
> {noformat}
> Assert.assertEquals(failFast, threadExited)
> {noformat}
> The root cause for this is that when`testBytesWrittenRespectingLimit` writes
> some bytes on the local file system, some counters are being incremented. The
> problem is that, after the test is done, the counter is not reset. With this
> polluted shared state, assumptions are broken, resulting in test failure in
> the second run.
> PR link: https://github.com/apache/hadoop/pull/2500
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Updated] (MAPREDUCE-7311) Fix non-idempotent test in TestTaskProgressReporter
[
https://issues.apache.org/jira/browse/MAPREDUCE-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhengxi Li updated MAPREDUCE-7311:
--
Status: Patch Available (was: Open)
> Fix non-idempotent test in TestTaskProgressReporter
> ---
>
> Key: MAPREDUCE-7311
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7311
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Reporter: Zhengxi Li
>Priority: Minor
> Attachments: MAPREDUCE-7311.001.patch
>
>
> The test
> {{`org.apache.hadoop.mapred.TestTaskProgressReporter.testBytesWrittenRespectingLimit`}}
> is not idempotent and fails if run twice in the same JVM, because it
> pollutes state shared among tests. It may be good to clean this state
> pollution so that some other tests do not fail in the future due to the
> shared state polluted by this test.
> h3. Details
> Running {{`TestTaskProgressReporter.testBytesWrittenRespectingLimit`}} twice
> would result in the second run failing with the following assertion:
> {noformat}
> Assert.assertEquals(failFast, threadExited)
> {noformat}
> The root cause for this is that when`testBytesWrittenRespectingLimit` writes
> some bytes on the local file system, some counters are being incremented. The
> problem is that, after the test is done, the counter is not reset. With this
> polluted shared state, assumptions are broken, resulting in test failure in
> the second run.
> PR link: https://github.com/apache/hadoop/pull/2500
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Updated] (MAPREDUCE-7311) Fix non-idempotent test in TestTaskProgressReporter
[
https://issues.apache.org/jira/browse/MAPREDUCE-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhengxi Li updated MAPREDUCE-7311:
--
Description:
The test
{{`org.apache.hadoop.mapred.TestTaskProgressReporter.testBytesWrittenRespectingLimit`}}
is not idempotent and fails if run twice in the same JVM, because it pollutes
state shared among tests. It may be good to clean this state pollution so that
some other tests do not fail in the future due to the shared state polluted by
this test.
h3. Details
Running {{`TestTaskProgressReporter.testBytesWrittenRespectingLimit`}} twice
would result in the second run failing with the following assertion:
{noformat}
Assert.assertEquals(failFast, threadExited)
{noformat}
The root cause for this is that when`testBytesWrittenRespectingLimit` writes
some bytes on the local file system, some counters are being incremented. The
problem is that, after the test is done, the counter is not reset. With this
polluted shared state, assumptions are broken, resulting in test failure in the
second run.
PR link: https://github.com/apache/hadoop/pull/2500
was:
The test
{{`org.apache.hadoop.mapred.TestTaskProgressReporter.testBytesWrittenRespectingLimit`}}
is not idempotent and fails if run twice in the same JVM, because it pollutes
state shared among tests. It may be good to clean this state pollution so that
some other tests do not fail in the future due to the shared state polluted by
this test.
h3. Details
Running {{`TestTaskProgressReporter.testBytesWrittenRespectingLimit`}} twice
would result in the second run failing with the following assertion:
{noformat}
Assert.assertEquals(failFast, threadExited)
{noformat}
The root cause for this is that when`testBytesWrittenRespectingLimit` writes
some bytes on the local file system, some counters are being incremented. The
problem is that, after the test is done, the counter is not reset. With this
polluted shared state, assumptions are broken, resulting in test failure in the
second run.
> Fix non-idempotent test in TestTaskProgressReporter
> ---
>
> Key: MAPREDUCE-7311
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7311
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Reporter: Zhengxi Li
>Priority: Minor
>
> The test
> {{`org.apache.hadoop.mapred.TestTaskProgressReporter.testBytesWrittenRespectingLimit`}}
> is not idempotent and fails if run twice in the same JVM, because it
> pollutes state shared among tests. It may be good to clean this state
> pollution so that some other tests do not fail in the future due to the
> shared state polluted by this test.
> h3. Details
> Running {{`TestTaskProgressReporter.testBytesWrittenRespectingLimit`}} twice
> would result in the second run failing with the following assertion:
> {noformat}
> Assert.assertEquals(failFast, threadExited)
> {noformat}
> The root cause for this is that when`testBytesWrittenRespectingLimit` writes
> some bytes on the local file system, some counters are being incremented. The
> problem is that, after the test is done, the counter is not reset. With this
> polluted shared state, assumptions are broken, resulting in test failure in
> the second run.
> PR link: https://github.com/apache/hadoop/pull/2500
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Updated] (MAPREDUCE-7311) Fix non-idempotent test in TestTaskProgressReporter
[
https://issues.apache.org/jira/browse/MAPREDUCE-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhengxi Li updated MAPREDUCE-7311:
--
Description:
The test
{{`org.apache.hadoop.mapred.TestTaskProgressReporter.testBytesWrittenRespectingLimit`}}
is not idempotent and fails if run twice in the same JVM, because it pollutes
state shared among tests. It may be good to clean this state pollution so that
some other tests do not fail in the future due to the shared state polluted by
this test.
h3. Details
Running {{`TestTaskProgressReporter.testBytesWrittenRespectingLimit`}} twice
would result in the second run failing with the following assertion:
{noformat}
Assert.assertEquals(failFast, threadExited)
{noformat}
The root cause for this is that when`testBytesWrittenRespectingLimit` writes
some bytes on the local file system, some counters are being incremented. The
problem is that, after the test is done, the counter is not reset. With this
polluted shared state, assumptions are broken, resulting in test failure in the
second run.
was:
The test
{{`org.apache.hadoop.mapred.TestTaskProgressReporter.testBytesWrittenRespectingLimit`}}
is not idempotent and fails if run twice in the same JVM, because it pollutes
state shared among tests. It may be good to clean this state pollution so that
some other tests do not fail in the future due to the shared state polluted by
this test.
h3. Details
Running {{`TestTaskProgressReporter.testBytesWrittenRespectingLimit`}} twice
would result in the second run failing with the following assertion:
{noformat}
Assert.assertEquals(failFast, threadExited)
{noformat}
The root cause for this is that when\{{`testBytesWrittenRespectingLimit`}}
writes some bytes on the local file system, some counters are being
incremented. The problem is that, after the test is done, the counter is not
reset. With this polluted shared state, assumptions are broken, resulting in
test failure in the second run.
> Fix non-idempotent test in TestTaskProgressReporter
> ---
>
> Key: MAPREDUCE-7311
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7311
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Reporter: Zhengxi Li
>Priority: Minor
>
> The test
> {{`org.apache.hadoop.mapred.TestTaskProgressReporter.testBytesWrittenRespectingLimit`}}
> is not idempotent and fails if run twice in the same JVM, because it
> pollutes state shared among tests. It may be good to clean this state
> pollution so that some other tests do not fail in the future due to the
> shared state polluted by this test.
> h3. Details
> Running {{`TestTaskProgressReporter.testBytesWrittenRespectingLimit`}} twice
> would result in the second run failing with the following assertion:
> {noformat}
> Assert.assertEquals(failFast, threadExited)
> {noformat}
> The root cause for this is that when`testBytesWrittenRespectingLimit` writes
> some bytes on the local file system, some counters are being incremented. The
> problem is that, after the test is done, the counter is not reset. With this
> polluted shared state, assumptions are broken, resulting in test failure in
> the second run.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Created] (MAPREDUCE-7311) Fix non-idempotent test in TestTaskProgressReporter
Zhengxi Li created MAPREDUCE-7311:
-
Summary: Fix non-idempotent test in TestTaskProgressReporter
Key: MAPREDUCE-7311
URL: https://issues.apache.org/jira/browse/MAPREDUCE-7311
Project: Hadoop Map/Reduce
Issue Type: Bug
Reporter: Zhengxi Li
The test
{{`org.apache.hadoop.mapred.TestTaskProgressReporter.testBytesWrittenRespectingLimit`}}
is not idempotent and fails if run twice in the same JVM, because it pollutes
state shared among tests. It may be good to clean this state pollution so that
some other tests do not fail in the future due to the shared state polluted by
this test.
h3. Details
Running {{`TestTaskProgressReporter.testBytesWrittenRespectingLimit`}} twice
would result in the second run failing with the following assertion:
{noformat}
Assert.assertEquals(failFast, threadExited)
{noformat}
The root cause for this is that when\{{`testBytesWrittenRespectingLimit`}}
writes some bytes on the local file system, some counters are being
incremented. The problem is that, after the test is done, the counter is not
reset. With this polluted shared state, assumptions are broken, resulting in
test failure in the second run.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Updated] (MAPREDUCE-7310) Fix flaky test TestJobHistoryEventHandler.testSigTermedFunctionality
[
https://issues.apache.org/jira/browse/MAPREDUCE-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhengxi Li updated MAPREDUCE-7310:
--
Status: Patch Available (was: Open)
> Fix flaky test TestJobHistoryEventHandler.testSigTermedFunctionality
>
>
> Key: MAPREDUCE-7310
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7310
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Reporter: Zhengxi Li
>Priority: Minor
> Attachments: MAPREDUCE-7310.001.patch
>
>
> The test
> '{{org.apache.hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler.testSigTermedFunctionality'}}
> is not idempotent and fails if run twice in the same JVM, because it
> pollutes state shared among tests. It may be good to clean this state
> pollution so that some other tests do not fail in the future due to the
> shared state polluted by this test.
> h3. Details
> Running `TestJobHistoryEventHandler.testSigTermedFunctionality` twice would
> result in the second run failing due to `NullPointerException`shown in the
> following:
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.hadoop.mapreduce.jobhistory.JobHistoryEventHandler.serviceStop(JobHistoryEventHandler.java:460)
> at org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
> at
> org.apache.hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler.testSigTermedFunctionality(TestJobHistoryEventHandler.java:933)
> {noformat}
> The root cause of this is that running
> '{{TestJobHistoryEventHandler.testSigTermedFunctionality'}} results in some
> entries to be added to the static '{{JobHistoryEventHandler.fileMap'}}. The
> entries in the '{{fileMap'}} are not cleaned up when the test is done,
> resulting in a NullPointerException in the second run as the stale
> object(added in the first run) in the 'fileMap' is accessed.
>
> PR link: https://github.com/apache/hadoop/pull/2499
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Updated] (MAPREDUCE-7310) Fix flaky test TestJobHistoryEventHandler.testSigTermedFunctionality
[
https://issues.apache.org/jira/browse/MAPREDUCE-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhengxi Li updated MAPREDUCE-7310:
--
Attachment: MAPREDUCE-7310.001.patch
> Fix flaky test TestJobHistoryEventHandler.testSigTermedFunctionality
>
>
> Key: MAPREDUCE-7310
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7310
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Reporter: Zhengxi Li
>Priority: Minor
> Attachments: MAPREDUCE-7310.001.patch
>
>
> The test
> '{{org.apache.hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler.testSigTermedFunctionality'}}
> is not idempotent and fails if run twice in the same JVM, because it
> pollutes state shared among tests. It may be good to clean this state
> pollution so that some other tests do not fail in the future due to the
> shared state polluted by this test.
> h3. Details
> Running `TestJobHistoryEventHandler.testSigTermedFunctionality` twice would
> result in the second run failing due to `NullPointerException`shown in the
> following:
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.hadoop.mapreduce.jobhistory.JobHistoryEventHandler.serviceStop(JobHistoryEventHandler.java:460)
> at org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
> at
> org.apache.hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler.testSigTermedFunctionality(TestJobHistoryEventHandler.java:933)
> {noformat}
> The root cause of this is that running
> '{{TestJobHistoryEventHandler.testSigTermedFunctionality'}} results in some
> entries to be added to the static '{{JobHistoryEventHandler.fileMap'}}. The
> entries in the '{{fileMap'}} are not cleaned up when the test is done,
> resulting in a NullPointerException in the second run as the stale
> object(added in the first run) in the 'fileMap' is accessed.
>
> PR link: https://github.com/apache/hadoop/pull/2499
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Updated] (MAPREDUCE-7310) Fix flaky test TestJobHistoryEventHandler.testSigTermedFunctionality
[
https://issues.apache.org/jira/browse/MAPREDUCE-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhengxi Li updated MAPREDUCE-7310:
--
Description:
The test
'{{org.apache.hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler.testSigTermedFunctionality'}}
is not idempotent and fails if run twice in the same JVM, because it pollutes
state shared among tests. It may be good to clean this state pollution so that
some other tests do not fail in the future due to the shared state polluted by
this test.
h3. Details
Running `TestJobHistoryEventHandler.testSigTermedFunctionality` twice would
result in the second run failing due to `NullPointerException`shown in the
following:
{noformat}
java.lang.NullPointerException
at
org.apache.hadoop.mapreduce.jobhistory.JobHistoryEventHandler.serviceStop(JobHistoryEventHandler.java:460)
at org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
at
org.apache.hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler.testSigTermedFunctionality(TestJobHistoryEventHandler.java:933)
{noformat}
The root cause of this is that running
'{{TestJobHistoryEventHandler.testSigTermedFunctionality'}} results in some
entries to be added to the static '{{JobHistoryEventHandler.fileMap'}}. The
entries in the '{{fileMap'}} are not cleaned up when the test is done,
resulting in a NullPointerException in the second run as the stale object(added
in the first run) in the 'fileMap' is accessed.
PR link: https://github.com/apache/hadoop/pull/2499
was:
The test
'{{org.apache.hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler.testSigTermedFunctionality'}}
is not idempotent and fails if run twice in the same JVM, because it pollutes
state shared among tests. It may be good to clean this state pollution so that
some other tests do not fail in the future due to the shared state polluted by
this test.
h3. Details
Running `TestJobHistoryEventHandler.testSigTermedFunctionality` twice would
result in the second run failing due to `NullPointerException`shown in the
following:
{noformat}
java.lang.NullPointerException
at
org.apache.hadoop.mapreduce.jobhistory.JobHistoryEventHandler.serviceStop(JobHistoryEventHandler.java:460)
at org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
at
org.apache.hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler.testSigTermedFunctionality(TestJobHistoryEventHandler.java:933)
{noformat}
The root cause of this is that running
'{{TestJobHistoryEventHandler.testSigTermedFunctionality'}} results in some
entries to be added to the static '{{JobHistoryEventHandler.fileMap'}}. The
entries in the '{{fileMap'}} are not cleaned up when the test is done,
resulting in a NullPointerException in the second run as the stale object(added
in the first run) in the 'fileMap' is accessed.
> Fix flaky test TestJobHistoryEventHandler.testSigTermedFunctionality
>
>
> Key: MAPREDUCE-7310
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7310
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Reporter: Zhengxi Li
>Priority: Minor
>
> The test
> '{{org.apache.hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler.testSigTermedFunctionality'}}
> is not idempotent and fails if run twice in the same JVM, because it
> pollutes state shared among tests. It may be good to clean this state
> pollution so that some other tests do not fail in the future due to the
> shared state polluted by this test.
> h3. Details
> Running `TestJobHistoryEventHandler.testSigTermedFunctionality` twice would
> result in the second run failing due to `NullPointerException`shown in the
> following:
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.hadoop.mapreduce.jobhistory.JobHistoryEventHandler.serviceStop(JobHistoryEventHandler.java:460)
> at org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
> at
> org.apache.hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler.testSigTermedFunctionality(TestJobHistoryEventHandler.java:933)
> {noformat}
> The root cause of this is that running
> '{{TestJobHistoryEventHandler.testSigTermedFunctionality'}} results in some
> entries to be added to the static '{{JobHistoryEventHandler.fileMap'}}. The
> entries in the '{{fileMap'}} are not cleaned up when the test is done,
> resulting in a NullPointerException in the second run as the stale
> object(added in the first run) in the 'fileMap' is accessed.
>
> PR link: https://github.com/apache/hadoop/pull/2499
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Created] (MAPREDUCE-7310) Fix flaky test TestJobHistoryEventHandler.testSigTermedFunctionality
Zhengxi Li created MAPREDUCE-7310:
-
Summary: Fix flaky test
TestJobHistoryEventHandler.testSigTermedFunctionality
Key: MAPREDUCE-7310
URL: https://issues.apache.org/jira/browse/MAPREDUCE-7310
Project: Hadoop Map/Reduce
Issue Type: Bug
Reporter: Zhengxi Li
The test
'{{org.apache.hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler.testSigTermedFunctionality'}}
is not idempotent and fails if run twice in the same JVM, because it pollutes
state shared among tests. It may be good to clean this state pollution so that
some other tests do not fail in the future due to the shared state polluted by
this test.
h3. Details
Running `TestJobHistoryEventHandler.testSigTermedFunctionality` twice would
result in the second run failing due to `NullPointerException`shown in the
following:
{noformat}
java.lang.NullPointerException
at
org.apache.hadoop.mapreduce.jobhistory.JobHistoryEventHandler.serviceStop(JobHistoryEventHandler.java:460)
at org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
at
org.apache.hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler.testSigTermedFunctionality(TestJobHistoryEventHandler.java:933)
{noformat}
The root cause of this is that running
'{{TestJobHistoryEventHandler.testSigTermedFunctionality'}} results in some
entries to be added to the static '{{JobHistoryEventHandler.fileMap'}}. The
entries in the '{{fileMap'}} are not cleaned up when the test is done,
resulting in a NullPointerException in the second run as the stale object(added
in the first run) in the 'fileMap' is accessed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
