[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202440#comment-16202440
]
Hudson commented on MAPREDUCE-5951:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13078
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202418#comment-16202418
]
Chris Trezzo commented on MAPREDUCE-5951:
-
Committed to trunk, branch-3.0 and branch-2. Thanks
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199540#comment-16199540
]
Sangjin Lee commented on MAPREDUCE-5951:
+1. Thanks for the great work and taking it to
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199008#comment-16199008
]
Chris Trezzo commented on MAPREDUCE-5951:
-
Thank you [~mingma] for the review! I will wait
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198205#comment-16198205
]
Ming Ma commented on MAPREDUCE-5951:
+1.
> Add support for the YARN Shared Cache
>
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194976#comment-16194976
]
Chris Trezzo commented on MAPREDUCE-5951:
-
Thanks for the comment [~mingma]!
bq. Should any
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194044#comment-16194044
]
Ming Ma commented on MAPREDUCE-5951:
Thanks [~ctrezzo]. The code looks good overall. The only
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193832#comment-16193832
]
Andrew Wang commented on MAPREDUCE-5951:
If it's going into 2.9.0, I think it's safe for 3.0.0
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193828#comment-16193828
]
Chris Trezzo commented on MAPREDUCE-5951:
-
Hi [~sjlee0], [~kasha], [~mingma], [~jlowe], and
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193573#comment-16193573
]
Chris Trezzo commented on MAPREDUCE-5951:
-
This is the javac warning:
{noformat}
[WARNING]
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192255#comment-16192255
]
Hadoop QA commented on MAPREDUCE-5951:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191196#comment-16191196
]
Hadoop QA commented on MAPREDUCE-5951:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189232#comment-16189232
]
Hadoop QA commented on MAPREDUCE-5951:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989545#comment-15989545
]
Chris Trezzo commented on MAPREDUCE-5951:
-
[~xkrogen]
bq. Is this so that the uploading to
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989035#comment-15989035
]
Erik Krogen commented on MAPREDUCE-5951:
Ah, excellent point, [~jlowe]... I actually would
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988744#comment-15988744
]
Jason Lowe commented on MAPREDUCE-5951:
---
I don't think it really matters whether the jar
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987897#comment-15987897
]
Chris Trezzo commented on MAPREDUCE-5951:
-
Thanks [~xkrogen] for the comment!
bq. is this an
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987585#comment-15987585
]
Erik Krogen commented on MAPREDUCE-5951:
Hey [~ctrezzo], I have a question about the behavior
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15948071#comment-15948071
]
Chris Trezzo commented on MAPREDUCE-5951:
-
This issue is currently waiting on MAPREDUCE-6862
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830767#comment-15830767
]
Chris Trezzo commented on MAPREDUCE-5951:
-
Note: currently this patch depends on how YARN-3637
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15829326#comment-15829326
]
Chris Trezzo commented on MAPREDUCE-5951:
-
These are the same 3 checkstyle warnings I
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15829318#comment-15829318
]
Hadoop QA commented on MAPREDUCE-5951:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819182#comment-15819182
]
Chris Trezzo commented on MAPREDUCE-5951:
-
Thanks [~sjlee0] for the review! I will work on v19
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817206#comment-15817206
]
Sangjin Lee commented on MAPREDUCE-5951:
I went over the patch with Chris in some detail
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15755575#comment-15755575
]
Chris Trezzo commented on MAPREDUCE-5951:
-
I have filed MAPREDUCE-6825 and MAPREDUCE-6824 to
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15755545#comment-15755545
]
Hadoop QA commented on MAPREDUCE-5951:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15750389#comment-15750389
]
Hadoop QA commented on MAPREDUCE-5951:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15746848#comment-15746848
]
Hadoop QA commented on MAPREDUCE-5951:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625083#comment-14625083
]
Sangjin Lee commented on MAPREDUCE-5951:
Thanks for the clarification
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624967#comment-14624967
]
Chris Trezzo commented on MAPREDUCE-5951:
-
Findbugs run was clean this time so
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625334#comment-14625334
]
Sangjin Lee commented on MAPREDUCE-5951:
That sounds fine with me. Thanks!
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625311#comment-14625311
]
Chris Trezzo commented on MAPREDUCE-5951:
-
[~sjlee0] thanks for pointing out
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14622675#comment-14622675
]
Sangjin Lee commented on MAPREDUCE-5951:
I've seen several cases where the
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14622856#comment-14622856
]
Hadoop QA commented on MAPREDUCE-5951:
--
\\
\\
| (x) *{color:red}-1
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621524#comment-14621524
]
Hadoop QA commented on MAPREDUCE-5951:
--
\\
\\
| (x) *{color:red}-1
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14619614#comment-14619614
]
Chris Trezzo commented on MAPREDUCE-5951:
-
Investigating
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14616112#comment-14616112
]
Hadoop QA commented on MAPREDUCE-5951:
--
\\
\\
| (x) *{color:red}-1
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14616148#comment-14616148
]
Hadoop QA commented on MAPREDUCE-5951:
--
\\
\\
| (x) *{color:red}-1
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14546352#comment-14546352
]
Karthik Kambatla commented on MAPREDUCE-5951:
-
Nice to see the patch size
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14546303#comment-14546303
]
Chris Trezzo commented on MAPREDUCE-5951:
-
1. All checkstyle errors (except
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14546261#comment-14546261
]
Hadoop QA commented on MAPREDUCE-5951:
--
\\
\\
| (x) *{color:red}-1
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542053#comment-14542053
]
Karthik Kambatla commented on MAPREDUCE-5951:
-
The latest patch is
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542840#comment-14542840
]
Jason Lowe commented on MAPREDUCE-5951:
---
bq. MRApps - we are using * instead of
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542904#comment-14542904
]
Chris Trezzo commented on MAPREDUCE-5951:
-
1. [~kasha] I have thought about
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14543022#comment-14543022
]
Chris Trezzo commented on MAPREDUCE-5951:
-
Note for the above calculation: We
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14543038#comment-14543038
]
Chris Trezzo commented on MAPREDUCE-5951:
-
Another note about removal of the
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541415#comment-14541415
]
Hadoop QA commented on MAPREDUCE-5951:
--
\\
\\
| (x) *{color:red}-1
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14540396#comment-14540396
]
Karthik Kambatla commented on MAPREDUCE-5951:
-
Sorry again for the delay
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14540464#comment-14540464
]
Hadoop QA commented on MAPREDUCE-5951:
--
\\
\\
| (x) *{color:red}-1
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541107#comment-14541107
]
Karthik Kambatla commented on MAPREDUCE-5951:
-
Thanks Chris.
Comments on
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541205#comment-14541205
]
Hadoop QA commented on MAPREDUCE-5951:
--
\\
\\
| (x) *{color:red}-1
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14540848#comment-14540848
]
Chris Trezzo commented on MAPREDUCE-5951:
-
Added YARN-3637 to address
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14366721#comment-14366721
]
Hadoop QA commented on MAPREDUCE-5951:
--
{color:green}+1 overall{color}. Here are
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14366656#comment-14366656
]
Hadoop QA commented on MAPREDUCE-5951:
--
{color:red}-1 overall{color}. Here are
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14338912#comment-14338912
]
Chris Trezzo commented on MAPREDUCE-5951:
-
Created MAPREDUCE-6267 to address
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14319375#comment-14319375
]
Karthik Kambatla commented on MAPREDUCE-5951:
-
Sorry for the delay in
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14284690#comment-14284690
]
Hadoop QA commented on MAPREDUCE-5951:
--
{color:red}-1 overall{color}. Here are
[
https://issues.apache.org/jira/browse/MAPREDUCE-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14103104#comment-14103104
]
Chris Trezzo commented on MAPREDUCE-5951:
-
Note: #2 is only in the case where
58 matches
Mail list logo
