[jira] [Commented] (MAPREDUCE-7344) Improve logging by removing string Concatenation and change level of logs from INFO to WARN
[ https://issues.apache.org/jira/browse/MAPREDUCE-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564505#comment-17564505 ] Ashutosh Gupta commented on MAPREDUCE-7344: --- Hi [~dmmkr] - Are you working on it or as suggested by [~brahmareddy] - I can break it up into subtasks for each module and take things forward ? > Improve logging by removing string Concatenation and change level of logs > from INFO to WARN > --- > > Key: MAPREDUCE-7344 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7344 > Project: Hadoop Map/Reduce > Issue Type: Improvement >Reporter: D M Murali Krishna Reddy >Assignee: D M Murali Krishna Reddy >Priority: Minor > Attachments: MAPREDUCE-7344.001.patch, MAPREDUCE-7344.002.patch > > > 1. Currently in few of debug logs string Concatenation is performed without > any debug check, this can be fixed by passing the variables as arguments. > 2. Few logs while catching exception can be moved from INFO to WARN. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7344) Improve logging by removing string Concatenation and change level of logs from INFO to WARN
[ https://issues.apache.org/jira/browse/MAPREDUCE-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564503#comment-17564503 ] Ashutosh Gupta commented on MAPREDUCE-7344: --- Hi @[~dmmkr] - Are you working it or I can take it forward ? [~brahmareddy] - Just wanted to double check with you - It seems all part of `hadoop-mapreduce-project`. Are you suggesting to break into sub tasks for different modules of hadoop-mapreduce-project? > Improve logging by removing string Concatenation and change level of logs > from INFO to WARN > --- > > Key: MAPREDUCE-7344 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7344 > Project: Hadoop Map/Reduce > Issue Type: Improvement >Reporter: D M Murali Krishna Reddy >Assignee: D M Murali Krishna Reddy >Priority: Minor > Attachments: MAPREDUCE-7344.001.patch, MAPREDUCE-7344.002.patch > > > 1. Currently in few of debug logs string Concatenation is performed without > any debug check, this can be fixed by passing the variables as arguments. > 2. Few logs while catching exception can be moved from INFO to WARN. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7344) Improve logging by removing string Concatenation and change level of logs from INFO to WARN
[ https://issues.apache.org/jira/browse/MAPREDUCE-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17346398#comment-17346398 ] Brahma Reddy Battula commented on MAPREDUCE-7344: - [~dmmkr] How about splitting this task to module wise..? > Improve logging by removing string Concatenation and change level of logs > from INFO to WARN > --- > > Key: MAPREDUCE-7344 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7344 > Project: Hadoop Map/Reduce > Issue Type: Improvement >Reporter: D M Murali Krishna Reddy >Assignee: D M Murali Krishna Reddy >Priority: Minor > Attachments: MAPREDUCE-7344.001.patch, MAPREDUCE-7344.002.patch > > > 1. Currently in few of debug logs string Concatenation is performed without > any debug check, this can be fixed by passing the variables as arguments. > 2. Few logs while catching exception can be moved from INFO to WARN. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7344) Improve logging by removing string Concatenation and change level of logs from INFO to WARN
[ https://issues.apache.org/jira/browse/MAPREDUCE-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340380#comment-17340380 ] D M Murali Krishna Reddy commented on MAPREDUCE-7344: - [~ebadger] Can you review the above patch. Thanks. > Improve logging by removing string Concatenation and change level of logs > from INFO to WARN > --- > > Key: MAPREDUCE-7344 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7344 > Project: Hadoop Map/Reduce > Issue Type: Improvement >Reporter: D M Murali Krishna Reddy >Assignee: D M Murali Krishna Reddy >Priority: Minor > Attachments: MAPREDUCE-7344.001.patch, MAPREDUCE-7344.002.patch > > > 1. Currently in few of debug logs string Concatenation is performed without > any debug check, this can be fixed by passing the variables as arguments. > 2. Few logs while catching exception can be moved from INFO to WARN. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7344) Improve logging by removing string Concatenation and change level of logs from INFO to WARN
[ https://issues.apache.org/jira/browse/MAPREDUCE-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339653#comment-17339653 ] D M Murali Krishna Reddy commented on MAPREDUCE-7344: - [~BilwaST] [~brahmareddy] can you review the above patch. > Improve logging by removing string Concatenation and change level of logs > from INFO to WARN > --- > > Key: MAPREDUCE-7344 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7344 > Project: Hadoop Map/Reduce > Issue Type: Improvement >Reporter: D M Murali Krishna Reddy >Assignee: D M Murali Krishna Reddy >Priority: Minor > Attachments: MAPREDUCE-7344.001.patch, MAPREDUCE-7344.002.patch > > > 1. Currently in few of debug logs string Concatenation is performed without > any debug check, this can be fixed by passing the variables as arguments. > 2. Few logs while catching exception can be moved from INFO to WARN. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7344) Improve logging by removing string Concatenation and change level of logs from INFO to WARN
[
https://issues.apache.org/jira/browse/MAPREDUCE-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339533#comment-17339533
]
Hadoop QA commented on MAPREDUCE-7344:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Logfile || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
43s{color} | {color:blue}{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} || ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
1s{color} | {color:green}{color} | {color:green} No case conflicting files
found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green}{color} | {color:green} The patch does not contain any
@author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red}{color} | {color:red} The patch doesn't appear to
include any new or modified tests. Please justify why no new tests are needed
for this patch. Also please list what manual steps were performed to verify
this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} || ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 11m
26s{color} | {color:blue}{color} | {color:blue} Maven dependency ordering for
branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 20m
4s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
28s{color} | {color:green}{color} | {color:green} trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
5s{color} | {color:green}{color} | {color:green} trunk passed with JDK Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
42s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 4m
7s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
18m 57s{color} | {color:green}{color} | {color:green} branch has no errors when
building and testing our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
19s{color} | {color:green}{color} | {color:green} trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
6s{color} | {color:green}{color} | {color:green} trunk passed with JDK Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 31m
15s{color} | {color:blue}{color} | {color:blue} Both FindBugs and SpotBugs are
enabled, using SpotBugs. {color} |
| {color:green}+1{color} | {color:green} spotbugs {color} | {color:green} 6m
8s{color} | {color:green}{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} || ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
25s{color} | {color:blue}{color} | {color:blue} Maven dependency ordering for
patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
14s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
21s{color} | {color:green}{color} | {color:green} the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
21s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
58s{color} | {color:green}{color} | {color:green} the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
58s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
1m 34s{color} |
{color:orange}https://ci-hadoop.apache.org/job/PreCommit-MAPREDUCE-Build/76/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt{color}
| {color:orange} hadoop-mapreduce-project/hadoop-mapreduce-client: The patch
generated 1 new + 1731 unchanged - 6 fixed = 1732 total (was 1737) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 3m
11s{color} | {color:green}{color} | {color:green} the patch passed {color} |
|
[jira] [Commented] (MAPREDUCE-7344) Improve logging by removing string Concatenation and change level of logs from INFO to WARN
[
https://issues.apache.org/jira/browse/MAPREDUCE-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339370#comment-17339370
]
Hadoop QA commented on MAPREDUCE-7344:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Logfile || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 14m
16s{color} | {color:blue}{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} || ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
1s{color} | {color:green}{color} | {color:green} No case conflicting files
found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green}{color} | {color:green} The patch does not contain any
@author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red}{color} | {color:red} The patch doesn't appear to
include any new or modified tests. Please justify why no new tests are needed
for this patch. Also please list what manual steps were performed to verify
this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} || ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 3m
58s{color} | {color:blue}{color} | {color:blue} Maven dependency ordering for
branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 20m
20s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
28s{color} | {color:green}{color} | {color:green} trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
6s{color} | {color:green}{color} | {color:green} trunk passed with JDK Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
43s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 4m
5s{color} | {color:green}{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
18m 52s{color} | {color:green}{color} | {color:green} branch has no errors when
building and testing our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
19s{color} | {color:green}{color} | {color:green} trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
8s{color} | {color:green}{color} | {color:green} trunk passed with JDK Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 31m
15s{color} | {color:blue}{color} | {color:blue} Both FindBugs and SpotBugs are
enabled, using SpotBugs. {color} |
| {color:green}+1{color} | {color:green} spotbugs {color} | {color:green} 6m
8s{color} | {color:green}{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} || ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
27s{color} | {color:blue}{color} | {color:blue} Maven dependency ordering for
patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
13s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
19s{color} | {color:green}{color} | {color:green} the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
19s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
58s{color} | {color:green}{color} | {color:green} the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
58s{color} | {color:green}{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
1m 37s{color} |
{color:orange}https://ci-hadoop.apache.org/job/PreCommit-MAPREDUCE-Build/75/artifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt{color}
| {color:orange} hadoop-mapreduce-project/hadoop-mapreduce-client: The patch
generated 5 new + 1731 unchanged - 6 fixed = 1736 total (was 1737) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 3m
10s{color} | {color:green}{color} | {color:green} the patch passed {color} |
|
