[jira] [Commented] (MAPREDUCE-7050) Debug logs should be improvement
[
https://issues.apache.org/jira/browse/MAPREDUCE-7050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378285#comment-16378285
]
Hadoop QA commented on MAPREDUCE-7050:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 10m
6s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 13 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
48s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 16m
51s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
1s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
48s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 3m
41s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
13m 14s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
50s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
33s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
8s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
51s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 46s{color} | {color:orange} hadoop-mapreduce-project: The patch generated 2
new + 1995 unchanged - 5 fixed = 1997 total (was 2000) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 3m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 7s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
36s{color} | {color:green} hadoop-mapreduce-client-core in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
48s{color} | {color:green} hadoop-mapreduce-client-common in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
22s{color} | {color:green} hadoop-mapreduce-client-shuffle in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 9m
0s{color} | {color:green} hadoop-mapreduce-client-app in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
4s{color} | {color:green} hadoop-mapreduce-client-hs in the patch passed.
{color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}126m 15s{color}
| {color:red} hadoop-mapreduce-client-jobclient in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
11s{color} | {color:green} hadoop-mapreduce-client-nativetask in the patch
passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
29s{color} | {color:green} hadoop-mapreduce-client-uploader in the patch
passed. {color} |
| {color:green}+1{color} | {color:green} unit {color}
[jira] [Commented] (MAPREDUCE-7050) Debug logs should be improvement
[
https://issues.apache.org/jira/browse/MAPREDUCE-7050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359243#comment-16359243
]
Igor Dvorzhak commented on MAPREDUCE-7050:
--
In case you plan to do a large scale change you can consider to use Log4j v2
with its support of lazy-logging with Java 8 lambdas
(https://logging.apache.org/log4j/2.x/manual/api.html#LambdaSupport):
{code:java}
logger.trace("Some long-running operation returned {}", () ->
expensiveOperation());
{code}
> Debug logs should be improvement
>
>
> Key: MAPREDUCE-7050
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7050
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
>Reporter: Sen Zhao
>Priority: Minor
>
> I noticed that in Mapreduced code, there are many places to use Log.debug as
> follows:
> {code}
> LOG.debug("example " + example.getClass().getName() + "example" );
> {code}
> When the system loglevel set higher than Debug, although the system does not
> print these levels of logs, but each time will splicing parameters string,
> affect system performance.
> It should be:
> {code}
> if(LOG.isDebugEnabled()){
> LOG.debug("example " + example.getClass().getName() + "example" );
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7050) Debug logs should be improvement
[
https://issues.apache.org/jira/browse/MAPREDUCE-7050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359241#comment-16359241
]
Sen Zhao commented on MAPREDUCE-7050:
-
Could someone add me into the contributor list ? So that I can submit a patch.
> Debug logs should be improvement
>
>
> Key: MAPREDUCE-7050
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7050
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
>Reporter: Sen Zhao
>Priority: Minor
>
> I noticed that in Mapreduced code, there are many places to use Log.debug as
> follows:
> {code}
> LOG.debug("example " + example.getClass().getName() + "example" );
> {code}
> When the system loglevel set higher than Debug, although the system does not
> print these levels of logs, but each time will splicing parameters string,
> affect system performance.
> It should be:
> {code}
> if(LOG.isDebugEnabled()){
> LOG.debug("example " + example.getClass().getName() + "example" );
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
