[jira] [Updated] (MAPREDUCE-7197) Fix order of actual and expected expression in assert statements

2019-08-12 Thread Szilard Nemeth (JIRA) 


 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Szilard Nemeth updated MAPREDUCE-7197:
--
   Resolution: Fixed
 Hadoop Flags: Reviewed
Fix Version/s: 3.3.0
   Status: Resolved  (was: Patch Available)

> Fix order of actual and expected expression in assert statements
> 
>
> Key: MAPREDUCE-7197
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7197
> Project: Hadoop Map/Reduce
>  Issue Type: Improvement
>Affects Versions: 3.2.0
>Reporter: Adam Antal
>Assignee: Adam Antal
>Priority: Major
> Fix For: 3.3.0
>
> Attachments: MAPREDUCE-7197.001.patch, MAPREDUCE-7197.002.patch, 
> MAPREDUCE-7197.003.patch, MAPREDUCE-7197.004.patch, MAPREDUCE-7197.004.patch, 
> MAPREDUCE-7197.005.patch, MAPREDUCE-7197.006.patch, 
> old-approx-from-HADOOP-12693
>
>
> Fix order of actual and expected expression in assert statements which gives 
> misleading message when test case fails. Attached file has some of the places 
> where it is placed wrongly.
> {code:java}
> [ERROR] 
> testNodeRemovalGracefully(org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService)
>   Time elapsed: 3.385 s  <<< FAILURE!
> java.lang.AssertionError: Shutdown nodes should be 0 now expected:<1> but 
> was:<0>
> {code}
> For long term, [AssertJ|http://joel-costigliola.github.io/assertj/] can be 
> used for new test cases which avoids such mistakes.
> This is a follow-up Jira on the fix for the MR project.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

[jira] [Updated] (MAPREDUCE-7197) Fix order of actual and expected expression in assert statements

2019-08-08 Thread Adam Antal (JIRA) 


 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adam Antal updated MAPREDUCE-7197:
--
Attachment: MAPREDUCE-7197.006.patch

> Fix order of actual and expected expression in assert statements
> 
>
> Key: MAPREDUCE-7197
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7197
> Project: Hadoop Map/Reduce
>  Issue Type: Improvement
>Affects Versions: 3.2.0
>Reporter: Adam Antal
>Assignee: Adam Antal
>Priority: Major
> Attachments: MAPREDUCE-7197.001.patch, MAPREDUCE-7197.002.patch, 
> MAPREDUCE-7197.003.patch, MAPREDUCE-7197.004.patch, MAPREDUCE-7197.004.patch, 
> MAPREDUCE-7197.005.patch, MAPREDUCE-7197.006.patch, 
> old-approx-from-HADOOP-12693
>
>
> Fix order of actual and expected expression in assert statements which gives 
> misleading message when test case fails. Attached file has some of the places 
> where it is placed wrongly.
> {code:java}
> [ERROR] 
> testNodeRemovalGracefully(org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService)
>   Time elapsed: 3.385 s  <<< FAILURE!
> java.lang.AssertionError: Shutdown nodes should be 0 now expected:<1> but 
> was:<0>
> {code}
> For long term, [AssertJ|http://joel-costigliola.github.io/assertj/] can be 
> used for new test cases which avoids such mistakes.
> This is a follow-up Jira on the fix for the MR project.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

[jira] [Updated] (MAPREDUCE-7197) Fix order of actual and expected expression in assert statements

2019-08-07 Thread Adam Antal (JIRA) 


 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adam Antal updated MAPREDUCE-7197:
--
Attachment: MAPREDUCE-7197.005.patch

> Fix order of actual and expected expression in assert statements
> 
>
> Key: MAPREDUCE-7197
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7197
> Project: Hadoop Map/Reduce
>  Issue Type: Improvement
>Affects Versions: 3.2.0
>Reporter: Adam Antal
>Assignee: Adam Antal
>Priority: Major
> Attachments: MAPREDUCE-7197.001.patch, MAPREDUCE-7197.002.patch, 
> MAPREDUCE-7197.003.patch, MAPREDUCE-7197.004.patch, MAPREDUCE-7197.004.patch, 
> MAPREDUCE-7197.005.patch, old-approx-from-HADOOP-12693
>
>
> Fix order of actual and expected expression in assert statements which gives 
> misleading message when test case fails. Attached file has some of the places 
> where it is placed wrongly.
> {code:java}
> [ERROR] 
> testNodeRemovalGracefully(org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService)
>   Time elapsed: 3.385 s  <<< FAILURE!
> java.lang.AssertionError: Shutdown nodes should be 0 now expected:<1> but 
> was:<0>
> {code}
> For long term, [AssertJ|http://joel-costigliola.github.io/assertj/] can be 
> used for new test cases which avoids such mistakes.
> This is a follow-up Jira on the fix for the MR project.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

[jira] [Updated] (MAPREDUCE-7197) Fix order of actual and expected expression in assert statements

2019-08-02 Thread Szilard Nemeth (JIRA) 


 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Szilard Nemeth updated MAPREDUCE-7197:
--
Attachment: MAPREDUCE-7197.004.patch

> Fix order of actual and expected expression in assert statements
> 
>
> Key: MAPREDUCE-7197
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7197
> Project: Hadoop Map/Reduce
>  Issue Type: Improvement
>Affects Versions: 3.2.0
>Reporter: Adam Antal
>Assignee: Adam Antal
>Priority: Major
> Attachments: MAPREDUCE-7197.001.patch, MAPREDUCE-7197.002.patch, 
> MAPREDUCE-7197.003.patch, MAPREDUCE-7197.004.patch, MAPREDUCE-7197.004.patch, 
> old-approx-from-HADOOP-12693
>
>
> Fix order of actual and expected expression in assert statements which gives 
> misleading message when test case fails. Attached file has some of the places 
> where it is placed wrongly.
> {code:java}
> [ERROR] 
> testNodeRemovalGracefully(org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService)
>   Time elapsed: 3.385 s  <<< FAILURE!
> java.lang.AssertionError: Shutdown nodes should be 0 now expected:<1> but 
> was:<0>
> {code}
> For long term, [AssertJ|http://joel-costigliola.github.io/assertj/] can be 
> used for new test cases which avoids such mistakes.
> This is a follow-up Jira on the fix for the MR project.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

[jira] [Updated] (MAPREDUCE-7197) Fix order of actual and expected expression in assert statements

2019-07-03 Thread Adam Antal (JIRA) 


 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adam Antal updated MAPREDUCE-7197:
--
Attachment: MAPREDUCE-7197.004.patch

> Fix order of actual and expected expression in assert statements
> 
>
> Key: MAPREDUCE-7197
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7197
> Project: Hadoop Map/Reduce
>  Issue Type: Improvement
>Affects Versions: 3.2.0
>Reporter: Adam Antal
>Assignee: Adam Antal
>Priority: Major
> Attachments: MAPREDUCE-7197.001.patch, MAPREDUCE-7197.002.patch, 
> MAPREDUCE-7197.003.patch, MAPREDUCE-7197.004.patch, 
> old-approx-from-HADOOP-12693
>
>
> Fix order of actual and expected expression in assert statements which gives 
> misleading message when test case fails. Attached file has some of the places 
> where it is placed wrongly.
> {code:java}
> [ERROR] 
> testNodeRemovalGracefully(org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService)
>   Time elapsed: 3.385 s  <<< FAILURE!
> java.lang.AssertionError: Shutdown nodes should be 0 now expected:<1> but 
> was:<0>
> {code}
> For long term, [AssertJ|http://joel-costigliola.github.io/assertj/] can be 
> used for new test cases which avoids such mistakes.
> This is a follow-up Jira on the fix for the MR project.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

[jira] [Updated] (MAPREDUCE-7197) Fix order of actual and expected expression in assert statements

2019-07-02 Thread Adam Antal (JIRA) 


 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adam Antal updated MAPREDUCE-7197:
--
Attachment: MAPREDUCE-7197.003.patch

> Fix order of actual and expected expression in assert statements
> 
>
> Key: MAPREDUCE-7197
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7197
> Project: Hadoop Map/Reduce
>  Issue Type: Improvement
>Affects Versions: 3.2.0
>Reporter: Adam Antal
>Assignee: Adam Antal
>Priority: Major
> Attachments: MAPREDUCE-7197.001.patch, MAPREDUCE-7197.002.patch, 
> MAPREDUCE-7197.003.patch, old-approx-from-HADOOP-12693
>
>
> Fix order of actual and expected expression in assert statements which gives 
> misleading message when test case fails. Attached file has some of the places 
> where it is placed wrongly.
> {code:java}
> [ERROR] 
> testNodeRemovalGracefully(org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService)
>   Time elapsed: 3.385 s  <<< FAILURE!
> java.lang.AssertionError: Shutdown nodes should be 0 now expected:<1> but 
> was:<0>
> {code}
> For long term, [AssertJ|http://joel-costigliola.github.io/assertj/] can be 
> used for new test cases which avoids such mistakes.
> This is a follow-up Jira on the fix for the MR project.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

[jira] [Updated] (MAPREDUCE-7197) Fix order of actual and expected expression in assert statements

2019-07-02 Thread Adam Antal (JIRA) 


 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adam Antal updated MAPREDUCE-7197:
--
Attachment: MAPREDUCE-7197.002.patch

> Fix order of actual and expected expression in assert statements
> 
>
> Key: MAPREDUCE-7197
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7197
> Project: Hadoop Map/Reduce
>  Issue Type: Improvement
>Affects Versions: 3.2.0
>Reporter: Adam Antal
>Assignee: Adam Antal
>Priority: Major
> Attachments: MAPREDUCE-7197.001.patch, MAPREDUCE-7197.002.patch, 
> old-approx-from-HADOOP-12693
>
>
> Fix order of actual and expected expression in assert statements which gives 
> misleading message when test case fails. Attached file has some of the places 
> where it is placed wrongly.
> {code:java}
> [ERROR] 
> testNodeRemovalGracefully(org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService)
>   Time elapsed: 3.385 s  <<< FAILURE!
> java.lang.AssertionError: Shutdown nodes should be 0 now expected:<1> but 
> was:<0>
> {code}
> For long term, [AssertJ|http://joel-costigliola.github.io/assertj/] can be 
> used for new test cases which avoids such mistakes.
> This is a follow-up Jira on the fix for the MR project.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

[jira] [Updated] (MAPREDUCE-7197) Fix order of actual and expected expression in assert statements

2019-07-02 Thread Adam Antal (JIRA) 


 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adam Antal updated MAPREDUCE-7197:
--
Status: Patch Available  (was: In Progress)

> Fix order of actual and expected expression in assert statements
> 
>
> Key: MAPREDUCE-7197
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7197
> Project: Hadoop Map/Reduce
>  Issue Type: Improvement
>Affects Versions: 3.2.0
>Reporter: Adam Antal
>Assignee: Adam Antal
>Priority: Major
> Attachments: MAPREDUCE-7197.001.patch, old-approx-from-HADOOP-12693
>
>
> Fix order of actual and expected expression in assert statements which gives 
> misleading message when test case fails. Attached file has some of the places 
> where it is placed wrongly.
> {code:java}
> [ERROR] 
> testNodeRemovalGracefully(org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService)
>   Time elapsed: 3.385 s  <<< FAILURE!
> java.lang.AssertionError: Shutdown nodes should be 0 now expected:<1> but 
> was:<0>
> {code}
> For long term, [AssertJ|http://joel-costigliola.github.io/assertj/] can be 
> used for new test cases which avoids such mistakes.
> This is a follow-up Jira on the fix for the MR project.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

[jira] [Updated] (MAPREDUCE-7197) Fix order of actual and expected expression in assert statements

2019-07-01 Thread Adam Antal (JIRA) 


 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adam Antal updated MAPREDUCE-7197:
--
Attachment: MAPREDUCE-7197.001.patch

> Fix order of actual and expected expression in assert statements
> 
>
> Key: MAPREDUCE-7197
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7197
> Project: Hadoop Map/Reduce
>  Issue Type: Improvement
>Affects Versions: 3.2.0
>Reporter: Adam Antal
>Assignee: Adam Antal
>Priority: Major
> Attachments: MAPREDUCE-7197.001.patch, old-approx-from-HADOOP-12693
>
>
> Fix order of actual and expected expression in assert statements which gives 
> misleading message when test case fails. Attached file has some of the places 
> where it is placed wrongly.
> {code:java}
> [ERROR] 
> testNodeRemovalGracefully(org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService)
>   Time elapsed: 3.385 s  <<< FAILURE!
> java.lang.AssertionError: Shutdown nodes should be 0 now expected:<1> but 
> was:<0>
> {code}
> For long term, [AssertJ|http://joel-costigliola.github.io/assertj/] can be 
> used for new test cases which avoids such mistakes.
> This is a follow-up Jira on the fix for the MR project.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

[jira] [Updated] (MAPREDUCE-7197) Fix order of actual and expected expression in assert statements

2019-04-18 Thread Adam Antal (JIRA) 


 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adam Antal updated MAPREDUCE-7197:
--
Attachment: old-approx-from-HADOOP-12693

> Fix order of actual and expected expression in assert statements
> 
>
> Key: MAPREDUCE-7197
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7197
> Project: Hadoop Map/Reduce
>  Issue Type: Improvement
>Affects Versions: 3.2.0
>Reporter: Adam Antal
>Assignee: Adam Antal
>Priority: Major
> Attachments: old-approx-from-HADOOP-12693
>
>
> Fix order of actual and expected expression in assert statements which gives 
> misleading message when test case fails. Attached file has some of the places 
> where it is placed wrongly.
> {code:java}
> [ERROR] 
> testNodeRemovalGracefully(org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService)
>   Time elapsed: 3.385 s  <<< FAILURE!
> java.lang.AssertionError: Shutdown nodes should be 0 now expected:<1> but 
> was:<0>
> {code}
> For long term, [AssertJ|http://joel-costigliola.github.io/assertj/] can be 
> used for new test cases which avoids such mistakes.
> This is a follow-up Jira on the fix for the MR project.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org