Re: [Marble-devel] Review Request 124666: Added stacking to Marble Maps

2015-08-16 Thread Gábor Péterffy
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124666/ --- (Updated Aug. 16, 2015, 4:12 p.m.) Review request for Marble, Mihail

Re: [Marble-devel] Review Request 124570: gsoc: Keeping OsmPlacemarkData synchronized with geometries while editing

2015-08-16 Thread Marius Stanciu
On Aug. 3, 2015, 11:22 a.m., Dennis Nienhüser wrote: src/lib/marble/osm/OsmPlacemarkData.cpp, line 181 https://git.reviewboard.kde.org/r/124570/diff/1/?file=388971#file388971line181 Did you consider moving from the QHash to a QVector (where the keys are implicitly given as

Re: [Marble-devel] Review Request 124570: gsoc: Keeping OsmPlacemarkData synchronized with geometries while editing

2015-08-16 Thread Marius Stanciu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124570/ --- (Updated Aug. 16, 2015, 4:55 p.m.) Review request for Marble. Changes

Re: [Marble-devel] Review Request 124522: gsoc: KML writer/handlers for OsmPlacemarkData objects

2015-08-16 Thread Marius Stanciu
On Aug. 6, 2015, 6:23 p.m., Marius Stanciu wrote: Can you check the various documentation snippets whether the mx: namespace is consistently included? you mean check marble's documentation ? or make sure KML standards allow declaring a namespace? - Marius

Re: [Marble-devel] Review Request 124666: Added stacking to Marble Maps

2015-08-16 Thread Dennis Nienhüser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124666/#review83886 --- I like the interaction with waypoints directly in the map. We

Re: [Marble-devel] Review Request 124775: gsoc: additional accesors and function name refactoring for the OsmPlacemarkData class

2015-08-16 Thread Dennis Nienhüser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124775/#review83890 --- Ship it! src/lib/marble/osm/OsmPlacemarkData.h (line 172)

Re: [Marble-devel] Review Request 124775: gsoc: additional accesors and function name refactoring for the OsmPlacemarkData class

2015-08-16 Thread Marius Stanciu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124775/ --- (Updated Aug. 16, 2015, 5:04 p.m.) Status -- This change has been

[Marble-devel] Jenkins-kde-ci: marble master kf5-qt5 » Linux,gcc - Build # 108 - Unstable!

2015-08-16 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/marble%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/108/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 16 Aug 2015 17:31:08 + Build duration: 25 min CHANGE SET Revision b0facbb668284acb65def96a6d8fb66f30442cbd by

[Marble-devel] Jenkins-kde-ci: marble master kf5-qt5 » Linux,gcc - Build # 108 - Unstable!

2015-08-16 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/marble%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/108/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 16 Aug 2015 17:31:08 + Build duration: 25 min CHANGE SET Revision b0facbb668284acb65def96a6d8fb66f30442cbd by

Re: [Marble-devel] Review Request 124522: gsoc: KML writer/handlers for OsmPlacemarkData objects

2015-08-16 Thread Dennis Nienhüser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124522/#review83892 --- Ship it! Ship It! - Dennis Nienhüser On Aug. 16, 2015,

Re: [Marble-devel] Review Request 124672: gsoc: Introducing OsmPresetLibrary class ( refactoring of osm tag presets )

2015-08-16 Thread Marius Stanciu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124672/ --- (Updated Aug. 16, 2015, 1:50 p.m.) Review request for Marble.

Re: [Marble-devel] Review Request 124672: gsoc: Introducing OsmPresetLibrary class ( refactoring of osm tag presets )

2015-08-16 Thread Marius Stanciu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124672/ --- (Updated Aug. 16, 2015, 3:59 p.m.) Review request for Marble.

Re: [Marble-devel] Review Request 124522: gsoc: KML writer/handlers for OsmPlacemarkData objects

2015-08-16 Thread Dennis Nienhüser
On Aug. 6, 2015, 6:23 p.m., Marius Stanciu wrote: Can you check the various documentation snippets whether the mx: namespace is consistently included? Marius Stanciu wrote: you mean check marble's documentation ? or make sure KML standards allow declaring a namespace? Marius

Re: [Marble-devel] Review Request 124522: gsoc: KML writer/handlers for OsmPlacemarkData objects

2015-08-16 Thread Marius Stanciu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124522/ --- (Updated Aug. 16, 2015, 4:13 p.m.) Review request for Marble.

Re: [Marble-devel] Review Request 124672: gsoc: Introducing OsmPresetLibrary class ( refactoring of osm tag presets )

2015-08-16 Thread Dennis Nienhüser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124672/#review83884 --- src/lib/marble/geodata/data/GeoDataFeature.h (line 76)

[Marble-devel] Review Request 124775: gsoc: additional accesors and function name refactoring for the OsmPlacemarkData class

2015-08-16 Thread Marius Stanciu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124775/ --- Review request for Marble. Repository: marble Description ---

Re: [Marble-devel] Review Request 124522: gsoc: KML writer/handlers for OsmPlacemarkData objects

2015-08-16 Thread Marius Stanciu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124522/ --- (Updated Aug. 16, 2015, 4:26 p.m.) Review request for Marble. Changes

Re: [Marble-devel] Review Request 124780: gsoc: Introduces the OsmTagEditorWidget

2015-08-16 Thread Marius Stanciu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124780/ --- (Updated Aug. 16, 2015, 8:06 p.m.) Review request for Marble.

[Marble-devel] Review Request 124781: gsoc: integrates the OsmTagEditorWidget ui in the annotate plugin tools

2015-08-16 Thread Marius Stanciu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124781/ --- Review request for Marble. Repository: marble Description ---

[Marble-devel] Jenkins-kde-ci: marble master kf5-qt5 » Linux,gcc - Build # 109 - Fixed!

2015-08-16 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/marble%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/109/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 16 Aug 2015 18:49:06 + Build duration: 25 min CHANGE SET Revision ea52eab22ba861466c32c474bac2abbcf6955510 by

[Marble-devel] Jenkins-kde-ci: marble master kf5-qt5 » Linux,gcc - Build # 109 - Fixed!

2015-08-16 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/marble%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/109/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 16 Aug 2015 18:49:06 + Build duration: 25 min CHANGE SET Revision ea52eab22ba861466c32c474bac2abbcf6955510 by

[Marble-devel] Review Request 124780: gsoc: Introduces the OsmTagEditorWidget

2015-08-16 Thread Marius Stanciu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124780/ --- Review request for Marble. Repository: marble Description --- !!!