[Marble-devel] Qt namespace patch

2014-08-15 Thread Martin Koller
Hi, to be able to compile the (Qt-only) marble lib when using a self-compiled Qt5 which was configured with a namespace (configure -qtnamespace MyNameSpace ...) one has to use the Qt macro QT_FORWARD_DECLARE_CLASS when forward declaring a Qt class (or directly including the class header), so

MarbleWidget::centerOn and altitude

2018-06-02 Thread Martin Koller
Hi all, I'm curious what's the difference on using centerOn(GeoDataCoordinates) where I also set an altitude (which seems to be ignored although the doc says it's used) and flyTo() giving a GeoDataLookAt which includes both, an altitude and also a range. In general: what is the difference of

D13640: stop InertialEarthRotation when a new coordinate is set or keyboard interaction

2018-06-20 Thread Martin Koller
mkoller created this revision. mkoller added reviewers: nienhueser, Marble. Restricted Application added projects: Marble, KDE Edu. Restricted Application added subscribers: kde-edu, marble-devel. mkoller requested review of this revision. REVISION SUMMARY When one starts to spin the globe with

D13640: stop InertialEarthRotation when a new coordinate is set or keyboard interaction

2018-06-21 Thread Martin Koller
This revision was automatically updated to reflect the committed changes. Closed by commit R34:f4ac4643827c: stop InertialEarthRotation when a new coordinate is set or keyboard interaction (authored by mkoller). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13640?vs=36410=36473#toc

D14098: Avoid "QObject::disconnect: Unexpected null parameter" error on application stop

2018-08-29 Thread Martin Koller
mkoller added a comment. ping REPOSITORY R34 Marble REVISION DETAIL https://phabricator.kde.org/D14098 To: mkoller, #marble, sanjibanb, rahn Cc: marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

D14098: Avoid "QObject::disconnect: Unexpected null parameter" error on application stop

2018-08-29 Thread Martin Koller
This revision was automatically updated to reflect the committed changes. Closed by commit R34:06b978062fff: Avoid QObject::disconnect: Unexpected null parameter error on application stop (authored by mkoller). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14098?vs=37699=40623#toc

Re: Android builds on binary-factory

2018-08-29 Thread Martin Koller
On Freitag, 27. Juli 2018 14:20:21 CEST Aleix Pol wrote: > Hi Marble, > You can find nightly marble builds for marble here: > https://binary-factory.kde.org/view/Android/job/Marble_android/ Downloaded current apk, tried to run it on Android 7.1.1, crashed: - beginning of crash 08-29

D14098: Avoid "QObject::disconnect: Unexpected null parameter" error on application stop

2018-07-23 Thread Martin Koller
mkoller added reviewers: sanjibanb, rahn. REPOSITORY R34 Marble REVISION DETAIL https://phabricator.kde.org/D14098 To: mkoller, #marble, sanjibanb, rahn Cc: marble-devel, kde-edu, torhamzed, jalvarez, tjakobi, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol,

pinch-zoom

2018-08-31 Thread Martin Koller
I'm using the MarbleWidget in a widget based app on a Desktop Computer using a TouchScreen. No QML used. What I see is that pinching does not work nicely - much too large jumps in zoom factor. I'm wondering if this is simply a bug in the calculation of the zoomDelta Factor:

D15182: ensure "make install" on windows also installs development header files

2018-08-31 Thread Martin Koller
mkoller added a comment. > Have you tested creating a new deployable Windows package? no > Or did you just test whether compilation on the platform works? :-) We are using Marble in our product, and therefore we just package what was installed into a tar file, which will then

Re: D15182: ensure "make install" on windows also installs development header files

2018-09-01 Thread Martin Koller
On Freitag, 31. August 2018 13:05:45 CEST Torsten Rahn wrote: > rahn added a comment. > > > Have you tested creating a new deployable Windows package? no > Or did you just test whether compilation on the platform works? :-) We are using Marble in our product, and therefore we just

D15182: ensure "make install" on windows also installs development header files

2018-08-31 Thread Martin Koller
mkoller created this revision. mkoller added a reviewer: Marble. Herald added projects: Marble, KDE Edu. Herald added subscribers: kde-edu, marble-devel. mkoller requested review of this revision. REVISION SUMMARY The attached change ensures we also get the header files installed. At least

MarbleWidget viewContext property

2018-07-04 Thread Martin Koller
In MarbleWidget there is Q_PROPERTY(ViewContext viewContext READ viewContext WRITE setViewContext NOTIFY viewContextChanged) however, ViewContext is not registered with the Qt meta-object system as it is not in a QObject of QGadget. So I get the following warnings in runtime:

D14053: avoid runtime error about unknown signal when compiled without WebKit

2018-07-11 Thread Martin Koller
mkoller created this revision. mkoller added reviewers: Marble, rahn. Restricted Application added projects: Marble, KDE Edu. Restricted Application added subscribers: kde-edu, marble-devel. mkoller requested review of this revision. REVISION SUMMARY When compiled without WebKit,

D14054: No version number for the libs on Android

2018-07-11 Thread Martin Koller
mkoller created this revision. mkoller added reviewers: Marble, kossebau. Restricted Application added projects: Marble, KDE Edu. Restricted Application added subscribers: kde-edu, marble-devel. mkoller requested review of this revision. REVISION SUMMARY When including the marble and astro libs

Re: AW: MarbleWidget viewContext property

2018-07-11 Thread Martin Koller
ion for a fix? What about removing the Q_PROPERTY macro then ? > > Best Regards, > Torsten > > > > > > -Original-Nachricht- > Betreff: MarbleWidget viewContext property > Datum: 2018-07-04T11:24:10+0200 > Von: "Martin Koller" > An:

D14098: Avoid "QObject::disconnect: Unexpected null parameter" error on application stop

2018-07-13 Thread Martin Koller
mkoller created this revision. mkoller added a reviewer: Marble. Restricted Application added projects: Marble, KDE Edu. Restricted Application added subscribers: kde-edu, marble-devel. mkoller requested review of this revision. REVISION SUMMARY When I use the MarbleWidget in my application -

Re: AW: MarbleWidget viewContext property

2018-07-13 Thread Martin Koller
> > -Original-Nachricht- > > Betreff: MarbleWidget viewContext property > > Datum: 2018-07-04T11:24:10+0200 > > Von: "Martin Koller" > > An: "marble-devel@kde.org" > > > > In MarbleWidget there is > > Q_PROPERT

D14054: No version number for the libs on Android

2018-07-12 Thread Martin Koller
This revision was automatically updated to reflect the committed changes. Closed by commit R34:59b95f5544bd: No version number for the libs on Android (authored by mkoller). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14054?vs=37584=37613#toc REPOSITORY R34 Marble CHANGES SINCE

D14053: avoid runtime error about unknown signal when compiled without WebKit

2018-07-12 Thread Martin Koller
This revision was automatically updated to reflect the committed changes. Closed by commit R34:c4850695c31d: avoid runtime error about unknown signal when compiled without WebKit (authored by mkoller). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14053?vs=37581=37614#toc REPOSITORY

D18124: Implement touch input handling in MarbleWidgetInputHandler

2019-01-09 Thread Martin Koller
mkoller created this revision. mkoller added reviewers: Marble, rahn. Herald added projects: Marble, KDE Edu. Herald added subscribers: kde-edu, marble-devel. mkoller requested review of this revision. REVISION SUMMARY This patch implements touch handling when using the marble widget in a

D18124: Implement touch input handling in MarbleWidgetInputHandler

2019-02-26 Thread Martin Koller
mkoller added a comment. ping REPOSITORY R34 Marble REVISION DETAIL https://phabricator.kde.org/D18124 To: mkoller, #marble, rahn Cc: marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

D19329: allow GeoDataCoordinates::toString() to create an ISO 6709 conforming string

2019-02-26 Thread Martin Koller
mkoller created this revision. mkoller added reviewers: Marble: General, rahn, nienhueser. Herald added projects: Marble, KDE Edu. Herald added subscribers: kde-edu, marble-devel. mkoller requested review of this revision. REVISION SUMMARY ISO 6709 "Standard representation of geographic point

D19330: fix failing DMS-String parsing on windows

2019-02-26 Thread Martin Koller
mkoller created this revision. mkoller added reviewers: Marble: General, rahn, nienhueser, kossebau. Herald added projects: Marble, KDE Edu. Herald added subscribers: kde-edu, marble-devel. mkoller requested review of this revision. REVISION SUMMARY This patch marks unicode strings so that the

D19329: allow GeoDataCoordinates::toString() to create an ISO 6709 conforming string

2019-02-26 Thread Martin Koller
mkoller updated this revision to Diff 52603. mkoller added a comment. Changed bool to enum REPOSITORY R34 Marble CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19329?vs=52590=52603 REVISION DETAIL https://phabricator.kde.org/D19329 AFFECTED FILES

D18124: Implement touch input handling in MarbleWidgetInputHandler

2019-02-26 Thread Martin Koller
mkoller added a comment. > So which applications did you use for testing? :-) Our WinCC_OA User Interface: https://www.winccoa.com/ On Android you could install it from google play store, however the version including the marble widget is not released yet (and you would also need our

D19341: avoid lots of "Unknown feature GeoDataRelationType" warnings when loading an OSM file

2019-02-26 Thread Martin Koller
mkoller created this revision. mkoller added reviewers: rahn, Marble: General, nienhueser. Herald added projects: Marble, KDE Edu. Herald added subscribers: kde-edu, marble-devel. mkoller requested review of this revision. REVISION SUMMARY Loading an osm file containing "relation" tags leads to

D19341: avoid lots of "Unknown feature GeoDataRelationType" warnings when loading an OSM file

2019-08-28 Thread Martin Koller
This revision was automatically updated to reflect the committed changes. Closed by commit R34:35256f57ce42: avoid Unknown feature GeoDataRelationType warnings on loading OSM file (authored by mkoller). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19341?vs=52613=64795#toc REPOSITORY

D19330: fix failing DMS-String parsing on windows

2019-07-22 Thread Martin Koller
This revision was automatically updated to reflect the committed changes. Closed by commit R34:bf90ef0232b6: fix failing DMS-String parsing on windows (authored by mkoller). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19330?vs=52592=62263#toc REPOSITORY R34 Marble CHANGES SINCE