Re: [Maria-developers] Review of patch for MDEV-4820

2013-08-13 Thread Kristian Nielsen
Jan Lindström jplin...@mariadb.org writes: I found this disturbing and not fully follow what kind of holes are possible. These GTIDS can be used by human users to start slaves on For example, if you use some of the many filtering options, like --replicate-ignore-*. Then there will be GTIDs on

Re: [Maria-developers] Review of patch for MDEV-4820

2013-08-13 Thread Kristian Nielsen
Pavel Ivanov piva...@google.com writes: Note that the patch I've attached have test case that should reproduce the problems. Thanks, I've now gone through the testcases also. Let me number the individual tests as follows: 1. Check that gap in seq_no without binlogs doesn't allow to replicate

Re: [Maria-developers] Review of patch for MDEV-4820

2013-08-13 Thread Jan Lindström
Hi, On 08/13/2013 09:49 AM, Kristian Nielsen wrote: You can always use the contents of the binlogs to know this. You can search the binlogs for your GTID and determine if it was a) logged in an earlier binlog that was purged, b) found in the binlog, c) a hole due to filtering or whatever, or

Re: [Maria-developers] MariaDB config files order

2013-08-13 Thread Michael Widenius
Hi! Honza == Honza Horak hho...@redhat.com writes: Honza Hi guys, Honza maybe I just need some little kick or I should get a coffee, but I can't Honza understand the following config file ordering difference. Honza Reading [1] and code in mariadb-5.5.32/mysys/default.c:1226, it looks Honza

Re: [Maria-developers] Review of patch for MDEV-4820

2013-08-13 Thread Kristian Nielsen
Jan Lindström jplin...@mariadb.org writes: Hi, On 08/13/2013 09:49 AM, Kristian Nielsen wrote: You can always use the contents of the binlogs to know this. You can search the binlogs for your GTID and determine if it was a) logged in an earlier binlog that was purged, b) found in the

Re: [Maria-developers] Review of patch for MDEV-4820

2013-08-13 Thread Kristian Nielsen
Vilho Raatikka vilho.raati...@skysql.com writes: What exactly does it require for the user to enable strict or 'relaxed' (=disasterous imho) mode? Technically, one needs to SET GLOBAL gtid_strict_mode=1 with root privileges (config file option works as well of course). That's it. The

Re: [Maria-developers] Review of patch for MDEV-4820

2013-08-13 Thread Kristian Nielsen
Kristian Nielsen kniel...@knielsen-hq.org writes: BTW, for the normal non-advanced user, I think silly stuff like running random manual transactions on slaves that get into the binlog is a far more common mistake. Gtid strict mode will cause errors on this, so it needs to be explictly enabled

Re: [Maria-developers] 10.x compatibility and separate namespace

2013-08-13 Thread Sergei Golubchik
Hi, Honza! On Jul 19, Honza Horak wrote: Hi Guys, since 10.x won't be compatible with mysql in every aspect any more, I'm wondering if there happen to be any plans to move all compatibility left-overs (client binary names, client library name, daemon binary name, etc.). Are there any

Re: [Maria-developers] Lack of linkage from MariaDB JIRA to commits

2013-08-13 Thread Sergei Golubchik
Hi, Jeremy! On Aug 08, Jeremy Cole wrote: All, I have noticed that the MariaDB JIRA tickets are rarely linked to any specific commit which purportedly fixes them. Is there any standard at the moment for what should be done (and then it isn't followed) or is there no standard (and perhaps

Re: [Maria-developers] Rev 3804: MDEV-4712 : Fix shutdown test

2013-08-13 Thread Vladislav Vaintroub
-Original Message- From: Sergei Golubchik [mailto:s...@mariadb.org] Sent: Donnerstag, 8. August 2013 18:29 To: maria-developers@lists.launchpad.net Cc: Vladislav Vaintroub Subject: Re: Rev 3804: MDEV-4712 : Fix shutdown test Hi, Vladislav! On Jul 31, Vladislav Vaintroub wrote:

Re: [Maria-developers] MariaDB config files order

2013-08-13 Thread Honza Horak
On 08/13/2013 12:51 PM, Michael Widenius wrote: Hi! Honza == Honza Horak hho...@redhat.com writes: Honza Hi guys, Honza maybe I just need some little kick or I should get a coffee, but I can't Honza understand the following config file ordering difference. Honza Reading [1] and code in

[Maria-developers] Value returned by my_getcputime

2013-08-13 Thread Weldon Whipple
Hello! (This is my first post to this list; long-time follower, however.) I've been looking at the block comment at the top of the my_getcputime() function at the bottom of the file mysys/my_getsystime.c The block comment reads: Return cpu time in milliseconds * 10 I interpret milliseconds *

[Maria-developers] Can there be a better storage engine API?

2013-08-13 Thread MARK CALLAGHAN
The storage engine API has never been my favorite part of MySQL. I haven't written a storage engine but I used to maintain a custom storage engine and migrated that from 4.0 to 5.0 so I had some experience with the API. Is there a different API that would make it easier for innovation to come to