Re: [Maria-developers] [Commits] 8983790: MDEV-7970: EXPLAIN FORMAT=JSON does not print HAVING

2015-09-14 Thread Oleksandr Byelkin
On 14.09.15 21:59, Sergey Petrunia wrote: Hi Sanja, The big comment: I see HAVING being printed for EXPLAIN FORMAT=JSON but not for ANALYZE FORMAT=JSON. For example: MariaDB [test]> explain format=json select count(*) from t1 where t1.a between 0 and 1000 group by b having count(*) > 0\G

Re: [Maria-developers] MDEV-3929 Add system variable explicit_defaults_for_timestamp for compatibility with MySQL

2015-09-14 Thread Alexander Barkov
Hi Sergei, Thanks for the review! Please see comments and questions below: On 09/11/2015 06:58 PM, Sergei Golubchik wrote: Hi, Alexander! On Jul 13, Alexander Barkov wrote: Forgot to attach the patch. Thanks, here's the review below. I did not review all the test changes, I suppose you've

Re: [Maria-developers] [Commits] 93a7c11: MDEV-8380: Subquery parse error

2015-09-14 Thread Oleksandr Byelkin
On 12.09.15 21:12, Sergei Golubchik wrote: Hi, Sanja! On Aug 31, sa...@mariadb.com wrote: revision-id: 93a7c11c51e2f5c0ca98600924172e452b6188b6 (mariadb-10.1.6-24-g93a7c11) parent(s): d07b780db239a909e667edf5657e3633e80d1451 committer: Oleksandr Byelkin timestamp: 2015-08-31 13:10:01 +0200