Re: [Maria-developers] [Commits] 2606b87: MDEV-9117: Client Server capability negotiation for MariaDB specific functionality

2015-11-24 Thread G R
Hi, > > Either "ulonglong" or "unsigned long long". > But not "ulong long", please. > +1 for ulonglong > > > > - unsigned long client_flag,server_capabilities; > > + unsigned long long client_flag,server_capabilities; > > This is an incompatible change, it breaks the ABI. > If we have to have

Re: [Maria-developers] [Commits] 2606b87: MDEV-9117: Client Server capability negotiation for MariaDB specific functionality

2015-11-24 Thread Sergei Golubchik
Hi, Oleksandr! On Nov 24, Oleksandr Byelkin wrote: > > On Nov 23, Oleksandr Byelkin wrote: > diff --git a/include/mysql.h b/include/mysql.h > index f088ad6..d398734 100644 > --- a/include/mysql.h > +++ b/include/mysql.h > @@ -270,7 +270,7 @@ typedef struct st_mysql >

Re: [Maria-developers] [Commits] 2606b87: MDEV-9117: Client Server capability negotiation for MariaDB specific functionality

2015-11-24 Thread Oleksandr Byelkin
On 24.11.15 12:27, Sergei Golubchik wrote: Hi, Oleksandr! On Nov 23, Oleksandr Byelkin wrote: diff --git a/include/mysql.h b/include/mysql.h index f088ad6..d398734 100644 --- a/include/mysql.h +++ b/include/mysql.h @@ -270,7 +270,7 @@ typedef struct st_mysql unsigned long thread_id;

Re: [Maria-developers] [Commits] 2606b87: MDEV-9117: Client Server capability negotiation for MariaDB specific functionality

2015-11-24 Thread Sergei Golubchik
Hi, Oleksandr! On Nov 23, Oleksandr Byelkin wrote: > >> diff --git a/include/mysql.h b/include/mysql.h > >> index f088ad6..d398734 100644 > >> --- a/include/mysql.h > >> +++ b/include/mysql.h > >> @@ -270,7 +270,7 @@ typedef struct st_mysql > >> unsigned long thread_id; /* Id for