Re: [Maria-developers] Please review MDEV-8092 Change Create_field::field from "const char *" to LEX_CSTRING

2016-01-08 Thread Alexander Barkov
Hi Sergei, On 01/08/2016 03:48 PM, Sergei Golubchik wrote: Hi, Alexander! On Jan 08, Alexander Barkov wrote: diff --git a/sql/field.h b/sql/field.h index 0591914..a40e307 100644 --- a/sql/field.h +++ b/sql/field.h @@ -537,6 +537,115 @@ inline bool is_temporal_type_with_time(enum_field_types

Re: [Maria-developers] Please review MDEV-8092 Change Create_field::field from "const char *" to LEX_CSTRING

2016-01-08 Thread Alexander Barkov
Hi Vicențiu, On 01/08/2016 02:27 PM, Vicențiu Ciorbaru wrote: Hi Alexander, Thanks for the explanation. I agree with your points regarding std::string. Although it is possible to control allocation using an allocator, it does indeed make sense that std::string is not easily applicable in this c

[Maria-developers] MDEV-8789: fully qualified field name resolving problem

2016-01-08 Thread Oleksandr Byelkin
Hi! I decided to show my finding as soon as I have them found (to give time to explain/fix, also I think that name resolving fix could possibly cause some big rewriting) but if you prefer "all togather" do not hesitate to say it. So the test suite which demostrate the problem: - cre

Re: [Maria-developers] Please review MDEV-8092 Change Create_field::field from "const char *" to LEX_CSTRING

2016-01-08 Thread Sergei Golubchik
Hi, Alexander! On Jan 08, Alexander Barkov wrote: > >> diff --git a/sql/field.h b/sql/field.h > >> index 0591914..a40e307 100644 > >> --- a/sql/field.h > >> +++ b/sql/field.h > >> @@ -537,6 +537,115 @@ inline bool > >> is_temporal_type_with_time(enum_field_types type) > >> } > >> > >> > >> +/**

Re: [Maria-developers] Please review MDEV-8092 Change Create_field::field from "const char *" to LEX_CSTRING

2016-01-08 Thread Vicențiu Ciorbaru
Hi Alexander, Thanks for the explanation. I agree with your points regarding std::string. Although it is possible to control allocation using an allocator, it does indeed make sense that std::string is not easily applicable in this case. I am personally for the introduction of an extra string cla