Re: [Maria-developers] Gsoc 2016 Mdev 371 Unique index for blob

2016-03-22 Thread Sergei Golubchik
Hi, Sachin! On Mar 22, Sachin Setia wrote: > Hello Sergei > Actually I was prototyping for blob and varchar for aria and myisam > storage engine. > My prototype worked for complex definations like > craete table(abc int primary key, blob_col blob unique, varchar_col > varchar(1000) unique)

Re: [Maria-developers] More memory allocation for key seg

2016-03-22 Thread Sergei Golubchik
Hi, Sachin! On Mar 22, Sachin Setia wrote: > Hello Devlopers > I was debugging the source code of mariadb. My query was > MariaDB [sachin]> create table pro2(abc int primary key,xyz int , > ass int ,unique(xyz,ass))engine=myisam; > > In table2myisam function of file ha_myisam.cc i found that >

Re: [Maria-developers] Please review MDEV-9604 crash in Item::save_in_field with empty enum value

2016-03-22 Thread Alexander Barkov
Hi Sergei, On 03/22/2016 09:48 PM, Sergei Golubchik wrote: > Hi, Alexander! > > On Mar 22, Alexander Barkov wrote: >> On 03/22/2016 09:33 PM, Sergei Golubchik wrote: >>> Hi, Alexander! >>> >>> On Mar 22, Alexander Barkov wrote: Hi Sergei, It fixes the reported crash, and

Re: [Maria-developers] Please review MDEV-9604 crash in Item::save_in_field with empty enum value

2016-03-22 Thread Sergei Golubchik
Hi, Alexander! On Mar 22, Alexander Barkov wrote: > On 03/22/2016 09:33 PM, Sergei Golubchik wrote: > > Hi, Alexander! > > > > On Mar 22, Alexander Barkov wrote: > >> Hi Sergei, > >> > >> It fixes the reported crash, and additionally > >> inconsistencies when comparing temporal columns to empty

Re: [Maria-developers] Please review MDEV-9604 crash in Item::save_in_field with empty enum value

2016-03-22 Thread Alexander Barkov
Hi Sergei, On 03/22/2016 09:33 PM, Sergei Golubchik wrote: > Hi, Alexander! > > On Mar 22, Alexander Barkov wrote: >> Hi Sergei, >> >> It fixes the reported crash, and additionally >> inconsistencies when comparing temporal columns to empty strings: >> >> In some cases it returned rows, in

Re: [Maria-developers] Please review MDEV-9604 crash in Item::save_in_field with empty enum value

2016-03-22 Thread Sergei Golubchik
Hi, Alexander! On Mar 22, Alexander Barkov wrote: > Hi Sergei, > > It fixes the reported crash, and additionally > inconsistencies when comparing temporal columns to empty strings: > > In some cases it returned rows, in other cases it returned no rows, > depending on: > - the engine > - the

Re: [Maria-developers] GSoC 2016:Unique indexes for blobs

2016-03-22 Thread Shubham Barai
Hello Sergei, I understood most of the internals of long unique constraints in MyISAM. I am still going through the code in InnoDB. I will soon reply to you. Thanks, Shubham On 21 March 2016 at 16:37, Sergei Golubchik wrote: > Hi, Shubham! > > On Mar 21, Shubham

[Maria-developers] More memory allocation for key seg

2016-03-22 Thread Sachin Setia
Hello Devlopers I was debugging the source code of mariadb. My query was MariaDB [sachin]> create table pro2(abc int primary key,xyz int , ass int ,unique(xyz,ass))engine=myisam; In table2myisam function of file ha_myisam.cc i found that we are allocating more memory for keysegments if

Re: [Maria-developers] Gsoc 2016 Mdev 371 Unique index for blob

2016-03-22 Thread Sachin Setia
Hello Sergei Actually I was prototyping for blob and varchar for aria and myisam storage engine. My prototype worked for complex definations like craete table(abc int primary key, blob_col blob unique, varchar_col varchar(1000) unique) engine=myisam; Solved the issue of frm file incosistance.

Re: [Maria-developers] Aggregate stored functions [MDEV-7773]

2016-03-22 Thread Varun Gupta
Hi Sergei, Sorry for the inconvenience , now you can comment on the document :) On Tue, Mar 22, 2016 at 1:25 PM, Sergei Golubchik wrote: > Hi, Varun! > > On Mar 22, Varun Gupta wrote: > > Hi Sergei , > > I have created a draft proposal and submitted to summerofcode website. >

[Maria-developers] Please review MDEV-9604 crash in Item::save_in_field with empty enum value

2016-03-22 Thread Alexander Barkov
Hi Sergei, It fixes the reported crash, and additionally inconsistencies when comparing temporal columns to empty strings: In some cases it returned rows, in other cases it returned no rows, depending on: - the engine - the type of comparison arguments (columns vs literals). - presence of an

Re: [Maria-developers] Aggregate stored functions [MDEV-7773]

2016-03-22 Thread Sergei Golubchik
Hi, Varun! On Mar 22, Varun Gupta wrote: > Hi Sergei , > I have created a draft proposal and submitted to summerofcode website. > I haven't written the project timeline yet. Please I would appreciate > if you could go through it and leave comments so that I can make any > necessary corrections.