Re: [Maria-developers] [Commits] a2a42a9: MDEV-11623: MariaDB 10.1 fails to start datadir created with MariaDB 10.0/MySQL 5.6 using innodb-page-size!=16K

2017-01-11 Thread Marko Mäkelä
Sorry for the delay. This patch looks great to me, except for one thing: I think that we should write the corrected flags back to the data file. Given that 10.1 is already in GA status, we should consider our options carefully. My preference would be (1) below: (1) If we adjust 10.1.21 so that

Re: [Maria-developers] [Commits] c32bc1afe82: MDEV-11254: innodb-use-trim has no effect in 10.2

2017-01-11 Thread Marko Mäkelä
On Tue, Jan 10, 2017 at 11:49 AM, jan wrote: > revision-id: c32bc1afe820aa90c2e2666a77ce2bb43019df3d > (mariadb-10.2.3-43-gc32bc1afe82) > parent(s): 3d46768da2a784ddc9c341d1fb03468525bd38f1 > author: Jan Lindström > committer: Jan Lindström > timestamp: 2017-01-10

Re: [Maria-developers] Please review MDEV-11134 Assertion `fixed' failed in Item::const_charset_converter(THD*, CHARSET_INFO*, bool, const char*)

2017-01-11 Thread Alexander Barkov
Hello Sergei, On 12/29/2016 05:33 PM, Sergei Golubchik wrote: > Hi, Alexander! > > On Dec 26, Alexander Barkov wrote: >> Hello Sergei, >> >> can you please review a fix for MDEV-11134. >> >> I made it the easiest way, just fixed the assert to cover this special >> case when

Re: [Maria-developers] InnoDB: Instant ADD COLUMN that works on old data files

2017-01-11 Thread Marko Mäkelä
Hi Jan, On Wed, Jan 11, 2017 at 9:07 AM, Jan Lindström wrote: > Number of the fields indeed would solve the ADD COLUMN default case but has > some limitations > > ADD COLUMN m default xxx; would be still slow, xxx = NULL maybe possible, in > other cases could we store