Re: [Maria-developers] MDEV-13467 review.

2021-03-19 Thread Alexey Botchkov
One thing i'd still like you to do differently. + if (g->get_class_info()->m_type_id == Geometry::wkb_multipoint) + { +const char point_size= 4 + WKB_HEADER_SIZE + POINT_DATA_SIZE+1; //1 for the type +char point_temp[point_size]; +memset(point_temp+4, Geometry::wkb_point, 1); +

Re: [Maria-developers] 0fc221a012d: MDEV-8334: Rename utf8 to utf8mb3

2021-03-19 Thread Sergei Golubchik
Hi, Rucha! Thanks for combining all commits in one and a cleanup. See comments below. On Mar 18, Rucha Deodhar wrote: > revision-id: 0fc221a012d (mariadb-10.5.2-402-g0fc221a012d) > parent(s): a1542f8a573 > author: Rucha Deodhar > committer: Rucha Deodhar > timestamp: 2021-03-16 23:31:12 +0530

Re: [Maria-developers] Old buildbot 10.5 branch failure review

2021-03-19 Thread Sergei Golubchik
Hi, Daniel! On Mar 19, Elena Stepanova wrote: > > > > ## kvm-deb-buster-amd6 minor-upgrade-all > > (http://buildbot.askmonty.org/buildbot/builders/kvm-deb-buster-amd64/builds/3995/steps/minor-upgrade-all/logs/stdio): > > > > ++ diff -U1000 > >